138414 2014-11-05 03:14:25 -0800 Fix Debug Build Error in Webcore module 2014-11-05 09:03:29 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 138407 P2 Normal --- 1 shiva.jm webkit-unassigned commit-queue d-r fmalita gyuyoung.kim krit nikos.andronikos ossy pdr schenney sergio zimmermann oldest_to_newest 1046434 0 shiva.jm 2014-11-05 03:14:25 -0800 Getting below debug build error on latest Wk2-efl build. Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -MMD -MT Source/WebCore/CMakeFiles/WebCore.dir/svg/SVGMarkerElement.cpp.o -MF "Source/WebCore/CMakeFiles/WebCore.dir/svg/SVGMarkerElement.cpp.o.d" -o Source/WebCore/CMakeFiles/WebCore.dir/svg/SVGMarkerElement.cpp.o -c ../../Source/WebCore/svg/SVGMarkerElement.cpp In file included from ../../Source/WTF/wtf/PossiblyNull.h:29:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/svg/SVGMarkerElement.cpp:22: ../../Source/WebCore/svg/SVGMarkerElement.cpp: In member function ‘WebCore::SVGMarkerOrientType& WebCore::SVGMarkerElement::orientType() const’: ../../Source/WebCore/svg/SVGMarkerElement.cpp:256:55: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] ASSERT(wrapper->currentAnimatedValue() >= 0 && wrapper->currentAnimatedValue() < SVGMarkerOrientMax); ^ ../../Source/WTF/wtf/Assertions.h:232:8: note: in definition of macro ‘ASSERT’ (!(assertion) ? 1046436 1 241020 shiva.jm 2014-11-05 03:23:04 -0800 Created attachment 241020 Patch Fixed debug build error. 1046438 2 shiva.jm 2014-11-05 03:26:54 -0800 Issue might have occured by https://bugs.webkit.org/show_bug.cgi?id=137942 1046446 3 ossy 2014-11-05 04:09:50 -0800 *** Bug 138416 has been marked as a duplicate of this bug. *** 1046452 4 ossy 2014-11-05 05:50:00 -0800 *** This bug has been marked as a duplicate of bug 138407 *** 241020 2014-11-05 03:23:04 -0800 2014-11-05 09:03:29 -0800 Patch bug-138414.patch text/plain 1495 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTYxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTA1ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IERlYnVnIEJ1aWxk IEVycm9yIGluIFdlYmNvcmUgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UsIGZpeGVk IHRoZSBkZWJ1ZyBidWlsZCBlcnJvci4KKworICAgICAgICAqIHN2Zy9TVkdNYXJrZXJFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR01hcmtlckVsZW1lbnQ6Om9yaWVudFR5cGUpOgor CiAyMDE0LTExLTA1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAg ICBTaW1wbGUgbGluZSBsYXlvdXQ6IHN1cHBvcnQgdGV4dC10cmFuc2Zvcm06IGxvd2VyY2FzZXx1 cHBlcmNhc2V8Y2FwaXRhbGl6ZQpJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL1NWR01hcmtlckVs ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdNYXJrZXJFbGVt ZW50LmNwcAkocmV2aXNpb24gMTc1NjE4KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL1NWR01hcmtl ckVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTMsNyArMjUzLDcgQEAgU1ZHTWFya2Vy T3JpZW50VHlwZSYgU1ZHTWFya2VyRWxlbWVudDo6bwogewogICAgIGlmIChTVkdBbmltYXRlZEVu dW1lcmF0aW9uKiB3cmFwcGVyID0gU1ZHQW5pbWF0ZWRQcm9wZXJ0eTo6bG9va3VwV3JhcHBlcjxV c2VPd25lclR5cGUsIFNWR0FuaW1hdGVkRW51bWVyYXRpb24+KHRoaXMsIG9yaWVudFR5cGVQcm9w ZXJ0eUluZm8oKSkpIHsKICAgICAgICAgaWYgKHdyYXBwZXItPmlzQW5pbWF0aW5nKCkpIHsKLSAg ICAgICAgICAgIEFTU0VSVCh3cmFwcGVyLT5jdXJyZW50QW5pbWF0ZWRWYWx1ZSgpID49IDAgJiYg d3JhcHBlci0+Y3VycmVudEFuaW1hdGVkVmFsdWUoKSA8IFNWR01hcmtlck9yaWVudE1heCk7Cisg ICAgICAgICAgICBBU1NFUlQod3JhcHBlci0+Y3VycmVudEFuaW1hdGVkVmFsdWUoKSA8IFNWR01h cmtlck9yaWVudE1heCk7CiAgICAgICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxTVkdN YXJrZXJPcmllbnRUeXBlJj4od3JhcHBlci0+Y3VycmVudEFuaW1hdGVkVmFsdWUoKSk7CiAgICAg ICAgIH0KICAgICB9Cg==