138410 2014-11-05 00:41:34 -0800 Fix build warning in WebKit2/WebProcess module 2014-11-05 02:01:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned andersca buildbot commit-queue gyuyoung.kim rniwa ryuan.choi thorton oldest_to_newest 1046401 0 shiva.jm 2014-11-05 00:41:34 -0800 Fix build warning caused by https://bugs.webkit.org/show_bug.cgi?id=138388 [4468/5021] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Network/NetworkProcessConnection.cpp.o In file included from DerivedSources/WebKit2/include/WebKit/WebPageOverlay.h:1:0, from ../../Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:40: ../../Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:53:22: warning: unused parameter ‘userData’ [-Wunused-parameter] virtual bool prepareForActionMenu(WebPageOverlay&, RefPtr<API::Object>& userData) { return false; } ^ [4469/5021] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Plugins/PluginProcessConnectionManager.cpp.o [4470/5021] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Network/WebResourceLoadScheduler.cpp.o [4471/5021] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp.o In file included from ../../Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:50:0: ../../Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:53:22: warning: unused parameter ‘userData’ [-Wunused-parameter] virtual bool prepareForActionMenu(WebPageOverlay&, RefPtr<API::Object>& userData) { return false; } ^ 1046404 1 241008 shiva.jm 2014-11-05 00:49:39 -0800 Created attachment 241008 Patch Fix build warning by removing parameter name 1046420 2 241008 commit-queue 2014-11-05 02:01:20 -0800 Comment on attachment 241008 Patch Clearing flags on attachment: 241008 Committed r175616: <http://trac.webkit.org/changeset/175616> 1046422 3 commit-queue 2014-11-05 02:01:27 -0800 All reviewed patches have been landed. Closing bug. 241008 2014-11-05 00:49:39 -0800 2014-11-05 02:01:20 -0800 Patch bug-138410.patch text/plain 1811 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTYxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTA1ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9XZWJQcm9jZXNzIG1vZHVsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCB3YXJuaW5nIGJ5IHJlbW92aW5nIHBh cmFtZXRlciBuYW1lCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZU92ZXJs YXkuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZU92ZXJsYXk6OkNsaWVudDo6cHJlcGFyZUZv ckFjdGlvbk1lbnUpOgorCiAyMDE0LTExLTA0ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNv bT4KIAogICAgICAgICBTcGVjdWxhdGl2ZSBidWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZU92ZXJsYXkuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZU92ZXJsYXkuaAkocmV2aXNpb24g MTc1NjEzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2VPdmVy bGF5LmgJKHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDcgQEAgcHVibGljOgogICAgICAgICB2 aXJ0dWFsIHZvaWQgZHJhd1JlY3QoV2ViUGFnZU92ZXJsYXkmLCBXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQmLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBkaXJ0eVJlY3QpID0gMDsKICAgICAgICAg dmlydHVhbCBib29sIG1vdXNlRXZlbnQoV2ViUGFnZU92ZXJsYXkmLCBjb25zdCBXZWJDb3JlOjpQ bGF0Zm9ybU1vdXNlRXZlbnQmKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRTY3JvbGxG cmFtZShXZWJQYWdlT3ZlcmxheSYsIFdlYkZyYW1lKikgeyB9Ci0gICAgICAgIHZpcnR1YWwgYm9v bCBwcmVwYXJlRm9yQWN0aW9uTWVudShXZWJQYWdlT3ZlcmxheSYsIFJlZlB0cjxBUEk6Ok9iamVj dD4mIHVzZXJEYXRhKSB7IHJldHVybiBmYWxzZTsgfQorICAgICAgICB2aXJ0dWFsIGJvb2wgcHJl cGFyZUZvckFjdGlvbk1lbnUoV2ViUGFnZU92ZXJsYXkmLCBSZWZQdHI8QVBJOjpPYmplY3Q+Jikg eyByZXR1cm4gZmFsc2U7IH0KIAogICAgICAgICB2aXJ0dWFsIGJvb2wgY29weUFjY2Vzc2liaWxp dHlBdHRyaWJ1dGVTdHJpbmdWYWx1ZUZvclBvaW50KFdlYlBhZ2VPdmVybGF5JiwgU3RyaW5nIC8q IGF0dHJpYnV0ZSAqLywgV2ViQ29yZTo6RmxvYXRQb2ludCAvKiBwYXJhbWV0ZXIgKi8sIFN0cmlu ZyYgLyogdmFsdWUgKi8pIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgICAgIHZpcnR1YWwgYm9vbCBj b3B5QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZUJvb2xWYWx1ZUZvclBvaW50KFdlYlBhZ2VPdmVybGF5 JiwgU3RyaW5nIC8qIGF0dHJpYnV0ZSAqLywgV2ViQ29yZTo6RmxvYXRQb2ludCAvKiBwYXJhbWV0 ZXIgKi8sIGJvb2wmIC8qIHZhbHVlICovKSB7IHJldHVybiBmYWxzZTsgfQo=