138408 2014-11-05 00:35:31 -0800 Incorrect sandbox_check in RemoteInspector.mm 2014-11-05 11:57:25 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap buildbot commit-queue graouts joepeck rniwa timothy webkit-bug-importer oldest_to_newest 1046396 0 ap 2014-11-05 00:35:31 -0800 1. There is no SANDBOX_CHECK_NO_REPORT, so I think that this still generates a sandbox violation. 2. In open source builds, the value of SANDBOX_FILTER_GLOBAL_NAME is incorrect - it should be 2, not 0. enum sandbox_filter_type { SANDBOX_FILTER_GLOBAL_NAME, }; 1046397 1 webkit-bug-importer 2014-11-05 00:35:54 -0800 <rdar://problem/18878299> 1046399 2 241006 ap 2014-11-05 00:39:19 -0800 Created attachment 241006 proposed fix 1046402 3 commit-queue 2014-11-05 00:42:02 -0800 Attachment 241006 did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:61: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1046544 4 241006 joepeck 2014-11-05 11:08:26 -0800 Comment on attachment 241006 proposed fix r=me 1046552 5 241006 commit-queue 2014-11-05 11:57:22 -0800 Comment on attachment 241006 proposed fix Clearing flags on attachment: 241006 Committed r175629: <http://trac.webkit.org/changeset/175629> 1046553 6 commit-queue 2014-11-05 11:57:25 -0800 All reviewed patches have been landed. Closing bug. 241006 2014-11-05 00:39:19 -0800 2014-11-05 11:57:22 -0800 proposed fix sandbox_check.txt text/plain 1838 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc1NjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTExLTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIEluY29ycmVjdCBzYW5kYm94X2NoZWNrIGluIFJlbW90ZUluc3BlY3Rvci5tbQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDA4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcmVt b3RlL1JlbW90ZUluc3BlY3Rvci5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6Y2FuQWNjZXNzV2Vi SW5zcGVjdG9yTWFjaFBvcnQpOgorCiAyMDE0LTExLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgY2hlY2tNYXJrQnl0ZSgpIHRvIGp1bXBJZklzUmVt ZW1iZXJlZE9ySW5FZGVuKCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCShyZXZpc2lvbiAxNzU2 MDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNw ZWN0b3IubW0JKHdvcmtpbmcgY29weSkKQEAgLTQzLDEyICs0MywxMiBAQAogI2ltcG9ydCA8c2Fu ZGJveC9wcml2YXRlLmg+CiAjZWxzZQogZW51bSBzYW5kYm94X2ZpbHRlcl90eXBlIHsKLSAgICBT QU5EQk9YX0ZJTFRFUl9HTE9CQUxfTkFNRSwKKyAgICBTQU5EQk9YX0ZJTFRFUl9HTE9CQUxfTkFN RSA9IDIsCiB9OwogI2VuZGlmCi1leHRlcm4gIkMiIHsKLSAgICBpbnQgc2FuZGJveF9jaGVjayhw aWRfdCwgY29uc3QgY2hhciAqb3BlcmF0aW9uLCBlbnVtIHNhbmRib3hfZmlsdGVyX3R5cGUsIC4u Lik7Ci19CisKK2V4dGVybiAiQyIgaW50IHNhbmRib3hfY2hlY2socGlkX3QsIGNvbnN0IGNoYXIg Km9wZXJhdGlvbiwgZW51bSBzYW5kYm94X2ZpbHRlcl90eXBlLCAuLi4pOworZXh0ZXJuICJDIiBj b25zdCBlbnVtIHNhbmRib3hfZmlsdGVyX3R5cGUgU0FOREJPWF9DSEVDS19OT19SRVBPUlQ7CiAK ICNpZiBQTEFURk9STShJT1MpCiAjaW1wb3J0IDx3dGYvaW9zL1dlYkNvcmVUaHJlYWQuaD4KQEAg LTU4LDcgKzU4LDcgQEAgbmFtZXNwYWNlIEluc3BlY3RvciB7CiAKIHN0YXRpYyBib29sIGNhbkFj Y2Vzc1dlYkluc3BlY3Rvck1hY2hQb3J0KCkKIHsKLSAgICByZXR1cm4gc2FuZGJveF9jaGVjayhn ZXRwaWQoKSwgIm1hY2gtbG9va3VwIiwgU0FOREJPWF9GSUxURVJfR0xPQkFMX05BTUUsIFdJUlhQ Q01hY2hQb3J0TmFtZSkgPT0gMDsKKyAgICByZXR1cm4gc2FuZGJveF9jaGVjayhnZXRwaWQoKSwg Im1hY2gtbG9va3VwIiwgc3RhdGljX2Nhc3Q8ZW51bSBzYW5kYm94X2ZpbHRlcl90eXBlPihTQU5E Qk9YX0ZJTFRFUl9HTE9CQUxfTkFNRSB8IFNBTkRCT1hfQ0hFQ0tfTk9fUkVQT1JUKSwgV0lSWFBD TWFjaFBvcnROYW1lKSA9PSAwOwogfQogCiBzdGF0aWMgYm9vbCBnbG9iYWxBdXRvbWF0aWNJbnNw ZWN0aW9uU3RhdGUoKQo=