138396 2014-11-04 18:17:17 -0800 Avoid double hash table lookup in SpaceSplitStringData::create() 2014-11-04 19:58:18 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin commit-queue esprehn+autocc kangil.han kling rniwa oldest_to_newest 1046331 0 cdumez 2014-11-04 18:17:17 -0800 Avoid double hash table lookup in SpaceSplitStringData::create() by calling HashMap::add() and using the AddResult, instead of calling HashMap::get() then HashMap::add(). 1046334 1 240994 cdumez 2014-11-04 18:22:36 -0800 Created attachment 240994 Patch 1046361 2 240994 commit-queue 2014-11-04 19:58:14 -0800 Comment on attachment 240994 Patch Clearing flags on attachment: 240994 Committed r175602: <http://trac.webkit.org/changeset/175602> 1046362 3 commit-queue 2014-11-04 19:58:18 -0800 All reviewed patches have been landed. Closing bug. 240994 2014-11-04 18:22:36 -0800 2014-11-04 19:58:14 -0800 Patch bug-138396-20141104182246.patch text/plain 2228 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzExN2NlNzBiMDFjOWQ3 NzI3NmUyMGQ2ZmIwYWJjYjJhODRiNjdhMy4uYWUyNjBkNzg2NjEzNDBlYzkzMWVmOTYxYmE2NjRj NWM4ZTRiYjgyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgZG91YmxlIGhhc2gg dGFibGUgbG9va3VwIGluIFNwYWNlU3BsaXRTdHJpbmdEYXRhOjpjcmVhdGUoKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4Mzk2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgZG91YmxlIGhhc2gg dGFibGUgbG9va3VwIGluIFNwYWNlU3BsaXRTdHJpbmdEYXRhOjpjcmVhdGUoKSBieQorICAgICAg ICBjYWxsaW5nIEhhc2hNYXA6OmFkZCgpIGFuZCB1c2luZyB0aGUgQWRkUmVzdWx0LCBpbnN0ZWFk IG9mIGNhbGxpbmcKKyAgICAgICAgSGFzaE1hcDo6Z2V0KCkgdGhlbiBIYXNoTWFwOjphZGQoKS4K KworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAq IGRvbS9TcGFjZVNwbGl0U3RyaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNwYWNlU3BsaXRT dHJpbmdEYXRhOjpjcmVhdGUpOgorCiAyMDE0LTExLTAzICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlq QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYnV0dG9uIGFuZCBlbmFibGUgb3B0aW1pemVkIGZ1 bGxzY3JlZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU3BhY2VTcGxpdFN0cmlu Zy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU3BhY2VTcGxpdFN0cmluZy5jcHAKaW5kZXggYWFl YWExM2U0YWUyMjMxZThlMjJhYmEyNzQ5ZmM0NTFkOTQ3MjBmNC4uZWM1YWZhY2U1MzBiYTIyYjk5 MzViYzgwOGNkOGQzYzBjMjE5NzBhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1Nw YWNlU3BsaXRTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TcGFjZVNwbGl0U3Ry aW5nLmNwcApAQCAtMTk2LDkgKzE5Niw5IEBAIFBhc3NSZWZQdHI8U3BhY2VTcGxpdFN0cmluZ0Rh dGE+IFNwYWNlU3BsaXRTdHJpbmdEYXRhOjpjcmVhdGUoY29uc3QgQXRvbWljU3RyaW5nCiAgICAg QVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBBU1NFUlQoIWtleVN0cmluZy5pc051bGwoKSk7 CiAKLSAgICBhdXRvJiB0YWJsZSA9IHNwYWNlU3BsaXRTdHJpbmdUYWJsZSgpOwotICAgIGlmIChT cGFjZVNwbGl0U3RyaW5nRGF0YSogZGF0YSA9IHRhYmxlLmdldChrZXlTdHJpbmcpKQotICAgICAg ICByZXR1cm4gZGF0YTsKKyAgICBhdXRvIGFkZFJlc3VsdCA9IHNwYWNlU3BsaXRTdHJpbmdUYWJs ZSgpLmFkZChrZXlTdHJpbmcsIG51bGxwdHIpOworICAgIGlmICghYWRkUmVzdWx0LmlzTmV3RW50 cnkpCisgICAgICAgIHJldHVybiBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlOwogCiAgICAgLy8g Tm90aGluZyBpbiB0aGUgY2FjaGU/IExldCdzIGNyZWF0ZSBhIG5ldyBTcGFjZVNwbGl0U3RyaW5n RGF0YSBpZiB0aGUgaW5wdXQgaGFzIHNvbWV0aGluZyB1c2VmdWwuCiAgICAgLy8gMSkgV2UgZmlu ZCB0aGUgbnVtYmVyIG9mIHN0cmluZ3MgaW4gdGhlIGlucHV0IHRvIGtub3cgaG93IG11Y2ggc2l6 ZSB3ZSBuZWVkIHRvIGFsbG9jYXRlLgpAQCAtMjEwLDcgKzIxMCw3IEBAIFBhc3NSZWZQdHI8U3Bh Y2VTcGxpdFN0cmluZ0RhdGE+IFNwYWNlU3BsaXRTdHJpbmdEYXRhOjpjcmVhdGUoY29uc3QgQXRv bWljU3RyaW5nCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCiAgICAgUmVmUHRyPFNwYWNlU3Bs aXRTdHJpbmdEYXRhPiBzcGFjZVNwbGl0U3RyaW5nRGF0YSA9IGNyZWF0ZShrZXlTdHJpbmcsIHRv a2VuQ291bnQpOwotICAgIHRhYmxlLmFkZChrZXlTdHJpbmcsIHNwYWNlU3BsaXRTdHJpbmdEYXRh LmdldCgpKTsKKyAgICBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlID0gc3BhY2VTcGxpdFN0cmlu Z0RhdGEuZ2V0KCk7CiAgICAgcmV0dXJuIHNwYWNlU3BsaXRTdHJpbmdEYXRhLnJlbGVhc2UoKTsK IH0KIAo=