138390 2014-11-04 17:26:22 -0800 Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64 2015-03-28 03:00:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) iPhone / iPad iOS 8.1 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=142629 InRadar P2 Normal --- 1 msaboff msaboff ossy webkit-bug-importer oldest_to_newest 1046306 0 msaboff 2014-11-04 17:26:22 -0800 These tests were disabled in change set r175586: <http://trac.webkit.org/changeset/175586>. They need to be investigated and the test or code needs to be fixed and then re-enabled. rdar://problem/18872936 1080241 1 ossy 2015-03-26 03:05:13 -0700 They were skipped on iOS, because they are flakey (bug138379). These tests fail on Linux too - bug142629 , but not flakey failures but constant failure after http://trac.webkit.org/changeset/181326, which seems to be absolutely unrelated. Could you provide some information about what kind of failure have you noticed on iOS? Did you get same or similar error log? 1080277 2 msaboff 2015-03-26 07:51:39 -0700 (In reply to comment #1) > They were skipped on iOS, because they are flakey (bug138379). > These tests fail on Linux too - bug142629 , but not flakey failures but > constant failure after http://trac.webkit.org/changeset/181326, which > seems to be absolutely unrelated. > > Could you provide some information about what kind of failure > have you noticed on iOS? Did you get same or similar error log? They are still flakey on iOS. They fail probably 1 out of every 3 test runs. Fixing them and other flakey tests is near the top of my to-do list. 1080808 3 msaboff 2015-03-27 16:52:15 -0700 The issue is that for typed arrays with signed values of 8 or 16 bits, when we do a get_by_val from the array, we sign extend it to a full 64 bits. For negative values this creates an illegal JSValue that causes problems in strict equal (====). The get_by_val slow path code for an Int16Array uses the load16Signed() macro assembler function which usually end up emitting an ldrsh x0, [x0, x1, lsl #1]. If the value of -10 (0xfff6) is stored in the array, we convert this to 64 bit signed value. The fix is to use the 32 bit variant of the instruction, ldrsh w0, ... The same issue exists with Int8Array's. Testing patch now. 1080815 4 249624 msaboff 2015-03-27 17:13:28 -0700 Created attachment 249624 Patch 1080816 5 249624 mark.lam 2015-03-27 17:16:32 -0700 Comment on attachment 249624 Patch r=me 1080822 6 msaboff 2015-03-27 17:41:38 -0700 Committed r182091: <http://trac.webkit.org/changeset/182091> 1080933 7 ossy 2015-03-28 03:00:08 -0700 *** Bug 142629 has been marked as a duplicate of this bug. *** 249624 2015-03-27 17:13:28 -0700 2015-03-27 17:16:32 -0700 Patch 138390.patch text/plain 5093 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE1LTAzLTI3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBmbGFrZXkgZGZnLWludDhhcnJheS5qcyBhbmQgZGZnLWludDE2YXJyYXkuanMgdGVz dHMgZm9yIEFSTTY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzgzOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaGFuZ2VkIGxvYWQ4U2lnbmVkKCkgYW5kIGxvYWQxNlNpZ25lZCgpIHRvIG9ubHkgc2ln biBleHRlbmQgdGhlIGxvYWRlZCB2YWx1ZSB0byAzMiBiaXRzCisgICAgICAgIGluc3RlYWQgb2Yg NjQgYml0cy4gIFRoaXMgaXMgd2hhdCBYODYtNjQgZG9lcy4KKworICAgICAgICAqIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJN NjQ6OmxvYWQxNlNpZ25lZCk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6Omxv YWQ4U2lnbmVkKToKKwogMjAxNS0wMy0yNyAgU2FhbSBCYXJhdGkgIDxzYWFtYmFyYXRpMUBnbWFp bC5jb20+CiAKICAgICAgICAgQWRkIGJhY2sgcHJldmlvdXNseSBicm9rZW4gYXNzZXJ0IGZyb20g YnVnIDE0MTg2OQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTTY0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgJKHJldmlzaW9uIDE4MjA1NykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCSh3b3JraW5nIGNv cHkpCkBAIC05MjEsMTMgKzkyMSwxMyBAQCBwdWJsaWM6CiAgICAgdm9pZCBsb2FkMTZTaWduZWQo QmFzZUluZGV4IGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKICAgICB7CiAgICAgICAgIGlmICgh YWRkcmVzcy5vZmZzZXQgJiYgKCFhZGRyZXNzLnNjYWxlIHx8IGFkZHJlc3Muc2NhbGUgPT0gMSkp IHsKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLmxkcnNoPDY0PihkZXN0LCBhZGRyZXNzLmJhc2Us IGFkZHJlc3MuaW5kZXgsIEFSTTY0QXNzZW1ibGVyOjpVWFRYLCBhZGRyZXNzLnNjYWxlKTsKKyAg ICAgICAgICAgIG1fYXNzZW1ibGVyLmxkcnNoPDMyPihkZXN0LCBhZGRyZXNzLmJhc2UsIGFkZHJl c3MuaW5kZXgsIEFSTTY0QXNzZW1ibGVyOjpVWFRYLCBhZGRyZXNzLnNjYWxlKTsKICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgfQogCiAgICAgICAgIHNpZ25FeHRlbmQzMlRvUHRyKFRydXN0 ZWRJbW0zMihhZGRyZXNzLm9mZnNldCksIGdldENhY2hlZE1lbW9yeVRlbXBSZWdpc3RlcklEQW5k SW52YWxpZGF0ZSgpKTsKICAgICAgICAgbV9hc3NlbWJsZXIuYWRkPDY0PihtZW1vcnlUZW1wUmVn aXN0ZXIsIG1lbW9yeVRlbXBSZWdpc3RlciwgYWRkcmVzcy5pbmRleCwgQVJNNjRBc3NlbWJsZXI6 OlVYVFgsIGFkZHJlc3Muc2NhbGUpOwotICAgICAgICBtX2Fzc2VtYmxlci5sZHJzaDw2ND4oZGVz dCwgYWRkcmVzcy5iYXNlLCBtZW1vcnlUZW1wUmVnaXN0ZXIpOworICAgICAgICBtX2Fzc2VtYmxl ci5sZHJzaDwzMj4oZGVzdCwgYWRkcmVzcy5iYXNlLCBtZW1vcnlUZW1wUmVnaXN0ZXIpOwogICAg IH0KIAogICAgIHZvaWQgbG9hZDgoSW1wbGljaXRBZGRyZXNzIGFkZHJlc3MsIFJlZ2lzdGVySUQg ZGVzdCkKQEAgLTk2MiwxMyArOTYyLDEzIEBAIHB1YmxpYzoKICAgICB2b2lkIGxvYWQ4U2lnbmVk KEJhc2VJbmRleCBhZGRyZXNzLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBpZiAo IWFkZHJlc3Mub2Zmc2V0ICYmICFhZGRyZXNzLnNjYWxlKSB7Ci0gICAgICAgICAgICBtX2Fzc2Vt Ymxlci5sZHJzYjw2ND4oZGVzdCwgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLmluZGV4LCBBUk02NEFz c2VtYmxlcjo6VVhUWCwgYWRkcmVzcy5zY2FsZSk7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5s ZHJzYjwzMj4oZGVzdCwgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLmluZGV4LCBBUk02NEFzc2VtYmxl cjo6VVhUWCwgYWRkcmVzcy5zY2FsZSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K IAogICAgICAgICBzaWduRXh0ZW5kMzJUb1B0cihUcnVzdGVkSW1tMzIoYWRkcmVzcy5vZmZzZXQp LCBnZXRDYWNoZWRNZW1vcnlUZW1wUmVnaXN0ZXJJREFuZEludmFsaWRhdGUoKSk7CiAgICAgICAg IG1fYXNzZW1ibGVyLmFkZDw2ND4obWVtb3J5VGVtcFJlZ2lzdGVyLCBtZW1vcnlUZW1wUmVnaXN0 ZXIsIGFkZHJlc3MuaW5kZXgsIEFSTTY0QXNzZW1ibGVyOjpVWFRYLCBhZGRyZXNzLnNjYWxlKTsK LSAgICAgICAgbV9hc3NlbWJsZXIubGRyc2I8NjQ+KGRlc3QsIGFkZHJlc3MuYmFzZSwgbWVtb3J5 VGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgbV9hc3NlbWJsZXIubGRyc2I8MzI+KGRlc3QsIGFkZHJl c3MuYmFzZSwgbWVtb3J5VGVtcFJlZ2lzdGVyKTsKICAgICB9CiAKICAgICB2b2lkIHN0b3JlNjQo UmVnaXN0ZXJJRCBzcmMsIEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzKQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTgyMDkwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTUtMDMtMjcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CisKKyAgICAgICAgRml4IGZsYWtleSBkZmctaW50OGFycmF5LmpzIGFuZCBkZmctaW50MTZh cnJheS5qcyB0ZXN0cyBmb3IgQVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzODM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlZW5hYmxlZCB0aGUgdGVzdHMgZm9yIEFSTTY0L2lPUy4gIExlZnQg dGhlIHRlc3RzIGRpc2FibGVkIGZvciBBUk02NC9saW51eCBhbmQgd2lsbCBsZXQgbGludXgKKyAg ICAgICAgZGV2ZWxvcGVycyB0ZXN0IGFuZCByZWVuYWJsZSB1bmRlciBleGlzdGluZyBidXQgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjYyOS4KKworICAgICAgICAq IGpzL3NjcmlwdC10ZXN0cy9kZmctaW50MTZhcnJheS5qczoKKyAgICAgICAgKiBqcy9zY3JpcHQt dGVzdHMvZGZnLWludDhhcnJheS5qczoKKwogMjAxNS0wMy0yNyAgSmVyIE5vYmxlICA8amVyLm5v YmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBTYWZhcmkgZmFpbHMgdG8gZmlyZSBwYWdl ICJsb2FkIiBldmVudCB3aXRoIHZpZGVvW3ByZWxvYWQ9bm9uZV0KSW5kZXg6IExheW91dFRlc3Rz L2pzL3NjcmlwdC10ZXN0cy9kZmctaW50OGFycmF5LmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2pzL3NjcmlwdC10ZXN0cy9kZmctaW50OGFycmF5LmpzCShyZXZpc2lvbiAxODIwNTcpCisr KyBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvZGZnLWludDhhcnJheS5qcwkod29ya2luZyBj b3B5KQpAQCAtMSwxMCArMSw3IEBACiAvLyBSRUdSRVNTSU9OKHIxODEzMjYpOiBJdCBtYWRlIGRm Zy1pbnQxNmFycmF5LmpzIGFuZCBkZmctaW50OGFycmF5LmpzIGZhaWwgb24gQUFyY2g2NCBMaW51 eAogLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjYyOQogCi0v LyBGaXggZmxha2V5IGRmZy1pbnQ4YXJyYXkuanMgYW5kIGRmZy1pbnQxNmFycmF5LmpzIHRlc3Rz IGZvciBBUk02NAotLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz ODM5MAotCi0vL0Agc2tpcCBpZiAkYXJjaGl0ZWN0dXJlID09ICJhcm02NCIKKy8vQCBza2lwIGlm ICRhcmNoaXRlY3R1cmUgPT0gImFybTY0IiBhbmQgJGhvc3RPUyA9PSAibGludXgiCiAKIGRlc2Ny aXB0aW9uKAogIlRoaXMgdGVzdHMgdGhhdCBpbnQ4IGFycmF5cyB3b3JrIGluIHRoZSBERkcuIgpJ bmRleDogTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2RmZy1pbnQxNmFycmF5LmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9kZmctaW50MTZhcnJheS5qcwko cmV2aXNpb24gMTgyMDU3KQorKysgTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2RmZy1pbnQx NmFycmF5LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDEwICsxLDcgQEAKIC8vIFJFR1JFU1NJT04o cjE4MTMyNik6IEl0IG1hZGUgZGZnLWludDE2YXJyYXkuanMgYW5kIGRmZy1pbnQ4YXJyYXkuanMg ZmFpbCBvbiBBQXJjaDY0IExpbnV4CiAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQyNjI5CiAKLS8vIEZpeCBmbGFrZXkgZGZnLWludDhhcnJheS5qcyBhbmQgZGZn LWludDE2YXJyYXkuanMgdGVzdHMgZm9yIEFSTTY0Ci0vLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzkwCi0KLS8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgPT0g ImFybTY0IgorLy9AIHNraXAgaWYgJGFyY2hpdGVjdHVyZSA9PSAiYXJtNjQiIGFuZCAkaG9zdE9T ID09ICJsaW51eCIKIAogZGVzY3JpcHRpb24oCiAiVGhpcyB0ZXN0cyB0aGF0IGludDE2IGFycmF5 cyB3b3JrIGluIHRoZSBERkcuIgo=