138389 2014-11-04 17:26:08 -0800 Allow constructing a PassRef from a Ref 2014-11-05 16:16:25 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin kling oldest_to_newest 1046305 0 cdumez 2014-11-04 17:26:08 -0800 Allow constructing a PassRef from a Ref, similarly to PassRefPtr that can be constructed from a RefPtr already. This avoids having to call Ref::get() and simplifies the code a bit. 1046325 1 240991 cdumez 2014-11-04 18:03:00 -0800 Created attachment 240991 Patch 1046636 2 240991 kling 2014-11-05 15:36:32 -0800 Comment on attachment 240991 Patch Seems fine. r=me 1046650 3 240991 commit-queue 2014-11-05 16:16:22 -0800 Comment on attachment 240991 Patch Clearing flags on attachment: 240991 Committed r175648: <http://trac.webkit.org/changeset/175648> 1046651 4 commit-queue 2014-11-05 16:16:25 -0800 All reviewed patches have been landed. Closing bug. 240991 2014-11-04 18:03:00 -0800 2014-11-05 16:16:22 -0800 Patch bug-138389-20141104180309.patch text/plain 6117 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE0YzM5MDFhNWQwNmIyZjQxOWI0NTgy ZWVlOTZjZGMzZjAzMzM5NmYuLmY4Nzc3YTA4YTRjZDcwOWY4NjQ4MzdkZDU2NjJhYjJmMGI5YWEx MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTQtMTEtMDQgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAorICAgICAgICBBbGxvdyBjb25zdHJ1Y3RpbmcgYSBQYXNzUmVmIGZyb20g YSBSZWYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz ODM4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFs bG93IGNvbnN0cnVjdGluZyBhIFBhc3NSZWYgZnJvbSBhIFJlZiwgc2ltaWxhcmx5IHRvIFBhc3NS ZWZQdHIgdGhhdAorICAgICAgICBjYW4gYmUgY29uc3RydWN0ZWQgZnJvbSBhIFJlZlB0ciBhbHJl YWR5LiBUaGlzIGF2b2lkcyBoYXZpbmcgdG8gY2FsbAorICAgICAgICBSZWY6OmdldCgpIGFuZCBz aW1wbGlmaWVzIHRoZSBjb2RlIGEgYml0LgorCisgICAgICAgICogd3RmL1Bhc3NSZWYuaDoKKyAg ICAgICAgKFdURjo6UGFzc1JlZjxUPjo6UGFzc1JlZik6CisKKzIwMTQtMTEtMDQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgcHRyKCkgbWV0aG9kIHRvIFJl ZiBjbGFzcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM4MzYxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjOGQ5ZDZmNjhiYTMyNWUxYTEzMTRhOTExNTg1MTI3MWE3 OTNiNmQ0Li42NDQ3ZDhjNmJkNWM1MjQ3YmZhZDFkMWFmMTljY2ExNzI3Njk0MzYyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTQtMTEtMDQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KKworICAgICAgICBBbGxvdyBjb25zdHJ1Y3RpbmcgYSBQYXNzUmVmIGZyb20gYSBS ZWYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODM4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBjYWxscyB0byBSZWY6OmdldCgpIG5vdyB0aGF0IGEgUGFzc1JlZiBjYW4gYmUgZGlyZWN0bHkK KyAgICAgICAgY29uc3RydWN0ZWQgZnJvbSBhIFJlZi4KKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNzcy9DU1NWYWx1ZVBvb2wuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTVmFsdWVQb29sOjpjcmVhdGVDb2xvclZhbHVlKToKKyAgICAg ICAgKiBjc3MvQ1NTVmFsdWVQb29sLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NWYWx1ZVBvb2w6 OmNyZWF0ZUluaGVyaXRlZFZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ZhbHVlUG9vbDo6 Y3JlYXRlSW1wbGljaXRJbml0aWFsVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTVmFsdWVQ b29sOjpjcmVhdGVFeHBsaWNpdEluaXRpYWxWYWx1ZSk6CisgICAgICAgICogaHRtbC9IVE1MTGlu a0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTExpbmtFbGVtZW50OjpzZXRDU1NT dHlsZVNoZWV0KToKKwogMjAxNC0xMS0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBhdXNlIG9uIGV4Y2VwdGlvbnMgc2hv dWxkIHNob3cgdGhlIGFjdHVhbCBleGNlcHRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L1Bhc3NSZWYuaCBiL1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWYuaAppbmRleCBkMzc0YWU1ZDk5YTY0 ZmMxOGVkNzYwODM0OWFmODIxMTk0OTkwYmJiLi44ODM2NTFlYzVmYTE5YzM1YzlhYTllZTQwODQ2 OTgwZTRiYzNhNWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QYXNzUmVmLmgKKysrIGIv U291cmNlL1dURi93dGYvUGFzc1JlZi5oCkBAIC00MCw2ICs0MCw3IEBAIHRlbXBsYXRlPHR5cGVu YW1lIFQ+IGNsYXNzIFBhc3NSZWYgewogcHVibGljOgogICAgIFBhc3NSZWYoVCYpOwogICAgIFBh c3NSZWYoUGFzc1JlZiYmKTsKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBQYXNzUmVmKGNvbnN0 IFJlZjxVPiYpOwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IFBhc3NSZWYoUGFzc1JlZjxVPik7 CiAKICAgICBjb25zdCBUJiBnZXQoKSBjb25zdDsKQEAgLTk4LDYgKzk5LDE1IEBAIHRlbXBsYXRl PHR5cGVuYW1lIFQ+IHRlbXBsYXRlPHR5cGVuYW1lIFU+IGlubGluZSBQYXNzUmVmPFQ+OjpQYXNz UmVmKFBhc3NSZWY8VT4KIHsKIH0KIAordGVtcGxhdGU8dHlwZW5hbWUgVD4gdGVtcGxhdGU8dHlw ZW5hbWUgVT4gaW5saW5lIFBhc3NSZWY8VD46OlBhc3NSZWYoY29uc3QgUmVmPFU+JiBvdGhlcikK KyAgICA6IG1fcmVmZXJlbmNlKGNvbnN0X2Nhc3Q8VCY+KG90aGVyLmdldCgpKSkKKyNpZm5kZWYg TkRFQlVHCisgICAgLCBtX2dhdmVVcFJlZmVyZW5jZShmYWxzZSkKKyNlbmRpZgoreworICAgIG1f cmVmZXJlbmNlLnJlZigpOworfQorCiAjaWZuZGVmIE5ERUJVRwogCiB0ZW1wbGF0ZTx0eXBlbmFt ZSBUPiBQYXNzUmVmPFQ+Ojp+UGFzc1JlZigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTVmFsdWVQb29sLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZVBvb2wuY3Bw CmluZGV4IGRkYThmMmE0NTg1MTczODFiMTkzODQyODM0Zjk0NTdjZjg5ZDViOWIuLmJlOTk0MzQ2 ODM2MjlhZmRhZWNjZWE2NzI0NzVlMzYxYzdkYzUzMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NWYWx1ZVBvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1 ZVBvb2wuY3BwCkBAIC02OSwxMiArNjksMTIgQEAgUGFzc1JlZjxDU1NQcmltaXRpdmVWYWx1ZT4g Q1NTVmFsdWVQb29sOjpjcmVhdGVDb2xvclZhbHVlKHVuc2lnbmVkIHJnYlZhbHVlKQogewogICAg IC8vIFRoZXNlIGFyZSB0aGUgZW1wdHkgYW5kIGRlbGV0ZWQgdmFsdWVzIG9mIHRoZSBoYXNoIHRh YmxlLgogICAgIGlmIChyZ2JWYWx1ZSA9PSBDb2xvcjo6dHJhbnNwYXJlbnQpCi0gICAgICAgIHJl dHVybiBtX2NvbG9yVHJhbnNwYXJlbnQuZ2V0KCk7CisgICAgICAgIHJldHVybiBtX2NvbG9yVHJh bnNwYXJlbnQ7CiAgICAgaWYgKHJnYlZhbHVlID09IENvbG9yOjp3aGl0ZSkKLSAgICAgICAgcmV0 dXJuIG1fY29sb3JXaGl0ZS5nZXQoKTsKKyAgICAgICAgcmV0dXJuIG1fY29sb3JXaGl0ZTsKICAg ICAvLyBKdXN0IGJlY2F1c2UgaXQgaXMgY29tbW9uLgogICAgIGlmIChyZ2JWYWx1ZSA9PSBDb2xv cjo6YmxhY2spCi0gICAgICAgIHJldHVybiBtX2NvbG9yQmxhY2suZ2V0KCk7CisgICAgICAgIHJl dHVybiBtX2NvbG9yQmxhY2s7CiAKICAgICAvLyBSZW1vdmUgb25lIGVudHJ5IGF0IHJhbmRvbSBp ZiB0aGUgY2FjaGUgZ3Jvd3MgdG9vIGxhcmdlLgogICAgIGNvbnN0IGludCBtYXhpbXVtQ29sb3JD YWNoZVNpemUgPSA1MTI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQ b29sLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29sLmgKaW5kZXggNzc1MGZkYzVi NGFjYmY1ODNlMDAxNmU0ZTBmYjMxNWIwOTI0MjY3Mi4uMzM5NjQ1MzkxZmViZDMxZjlkZTBmYmE1 MjljYWQ4OGY5YzAyNjNmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVl UG9vbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZVBvb2wuaApAQCAtNDUsOSAr NDUsOSBAQCBjbGFzcyBDU1NWYWx1ZVBvb2wgewogcHVibGljOgogICAgIFBhc3NSZWZQdHI8Q1NT VmFsdWVMaXN0PiBjcmVhdGVGb250RmFjZVZhbHVlKGNvbnN0IEF0b21pY1N0cmluZyYpOwogICAg IFBhc3NSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZUZvbnRGYW1pbHlWYWx1ZShjb25zdCBT dHJpbmcmKTsKLSAgICBQYXNzUmVmPENTU0luaGVyaXRlZFZhbHVlPiBjcmVhdGVJbmhlcml0ZWRW YWx1ZSgpIHsgcmV0dXJuIG1faW5oZXJpdGVkVmFsdWUuZ2V0KCk7IH0KLSAgICBQYXNzUmVmPENT U0luaXRpYWxWYWx1ZT4gY3JlYXRlSW1wbGljaXRJbml0aWFsVmFsdWUoKSB7IHJldHVybiBtX2lt cGxpY2l0SW5pdGlhbFZhbHVlLmdldCgpOyB9Ci0gICAgUGFzc1JlZjxDU1NJbml0aWFsVmFsdWU+ IGNyZWF0ZUV4cGxpY2l0SW5pdGlhbFZhbHVlKCkgeyByZXR1cm4gbV9leHBsaWNpdEluaXRpYWxW YWx1ZS5nZXQoKTsgfQorICAgIFBhc3NSZWY8Q1NTSW5oZXJpdGVkVmFsdWU+IGNyZWF0ZUluaGVy aXRlZFZhbHVlKCkgeyByZXR1cm4gbV9pbmhlcml0ZWRWYWx1ZTsgfQorICAgIFBhc3NSZWY8Q1NT SW5pdGlhbFZhbHVlPiBjcmVhdGVJbXBsaWNpdEluaXRpYWxWYWx1ZSgpIHsgcmV0dXJuIG1faW1w bGljaXRJbml0aWFsVmFsdWU7IH0KKyAgICBQYXNzUmVmPENTU0luaXRpYWxWYWx1ZT4gY3JlYXRl RXhwbGljaXRJbml0aWFsVmFsdWUoKSB7IHJldHVybiBtX2V4cGxpY2l0SW5pdGlhbFZhbHVlOyB9 CiAgICAgUGFzc1JlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlSWRlbnRpZmllclZhbHVlKENT U1ZhbHVlSUQgaWRlbnRpZmllcik7CiAgICAgUGFzc1JlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3Jl YXRlSWRlbnRpZmllclZhbHVlKENTU1Byb3BlcnR5SUQgaWRlbnRpZmllcik7CiAgICAgUGFzc1Jl ZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlQ29sb3JWYWx1ZSh1bnNpZ25lZCByZ2JWYWx1ZSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKaW5kZXggMmI0NWVlZWI5MTFm MGIxOWFlZTQzYTI3MWJhMjQ2MmQwMDE2N2VhMi4uNjk2NDFmMTEwYTdjNDI1YjRiNjE3NTVlNzEy MzFjNjkzYTdmNDAxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0Vs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcApA QCAtMzI4LDcgKzMyOCw3IEBAIHZvaWQgSFRNTExpbmtFbGVtZW50OjpzZXRDU1NTdHlsZVNoZWV0 KGNvbnN0IFN0cmluZyYgaHJlZiwgY29uc3QgVVJMJiBiYXNlVVJMLCBjCiAgICAgfQogCiAgICAg UmVmPFN0eWxlU2hlZXRDb250ZW50cz4gc3R5bGVTaGVldChTdHlsZVNoZWV0Q29udGVudHM6OmNy ZWF0ZShocmVmLCBwYXJzZXJDb250ZXh0KSk7Ci0gICAgbV9zaGVldCA9IENTU1N0eWxlU2hlZXQ6 OmNyZWF0ZShzdHlsZVNoZWV0LmdldCgpLCB0aGlzKTsKKyAgICBtX3NoZWV0ID0gQ1NTU3R5bGVT aGVldDo6Y3JlYXRlKHN0eWxlU2hlZXQsIHRoaXMpOwogICAgIG1fc2hlZXQtPnNldE1lZGlhUXVl cmllcyhNZWRpYVF1ZXJ5U2V0OjpjcmVhdGVBbGxvd2luZ0Rlc2NyaXB0aW9uU3ludGF4KG1fbWVk aWEpKTsKICAgICBtX3NoZWV0LT5zZXRUaXRsZSh0aXRsZSgpKTsKIApAQCAtMzM5LDcgKzMzOSw3 IEBAIHZvaWQgSFRNTExpbmtFbGVtZW50OjpzZXRDU1NTdHlsZVNoZWV0KGNvbnN0IFN0cmluZyYg aHJlZiwgY29uc3QgVVJMJiBiYXNlVVJMLCBjCiAgICAgc3R5bGVTaGVldC5nZXQoKS5jaGVja0xv YWRlZCgpOwogCiAgICAgaWYgKHN0eWxlU2hlZXQuZ2V0KCkuaXNDYWNoZWFibGUoKSkKLSAgICAg ICAgY29uc3RfY2FzdDxDYWNoZWRDU1NTdHlsZVNoZWV0Kj4oY2FjaGVkU3R5bGVTaGVldCktPnNh dmVQYXJzZWRTdHlsZVNoZWV0KHN0eWxlU2hlZXQuZ2V0KCkpOworICAgICAgICBjb25zdF9jYXN0 PENhY2hlZENTU1N0eWxlU2hlZXQqPihjYWNoZWRTdHlsZVNoZWV0KS0+c2F2ZVBhcnNlZFN0eWxl U2hlZXQoc3R5bGVTaGVldCk7CiB9CiAKIGJvb2wgSFRNTExpbmtFbGVtZW50OjpzdHlsZVNoZWV0 SXNMb2FkaW5nKCkgY29uc3QK