138387 2014-11-04 17:08:49 -0800 Web Inspector: Lots of TimelineDataGridNode asserts on reloads 2014-11-04 18:31:55 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1046294 0 joepeck 2014-11-04 17:08:49 -0800 * SUMMARY Hundreds of of TimelineDataGridNode asserts reloading pages. console.assert(isFinite(secondsPerPixel) && secondsPerPixel > 0); [Error] Assertion failed: refreshGraph (TimelineDataGridNode.js, line 240) updateLayout (OverviewTimelineView.js, line 110) updateLayoutIfNeeded (TimelineView.js, line 217) _updateTimes (TimelineContentView.js, line 367) _update (TimelineContentView.js, line 331) (anonymous function) ([native code], line 0) * STEPS TO REPRODUCE 1. Inspect http://daringfireball.net 2. Ensure Resource sidebar is selected not Timelines. Close and reopen inspector if needed. 3. Reload page => hundreds of asserts * NOTES secondsPerPixel is 0. 1046295 1 webkit-bug-importer 2014-11-04 17:09:18 -0800 <rdar://problem/18875354> 1046296 2 240984 joepeck 2014-11-04 17:11:13 -0800 Created attachment 240984 [PATCH] Proposed Fix 1046321 3 240984 burg 2014-11-04 17:54:13 -0800 Comment on attachment 240984 [PATCH] Proposed Fix Another thought (maybe a different bug): why do we refresh the timeline ruler's layout when it's not visible? This seems like a lot of work for no reason. 1046333 4 joepeck 2014-11-04 18:22:30 -0800 (In reply to comment #3) > Comment on attachment 240984 [details] > [PATCH] Proposed Fix > > Another thought (maybe a different bug): why do we refresh the timeline > ruler's layout when it's not visible? This seems like a lot of work for no > reason. Totally agree. I'll file a bug about that right now. 1046338 5 240984 commit-queue 2014-11-04 18:31:52 -0800 Comment on attachment 240984 [PATCH] Proposed Fix Clearing flags on attachment: 240984 Committed r175598: <http://trac.webkit.org/changeset/175598> 1046339 6 commit-queue 2014-11-04 18:31:55 -0800 All reviewed patches have been landed. Closing bug. 240984 2014-11-04 17:11:13 -0800 2014-11-04 18:31:52 -0800 [PATCH] Proposed Fix fix-assert.patch text/plain 2580 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRiYWJkNzIuLjI1ODg4ZmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTExLTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTG90cyBv ZiBUaW1lbGluZURhdGFHcmlkTm9kZSBhc3NlcnRzIG9uIHJlbG9hZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODM4NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBUaW1lbGluZVJ1bGVyLnNlY29u ZHNQZXJQaXhlbCBpbiB0aGUgVGltZWxpbmVPdmVydmlldyBpcyBpbml0aWFsaXplZAorICAgICAg ICB3aXRoIGEgbm9uLTAgdmFsdWUgYW5kIHNhdmVkIGluIGEgc2V0dGluZy4gSG93ZXZlciB0aGUg VGltZWxpbmVSdWxlciBpbgorICAgICAgICB0aGUgT3ZlcnZpZXdUaW1lbGluZVZpZXcgaXMgbm90 IGluaXRpYWxpemVkIHdpdGggdGhpcyB2YWx1ZSwgYW5kIGluc3RlYWQKKyAgICAgICAgaW5pdGlh bGl6ZWQgdG8gMC4gVGhpcyBwYXRjaCBpbml0aWFsaXplcyB0aGVtIHRvIHRoZSBzYW1lIG5vbi0w IHZhbHVlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PdmVydmlld1RpbWVsaW5l Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PdmVydmlld1RpbWVsaW5lVmlldy5wcm90 b3R5cGUuc2V0IHNlY29uZHNQZXJQaXhlbCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZUNvbnRlbnRWaWV3LmpzOgorCisyMDE0LTExLTA0ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVG9vIG11Y2gg d2hpdGVzcGFjZSBpbiByZXNvdXJjZSBkZXRhaWxzIHNpZGViYXIgaW4gZ3JvdXBzCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzODYKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdU aW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9PdmVydmlld1RpbWVsaW5lVmlldy5qcwppbmRleCBhYWZjYTRmLi4xYzQ5ZGZiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PdmVydmlld1Rp bWVsaW5lVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9PdmVydmlld1RpbWVsaW5lVmlldy5qcwpAQCAtNzYsNiArNzYsMTEgQEAgV2ViSW5zcGVj dG9yLk92ZXJ2aWV3VGltZWxpbmVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRo aXMuX3RpbWVsaW5lUnVsZXIuc2Vjb25kc1BlclBpeGVsOwogICAgIH0sCiAKKyAgICBzZXQgc2Vj b25kc1BlclBpeGVsKHgpCisgICAgeworICAgICAgICB0aGlzLl90aW1lbGluZVJ1bGVyLnNlY29u ZHNQZXJQaXhlbCA9IHg7CisgICAgfSwKKwogICAgIHNob3duOiBmdW5jdGlvbigpCiAgICAgewog ICAgICAgICBXZWJJbnNwZWN0b3IuVGltZWxpbmVWaWV3LnByb3RvdHlwZS5zaG93bi5jYWxsKHRo aXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lQ29udGVudFZpZXcuanMKaW5kZXggYTIwM2YyZS4uYTM2NGJj NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZUNvbnRlbnRWaWV3LmpzCkBAIC01Myw2ICs1Myw3IEBAIFdl Ykluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3ID0gZnVuY3Rpb24ocmVjb3JkaW5nKQogICAg IHRoaXMuX2NsZWFyVGltZWxpbmVOYXZpZ2F0aW9uSXRlbS5hZGRFdmVudExpc3RlbmVyKFdlYklu c3BlY3Rvci5CdXR0b25OYXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlzLl9jbGVhclRp bWVsaW5lLCB0aGlzKTsKIAogICAgIHRoaXMuX292ZXJ2aWV3VGltZWxpbmVWaWV3ID0gbmV3IFdl Ykluc3BlY3Rvci5PdmVydmlld1RpbWVsaW5lVmlldyhyZWNvcmRpbmcpOworICAgIHRoaXMuX292 ZXJ2aWV3VGltZWxpbmVWaWV3LnNlY29uZHNQZXJQaXhlbCA9IHRoaXMuX3RpbWVsaW5lT3ZlcnZp ZXcuc2Vjb25kc1BlclBpeGVsOwogCiAgICAgdGhpcy5fZGlzY3JldGVUaW1lbGluZVZpZXdNYXAg PSBuZXcgTWFwOwogICAgIGZvciAodmFyIFtpZGVudGlmaWVyLCB0aW1lbGluZV0gb2YgcmVjb3Jk aW5nLnRpbWVsaW5lcykK