138377 2014-11-04 15:03:19 -0800 Remove two unused ScrollingCoordinator methods. 2014-11-04 15:14:25 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling cmarcelo commit-queue jamesr kling luiz tonikitoo oldest_to_newest 1046197 0 kling 2014-11-04 15:03:19 -0800 These functions appear to be unused: scrollLayerForScrollableArea horizontalScrollbarLayerForScrollableArea verticalScrollbarLayerForScrollableArea 1046198 1 240954 kling 2014-11-04 15:03:46 -0800 Created attachment 240954 Patch 1046200 2 240954 cdumez 2014-11-04 15:06:17 -0800 Comment on attachment 240954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240954&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.h:-211 > - static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea*); Isn't this used for CoordinatedGraphics? Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp 1046201 3 kling 2014-11-04 15:07:04 -0800 (In reply to comment #2) > Comment on attachment 240954 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240954&action=review > > > Source/WebCore/page/scrolling/ScrollingCoordinator.h:-211 > > - static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea*); > > Isn't this used for CoordinatedGraphics? > Source/WebCore/page/scrolling/coordinatedgraphics/ > ScrollingCoordinatorCoordinatedGraphics.cpp Whoops! Right you are. 1046204 4 240955 kling 2014-11-04 15:08:50 -0800 Created attachment 240955 Patch II 1046205 5 240955 cdumez 2014-11-04 15:09:19 -0800 Comment on attachment 240955 Patch II r=me 1046207 6 kling 2014-11-04 15:14:25 -0800 Committed r175584: <http://trac.webkit.org/changeset/175584> 240954 2014-11-04 15:03:46 -0800 2014-11-04 15:08:50 -0800 Patch bug-138377.diff text/plain 2779 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZmM1ODQwLi5lZTY1MjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMTEtMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSB0aHJlZSB1bnVzZWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3IgbWV0aG9kcy4KKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzODM3Nz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSBhcHBlYXIgdG8gYmUgbGVmdG92ZXJz IGZyb20gdGhlIG5vdy1kZWZ1bmN0IGNocm9taXVtIHBvcnQuCisKKyAgICAgICAgKiBwYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3Jv bGxpbmdDb29yZGluYXRvcjo6c2Nyb2xsTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYSk6IERlbGV0ZWQu CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6aG9yaXpvbnRhbFNjcm9s bGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxl QXJlYSk6IERlbGV0ZWQuCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRp bmF0b3IuaDoKKwogMjAxNC0xMS0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBwdHIoKSBtZXRob2QgdG8gUmVmIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKaW5kZXgg NWZhZDc5ZC4uZTM1ZmNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcApAQCAtMTk0LDIxICsxOTQsNiBAQCB2b2lk IFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpmcmFtZVZpZXdGaXhlZE9iamVjdHNEaWRDaGFuZ2UoRnJh bWVWaWV3KiBmcmFtZVZpZXcpCiAgICAgdXBkYXRlU3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25z KGZyYW1lVmlldyk7CiB9CiAKLUdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpz Y3JvbGxMYXllckZvclNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJl YSkKLXsKLSAgICByZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yU2Nyb2xsaW5nKCk7Ci19 Ci0KLUdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpob3Jpem9udGFsU2Nyb2xs YmFyTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEp Ci17Ci0gICAgcmV0dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvckhvcml6b250YWxTY3JvbGxi YXIoKTsKLX0KLQotR3JhcGhpY3NMYXllciogU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2Fs U2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJs ZUFyZWEpCi17Ci0gICAgcmV0dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvclZlcnRpY2FsU2Ny b2xsYmFyKCk7Ci19Ci0KIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3Jv bGxMYXllckZvckZyYW1lVmlldyhGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsKICAgICBpZiAoUmVu ZGVyVmlldyogcmVuZGVyVmlldyA9IGZyYW1lVmlldy0+ZnJhbWUoKS5jb250ZW50UmVuZGVyZXIo KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nv b3JkaW5hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29y ZGluYXRvci5oCmluZGV4IDM5M2ZhZjYuLjE3OTQ2ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApAQCAtMjA4LDEwICsy MDgsNiBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAgZXhwbGljaXQgU2Nyb2xsaW5nQ29vcmRp bmF0b3IoUGFnZSopOwogCi0gICAgc3RhdGljIEdyYXBoaWNzTGF5ZXIqIHNjcm9sbExheWVyRm9y U2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEqKTsKLSAgICBzdGF0aWMgR3JhcGhpY3NMYXll ciogaG9yaXpvbnRhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFy ZWEqKTsKLSAgICBzdGF0aWMgR3JhcGhpY3NMYXllciogdmVydGljYWxTY3JvbGxiYXJMYXllckZv clNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKik7Ci0KICAgICB1bnNpZ25lZCBjb21wdXRl Q3VycmVudFdoZWVsRXZlbnRIYW5kbGVyQ291bnQoKTsKICAgICBHcmFwaGljc0xheWVyKiBzY3Jv bGxMYXllckZvckZyYW1lVmlldyhGcmFtZVZpZXcqKTsKICAgICBHcmFwaGljc0xheWVyKiBjb3Vu dGVyU2Nyb2xsaW5nTGF5ZXJGb3JGcmFtZVZpZXcoRnJhbWVWaWV3Kik7Cg== 240955 2014-11-04 15:08:50 -0800 2014-11-04 15:09:19 -0800 Patch II bug-138377-2.diff text/plain 2462 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZmM1ODQwLi4wZThjODA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMTEtMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSB0d28gdW51c2VkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yIG1ldGhvZHMuCisgICAg ICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzgzNzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgYXBwZWFyIHRvIGJlIGxlZnRvdmVycyBm cm9tIHRoZSBub3ctZGVmdW5jdCBjaHJvbWl1bSBwb3J0LgorCisgICAgICAgICogcGFnZS9zY3Jv bGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs aW5nQ29vcmRpbmF0b3I6Omhvcml6b250YWxTY3JvbGxiYXJMYXllckZvclNjcm9sbGFibGVBcmVh KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yOjp2ZXJ0 aWNhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEpOiBEZWxldGVkLgorICAgICAgICAq IHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmg6CisKIDIwMTQtMTEtMDQgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcHRyKCkgbWV0aG9k IHRvIFJlZiBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv U2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv U2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IDVmYWQ3OWQuLmE5MTQwNTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRv ci5jcHAKQEAgLTE5OSwxNiArMTk5LDYgQEAgR3JhcGhpY3NMYXllciogU2Nyb2xsaW5nQ29vcmRp bmF0b3I6OnNjcm9sbExheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEKICAgICBy ZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yU2Nyb2xsaW5nKCk7CiB9CiAKLUdyYXBoaWNz TGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXJGb3JT Y3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEpCi17Ci0gICAgcmV0 dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIoKTsKLX0KLQot R3JhcGhpY3NMYXllciogU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2FsU2Nyb2xsYmFyTGF5 ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEpCi17Ci0g ICAgcmV0dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvclZlcnRpY2FsU2Nyb2xsYmFyKCk7Ci19 Ci0KIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxMYXllckZvckZy YW1lVmlldyhGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsKICAgICBpZiAoUmVuZGVyVmlldyogcmVu ZGVyVmlldyA9IGZyYW1lVmlldy0+ZnJhbWUoKS5jb250ZW50UmVuZGVyZXIoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oCmlu ZGV4IDM5M2ZhZjYuLmMwYzUyN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApAQCAtMjA5LDggKzIwOSw2IEBAIHByb3Rl Y3RlZDoKICAgICBleHBsaWNpdCBTY3JvbGxpbmdDb29yZGluYXRvcihQYWdlKik7CiAKICAgICBz dGF0aWMgR3JhcGhpY3NMYXllciogc2Nyb2xsTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxh YmxlQXJlYSopOwotICAgIHN0YXRpYyBHcmFwaGljc0xheWVyKiBob3Jpem9udGFsU2Nyb2xsYmFy TGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSopOwotICAgIHN0YXRpYyBHcmFw aGljc0xheWVyKiB2ZXJ0aWNhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xs YWJsZUFyZWEqKTsKIAogICAgIHVuc2lnbmVkIGNvbXB1dGVDdXJyZW50V2hlZWxFdmVudEhhbmRs ZXJDb3VudCgpOwogICAgIEdyYXBoaWNzTGF5ZXIqIHNjcm9sbExheWVyRm9yRnJhbWVWaWV3KEZy YW1lVmlldyopOwo=