138367 2014-11-04 13:04:12 -0800 RenderBox shouldn't need a pre-destructor hook. 2014-11-04 14:16:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn koivisto kondapallykalyan oldest_to_newest 1046150 0 kling 2014-11-04 13:04:12 -0800 RenderBox::willBeDestroyed() does a couple of things, but none of them require the renderer to be in-tree, nor does it do any virtual dispatch. We should move the logic to the plain destructor and get rid of the hook. 1046151 1 240942 kling 2014-11-04 13:05:37 -0800 Created attachment 240942 Patch 1046175 2 240942 commit-queue 2014-11-04 14:16:47 -0800 Comment on attachment 240942 Patch Clearing flags on attachment: 240942 Committed r175580: <http://trac.webkit.org/changeset/175580> 1046176 3 commit-queue 2014-11-04 14:16:51 -0800 All reviewed patches have been landed. Closing bug. 240942 2014-11-04 13:05:37 -0800 2014-11-04 14:16:47 -0800 Patch bug-138367.diff text/plain 3080 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNjkwYTllLi5hYWEwZjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMTEtMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbmRlckJveCBzaG91bGRuJ3QgbmVlZCBhIHByZS1kZXN0cnVjdG9yIGhvb2suCisgICAg ICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzgzNjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0ZWFyZG93biBsb2dpYyBmcm9tIHdpbGxC ZURlc3Ryb3llZCgpIHRvIHRoZSByZWd1bGFyIH5SZW5kZXJCb3goKQorICAgICAgICBkZXN0cnVj dG9yIHNpbmNlIG5vbmUgb2YgaXQgZGVwZW5kcyBvbiBiZWluZyBpbi10cmVlIG9yIGhhdmluZyBh IGZ1bGx5CisgICAgICAgIGNvbnN0cnVjdGVkIHZ0YWJsZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojp+UmVuZGVyQm94 KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6d2lsbEJlRGVzdHJveWVkKTogRGVsZXRl ZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisKIDIwMTQtMTEtMDQgIFphbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGUgbGluZSBsYXlvdXQ6 IENsZWFudXAgbGluZSBpbml0aWFsaXphdGlvbiBhbmQgbGluZSBjbG9zaW5nLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCA0Y2NjZmJhLi4xNjdmODVhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtMTMxLDYgKzEzMSwyMCBAQCBSZW5k ZXJCb3g6OlJlbmRlckJveChEb2N1bWVudCYgZG9jdW1lbnQsIFBhc3NSZWY8UmVuZGVyU3R5bGU+ IHN0eWxlLCB1bnNpZ25lZCBiYQogCiBSZW5kZXJCb3g6On5SZW5kZXJCb3goKQogeworICAgIGlm IChmcmFtZSgpLmV2ZW50SGFuZGxlcigpLmF1dG9zY3JvbGxSZW5kZXJlcigpID09IHRoaXMpCisg ICAgICAgIGZyYW1lKCkuZXZlbnRIYW5kbGVyKCkuc3RvcEF1dG9zY3JvbGxUaW1lcih0cnVlKTsK KworICAgIGNsZWFyT3ZlcnJpZGVTaXplKCk7CisjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkK KyAgICBjbGVhckNvbnRhaW5pbmdCbG9ja092ZXJyaWRlU2l6ZSgpOworI2VuZGlmCisKKyAgICBS ZW5kZXJCbG9jazo6cmVtb3ZlUGVyY2VudEhlaWdodERlc2NlbmRhbnRJZk5lZWRlZCgqdGhpcyk7 CisKKyNpZiBFTkFCTEUoQ1NTX1NIQVBFUykKKyAgICBTaGFwZU91dHNpZGVJbmZvOjpyZW1vdmVJ bmZvKCp0aGlzKTsKKyNlbmRpZgorCiAgICAgdmlldygpLnVuc2NoZWR1bGVMYXp5UmVwYWludCgq dGhpcyk7CiAgICAgaWYgKGhhc0NvbnRyb2xTdGF0ZXNGb3JSZW5kZXJlcih0aGlzKSkKICAgICAg ICAgcmVtb3ZlQ29udHJvbFN0YXRlc0ZvclJlbmRlcmVyKHRoaXMpOwpAQCAtMjM2LDI1ICsyNTAs NiBAQCBMYXlvdXRSZWN0IFJlbmRlckJveDo6Ym9yZGVyQm94UmVjdEluUmVnaW9uKFJlbmRlclJl Z2lvbiogcmVnaW9uLCBSZW5kZXJCb3hSZWdpbwogICAgIHJldHVybiBMYXlvdXRSZWN0KDAsIGxv Z2ljYWxMZWZ0LCB3aWR0aCgpLCBsb2dpY2FsV2lkdGgpOwogfQogCi12b2lkIFJlbmRlckJveDo6 d2lsbEJlRGVzdHJveWVkKCkKLXsKLSAgICBpZiAoZnJhbWUoKS5ldmVudEhhbmRsZXIoKS5hdXRv c2Nyb2xsUmVuZGVyZXIoKSA9PSB0aGlzKQotICAgICAgICBmcmFtZSgpLmV2ZW50SGFuZGxlcigp LnN0b3BBdXRvc2Nyb2xsVGltZXIodHJ1ZSk7Ci0KLSAgICBjbGVhck92ZXJyaWRlU2l6ZSgpOwot I2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCi0gICAgY2xlYXJDb250YWluaW5nQmxvY2tPdmVy cmlkZVNpemUoKTsKLSNlbmRpZgotCi0gICAgUmVuZGVyQmxvY2s6OnJlbW92ZVBlcmNlbnRIZWln aHREZXNjZW5kYW50SWZOZWVkZWQoKnRoaXMpOwotCi0jaWYgRU5BQkxFKENTU19TSEFQRVMpCi0g ICAgU2hhcGVPdXRzaWRlSW5mbzo6cmVtb3ZlSW5mbygqdGhpcyk7Ci0jZW5kaWYKLQotICAgIFJl bmRlckJveE1vZGVsT2JqZWN0Ojp3aWxsQmVEZXN0cm95ZWQoKTsKLX0KLQogUmVuZGVyQmxvY2tG bG93KiBSZW5kZXJCb3g6Om91dGVybW9zdEJsb2NrQ29udGFpbmluZ0Zsb2F0aW5nT2JqZWN0KCkK IHsKICAgICBBU1NFUlQoaXNGbG9hdGluZygpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC b3guaAppbmRleCAwM2VjNzFkLi43ZWYwYzI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveC5oCkBAIC02MTUsOCArNjE1LDYgQEAgcHJvdGVjdGVkOgogICAgIFJlbmRlckJveChFbGVt ZW50JiwgUGFzc1JlZjxSZW5kZXJTdHlsZT4sIHVuc2lnbmVkIGJhc2VUeXBlRmxhZ3MpOwogICAg IFJlbmRlckJveChEb2N1bWVudCYsIFBhc3NSZWY8UmVuZGVyU3R5bGU+LCB1bnNpZ25lZCBiYXNl VHlwZUZsYWdzKTsKIAotICAgIHZpcnR1YWwgdm9pZCB3aWxsQmVEZXN0cm95ZWQoKSBvdmVycmlk ZTsKLQogICAgIHZpcnR1YWwgdm9pZCBzdHlsZVdpbGxDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlLCBj b25zdCBSZW5kZXJTdHlsZSYgbmV3U3R5bGUpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBz dHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHls ZSkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUZyb21TdHlsZSgpIG92ZXJyaWRl Owo=