138360 2014-11-04 10:20:50 -0800 Web Inspector: Stopwatch ASSERT when continuing inspector 2015-01-14 11:41:57 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck burg burg graouts joepeck timothy webkit-bug-importer oldest_to_newest 1046102 0 joepeck 2014-11-04 10:20:50 -0800 * SUMMARY Stopwatch ASSERT when continuing inspector. * TEST CASE <script> try { [].x.x } catch (e) { console.log(e); } </script> * STEPS TO REPRODUCE 1. Inspect Test Case 2. Enable Breakpoints on All Exceptions 3. Reload => hits breakpoint 4. Continue => ASSERT ASSERTION FAILED: isnan(m_lastStartTime) /Users/pecoraro/Build/Debug/usr/local/include/wtf/Stopwatch.h(67) : void WTF::Stopwatch::start() 1 0x116a218b0 WTFCrash 2 0x1165ee0c1 WTF::Stopwatch::start() 3 0x1165ec0da Inspector::InspectorDebuggerAgent::didContinue() 4 0x1165ec13c non-virtual thunk to Inspector::InspectorDebuggerAgent::didContinue() 5 0x11695ad95 Inspector::ScriptDebugServer::dispatchDidContinue(Inspector::ScriptDebugListener*) 6 0x11695b3c5 Inspector::ScriptDebugServer::dispatchFunctionToListeners(WTF::HashSet<Inspector::ScriptDebugListener*, WTF::PtrHash<Inspector::ScriptDebugListener*>, WTF::HashTraits<Inspector::ScriptDebugListener*> > const&, void (Inspector::ScriptDebugServer::*)(Inspector::ScriptDebugListener*)) 7 0x11695b2cc Inspector::ScriptDebugServer::dispatchFunctionToListeners(void (Inspector::ScriptDebugServer::*)(Inspector::ScriptDebugListener*)) 8 0x11695b66c Inspector::ScriptDebugServer::handlePause(JSC::Debugger::ReasonForPause, JSC::JSGlobalObject*) 9 0x116225500 JSC::Debugger::pauseIfNeeded(JSC::ExecState*) 10 0x11622578c JSC::Debugger::updateCallFrameAndPauseIfNeeded(JSC::ExecState*) 11 0x116225867 JSC::Debugger::exception(JSC::ExecState*, JSC::JSValue, bool) 12 0x11665d185 JSC::Interpreter::unwind(void*&, JSC::ExecState*&, JSC::JSValue&) 13 0x11667d49a JSC::genericUnwind(JSC::VM*, JSC::ExecState*, JSC::JSValue) 14 0x1167e7a9a llint_slow_path_handle_exception 15 0x1167f1201 llint_entry 16 0x1167eca69 vmEntryToJavaScript 17 0x116679e7a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 18 0x11665e6b4 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) 19 0x1161fe3a0 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 20 0x119051845 WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 21 0x119a3307d WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) 22 0x119a331c4 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) 23 0x119a42817 WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) 24 0x119a417e0 WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) 25 0x118abb0d9 WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) 26 0x118abaee9 WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) 1046103 1 webkit-bug-importer 2014-11-04 10:21:28 -0800 <rdar://problem/18868233> 1048798 2 joepeck 2014-11-14 11:14:32 -0800 Others have seen the ASSERT in Stopewatch::stop() as well due to a reload. 1048801 3 burg 2014-11-14 11:22:24 -0800 I will look at this today. 1054272 4 joepeck 2014-12-10 12:35:03 -0800 I'm hearing WebKit developers run into this frequently. 1061081 5 244581 burg 2015-01-13 22:23:37 -0800 Created attachment 244581 Patch 1061173 6 244581 eric.carlson 2015-01-14 08:01:22 -0800 Comment on attachment 244581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244581&action=review > Source/JavaScriptCore/ChangeLog:9 > + We were unconditionally resuming the stopwatch even if we never > + never paused it in the first place. Maintain a flag for whether Nit: "never never" 1061257 7 burg 2015-01-14 11:41:57 -0800 Committed r178433: <http://trac.webkit.org/changeset/178433> 244581 2015-01-13 22:23:37 -0800 2015-01-14 02:29:07 -0800 Patch bug-138360-20150113222343.patch text/plain 3206 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YTI3ZGEwMjZmZDBlODdiNGIxY2E1NmQ0ZGFjNWJlM2E1ZGIzNDNhLi4xYjY3NjliY2QxYTM4Yzc5 YmVhMWEzOTNkMWYwM2M0MWNlYThhMDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wMS0xMyAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU3RvcHdhdGNoIEFTU0VSVCB3aGVuIGNv bnRpbnVpbmcgaW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzgzNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZSB3ZXJlIHVuY29uZGl0aW9uYWxseSByZXN1bWluZyB0aGUgc3RvcHdhdGNo IGV2ZW4gaWYgd2UgbmV2ZXIKKyAgICAgICAgbmV2ZXIgcGF1c2VkIGl0IGluIHRoZSBmaXJzdCBw bGFjZS4gTWFpbnRhaW4gYSBmbGFnIGZvciB3aGV0aGVyCisgICAgICAgIHRoZSBzdG9wd2F0Y2gg d2FzIHBhdXNlZCB3aGVuIHRoZSBkZWJ1Z2dlciBsYXN0IHBhdXNlZC4KKworICAgICAgICAqIGlu c3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHA6CisgICAgICAgIChJbnNw ZWN0b3I6Okluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmRpZFBhdXNlKToKKyAgICAgICAgKEluc3Bl Y3Rvcjo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZGlkQ29udGludWUpOgorICAgICAgICAqIGlu c3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oOgorCiAyMDE1LTAxLTEyICBC ZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgYmFz aWMgcGF0dGVybiBtYXRjaGluZyBzdXBwb3J0IHRvIHRoZSB1cmwgZmlsdGVycwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdn ZXJBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNw ZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAppbmRleCA3MDk2OWY3YzM5ZjM2ZThjZWYwYzNjYmUwNThk NTBhOGQxMzI5Y2UwLi4zZmRjMGVjOTYyZTg5NTQxZmM1MTJkYmE2ZWY0YzVjNjZjNjRjYmVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0 b3JEZWJ1Z2dlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAtNzE1LDggKzcxNSwxMCBAQCB2 b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmRpZFBhdXNlKEpTQzo6RXhlY1N0YXRlKiBzY3Jp cHRTdGF0ZSwgY29uc3QgRGVwcmVjYQogICAgICAgICBtX2xpc3RlbmVyLT5kaWRQYXVzZSgpOwog CiAgICAgUmVmUHRyPFN0b3B3YXRjaD4gc3RvcHdhdGNoID0gbV9pbmplY3RlZFNjcmlwdE1hbmFn ZXItPmluc3BlY3RvckVudmlyb25tZW50KCkuZXhlY3V0aW9uU3RvcHdhdGNoKCk7Ci0gICAgaWYg KHN0b3B3YXRjaCAmJiBzdG9wd2F0Y2gtPmlzQWN0aXZlKCkpCisgICAgaWYgKHN0b3B3YXRjaCAm JiBzdG9wd2F0Y2gtPmlzQWN0aXZlKCkpIHsKICAgICAgICAgc3RvcHdhdGNoLT5zdG9wKCk7Cisg ICAgICAgIG1fZGlkUGF1c2VTdG9wd2F0Y2ggPSB0cnVlOworICAgIH0KIH0KIAogdm9pZCBJbnNw ZWN0b3JEZWJ1Z2dlckFnZW50OjpicmVha3BvaW50QWN0aW9uU291bmQoaW50IGJyZWFrcG9pbnRB Y3Rpb25JZGVudGlmaWVyKQpAQCAtNzQxLDEwICs3NDMsMTQgQEAgdm9pZCBJbnNwZWN0b3JEZWJ1 Z2dlckFnZW50OjpicmVha3BvaW50QWN0aW9uUHJvYmUoSlNDOjpFeGVjU3RhdGUqIHNjcmlwdFN0 YXRlLAogCiB2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmRpZENvbnRpbnVlKCkKIHsKKyAg ICBpZiAobV9kaWRQYXVzZVN0b3B3YXRjaCkgeworICAgICAgICBtX2RpZFBhdXNlU3RvcHdhdGNo ID0gZmFsc2U7CisgICAgICAgIG1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLT5pbnNwZWN0b3JFbnZp cm9ubWVudCgpLmV4ZWN1dGlvblN0b3B3YXRjaCgpLT5zdGFydCgpOworICAgIH0KKwogICAgIG1f cGF1c2VkU2NyaXB0U3RhdGUgPSBudWxscHRyOwogICAgIG1fY3VycmVudENhbGxTdGFjayA9IERl cHJlY2F0ZWQ6OlNjcmlwdFZhbHVlKCk7CiAgICAgbV9pbmplY3RlZFNjcmlwdE1hbmFnZXItPnJl bGVhc2VPYmplY3RHcm91cChJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpiYWNrdHJhY2VPYmplY3RH cm91cCk7Ci0gICAgbV9pbmplY3RlZFNjcmlwdE1hbmFnZXItPmluc3BlY3RvckVudmlyb25tZW50 KCkuZXhlY3V0aW9uU3RvcHdhdGNoKCktPnN0YXJ0KCk7CiAgICAgY2xlYXJCcmVha0RldGFpbHMo KTsKICAgICBjbGVhckV4Y2VwdGlvblZhbHVlKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdl bnQuaAppbmRleCBjODEyNmM5MTUxZGUyMGRiNmMwMWY0ZmNhNTc1MDllMzEwMGNjOTA0Li5hYjk2 MTk4OWVjZTc1YmZkYTdhMjhhOWRlZTg3Y2NlODg1M2NjNDhiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVi dWdnZXJBZ2VudC5oCkBAIC0xNzIsNiArMTcyLDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1fZW5h YmxlZCB7ZmFsc2V9OwogICAgIGJvb2wgbV9qYXZhU2NyaXB0UGF1c2VTY2hlZHVsZWQge2ZhbHNl fTsKICAgICBib29sIG1faGFzRXhjZXB0aW9uVmFsdWUge2ZhbHNlfTsKKyAgICBib29sIG1fZGlk UGF1c2VTdG9wd2F0Y2gge2ZhbHNlfTsKICAgICBSZWZQdHI8V1RGOjpTdG9wd2F0Y2g+IG1fc3Rv cHdhdGNoOwogfTsKIAo=