138358 2014-11-04 08:56:53 -0800 REGRESSION (r175549): http/tests/multipart/stop-crash.html failing (assertion failure in CachedResource::setEncodedSize) 2014-11-06 19:16:36 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin ap commit-queue japhet oldest_to_newest 1046085 0 darin 2014-11-04 08:56:53 -0800 I’ll fix this soon, probably tonight. For now, turning off the test. 1046493 1 darin 2014-11-05 09:24:15 -0800 Mostly done with the patch for this. It’s the assertion that seems to be incorrect, not the code. 1046494 2 darin 2014-11-05 09:24:46 -0800 It’s hard to find real multipart mixed replace image tests on the web. I could use help with that! 1046512 3 ap 2014-11-05 09:53:59 -0800 We usually learn about these through bug reports about broken webcams, which go away after a bug is fixed. rdar://problem/12369833 has a URL that is currently live. http://158.250.33.102/axis-cgi/mjpg/video.cgi?camera=1&1415209935808 is an example I found by searching the web now. 1046794 4 241103 darin 2014-11-06 07:15:18 -0800 Created attachment 241103 Patch 1046796 5 241104 darin 2014-11-06 07:19:53 -0800 Created attachment 241104 Patch 1046797 6 darin 2014-11-06 07:20:35 -0800 I also used http://www.fortnet.org/FortNet/HTML/Presentation/animation/pull2.html for some testing. 1046835 7 241104 ap 2014-11-06 10:04:27 -0800 Comment on attachment 241104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241104&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart): Fix another > + incorrect assertion that can fire for any parts after the first one. I ran into This change looks like it changes behavior in release mode, too - we used to call remove() unconditionally, but no longer do. > Source/WebCore/ChangeLog:18 > + this while testing various websites that use multipart/mixed-replace. Is there a way to add a regression test for that? Sounds like this issue was not covered by existing tests. > Source/WebCore/loader/DocumentLoader.cpp:1494 > + auto identifier = loader->identifier(); I wanted to know what "identifier" was, but with auto, I can't see that. > Source/WebCore/loader/cache/CachedResource.cpp:-531 > - // The size cannot ever shrink (unless it is being nulled out because of an error). If it ever does, assert. > - ASSERT(size == 0 || size >= m_encodedSize); Presumably we don't actually ever cache parts of a multipart response, and CachedResource is just a somewhat misleading class name. > LayoutTests/TestExpectations:233 > +webkit.org/b/138145 fast/multicol/multicol-crazy-nesting.html [ Skip ] This doesn't look like part of this change. 1047002 8 241104 darin 2014-11-06 19:07:41 -0800 Comment on attachment 241104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241104&action=review >> Source/WebCore/ChangeLog:17 >> + incorrect assertion that can fire for any parts after the first one. I ran into > > This change looks like it changes behavior in release mode, too - we used to call remove() unconditionally, but no longer do. That’s true. If we wanted to be more conservative I could trivially change the patch to call remove unconditionally. >> Source/WebCore/ChangeLog:18 >> + this while testing various websites that use multipart/mixed-replace. > > Is there a way to add a regression test for that? Sounds like this issue was not covered by existing tests. Maybe, not sure. >> Source/WebCore/loader/DocumentLoader.cpp:1494 >> + auto identifier = loader->identifier(); > > I wanted to know what "identifier" was, but with auto, I can't see that. True; we also couldn’t see that in the old code. >> Source/WebCore/loader/cache/CachedResource.cpp:-531 >> - ASSERT(size == 0 || size >= m_encodedSize); > > Presumably we don't actually ever cache parts of a multipart response, and CachedResource is just a somewhat misleading class name. That’s right. Your question makes me realize that another way to fix this would be to add an early return for !inCache() that only sets m_encodedSize; then we could keep the assertion. >> LayoutTests/TestExpectations:233 >> +webkit.org/b/138145 fast/multicol/multicol-crazy-nesting.html [ Skip ] > > This doesn't look like part of this change. Looks like I made a merge mistake. 1047006 9 darin 2014-11-06 19:16:36 -0800 Committed r175740: <http://trac.webkit.org/changeset/175740> 241103 2014-11-06 07:15:18 -0800 2014-11-06 07:19:50 -0800 Patch bug-138358-20141106071527.patch text/plain 5308 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEzMzVkM2Q5MDU3Njhm MjhkMDBhZDc4YjZmNzAwMDUxODhlMmNiZS4uNmYxN2EyMWYwN2U1MDI4NmI0MTZhYTFmMTFiODdj NDUyNzIzMTNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTExLTA2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTc1NTQ5 KTogaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sIGZhaWxpbmcgKGFzc2VydGlv biBmYWlsdXJlIGluIENhY2hlZFJlc291cmNlOjpzZXRFbmNvZGVkU2l6ZSkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODM1OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hl ZFJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlOjpzZXRFbmNv ZGVkU2l6ZSk6IFJlbW92ZWQgdGhlIGluY29ycmVjdCBhc3NlcnRpb24gaGVyZS4KKyAgICAgICAg VGhlIGNvZGUgYXNzZXJ0cyB0aGF0IHJlc291cmNlcyBvbmx5IGdldCBiaWdnZXIsIG5ldmVyIHNt YWxsZXIuIFRoaXMgaXMgaW5jb3JyZWN0CisgICAgICAgIGZvciBhIG11bHRpcGFydC9taXhlZC1y ZXBsYWNlIGltYWdlLCB3aGVyZSBhIGxhdGVyIGltYWdlIHRoYXQgaXMgc21hbGxlciBjYW4gcmVw bGFjZQorICAgICAgICBhbiBlYXJsaWVyIG9uZS4gSSBkb24ndCBmdWxseSB1bmRlcnN0YW5kIHdo eSB0aGlzIGFzc2VydGlvbiB3YXMgbm90IGZpcmluZyBiZWZvcmUsCisgICAgICAgIGJ1dCB0aGUg cmVsZXZhbnQgd2Vic2l0ZXMgYXJlIHdvcmtpbmcgZmluZSBhbmQgdGhlIHRlc3Qgb3RoZXJ3aXNl IHBhc3Nlcy4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c3VicmVzb3VyY2VMb2FkZXJGaW5pc2hlZExvYWRp bmdPbmVQYXJ0KTogRml4IGFub3RoZXIKKyAgICAgICAgaW5jb3JyZWN0IGFzc2VydGlvbiB0aGF0 IGNhbiBmaXJlIGZvciBhbnkgcGFydHMgYWZ0ZXIgdGhlIGZpcnN0IG9uZS4gSSByYW4gaW50bwor ICAgICAgICB0aGlzIHdoaWxlIHRlc3RpbmcgdmFyaW91cyB3ZWJzaXRlcyB0aGF0IHVzZSBtdWx0 aXBhcnQvbWl4ZWQtcmVwbGFjZS4KKwogMjAxNC0xMS0wNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgRWxpbWluYXRlIFJlc291cmNlQnVmZmVyIGFuZCB1c2UgU2hh cmVkQnVmZmVyIGRpcmVjdGx5IGluc3RlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9Eb2N1bWVudExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRM b2FkZXIuY3BwCmluZGV4IDk3N2VkMTRiMGUyMTYzNjhiMTEwYjI1YzMyNjRkMTI1MDEzYjZjNzYu LjY4MjgwMzY1N2E5MmRlYTdkNzI3YmFiZmIxODMyY2I2NWJjYjcxM2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcApAQCAtMTQ5MSwxMiArMTQ5MSwxNyBAQCB2b2lk IERvY3VtZW50TG9hZGVyOjpjbGVhck1haW5SZXNvdXJjZSgpCiAKIHZvaWQgRG9jdW1lbnRMb2Fk ZXI6OnN1YnJlc291cmNlTG9hZGVyRmluaXNoZWRMb2FkaW5nT25lUGFydChSZXNvdXJjZUxvYWRl ciogbG9hZGVyKQogewotICAgIEFTU0VSVChsb2FkZXItPmlkZW50aWZpZXIoKSk7Ci0gICAgQVNT RVJUKCFtX211bHRpcGFydFN1YnJlc291cmNlTG9hZGVycy5jb250YWlucyhsb2FkZXItPmlkZW50 aWZpZXIoKSkpOwotICAgIEFTU0VSVChtX3N1YnJlc291cmNlTG9hZGVycy5jb250YWlucyhsb2Fk ZXItPmlkZW50aWZpZXIoKSkpOworICAgIGF1dG8gaWRlbnRpZmllciA9IGxvYWRlci0+aWRlbnRp ZmllcigpOworICAgIEFTU0VSVChpZGVudGlmaWVyKTsKKworICAgIGlmICghbV9tdWx0aXBhcnRT dWJyZXNvdXJjZUxvYWRlcnMuYWRkKGlkZW50aWZpZXIsIGxvYWRlcikuaXNOZXdFbnRyeSkgewor ICAgICAgICBBU1NFUlQobV9tdWx0aXBhcnRTdWJyZXNvdXJjZUxvYWRlcnMuZ2V0KGlkZW50aWZp ZXIpID09IGxvYWRlcik7CisgICAgICAgIEFTU0VSVCghbV9zdWJyZXNvdXJjZUxvYWRlcnMuY29u dGFpbnMoaWRlbnRpZmllcikpOworICAgIH0gZWxzZSB7CisgICAgICAgIEFTU0VSVChtX3N1YnJl c291cmNlTG9hZGVycy5jb250YWlucyhpZGVudGlmaWVyKSk7CisgICAgICAgIG1fc3VicmVzb3Vy Y2VMb2FkZXJzLnJlbW92ZShpZGVudGlmaWVyKTsKKyAgICB9CiAKLSAgICBtX211bHRpcGFydFN1 YnJlc291cmNlTG9hZGVycy5hZGQobG9hZGVyLT5pZGVudGlmaWVyKCksIGxvYWRlcik7Ci0gICAg bV9zdWJyZXNvdXJjZUxvYWRlcnMucmVtb3ZlKGxvYWRlci0+aWRlbnRpZmllcigpKTsKICAgICBj aGVja0xvYWRDb21wbGV0ZSgpOwogICAgIGlmIChGcmFtZSogZnJhbWUgPSBtX2ZyYW1lKQogICAg ICAgICBmcmFtZS0+bG9hZGVyKCkuY2hlY2tMb2FkQ29tcGxldGUoKTsgICAgCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAppbmRleCBjZWVlNThjMDMy NDZmOGM4YWRlZmRmMTUxMzc2ZjJiMWNlOWMzOGJiLi5lYzA4NjJmNzAzMWEwYTE1Nzg5ZTk2NDk4 Y2UwNTJiNDc0YzMzZjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv Q2FjaGVkUmVzb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNo ZWRSZXNvdXJjZS5jcHAKQEAgLTUyNywyMyArNTI3LDE5IEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2U6 OnNldEVuY29kZWRTaXplKHVuc2lnbmVkIHNpemUpCiAgICAgaWYgKHNpemUgPT0gbV9lbmNvZGVk U2l6ZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gVGhlIHNpemUgY2Fubm90IGV2ZXIgc2hy aW5rICh1bmxlc3MgaXQgaXMgYmVpbmcgbnVsbGVkIG91dCBiZWNhdXNlIG9mIGFuIGVycm9yKS4g IElmIGl0IGV2ZXIgZG9lcywgYXNzZXJ0LgotICAgIEFTU0VSVChzaXplID09IDAgfHwgc2l6ZSA+ PSBtX2VuY29kZWRTaXplKTsKLSAgICAKICAgICBpbnQgZGVsdGEgPSBzaXplIC0gbV9lbmNvZGVk U2l6ZTsKIAogICAgIC8vIFRoZSBvYmplY3QgbXVzdCBub3cgYmUgbW92ZWQgdG8gYSBkaWZmZXJl bnQgcXVldWUsIHNpbmNlIGl0cyBzaXplIGhhcyBiZWVuIGNoYW5nZWQuCi0gICAgLy8gV2UgaGF2 ZSB0byByZW1vdmUgZXhwbGljaXRseSBiZWZvcmUgdXBkYXRpbmcgbV9lbmNvZGVkU2l6ZSwgc28g dGhhdCB3ZSBmaW5kIHRoZSBjb3JyZWN0IHByZXZpb3VzCi0gICAgLy8gcXVldWUuCisgICAgLy8g V2UgaGF2ZSB0byByZW1vdmUgYmVmb3JlIHVwZGF0aW5nIG1fZW5jb2RlZFNpemUsIHNvIHdlIGZp bmQgdGhlIGNvcnJlY3QgcHJldmlvdXMgcXVldWUuCiAgICAgaWYgKGluQ2FjaGUoKSkKICAgICAg ICAgbWVtb3J5Q2FjaGUoKS0+cmVtb3ZlRnJvbUxSVUxpc3QodGhpcyk7Ci0gICAgCisKICAgICBt X2VuY29kZWRTaXplID0gc2l6ZTsKLSAgIAorCiAgICAgaWYgKGluQ2FjaGUoKSkgeyAKICAgICAg ICAgLy8gTm93IGluc2VydCBpbnRvIHRoZSBuZXcgTFJVIGxpc3QuCiAgICAgICAgIG1lbW9yeUNh Y2hlKCktPmluc2VydEluTFJVTGlzdCh0aGlzKTsKLSAgICAgICAgCisKICAgICAgICAgLy8gVXBk YXRlIHRoZSBjYWNoZSdzIHNpemUgdG90YWxzLgogICAgICAgICBtZW1vcnlDYWNoZSgpLT5hZGp1 c3RTaXplKGhhc0NsaWVudHMoKSwgZGVsdGEpOwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNzA3NWMyMjcwYmMy Y2RlMTg0NDFjNGFiNDMwMTE3Yjg3MGE2NWEzLi4yYjg3NmFlOTU3ZTZlYTI5MmRhMjkxMjkyZDBm OTM2OTFmM2MxNDNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMTEtMDYgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNzU1NDkpOiBo dHRwL3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLmh0bWwgZmFpbGluZyAoYXNzZXJ0aW9uIGZh aWx1cmUgaW4gQ2FjaGVkUmVzb3VyY2U6OnNldEVuY29kZWRTaXplKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOiBUdXJu IHRoZSB0ZXN0IGJhY2sgb24uCisKIDIwMTQtMTEtMDQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogVHVybiBvZmYgaHR0cC90ZXN0 cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZmI5NGE0 YzMzNGUwYTEyZTgzYTY3MDZhZjZmZDJiZmVlY2EwMTcyYi4uYzFiNWUwYWNlODFiODQ0N2U5ZDQx NzU5NjVjNzZjMTQzNDI5ZjM2NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0yNDAsNiArMjQwLDMg QEAgd2Via2l0Lm9yZy9iLzEzNzg4MyB0cmFuc2l0aW9ucy9jb2xvci10cmFuc2l0aW9uLXJvdW5k aW5nLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzNzg4MyB0cmFuc2l0aW9u cy9jcmVhdGVkLXdoaWxlLXN1c3BlbmRlZC5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIAogd2Via2l0 Lm9yZy9iLzEzODE0NSBmYXN0L211bHRpY29sL211bHRpY29sLWNyYXp5LW5lc3RpbmcuaHRtbCBb IFNraXAgXQotCi0jIFRlbXBvcmFyaWx5IHR1cm4gdGhpcyBvZmYuIEJhY2sgb24gc29vbi4KLXdl YmtpdC5vcmcvYi8xMzgzNTggaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sIFsg U2tpcCBdCg== 241104 2014-11-06 07:19:53 -0800 2014-11-06 10:04:27 -0800 Patch bug-138358-20141106072003.patch text/plain 5350 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Njk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjcyYTRkZmE5ZDY0OWUw NDFjYTQwNWVhZDVhZTE1ZjJmY2RlMmVjOC4uYjMwMmNjYzRhMjc1OWVkMDU1Zjk5NmYyYzc4YTIz MzIyMDc4ODQzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTExLTA2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTc1NTQ5 KTogaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sIGZhaWxpbmcgKGFzc2VydGlv biBmYWlsdXJlIGluIENhY2hlZFJlc291cmNlOjpzZXRFbmNvZGVkU2l6ZSkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODM1OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hl ZFJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlOjpzZXRFbmNv ZGVkU2l6ZSk6IFJlbW92ZWQgdGhlIGluY29ycmVjdCBhc3NlcnRpb24gaGVyZS4KKyAgICAgICAg VGhlIGNvZGUgYXNzZXJ0cyB0aGF0IHJlc291cmNlcyBvbmx5IGdldCBiaWdnZXIsIG5ldmVyIHNt YWxsZXIuIFRoaXMgaXMgaW5jb3JyZWN0CisgICAgICAgIGZvciBhIG11bHRpcGFydC9taXhlZC1y ZXBsYWNlIGltYWdlLCB3aGVyZSBhIGxhdGVyIGltYWdlIHRoYXQgaXMgc21hbGxlciBjYW4gcmVw bGFjZQorICAgICAgICBhbiBlYXJsaWVyIG9uZS4gSSBkb24ndCBmdWxseSB1bmRlcnN0YW5kIHdo eSB0aGlzIGFzc2VydGlvbiB3YXMgbm90IGZpcmluZyBiZWZvcmUsCisgICAgICAgIGJ1dCB0aGUg cmVsZXZhbnQgd2Vic2l0ZXMgYXJlIHdvcmtpbmcgZmluZSBhbmQgdGhlIHRlc3Qgb3RoZXJ3aXNl IHBhc3Nlcy4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c3VicmVzb3VyY2VMb2FkZXJGaW5pc2hlZExvYWRp bmdPbmVQYXJ0KTogRml4IGFub3RoZXIKKyAgICAgICAgaW5jb3JyZWN0IGFzc2VydGlvbiB0aGF0 IGNhbiBmaXJlIGZvciBhbnkgcGFydHMgYWZ0ZXIgdGhlIGZpcnN0IG9uZS4gSSByYW4gaW50bwor ICAgICAgICB0aGlzIHdoaWxlIHRlc3RpbmcgdmFyaW91cyB3ZWJzaXRlcyB0aGF0IHVzZSBtdWx0 aXBhcnQvbWl4ZWQtcmVwbGFjZS4KKwogMjAxNC0xMS0wNSAgU2hpdmFrdW1hciBKTSAgPHNoaXZh LmptQHNhbXN1bmcuY29tPgogCiAgICAgICAgIHNwbGl0VGV4dCBBUEkgZG9lcyBub3QgbWF0Y2gg RE9NIHNwZWNpZmljYXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNw cAppbmRleCA5NzdlZDE0YjBlMjE2MzY4YjExMGIyNWMzMjY0ZDEyNTAxM2I2Yzc2Li42ODI4MDM2 NTdhOTJkZWE3ZDcyN2JhYmZiMTgzMmNiNjViY2I3MTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTE0OTEsMTIgKzE0OTEsMTcgQEAgdm9pZCBEb2N1bWVu dExvYWRlcjo6Y2xlYXJNYWluUmVzb3VyY2UoKQogCiB2b2lkIERvY3VtZW50TG9hZGVyOjpzdWJy ZXNvdXJjZUxvYWRlckZpbmlzaGVkTG9hZGluZ09uZVBhcnQoUmVzb3VyY2VMb2FkZXIqIGxvYWRl cikKIHsKLSAgICBBU1NFUlQobG9hZGVyLT5pZGVudGlmaWVyKCkpOwotICAgIEFTU0VSVCghbV9t dWx0aXBhcnRTdWJyZXNvdXJjZUxvYWRlcnMuY29udGFpbnMobG9hZGVyLT5pZGVudGlmaWVyKCkp KTsKLSAgICBBU1NFUlQobV9zdWJyZXNvdXJjZUxvYWRlcnMuY29udGFpbnMobG9hZGVyLT5pZGVu dGlmaWVyKCkpKTsKKyAgICBhdXRvIGlkZW50aWZpZXIgPSBsb2FkZXItPmlkZW50aWZpZXIoKTsK KyAgICBBU1NFUlQoaWRlbnRpZmllcik7CisKKyAgICBpZiAoIW1fbXVsdGlwYXJ0U3VicmVzb3Vy Y2VMb2FkZXJzLmFkZChpZGVudGlmaWVyLCBsb2FkZXIpLmlzTmV3RW50cnkpIHsKKyAgICAgICAg QVNTRVJUKG1fbXVsdGlwYXJ0U3VicmVzb3VyY2VMb2FkZXJzLmdldChpZGVudGlmaWVyKSA9PSBs b2FkZXIpOworICAgICAgICBBU1NFUlQoIW1fc3VicmVzb3VyY2VMb2FkZXJzLmNvbnRhaW5zKGlk ZW50aWZpZXIpKTsKKyAgICB9IGVsc2UgeworICAgICAgICBBU1NFUlQobV9zdWJyZXNvdXJjZUxv YWRlcnMuY29udGFpbnMoaWRlbnRpZmllcikpOworICAgICAgICBtX3N1YnJlc291cmNlTG9hZGVy cy5yZW1vdmUoaWRlbnRpZmllcik7CisgICAgfQogCi0gICAgbV9tdWx0aXBhcnRTdWJyZXNvdXJj ZUxvYWRlcnMuYWRkKGxvYWRlci0+aWRlbnRpZmllcigpLCBsb2FkZXIpOwotICAgIG1fc3VicmVz b3VyY2VMb2FkZXJzLnJlbW92ZShsb2FkZXItPmlkZW50aWZpZXIoKSk7CiAgICAgY2hlY2tMb2Fk Q29tcGxldGUoKTsKICAgICBpZiAoRnJhbWUqIGZyYW1lID0gbV9mcmFtZSkKICAgICAgICAgZnJh bWUtPmxvYWRlcigpLmNoZWNrTG9hZENvbXBsZXRlKCk7ICAgIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKaW5kZXggY2VlZTU4YzAzMjQ2ZjhjOGFk ZWZkZjE1MTM3NmYyYjFjZTljMzhiYi4uZWMwODYyZjcwMzFhMGExNTc4OWU5NjQ5OGNlMDUyYjQ3 NGMzM2YxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJl c291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2UuY3BwCkBAIC01MjcsMjMgKzUyNywxOSBAQCB2b2lkIENhY2hlZFJlc291cmNlOjpzZXRFbmNv ZGVkU2l6ZSh1bnNpZ25lZCBzaXplKQogICAgIGlmIChzaXplID09IG1fZW5jb2RlZFNpemUpCiAg ICAgICAgIHJldHVybjsKIAotICAgIC8vIFRoZSBzaXplIGNhbm5vdCBldmVyIHNocmluayAodW5s ZXNzIGl0IGlzIGJlaW5nIG51bGxlZCBvdXQgYmVjYXVzZSBvZiBhbiBlcnJvcikuICBJZiBpdCBl dmVyIGRvZXMsIGFzc2VydC4KLSAgICBBU1NFUlQoc2l6ZSA9PSAwIHx8IHNpemUgPj0gbV9lbmNv ZGVkU2l6ZSk7Ci0gICAgCiAgICAgaW50IGRlbHRhID0gc2l6ZSAtIG1fZW5jb2RlZFNpemU7CiAK ICAgICAvLyBUaGUgb2JqZWN0IG11c3Qgbm93IGJlIG1vdmVkIHRvIGEgZGlmZmVyZW50IHF1ZXVl LCBzaW5jZSBpdHMgc2l6ZSBoYXMgYmVlbiBjaGFuZ2VkLgotICAgIC8vIFdlIGhhdmUgdG8gcmVt b3ZlIGV4cGxpY2l0bHkgYmVmb3JlIHVwZGF0aW5nIG1fZW5jb2RlZFNpemUsIHNvIHRoYXQgd2Ug ZmluZCB0aGUgY29ycmVjdCBwcmV2aW91cwotICAgIC8vIHF1ZXVlLgorICAgIC8vIFdlIGhhdmUg dG8gcmVtb3ZlIGJlZm9yZSB1cGRhdGluZyBtX2VuY29kZWRTaXplLCBzbyB3ZSBmaW5kIHRoZSBj b3JyZWN0IHByZXZpb3VzIHF1ZXVlLgogICAgIGlmIChpbkNhY2hlKCkpCiAgICAgICAgIG1lbW9y eUNhY2hlKCktPnJlbW92ZUZyb21MUlVMaXN0KHRoaXMpOwotICAgIAorCiAgICAgbV9lbmNvZGVk U2l6ZSA9IHNpemU7Ci0gICAKKwogICAgIGlmIChpbkNhY2hlKCkpIHsgCiAgICAgICAgIC8vIE5v dyBpbnNlcnQgaW50byB0aGUgbmV3IExSVSBsaXN0LgogICAgICAgICBtZW1vcnlDYWNoZSgpLT5p bnNlcnRJbkxSVUxpc3QodGhpcyk7Ci0gICAgICAgIAorCiAgICAgICAgIC8vIFVwZGF0ZSB0aGUg Y2FjaGUncyBzaXplIHRvdGFscy4KICAgICAgICAgbWVtb3J5Q2FjaGUoKS0+YWRqdXN0U2l6ZSho YXNDbGllbnRzKCksIGRlbHRhKTsKICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTA5MjRkNDU2Mjg1OGMyNDZlYzY4 OGNiMDk3YWZiZThmYzQ4OTQyMC4uZWE2MjViNTFiMGU2ODRlMDFiM2JhN2EyYjk3YmFlZTI4MDgw ZGU2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTExLTA2ICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTc1NTQ5KTogaHR0cC90ZXN0 cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sIGZhaWxpbmcgKGFzc2VydGlvbiBmYWlsdXJlIGlu IENhY2hlZFJlc291cmNlOjpzZXRFbmNvZGVkU2l6ZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODM1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogVHVybiB0aGUgdGVz dCBiYWNrIG9uLgorCiAyMDE0LTExLTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IG5pdHMgYWZ0ZXIgcjE3NTY4OC4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0 YXRpb25zCmluZGV4IGQ3MjQ3MWFhNWRiOTQyMjFhZjQyODlmMjg0MzIzODYxZjI5NzMyZWIuLmQ5 OWI0NmIwZmI1NTZlYzc0NDg4NmY0YTE5ZDdmMDI0ZmRjOTRlODEgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMjMwLDUgKzIzMCw0IEBAIHdlYmtpdC5vcmcvYi8xMzc4ODMgdHJhbnNpdGlvbnMvY29s b3ItdHJhbnNpdGlvbi1wcmVtdWx0aXBsaWVkLmh0bWwgWyBGYWlsdXJlIFBhCiB3ZWJraXQub3Jn L2IvMTM3ODgzIHRyYW5zaXRpb25zL2NvbG9yLXRyYW5zaXRpb24tcm91bmRpbmcuaHRtbCBbIEZh aWx1cmUgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTM3ODgzIHRyYW5zaXRpb25zL2NyZWF0ZWQtd2hp bGUtc3VzcGVuZGVkLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogCi0jIFRlbXBvcmFyaWx5IHR1cm4g dGhpcyBvZmYuIEJhY2sgb24gc29vbi4KLXdlYmtpdC5vcmcvYi8xMzgzNTggaHR0cC90ZXN0cy9t dWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sIFsgU2tpcCBdCit3ZWJraXQub3JnL2IvMTM4MTQ1IGZh c3QvbXVsdGljb2wvbXVsdGljb2wtY3JhenktbmVzdGluZy5odG1sIFsgU2tpcCBdCg==