138345 2014-11-03 19:37:11 -0800 Use SPECIALIZE_TYPE_TRAITS_*() macro for StyleRuleGroup subclasses 2014-11-04 08:17:49 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin commit-queue darin gyuyoung.kim kling rniwa oldest_to_newest 1045959 0 cdumez 2014-11-03 19:37:11 -0800 Use SPECIALIZE_TYPE_TRAITS_*() macro for StyleRuleGroup subclasses instead of manual toXXX() function. 1045962 1 240902 cdumez 2014-11-03 19:54:19 -0800 Created attachment 240902 Patch 1046016 2 240902 kling 2014-11-03 23:51:51 -0800 Comment on attachment 240902 Patch r=me 1046076 3 240902 commit-queue 2014-11-04 08:17:45 -0800 Comment on attachment 240902 Patch Clearing flags on attachment: 240902 Committed r175548: <http://trac.webkit.org/changeset/175548> 1046077 4 commit-queue 2014-11-04 08:17:49 -0800 All reviewed patches have been landed. Closing bug. 240902 2014-11-03 19:54:19 -0800 2014-11-04 08:17:45 -0800 Patch bug-138345-20141103195430.patch text/plain 4788 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ4MmRjNDE5MjBiM2Vi YWZjYzg1NzFhYjA0NWI1ZmJjY2ZkYzA5My4uMzc3M2I1OWY4ODIzZGUzNTNmMmU5MzcwMGJhMjIz YzFjNWY3NmRhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTExLTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFNQRUNJQUxJWkVfVFlQ RV9UUkFJVFNfKigpIG1hY3JvIGZvciBTdHlsZVJ1bGVHcm91cCBzdWJjbGFzc2VzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzNDUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgU1BFQ0lBTElaRV9U WVBFX1RSQUlUU18qKCkgbWFjcm8gZm9yIFN0eWxlUnVsZUdyb3VwIHN1YmNsYXNzZXMKKyAgICAg ICAgaW5zdGVhZCBvZiBvbGQtZmFzaGlvbiB0b1hYWCgpIGZ1bmN0aW9ucy4KKworICAgICAgICBO byBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNzcy9DU1NNZWRp YVJ1bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTTWVkaWFSdWxlOjptZWRpYVF1ZXJpZXMp OgorICAgICAgICAqIGNzcy9DU1NTdXBwb3J0c1J1bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTU3VwcG9ydHNSdWxlOjpjb25kaXRpb25UZXh0KToKKyAgICAgICAgKiBjc3MvU3R5bGVSdWxl Lmg6CisgICAgICAgIChpc1R5cGUpOgorICAgICAgICAoV2ViQ29yZTo6dG9TdHlsZVJ1bGVNZWRp YSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjp0b1N0eWxlUnVsZVN1cHBvcnRzKTogRGVs ZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OnRvU3R5bGVSdWxlUmVnaW9uKTogRGVsZXRlZC4KKyAg ICAgICAgKiBjc3MvV2ViS2l0Q1NTUmVnaW9uUnVsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX ZWJLaXRDU1NSZWdpb25SdWxlOjpjc3NUZXh0KToKKwogMjAxNC0xMS0wMyAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBOb24tZmFzdCBzY3JvbGxhYmxl IHJlZ2lvbiBvdmVybGF5IG9mZnNldHMgdGhlIG92ZXJsYXkgYnkgdG9wQ29udGVudEluc2V0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTTWVkaWFSdWxlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NNZWRpYVJ1bGUuY3BwCmluZGV4IDhjYmUzMmY5OGZjZGJlOWU0YzJkN2E2 YjE4OGZmOGFjMWFmNTU0YTQuLjY4ZGZhNjcxYmM5YjU4YzY5ZTdiY2RkMzVmYjBjNGNiY2Q0OGVk MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NNZWRpYVJ1bGUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NNZWRpYVJ1bGUuY3BwCkBAIC00NSw3ICs0NSw3IEBAIENT U01lZGlhUnVsZTo6fkNTU01lZGlhUnVsZSgpCiAKIE1lZGlhUXVlcnlTZXQqIENTU01lZGlhUnVs ZTo6bWVkaWFRdWVyaWVzKCkgY29uc3QKIHsKLSAgICByZXR1cm4gdG9TdHlsZVJ1bGVNZWRpYSgm bV9ncm91cFJ1bGUuZ2V0KCkpLT5tZWRpYVF1ZXJpZXMoKTsKKyAgICByZXR1cm4gZG93bmNhc3Q8 U3R5bGVSdWxlTWVkaWE+KG1fZ3JvdXBSdWxlLmdldCgpKS5tZWRpYVF1ZXJpZXMoKTsKIH0KIAog U3RyaW5nIENTU01lZGlhUnVsZTo6Y3NzVGV4dCgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3VwcG9ydHNSdWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT dXBwb3J0c1J1bGUuY3BwCmluZGV4IGE1MGUxM2NiN2UwMGEyZGEwYmUzNTIyMzc4NWI5YjViNjI3 YjY5NDIuLmM3NjJjNDQzMWY4ZWI2ZDg0MDAwZGE1OGYzZmZkM2ZiZmYyZDkzYzUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdXBwb3J0c1J1bGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdXBwb3J0c1J1bGUuY3BwCkBAIC01OSw3ICs1OSw3IEBAIFN0cmluZyBD U1NTdXBwb3J0c1J1bGU6OmNzc1RleHQoKSBjb25zdAogCiBTdHJpbmcgQ1NTU3VwcG9ydHNSdWxl Ojpjb25kaXRpb25UZXh0KCkgY29uc3QKIHsKLSAgICByZXR1cm4gdG9TdHlsZVJ1bGVTdXBwb3J0 cygmbV9ncm91cFJ1bGUuZ2V0KCkpLT5jb25kaXRpb25UZXh0KCk7CisgICAgcmV0dXJuIGRvd25j YXN0PFN0eWxlUnVsZVN1cHBvcnRzPihtX2dyb3VwUnVsZS5nZXQoKSkuY29uZGl0aW9uVGV4dCgp OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxlLmgKaW5kZXgg ZGQ5ZDNiZDhkOWNhMTQ2ZGZjNWRhMjI5OGRkMDNhYTY5ZmM1ZWFlZS4uOTQ1NTE0Mjc0ZmExZTc1 ZTM3ODFmNjYxOWMzOGFhMzk1N2Y3MWQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUnVsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJ1bGUuaApAQCAtMjYs NiArMjYsNyBAQAogI2luY2x1ZGUgIk1lZGlhTGlzdC5oIgogI2luY2x1ZGUgIlN0eWxlUHJvcGVy dGllcy5oIgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvVHlwZUNhc3Rz Lmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMjcxLDI0ICsyNzIsMTggQEAgcHJpdmF0 ZToKIH07CiAjZW5kaWYgLy8gRU5BQkxFKENTU19ERVZJQ0VfQURBUFRBVElPTikKIAotaW5saW5l IGNvbnN0IFN0eWxlUnVsZU1lZGlhKiB0b1N0eWxlUnVsZU1lZGlhKGNvbnN0IFN0eWxlUnVsZUdy b3VwKiBydWxlKQotewotICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKCFydWxl IHx8IHJ1bGUtPmlzTWVkaWFSdWxlKCkpOwotICAgIHJldHVybiBzdGF0aWNfY2FzdDxjb25zdCBT dHlsZVJ1bGVNZWRpYSo+KHJ1bGUpOwotfQorfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCi1pbmxp bmUgY29uc3QgU3R5bGVSdWxlU3VwcG9ydHMqIHRvU3R5bGVSdWxlU3VwcG9ydHMoY29uc3QgU3R5 bGVSdWxlR3JvdXAqIHJ1bGUpCi17Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJ T04oIXJ1bGUgfHwgcnVsZS0+aXNTdXBwb3J0c1J1bGUoKSk7Ci0gICAgcmV0dXJuIHN0YXRpY19j YXN0PGNvbnN0IFN0eWxlUnVsZVN1cHBvcnRzKj4ocnVsZSk7Ci19CitTUEVDSUFMSVpFX1RZUEVf VFJBSVRTX0JFR0lOKFdlYkNvcmU6OlN0eWxlUnVsZU1lZGlhKQorICAgIHN0YXRpYyBib29sIGlz VHlwZShjb25zdCBXZWJDb3JlOjpTdHlsZVJ1bGVHcm91cCYgZ3JvdXApIHsgcmV0dXJuIGdyb3Vw LmlzTWVkaWFSdWxlKCk7IH0KK1NQRUNJQUxJWkVfVFlQRV9UUkFJVFNfRU5EKCkKIAotaW5saW5l IGNvbnN0IFN0eWxlUnVsZVJlZ2lvbiogdG9TdHlsZVJ1bGVSZWdpb24oY29uc3QgU3R5bGVSdWxl R3JvdXAqIHJ1bGUpCi17Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIXJ1 bGUgfHwgcnVsZS0+aXNSZWdpb25SdWxlKCkpOwotICAgIHJldHVybiBzdGF0aWNfY2FzdDxjb25z dCBTdHlsZVJ1bGVSZWdpb24qPihydWxlKTsKLX0KK1NQRUNJQUxJWkVfVFlQRV9UUkFJVFNfQkVH SU4oV2ViQ29yZTo6U3R5bGVSdWxlU3VwcG9ydHMpCisgICAgc3RhdGljIGJvb2wgaXNUeXBlKGNv bnN0IFdlYkNvcmU6OlN0eWxlUnVsZUdyb3VwJiBncm91cCkgeyByZXR1cm4gZ3JvdXAuaXNTdXBw b3J0c1J1bGUoKTsgfQorU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19FTkQoKQogCi19IC8vIG5hbWVz cGFjZSBXZWJDb3JlCitTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0JFR0lOKFdlYkNvcmU6OlN0eWxl UnVsZVJlZ2lvbikKKyAgICBzdGF0aWMgYm9vbCBpc1R5cGUoY29uc3QgV2ViQ29yZTo6U3R5bGVS dWxlR3JvdXAmIGdyb3VwKSB7IHJldHVybiBncm91cC5pc1JlZ2lvblJ1bGUoKTsgfQorU1BFQ0lB TElaRV9UWVBFX1RSQUlUU19FTkQoKQogCiAjZW5kaWYgLy8gU3R5bGVSdWxlX2gKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NSZWdpb25SdWxlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9XZWJLaXRDU1NSZWdpb25SdWxlLmNwcAppbmRleCBlYzEwZTEyM2NhZGQwNzFh ZTA5MzE3MmFhNzdhY2NkMTkzYzdlYzQ4Li5iMDE4YjcyZTlmM2QyODg5ZjBmOWViZDhhYzM3ZGYx NTM0ZTE5M2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTUmVnaW9u UnVsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU1JlZ2lvblJ1bGUuY3Bw CkBAIC01MSw3ICs1MSw3IEBAIFN0cmluZyBXZWJLaXRDU1NSZWdpb25SdWxlOjpjc3NUZXh0KCkg Y29uc3QKICAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiQC13ZWJraXQtcmVnaW9uICIpOwogCiAg ICAgLy8gRmlyc3QgYWRkIHRoZSBzZWxlY3RvcnMuCi0gICAgcmVzdWx0LmFwcGVuZCh0b1N0eWxl UnVsZVJlZ2lvbigmbV9ncm91cFJ1bGUuZ2V0KCkpLT5zZWxlY3Rvckxpc3QoKS5zZWxlY3RvcnNU ZXh0KCkpOworICAgIHJlc3VsdC5hcHBlbmQoZG93bmNhc3Q8U3R5bGVSdWxlUmVnaW9uPihtX2dy b3VwUnVsZS5nZXQoKSkuc2VsZWN0b3JMaXN0KCkuc2VsZWN0b3JzVGV4dCgpKTsKIAogICAgIC8v IFRoZW4gYWRkIHRoZSBydWxlcy4KICAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiIHsgXG4iKTsK