138342 2014-11-03 17:54:40 -0800 Expose visibleDebugOverlayRegions pref via the WK2 C SPI 2014-12-09 20:40:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 1045927 0 simon.fraser 2014-11-03 17:54:40 -0800 Expose visibleDebugOverlayRegions pref via the WK2 C SPI 1045928 1 240893 simon.fraser 2014-11-03 17:55:30 -0800 Created attachment 240893 Patch 1045929 2 240893 mitz 2014-11-03 17:59:16 -0800 Comment on attachment 240893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240893&action=review > Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h:258 > +WK_EXPORT void WKPreferencesSetVisibleDebugOverlayRegions(WKPreferencesRef preferencesRef, WKDebugOverlayRegions enabled); s/enabled/visible/ > Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h:259 > +WK_EXPORT WKDebugOverlayRegions WKPreferencesGetVisibleDebugOverlayRegions(WKPreferencesRef preferencesRef); this can be called WKPreferencesGetVisibleDebugOverlayRegions 1054031 3 simon.fraser 2014-12-09 20:40:32 -0800 http://trac.webkit.org/changeset/175503 240893 2014-11-03 17:55:30 -0800 2014-11-03 17:59:16 -0800 Patch bug-138342-20141103175540.patch text/plain 3168 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWI4MmRiYmQ5YmUxNjM0 ZTYxNTFiMmY0YjcyMjE1ZWFlYzMwYmEwOC4uMjEwM2ZhNWU5YzM2Mjg2MGY5MzcwNGQzNDlhODA4 YzBmOTU1Mjk5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTExLTAzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEV4cG9zZSB2aXNp YmxlRGVidWdPdmVybGF5UmVnaW9ucyBwcmVmIHZpYSB0aGUgV0syIEMgU1BJCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzNDIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEV4cG9zZSBXS0Rl YnVnT3ZlcmxheVJlZ2lvbnMgdmlhIHRoZSBDIFNQSS4KKyAgICAgICAgCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV0tQcmVmZXJlbmNlc1Nl dFZpc2libGVEZWJ1Z092ZXJsYXlSZWdpb25zKToKKyAgICAgICAgKFdLUHJlZmVyZW5jZXNHZXRW aXNpYmxlRGVidWdPdmVybGF5UmVnaW9ucyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dL UHJlZmVyZW5jZXNSZWYuaDoKKworMjAxNC0xMS0wMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgcGFnZSBvdmVybGF5cyB0aGF0IHNob3cgcmVn aW9ucyB3aXRoIG1vdXNlV2hlZWwgZXZlbnQgaGFuZGxlcnMsIGFuZCB0aGUgbm9uLWZhc3Qtc2Ny b2xsYWJsZSByZWdpb24sIGFuZCBjb2RlIHRvIHRvZ2dsZSB0aGVtIGluIE1pbmlCcm93c2VyIFdL MgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MjU3 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVu Y2VzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNw cAppbmRleCAzZTU1MjMwMDY5NmQ1YjAyMjIxYzBlNGYzMzEzNjBlNmU4ODViOTllLi4xNjNkMmRm ZWJhODJkNGE2NzlhOGJiNzI1NTk5OTNkNjMzYWNjM2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwCkBAIC0xMjk1LDMgKzEyOTUsMTQg QEAgZG91YmxlIFdLUHJlZmVyZW5jZXNHZXRNaW5pbXVtWm9vbUZvbnRTaXplKFdLUHJlZmVyZW5j ZXNSZWYgcHJlZmVyZW5jZXNSZWYpCiB7CiAgICAgcmV0dXJuIHRvSW1wbChwcmVmZXJlbmNlc1Jl ZiktPm1pbmltdW1ab29tRm9udFNpemUoKTsKIH0KKwordm9pZCBXS1ByZWZlcmVuY2VzU2V0Vmlz aWJsZURlYnVnT3ZlcmxheVJlZ2lvbnMoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZiwg V0tEZWJ1Z092ZXJsYXlSZWdpb25zIGVuYWJsZWQpCit7CisgICAgdG9JbXBsKHByZWZlcmVuY2Vz UmVmKS0+c2V0VmlzaWJsZURlYnVnT3ZlcmxheVJlZ2lvbnMoZW5hYmxlZCk7Cit9CisKK1dLRGVi dWdPdmVybGF5UmVnaW9ucyBXS1ByZWZlcmVuY2VzR2V0VmlzaWJsZURlYnVnT3ZlcmxheVJlZ2lv bnMoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZikKK3sKKyAgICByZXR1cm4gdG9JbXBs KHByZWZlcmVuY2VzUmVmKS0+dmlzaWJsZURlYnVnT3ZlcmxheVJlZ2lvbnMoKTsKK30KKwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWYu aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUmVmLmgKaW5k ZXggOWU3OWEyMDk0YThkOTdiOWVjZDMwNDcyYTA2YjY2MGZiYTMyMDQxYi4uZmJmNDFiOWJkNDEz YmM1ODdmZjc5ZTU0NTg1ZWExNzJhMTk2NjA4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWYuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlc1JlZi5oCkBAIC00Myw2ICs0MywxMiBAQCBlbnVt IFdLU3RvcmFnZUJsb2NraW5nUG9saWN5IHsKIH07CiB0eXBlZGVmIGVudW0gV0tTdG9yYWdlQmxv Y2tpbmdQb2xpY3kgV0tTdG9yYWdlQmxvY2tpbmdQb2xpY3k7CiAKK2VudW0gV0tEZWJ1Z092ZXJs YXlSZWdpb25GbGFncyB7CisgICAga1dLTm9uRmFzdFNjcm9sbGFibGVSZWdpb24gPSAxIDw8IDAs CisgICAga1dLV2hlZWxFdmVudEhhbmRsZXJSZWdpb24gPSAxIDw8IDEKK307Cit0eXBlZGVmIHVu c2lnbmVkIFdLRGVidWdPdmVybGF5UmVnaW9uczsKKwogV0tfRVhQT1JUIFdLVHlwZUlEIFdLUHJl ZmVyZW5jZXNHZXRUeXBlSUQoKTsKIAogV0tfRVhQT1JUIFdLUHJlZmVyZW5jZXNSZWYgV0tQcmVm ZXJlbmNlc0NyZWF0ZSgpOwpAQCAtMjQ4LDYgKzI1NCwxMCBAQCBXS19FWFBPUlQgYm9vbCBXS1By ZWZlcmVuY2VzR2V0TWVkaWFTdHJlYW1FbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5j ZXNSZQogV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNlc1NldFNwYXRpYWxOYXZpZ2F0aW9uRW5h YmxlZChXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmLCBib29sIGVuYWJsZWQpOwogV0tf RVhQT1JUIGJvb2wgV0tQcmVmZXJlbmNlc0dldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChXS1By ZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmKTsKIAorLy8gRGVmYXVsdHMgdG8gMC4KK1dLX0VY UE9SVCB2b2lkIFdLUHJlZmVyZW5jZXNTZXRWaXNpYmxlRGVidWdPdmVybGF5UmVnaW9ucyhXS1By ZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmLCBXS0RlYnVnT3ZlcmxheVJlZ2lvbnMgZW5hYmxl ZCk7CitXS19FWFBPUlQgV0tEZWJ1Z092ZXJsYXlSZWdpb25zIFdLUHJlZmVyZW5jZXNHZXRWaXNp YmxlRGVidWdPdmVybGF5UmVnaW9ucyhXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmKTsK KwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK