138339 2014-11-03 17:33:46 -0800 Re-evaluate if a repetitive timer should be throttled upon firing 2014-11-05 10:43:17 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136197 138292 1 cdumez cdumez barraclough commit-queue kling koivisto oldest_to_newest 1045914 0 cdumez 2014-11-03 17:33:46 -0800 We should re-evaluate if a repetitive timer should be throttled upon firing in case the plugin observability state has changed: - It used to be visible but now isn't and thus the timer can be throttled - It used to play audio but now doesn't and thus the timer can be throttled We already stop throttling if the plugin becomes observable. However, we don't start throttling if the plugin becomes non-observable. 1045925 1 240891 cdumez 2014-11-03 17:52:23 -0800 Created attachment 240891 Patch 1046531 2 240891 commit-queue 2014-11-05 10:43:14 -0800 Comment on attachment 240891 Patch Clearing flags on attachment: 240891 Committed r175627: <http://trac.webkit.org/changeset/175627> 1046532 3 commit-queue 2014-11-05 10:43:17 -0800 All reviewed patches have been landed. Closing bug. 240891 2014-11-03 17:52:23 -0800 2014-11-05 10:43:14 -0800 Patch bug-138339-20141103175233.patch text/plain 2444 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc2MTQ4NTE0M2YwOWIw ZDdiNjFjNTM2Njg0Njg2ZGU4NmIyYzQ4Ny4uOWJlN2NkMGMzMDFhMjg4NGEzMTE0NDY1YTI0NzQz MTViMmJhZWM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTExLTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmUtZXZhbHVhdGUgaWYgYSBy ZXBldGl0aXZlIHRpbWVyIHNob3VsZCBiZSB0aHJvdHRsZWQgdXBvbiBmaXJpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWV2YWx1YXRlIGlmIGEg cmVwZXRpdGl2ZSB0aW1lciBzaG91bGQgYmUgdGhyb3R0bGVkIHVwb24gZmlyaW5nIGluCisgICAg ICAgIGNhc2UgdGhlIHBsdWdpbiBvYnNlcnZhYmlsaXR5IHN0YXRlIGhhcyBjaGFuZ2VkOgorICAg ICAgICAtIEl0IHVzZWQgdG8gYmUgdmlzaWJsZSBidXQgbm93IGlzbid0IGFuZCB0aHVzIHRoZSB0 aW1lciBjYW4gYmUgdGhyb3R0bGVkCisgICAgICAgIC0gSXQgdXNlZCB0byBwbGF5IGF1ZGlvIGJ1 dCBub3cgZG9lc24ndCBhbmQgdGh1cyB0aGUgdGltZXIgY2FuIGJlIHRocm90dGxlZAorCisgICAg ICAgIFdlIGFscmVhZHkgc3RvcHBlZCB0aHJvdHRsaW5nIGlmIHRoZSBwbHVnaW4gYmVjYW1lIG9i c2VydmFibGUuIEhvd2V2ZXIsCisgICAgICAgIHdlIGRpZG4ndCBzdGFydCB0aHJvdHRsaW5nIGlm IHRoZSBwbHVnaW4gYmVjYW1lIG5vbi1vYnNlcnZhYmxlLgorCisgICAgICAgICogcGFnZS9ET01U aW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01UaW1lcjo6dXBkYXRlVGhyb3R0bGluZ1N0 YXRlSWZOZWNlc3NhcnkpOgorCiAyMDE0LTExLTAzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgTW92ZSBXZWJDb3JlL2JyaWRnZSB0byBzdGQ6OnVu aXF1ZV9wdHIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKaW5kZXggZDhjODExOGJjMmJhZGFlOGI0 MDllMDM0NWRhOTIxOTE1MjIyZTIwOS4uOTRkMmIxZjQ1OGFhYjUxMDk2Mjg3YzlkNjM2ZGU3MjQ2 OGRkNzdhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKQEAgLTE5MCwxMiArMTkwLDE2IEBA IHZvaWQgRE9NVGltZXI6OnJlbW92ZUJ5SWQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4 dCwgaW50IHRpbWVvdXRJZCkKIAogdm9pZCBET01UaW1lcjo6dXBkYXRlVGhyb3R0bGluZ1N0YXRl SWZOZWNlc3NhcnkoY29uc3QgRE9NVGltZXJGaXJlU3RhdGUmIGZpcmVTdGF0ZSkKIHsKLSAgICBp ZiAoZmlyZVN0YXRlLnNjcmlwdERpZEludGVyYWN0V2l0aFVzZXJPYnNlcnZhYmxlUGx1Z2luICYm IG1fdGhyb3R0bGVTdGF0ZSAhPSBTaG91bGROb3RUaHJvdHRsZSkgewotICAgICAgICBtX3Rocm90 dGxlU3RhdGUgPSBTaG91bGROb3RUaHJvdHRsZTsKLSAgICAgICAgdXBkYXRlVGltZXJJbnRlcnZh bElmTmVjZXNzYXJ5KCk7Ci0gICAgfSBlbHNlIGlmIChmaXJlU3RhdGUuc2NyaXB0RGlkSW50ZXJh Y3RXaXRoTm9uVXNlck9ic2VydmFibGVQbHVnaW4gJiYgbV90aHJvdHRsZVN0YXRlID09IFVuZGV0 ZXJtaW5lZCkgewotICAgICAgICBtX3Rocm90dGxlU3RhdGUgPSBTaG91bGRUaHJvdHRsZTsKLSAg ICAgICAgdXBkYXRlVGltZXJJbnRlcnZhbElmTmVjZXNzYXJ5KCk7CisgICAgaWYgKGZpcmVTdGF0 ZS5zY3JpcHREaWRJbnRlcmFjdFdpdGhVc2VyT2JzZXJ2YWJsZVBsdWdpbikgeworICAgICAgICBp ZiAobV90aHJvdHRsZVN0YXRlICE9IFNob3VsZE5vdFRocm90dGxlKSB7CisgICAgICAgICAgICBt X3Rocm90dGxlU3RhdGUgPSBTaG91bGROb3RUaHJvdHRsZTsKKyAgICAgICAgICAgIHVwZGF0ZVRp bWVySW50ZXJ2YWxJZk5lY2Vzc2FyeSgpOworICAgICAgICB9CisgICAgfSBlbHNlIGlmIChmaXJl U3RhdGUuc2NyaXB0RGlkSW50ZXJhY3RXaXRoTm9uVXNlck9ic2VydmFibGVQbHVnaW4pIHsKKyAg ICAgICAgaWYgKG1fdGhyb3R0bGVTdGF0ZSAhPSBTaG91bGRUaHJvdHRsZSkgeworICAgICAgICAg ICAgbV90aHJvdHRsZVN0YXRlID0gU2hvdWxkVGhyb3R0bGU7CisgICAgICAgICAgICB1cGRhdGVU aW1lckludGVydmFsSWZOZWNlc3NhcnkoKTsKKyAgICAgICAgfQogICAgIH0KIH0KIAo=