<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138332</bug_id>
          
          <creation_ts>2014-11-03 16:00:13 -0800</creation_ts>
          <short_desc>libwebkit2gtk fails to link without opengl</short_desc>
          <delta_ts>2015-09-14 11:02:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126492</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Benedikt Morbach">benedikt.morbach</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ossy</cc>
    
    <cc>philip.chimento</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1045883</commentid>
    <comment_count>0</comment_count>
    <who name="Benedikt Morbach">benedikt.morbach</who>
    <bug_when>2014-11-03 16:00:13 -0800</bug_when>
    <thetext>If built without OpenGL, libwebkit2gtk fails to link because it is missing &apos;-lX11&apos; and friends.

CMakeFiles/WebKit2.dir/PluginProcess/unix/PluginProcessMainUnix.cpp.o: In function `WebKit::webkitXError(_XDisplay*, XErrorEvent*)&apos;:
PluginProcessMainUnix.cpp:(.text+0x11): undefined reference to `XGetErrorText&apos;
CMakeFiles/WebKit2.dir/PluginProcess/unix/PluginProcessMainUnix.cpp.o: In function `WebKit::PluginProcessMain::parseCommandLine(int, char**)&apos;:
PluginProcessMainUnix.cpp:(.text._ZN6WebKit17PluginProcessMain16parseCommandLineEiPPc[_ZN6WebKit17PluginProcessMain16parseCommandLineEiPPc]+0xe2): undefined reference to `XSetErrorHandler&apos;
&lt;snip&gt;
...and a lot more errors along those lines

As far as I can tell this is because OptionsGTK.cmake doesn&apos;t explicitly call
find_package(X11), but relies on FindOpenGL doing so implicitly.
($X11_*_LIB are referenced in WebCore/PlatformGTK.cmake)

However, OpenGL is an optional dependency and as such can be disabled using
cmakes CMAKE_DISABLE_FIND_PACKAGE_FOO. (see [1]).

I think the correct fix would be to explicitly call find_package(X11), probably inside if (ENABLE_X11_TARGET)

[1] http://www.cmake.org/cmake/help/v3.0/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1051760</commentid>
    <comment_count>1</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-12-02 00:25:10 -0800</bug_when>
    <thetext>Any specific version of WebKitGTK+, or are you using tip-of-tree?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1051807</commentid>
    <comment_count>2</comment_count>
    <who name="Benedikt Morbach">benedikt.morbach</who>
    <bug_when>2014-12-02 05:23:43 -0800</bug_when>
    <thetext>Tested with 2.6.2 and 2.7.1, but as far as I can tell it&apos;s still the same in current tip-of-tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053204</commentid>
    <comment_count>3</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-12-07 11:29:57 -0800</bug_when>
    <thetext>It&apos;s not just libX11, there&apos;s also many other OpenGL symbols in platforms/graphics/*, is OpenGL really optional for us?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053205</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-12-07 11:35:56 -0800</bug_when>
    <thetext>I think you at least need the headers while building.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053218</commentid>
    <comment_count>5</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-12-07 12:57:26 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; I think you at least need the headers while building.

I actually made it work, following these steps:

- Disabling WebGL as well.
- Defining WTF_USE_TEXTURE_MAPPER=1 (but not TEXTURE_MAPPER_GL)
- Building GraphicsLayerTextureMapper.cpp

I can prepare a patch, but do we want this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053220</commentid>
    <comment_count>6</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-12-07 13:02:23 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; I think you at least need the headers while building.
&gt; 
&gt; I actually made it work, following these steps:
&gt; 
&gt; - Disabling WebGL as well.
&gt; - Defining WTF_USE_TEXTURE_MAPPER=1 (but not TEXTURE_MAPPER_GL)
&gt; - Building GraphicsLayerTextureMapper.cpp
&gt; 
&gt; I can prepare a patch, but do we want this?

I don&apos;t think we want to support the fallback TextureMapper configuration (if it even exists any longer).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053227</commentid>
    <comment_count>7</comment_count>
      <attachid>242768</attachid>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-12-07 13:20:55 -0800</bug_when>
    <thetext>Created attachment 242768
Patch

Here&apos;s a quick &amp; dirty patch to make it work, but if we don&apos;t want to support
this we should close this and bug 138347 as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053309</commentid>
    <comment_count>8</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-12-08 01:20:21 -0800</bug_when>
    <thetext>*** Bug 138347 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058495</commentid>
    <comment_count>9</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-01-02 20:02:34 -0800</bug_when>
    <thetext>I was building 2.6.4 without X11 on OSX (using the Quartz backend of GTK) and ran into a related issue while linking:

Linking CXX shared library ../../lib/libwebkit2gtk-4.0.dylib
Undefined symbols for architecture x86_64:
  &quot;WebCore::GraphicsLayer::create(WebCore::GraphicsLayerFactory*, WebCore::GraphicsLayerClient&amp;)&quot;, referenced from:
      WebKit::WebInspectorClient::showPaintRect(WebCore::FloatRect const&amp;) in WebInspectorClient.cpp.o
      WebKit::PageOverlayController::initialize() in PageOverlayController.cpp.o
      WebKit::PageOverlayController::installPageOverlay(WTF::PassRefPtr&lt;WebKit::PageOverlay&gt;, WebKit::PageOverlay::FadeMode) in PageOverlayController.cpp.o
      WebCore::RenderLayerBacking::createGraphicsLayer(WTF::String const&amp;) in libWebCoreGTK.a(RenderLayerBacking.cpp.o)
      WebCore::RenderLayerCompositor::ensureRootLayer() in libWebCoreGTK.a(RenderLayerCompositor.cpp.o)
      WebCore::RenderLayerCompositor::updateOverflowControlsLayers() in libWebCoreGTK.a(RenderLayerCompositor.cpp.o)
ld: symbol(s) not found for architecture x86_64

I think the issue here is that without X11, GraphicsLayerTextureMapper.cpp is the only available implementation of WebCore::GraphicsLayer::create(). It&apos;s mentioned in comment 6 that the texture mapper is a fallback; I guess the question is fallback from what? What should provide GraphicsLayer::create() in the case of the Quartz backend WebKitGTK port?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058504</commentid>
    <comment_count>10</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-01-02 20:26:23 -0800</bug_when>
    <thetext>I also had to add &quot;${CMAKE_SOURCE_DIR}/Source/ThirdParty/ANGLE/include/GLSLANG&quot; and &quot;${CMAKE_SOURCE_DIR}/Source/ThirdParty/ANGLE/include/KHR&quot; to the include directories in WebCore/PlatformGTK.cmake, by the way, for this fix to compile. I&apos;ll provide an updated patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1058519</commentid>
    <comment_count>11</comment_count>
      <attachid>243920</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-01-03 12:37:02 -0800</bug_when>
    <thetext>Created attachment 243920
Updated patch

Updated patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091264</commentid>
    <comment_count>12</comment_count>
      <attachid>252286</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-03 15:29:01 -0700</bug_when>
    <thetext>Created attachment 252286
Updated patch

Updated patch for 2.8.0.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091267</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-03 15:31:53 -0700</bug_when>
    <thetext>Attachment 252286 did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091268</commentid>
    <comment_count>14</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-05-03 15:38:25 -0700</bug_when>
    <thetext>I think this patch is out of date after the latest changes to the CMake build system.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091273</commentid>
    <comment_count>15</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-05-03 15:55:59 -0700</bug_when>
    <thetext>The comment says the patch is for 2.8.0. :) It&apos;d be great to have a patch that can apply on master as well.

Also, the ANGLE directories are already appended to WebCore_INCLUDE_DIRECTORIES in WebCore/CMakeLists.txt, so they should be removed from there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091281</commentid>
    <comment_count>16</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-05-03 16:21:13 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; The comment says the patch is for 2.8.0. :) It&apos;d be great to have a patch
&gt; that can apply on master as well.
&gt; 
&gt; Also, the ANGLE directories are already appended to
&gt; WebCore_INCLUDE_DIRECTORIES in WebCore/CMakeLists.txt, so they should be
&gt; removed from there.

Oops. Sorry about the noise.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091384</commentid>
    <comment_count>17</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-05-04 08:33:16 -0700</bug_when>
    <thetext>$ Tools/Scripts/svn-apply attachment.cgi\?id=252286
Parsed 0 diffs from patch file(s).

It seems it isn&apos;t valid patch for svn-apply, similar to bug126433</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093035</commentid>
    <comment_count>18</comment_count>
      <attachid>252685</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-07 22:27:53 -0700</bug_when>
    <thetext>Created attachment 252685
Patch for 2.8.0

Here&apos;s a patch with the requested changes and with a changelog.

If this doesn&apos;t apply to master, then I&apos;m not sure when I&apos;ll get a chance to prepare a patch that does. Due to the esoteric platform (GTK on OSX) I&apos;m compiling on, it&apos;s a rare occurrence that I can compile WebKit to a working state at all. For example, the entire 2.6.x series segfaulted on startup for me, and I never figured out why. On master, it tends to be a losing battle. Now that I have a working state on 2.8.0, I am trying to give you all the patches that I can, before they become stale :-( Any help would be appreciated.

In any case I&apos;ll propose this for inclusion on https://trac.webkit.org/wiki/WebKitGTK/2.8.x</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093536</commentid>
    <comment_count>19</comment_count>
      <attachid>252818</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-10 11:24:53 -0700</bug_when>
    <thetext>Created attachment 252818
Patch for master

Here&apos;s a patch that applies to master, as well. I&apos;ve tested it on 2.9.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093546</commentid>
    <comment_count>20</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-05-10 12:03:19 -0700</bug_when>
    <thetext>Thanks for these patches.

In WebCore/CMakeLists.txt, I&apos;d prefer to append the two ANGLE include directories once, outside the conditional.

Why is one added in PlatformGTK.cmake? Is that needed only when GRAPHICS_CONTEXT_3D is off? I think that should still be added in WebCore/CMakeLists.txt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093591</commentid>
    <comment_count>21</comment_count>
      <attachid>252826</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-10 14:50:03 -0700</bug_when>
    <thetext>Created attachment 252826
Patch for master</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093592</commentid>
    <comment_count>22</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-10 14:52:20 -0700</bug_when>
    <thetext>You&apos;re welcome.

I initially kept the GLSLANG directory out of CMakeLists.txt because it wasn&apos;t added either in the GRAPHICS_CONTEXT_3D case. But it surely can&apos;t be harmful to add it anyway, so I just moved it there as you suggested.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093761</commentid>
    <comment_count>23</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-05-11 08:24:22 -0700</bug_when>
    <thetext>EFL bot is having problems:

c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See &lt;file:///usr/share/doc/gcc-4.8/README.Bugs&gt; for instructions.

Probably time for them to upgrade GCC, anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094021</commentid>
    <comment_count>24</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-05-11 20:40:15 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; EFL bot is having problems:
&gt; 
&gt; c++: internal compiler error: Killed (program cc1plus)
&gt; Please submit a full bug report,
&gt; with preprocessed source if appropriate.
&gt; See &lt;file:///usr/share/doc/gcc-4.8/README.Bugs&gt; for instructions.
&gt; 
&gt; Probably time for them to upgrade GCC, anyway.

Sorry for inconvenient. EFL EWS was sick yesterday. This patch is fine when building locally. Please land it !</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094166</commentid>
    <comment_count>25</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-05-12 08:29:05 -0700</bug_when>
    <thetext>(In reply to comment #24) 
&gt; Sorry for inconvenient. EFL EWS was sick yesterday. This patch is fine when
&gt; building locally. Please land it !

Do you have time to review it? :) It looks good to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094168</commentid>
    <comment_count>26</comment_count>
      <attachid>252826</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-05-12 08:37:58 -0700</bug_when>
    <thetext>Comment on attachment 252826
Patch for master

View in context: https://bugs.webkit.org/attachment.cgi?id=252826&amp;action=review

&gt; Source/cmake/OptionsGTK.cmake:281
&gt; +SET_AND_EXPOSE_TO_BUILD(USE_TEXTURE_MAPPER TRUE)
&gt; +

FWIW, we are going to be removing the non-OpenGL version of the texture mapper.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094674</commentid>
    <comment_count>27</comment_count>
      <attachid>252826</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-05-13 18:14:39 -0700</bug_when>
    <thetext>Comment on attachment 252826
Patch for master

LGTM, however it looks GTK folks might need to have final review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094730</commentid>
    <comment_count>28</comment_count>
      <attachid>252826</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-13 22:54:32 -0700</bug_when>
    <thetext>Comment on attachment 252826
Patch for master

View in context: https://bugs.webkit.org/attachment.cgi?id=252826&amp;action=review

&gt; Source/WebCore/CMakeLists.txt:3120
&gt; +    &quot;${THIRDPARTY_DIR}/ANGLE/include/GLSLANG&quot;

I don&apos;t get why you added GLSLANG, if it wasn&apos;t needed before, why is it needed now? There&apos;s some conflict with the in-tree headers and the installed ones, so I prefer not to change this if it&apos;s not needed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094809</commentid>
    <comment_count>29</comment_count>
      <attachid>253122</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-14 08:56:33 -0700</bug_when>
    <thetext>Created attachment 253122
Updated patch for master</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094810</commentid>
    <comment_count>30</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-14 08:58:01 -0700</bug_when>
    <thetext>(In reply to comment #28)
&gt; I don&apos;t get why you added GLSLANG, if it wasn&apos;t needed before, why is it
&gt; needed now? There&apos;s some conflict with the in-tree headers and the installed
&gt; ones, so I prefer not to change this if it&apos;s not needed

I tested and indeed it wasn&apos;t needed. I think it was needed when I originally wrote this patch on 2.6.x and I just carried it over. I&apos;ve updated the patch to remove it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094813</commentid>
    <comment_count>31</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-14 08:59:23 -0700</bug_when>
    <thetext>Attachment 253122 did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094849</commentid>
    <comment_count>32</comment_count>
      <attachid>253122</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-14 11:15:12 -0700</bug_when>
    <thetext>Comment on attachment 253122
Updated patch for master

Rejecting attachment 253122 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.appspot.com&apos;, &apos;--bot-id=webkit-cq-02&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 253122, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 184339 = 76760c75eaef3255b23d23a9f0f0aa94103e47dc
r184340 = 23c2df7821affb0236a545d888809229f80b5dda
r184341 = 5615cb361c49318e67ede4d0f1ecf598beaf7a74
r184344 = fbf429221728313e13303bdcd358c9a4543987e2
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5510072457232384</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095037</commentid>
    <comment_count>33</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-05-14 22:40:37 -0700</bug_when>
    <thetext>Copying what seems to be the relevant output here:

Processing patch 253122 from bug 138332.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html

The patch definitely does have a ChangeLog entry, so I&apos;m not sure what&apos;s going on here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095070</commentid>
    <comment_count>34</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2015-05-15 02:35:34 -0700</bug_when>
    <thetext>The changed files in the diff have incorrect paths:
a/Source/WebCore/ChangeLog
a/Source/WebCore/CMakeLists.txt
a/Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp
a/Source/cmake/OptionsGTK.cmake
a/ChangeLog

I don&apos;t think the diff was generated correctly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1103642</commentid>
    <comment_count>35</comment_count>
      <attachid>255294</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-06-20 12:04:14 -0700</bug_when>
    <thetext>Created attachment 255294
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1103643</commentid>
    <comment_count>36</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-06-20 12:06:27 -0700</bug_when>
    <thetext>I regenerated the patch; not sure what wasn&apos;t working before. Since the previous patch was already r+, I&apos;m hoping it won&apos;t take too long to review this one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1103714</commentid>
    <comment_count>37</comment_count>
      <attachid>255294</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-06-21 03:07:00 -0700</bug_when>
    <thetext>Comment on attachment 255294
Patch

Clearing flags on attachment: 255294

Committed r185805: &lt;http://trac.webkit.org/changeset/185805&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107437</commentid>
    <comment_count>38</comment_count>
      <attachid>252685</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-07-07 05:53:19 -0700</bug_when>
    <thetext>Comment on attachment 252685
Patch for 2.8.0

View in context: https://bugs.webkit.org/attachment.cgi?id=252685&amp;action=review

&gt; Source/WebCore/PlatformGTK.cmake:26
&gt; +    &quot;${CMAKE_SOURCE_DIR}/Source/ThirdParty/ANGLE/include/GLSLANG&quot;

As in trunk patch I don&apos;t get why we need to add GLSLANG.

&gt; Source/WebCore/PlatformGTK.cmake:216
&gt; +    platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
&gt; +

Why do you need to move this file? This file doesn&apos;t belong to WebCorePlatformGTK since it doens&apos;t use GTK+ at all</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1121558</commentid>
    <comment_count>39</comment_count>
      <attachid>260116</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-08-27 20:59:38 -0700</bug_when>
    <thetext>Created attachment 260116
Patch for 2.8.5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1121559</commentid>
    <comment_count>40</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-08-27 21:01:31 -0700</bug_when>
    <thetext>Here&apos;s an updated patch that applies to 2.8.5.

Indeed, I had mistakenly put the file in WebCoreGTK when it should have gone in WebCore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1123439</commentid>
    <comment_count>41</comment_count>
      <attachid>260116</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-09-04 08:49:11 -0700</bug_when>
    <thetext>Comment on attachment 260116
Patch for 2.8.5

View in context: https://bugs.webkit.org/attachment.cgi?id=260116&amp;action=review

It looks like this patch does more than fix the build when OpenGL is off. Some of these changes look like they are making the TextureMapper unconditional.

&gt; Source/WebCore/CMakeLists.txt:-2985
&gt; -        &quot;${THIRDPARTY_DIR}/ANGLE/&quot;
&gt; -        &quot;${THIRDPARTY_DIR}/ANGLE/include/KHR&quot;

This file is shared between all ports, so I don&apos;t think you should remove them from here.

&gt; Source/WebCore/PlatformGTK.cmake:128
&gt; +    platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
&gt; +
&gt;      platform/gtk/ErrorsGtk.cpp

What is the purpose of compiling the TextureMapper unconditionally?

&gt; Source/cmake/OptionsGTK.cmake:355
&gt; +add_definitions(-DWTF_USE_TEXTURE_MAPPER=1)
&gt; +

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1123847</commentid>
    <comment_count>42</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-09-04 20:33:13 -0700</bug_when>
    <thetext>(In reply to comment #41)
&gt; Comment on attachment 260116 [details]
&gt; Patch for 2.8.5
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=260116&amp;action=review
&gt; 
&gt; It looks like this patch does more than fix the build when OpenGL is off.
&gt; Some of these changes look like they are making the TextureMapper
&gt; unconditional.

This is the same as what was committed to master in http://trac.webkit.org/changeset/185805. The TextureMapper (not the TextureMapperGL, though) was already unconditional in practice, because without it there was no implementation of WebCore::GraphicsLayer::create(). I wondered if there was any other way to fix this in comment #9 but I guess there wasn&apos;t.

&gt; &gt; Source/WebCore/CMakeLists.txt:-2985
&gt; &gt; -        &quot;${THIRDPARTY_DIR}/ANGLE/&quot;
&gt; &gt; -        &quot;${THIRDPARTY_DIR}/ANGLE/include/KHR&quot;
&gt; 
&gt; This file is shared between all ports, so I don&apos;t think you should remove
&gt; them from here.

True, in that case I&apos;ll leave them in place here but still add them to PlatformGTK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1123851</commentid>
    <comment_count>43</comment_count>
      <attachid>260670</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-09-04 20:36:41 -0700</bug_when>
    <thetext>Created attachment 260670
Patch for 2.8 branch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1123925</commentid>
    <comment_count>44</comment_count>
      <attachid>260670</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-09-05 06:41:08 -0700</bug_when>
    <thetext>Comment on attachment 260670
Patch for 2.8 branch

OK, seems like this is already fixed on master, and the patch is only needed for 2.8. To avoid confusion, I will close this bug as fixed. It&apos;s already linked to from [1] which is where we keep the list of backport requests.

Please also note that commit-queue is patches for master.

[1] https://trac.webkit.org/wiki/WebKitGTK/2.8.x</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1125657</commentid>
    <comment_count>45</comment_count>
      <attachid>260670</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-09-14 11:02:43 -0700</bug_when>
    <thetext>Comment on attachment 260670
Patch for 2.8 branch

Cleared review? from attachment 260670 so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>242768</attachid>
            <date>2014-12-07 13:20:55 -0800</date>
            <delta_ts>2014-12-07 13:20:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>138332.diff</filename>
            <type>text/plain</type>
            <size>2151</size>
            <attacher name="Alberto Garcia">berto</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMTY1MDIyYy4uMDk4ZDhiNyAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUv
UGxhdGZvcm1HVEsuY21ha2UKQEAgLTIxNCw2ICsyMTQsOCBAQCBsaXN0KEFQUEVORCBXZWJDb3Jl
UGxhdGZvcm1HVEtfU09VUkNFUwogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUJ1ZmZl
ckd0ay5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3BwCiAKKyAgICBw
bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3BwCisK
ICAgICBwbGF0Zm9ybS9ndGsvQ29udGV4dE1lbnVHdGsuY3BwCiAgICAgcGxhdGZvcm0vZ3RrL0Nv
bnRleHRNZW51SXRlbUd0ay5jcHAKICAgICBwbGF0Zm9ybS9ndGsvQ3Vyc29yR3RrLmNwcApAQCAt
MzcwLDcgKzM3Miw2IEBAIGlmIChFTkFCTEVfVEVYVFVSRV9NQVBQRVIpCiAgICAgICAgICIke1dF
QkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAiCiAgICAgKQogICAgIGxpc3QoQVBQ
RU5EIFdlYkNvcmVfU09VUkNFUwotICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3Jh
cGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL3Rl
eG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1h
cC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAKICAgICApCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl
CmluZGV4IGYyNjkxMTMuLmEyNDA5NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25z
R1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC01NSw2ICs1
NSw3IEBAIGlmIChOT1QgR0VPQ0xVRTJfRk9VTkQpCiBlbmRpZiAoKQogCiBpZiAoRU5BQkxFX1gx
MV9UQVJHRVQpCisgICAgZmluZF9wYWNrYWdlKFgxMSkKICAgICAjIFdlIGRvbid0IHVzZSBmaW5k
X3BhY2thZ2UgZm9yIEdMWCBiZWNhdXNlIGl0IGlzIHBhcnQgb2YgLWxHTCwgdW5saWtlIEVHTC4K
ICAgICBjaGVja19pbmNsdWRlX2ZpbGVzKCJHTC9nbHguaCIgR0xYX0ZPVU5EKQogZW5kaWYgKCkK
QEAgLTc4LDYgKzc5LDkgQEAgaWYgKE9QRU5HTF9GT1VORCBBTkQgKEdMWF9GT1VORCBPUiBFR0xf
Rk9VTkQpKQogICAgICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf
QUNDRUxFUkFURURfMkRfQ0FOVkFTIE9GRikKICAgICBlbmRpZiAoKQogZWxzZSAoKQorICAgIGlm
IChFTkFCTEVfV0VCR0wpCisgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiT3BlbkdMIGlzIG5l
ZWRlZCBmb3IgV2ViR0wgc3VwcG9ydCIpCisgICAgZW5kaWYgKCkKICAgICBXRUJLSVRfT1BUSU9O
X0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCR0wgT0ZGKQogICAgIFdFQktJVF9PUFRJT05f
REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMgT0ZGKQogZW5k
aWYgKCkKQEAgLTI5NCwxMyArMjk4LDE0IEBAIGlmIChFTkFCTEVfU1BFTExDSEVDSykKICAgICBm
aW5kX3BhY2thZ2UoRW5jaGFudCBSRVFVSVJFRCkKIGVuZGlmICgpCiAKK2FkZF9kZWZpbml0aW9u
cygtRFdURl9VU0VfVEVYVFVSRV9NQVBQRVI9MSkKKwogaWYgKE9QRU5HTF9GT1VORCBBTkQgKEdM
WF9GT1VORCBPUiBFR0xfRk9VTkQpKQogICAgIHNldChFTkFCTEVfVEVYVFVSRV9NQVBQRVIgMSkK
ICAgICBzZXQoV1RGX1VTRV8zRF9HUkFQSElDUyAxKQogCiAgICAgYWRkX2RlZmluaXRpb25zKC1E
V1RGX1VTRV9PUEVOR0w9MSkKICAgICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFXzNEX0dSQVBI
SUNTPTEpCi0gICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9URVhUVVJFX01BUFBFUj0xKQog
ICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfVEVYVFVSRV9NQVBQRVJfR0w9MSkKICAgICBh
ZGRfZGVmaW5pdGlvbnMoLURFTkFCTEVfM0RfUkVOREVSSU5HPTEpCiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>243920</attachid>
            <date>2015-01-03 12:37:02 -0800</date>
            <delta_ts>2015-05-03 15:29:01 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>138332.patch</filename>
            <type>text/plain</type>
            <size>3865</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkNmExNDUzLi4zNjNjYWY4
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK
KzIwMTUtMDEtMDMgIFBoaWxpcCBDaGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+
CisKKyAgICAgICAgbGlid2Via2l0Mmd0ayBmYWlscyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9j
bWFrZS9PcHRpb25zR1RLLmNtYWtlOiBCdWlsZCBUZXh0dXJlTWFwcGVyIHVuY29uZGl0aW9uYWxs
eSBzbyBhcyB0byBsaW5rIGluIGFuIGltcGxlbWVudGF0aW9uIG9mIEdyYXBoaWNzTGF5ZXI6OmNy
ZWF0ZSgpLgorCiAyMDE0LTEyLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t
PgogCiAgICAgICAgIFNpbXBsaWZ5IGJ1aWxkaW5nIHdpdGggQVNhbgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDk3
ZDIwZWEuLjc2NDNhNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0wMS0wMyAg
UGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4KKworICAgICAgICBs
aWJ3ZWJraXQyZ3RrIGZhaWxzIHRvIGxpbmsgd2l0aG91dCBvcGVuZ2wKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzMgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzIGFyZSBub3QgbmVjZXNzYXJ5
LCBzaW5jZSBubyBjb2RlIGNoYW5nZXMgd2VyZSBtYWRlLiBUaGlzIGlzIGFib3V0CisgICAgICAg
IGEgYnVpbGQgZmFpbHVyZSwgc28gYSBzdWNjZXNzZnVsIGJ1aWxkIGlzIHRoZSB0ZXN0LiAKKwor
ICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOiBCdWlsZCBUZXh0dXJlTWFwcGVyIHVuY29uZGl0
aW9uYWxseSBzbyBhcyB0byBsaW5rIGluCisgICAgICAgIGFuIGltcGxlbWVudGF0aW9uIG9mIEdy
YXBoaWNzTGF5ZXI6OmNyZWF0ZSgpLiBJbmNsdWRlIEFOR0xFIGhlYWRlcnMgaW4KKyAgICAgICAg
V2ViQ29yZSdzIGluY2x1ZGUgZGlycy4KKwogMjAxNS0wMS0wMiAgQ2hyaXMgRHVtZXogIDxjZHVt
ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEtpbGwgdGhlIERlcHJlY2F0ZWRTdHlsZUJ1aWxkZXIK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMWJmNjczYS4uYmQ5ZTU5MiAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUv
UGxhdGZvcm1HVEsuY21ha2UKQEAgLTIyLDYgKzIyLDggQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9J
TkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsv
c291cCIKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vdGV4dC9ndGsiCiAgICAgIiR7V0VC
Q09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvaWN1IgorICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1Nv
dXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvR0xTTEFORyIKKyAgICAiJHtDTUFLRV9TT1VS
Q0VfRElSfS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0tIUiIKICkKIAogbGlzdChB
UFBFTkQgV2ViQ29yZV9TT1VSQ0VTCkBAIC0yMTUsNiArMjE3LDggQEAgbGlzdChBUFBFTkQgV2Vi
Q29yZVBsYXRmb3JtR1RLX1NPVVJDRVMKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VC
dWZmZXJHdGsuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcAogCisg
ICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNw
cAorCiAgICAgcGxhdGZvcm0vZ3RrL0NvbnRleHRNZW51R3RrLmNwcAogICAgIHBsYXRmb3JtL2d0
ay9Db250ZXh0TWVudUl0ZW1HdGsuY3BwCiAgICAgcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAK
QEAgLTM3MCw3ICszNzQsNiBAQCBpZiAoRU5BQkxFX1RFWFRVUkVfTUFQUEVSKQogICAgICAgICAi
JHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwIgogICAgICkKICAgICBsaXN0
KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw
L0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGlj
cy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy90
ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCiAgICAgKQpkaWZmIC0tZ2l0IGEv
U291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j
bWFrZQppbmRleCA1NGNiMDAzLi45YWMwNDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtNTcs
NiArNTcsNyBAQCBpZiAoTk9UIEdFT0NMVUUyX0ZPVU5EKQogZW5kaWYgKCkKIAogaWYgKEVOQUJM
RV9YMTFfVEFSR0VUKQorICAgIGZpbmRfcGFja2FnZShYMTEpCiAgICAgIyBXZSBkb24ndCB1c2Ug
ZmluZF9wYWNrYWdlIGZvciBHTFggYmVjYXVzZSBpdCBpcyBwYXJ0IG9mIC1sR0wsIHVubGlrZSBF
R0wuCiAgICAgY2hlY2tfaW5jbHVkZV9maWxlcygiR0wvZ2x4LmgiIEdMWF9GT1VORCkKIGVuZGlm
ICgpCkBAIC04MCw2ICs4MSw5IEBAIGlmIChPUEVOR0xfRk9VTkQgQU5EIChHTFhfRk9VTkQgT1Ig
RUdMX0ZPVU5EKSkKICAgICAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B
QkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyBPRkYpCiAgICAgZW5kaWYgKCkKIGVsc2UgKCkKKyAg
ICBpZiAoRU5BQkxFX1dFQkdMKQorICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIk9wZW5HTCBp
cyBuZWVkZWQgZm9yIFdlYkdMIHN1cHBvcnQiKQorICAgIGVuZGlmICgpCiAgICAgV0VCS0lUX09Q
VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQkdMIE9GRikKICAgICBXRUJLSVRfT1BU
SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIE9GRikK
IGVuZGlmICgpCkBAIC0zMTIsMTMgKzMxNiwxNCBAQCBpZiAoRU5BQkxFX1NQRUxMQ0hFQ0spCiAg
ICAgZmluZF9wYWNrYWdlKEVuY2hhbnQgUkVRVUlSRUQpCiBlbmRpZiAoKQogCithZGRfZGVmaW5p
dGlvbnMoLURXVEZfVVNFX1RFWFRVUkVfTUFQUEVSPTEpCisKIGlmIChPUEVOR0xfRk9VTkQgQU5E
IChHTFhfRk9VTkQgT1IgRUdMX0ZPVU5EKSkKICAgICBzZXQoRU5BQkxFX1RFWFRVUkVfTUFQUEVS
IDEpCiAgICAgc2V0KFdURl9VU0VfM0RfR1JBUEhJQ1MgMSkKIAogICAgIGFkZF9kZWZpbml0aW9u
cygtRFdURl9VU0VfT1BFTkdMPTEpCiAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV8zRF9H
UkFQSElDUz0xKQotICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfVEVYVFVSRV9NQVBQRVI9
MSkKICAgICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFX1RFWFRVUkVfTUFQUEVSX0dMPTEpCiAg
ICAgYWRkX2RlZmluaXRpb25zKC1ERU5BQkxFXzNEX1JFTkRFUklORz0xKQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>252286</attachid>
            <date>2015-05-03 15:29:01 -0700</date>
            <delta_ts>2015-05-07 22:27:53 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>webkit-138332-fix-opengl-link.patch</filename>
            <type>text/plain</type>
            <size>1971</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">LS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UgIAorKysgYS9Tb3VyY2UvV2Vi
Q29yZS9QbGF0Zm9ybUdUSy5jbWFrZSAgCkBAIC0yMiw2ICsyMiw5IEBACiAgICAgIiR7V0VCQ09S
RV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvc291cCIKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZv
cm0vdGV4dC9ndGsiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvaWN1IgorICAg
ICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFIgorICAgICIke0NN
QUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvR0xTTEFORyIK
KyAgICAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRl
L0tIUiIKICkKIAogbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCkBAIC0yMTEsNiArMjEyLDgg
QEAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VCdWZmZXJHdGsuY3BwCiAgICAgcGxh
dGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcAogCisgICAgcGxhdGZvcm0vZ3JhcGhpY3Mv
dGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAorCiAgICAgcGxhdGZvcm0vZ3Rr
L0NvbnRleHRNZW51R3RrLmNwcAogICAgIHBsYXRmb3JtL2d0ay9Db250ZXh0TWVudUl0ZW1HdGsu
Y3BwCiAgICAgcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAKQEAgLTM2Niw3ICszNjksNiBAQAog
ICAgICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwIgogICAgICkK
ICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAgICAgICAgcGxhdGZvcm0vZ3JhcGhp
Y3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAogICAgICAgICBwbGF0Zm9y
bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAogICAgICAgICBwbGF0Zm9ybS9n
cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCiAgICAgKQotLS0g
YS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSAKKysrIGEvU291cmNlL2NtYWtlL09wdGlv
bnNHVEsuY21ha2UgCkBAIC0xMTIsNiArMTEyLDkgQEAKICAgICAgICAgV0VCS0lUX09QVElPTl9E
RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyBPRkYpCiAgICAg
ZW5kaWYgKCkKIGVsc2UgKCkKKyAgICBpZiAoRU5BQkxFX1dFQkdMKQorICAgICAgICBtZXNzYWdl
KEZBVEFMX0VSUk9SICJPcGVuR0wgaXMgbmVlZGVkIGZvciBXZWJHTCBzdXBwb3J0IikKKyAgICBl
bmRpZiAoKQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJH
TCBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FDQ0VM
RVJBVEVEXzJEX0NBTlZBUyBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM
VUUoVVNFX1JFRElSRUNURURfWENPTVBPU0lURV9XSU5ET1cgT0ZGKQpAQCAtMzU0LDEyICszNTcs
MTMgQEAKICAgICBmaW5kX3BhY2thZ2UoRW5jaGFudCBSRVFVSVJFRCkKIGVuZGlmICgpCiAKK2Fk
ZF9kZWZpbml0aW9ucygtRFdURl9VU0VfVEVYVFVSRV9NQVBQRVI9MSkKKwogaWYgKChPUEVOR0xf
Rk9VTkQgT1IgT1BFTkdMRVMyX0ZPVU5EKSBBTkQgKEdMWF9GT1VORCBPUiBFR0xfRk9VTkQpKQog
ICAgIHNldChFTkFCTEVfVEVYVFVSRV9NQVBQRVIgMSkKICAgICBzZXQoV1RGX1VTRV8zRF9HUkFQ
SElDUyAxKQogCiAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV8zRF9HUkFQSElDUz0xKQot
ICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfVEVYVFVSRV9NQVBQRVI9MSkKICAgICBhZGRf
ZGVmaW5pdGlvbnMoLURXVEZfVVNFX1RFWFRVUkVfTUFQUEVSX0dMPTEpCiAgICAgYWRkX2RlZmlu
aXRpb25zKC1ERU5BQkxFXzNEX1JFTkRFUklORz0xKQog
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>252685</attachid>
            <date>2015-05-07 22:27:53 -0700</date>
            <delta_ts>2015-08-27 21:00:38 -0700</delta_ts>
            <desc>Patch for 2.8.0</desc>
            <filename>138332.patch</filename>
            <type>text/plain</type>
            <size>4171</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkNjc3YjMxLi40NjlmY2Mw
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMTUtMDUtMDcgIFBoaWxpcCBDaGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+
CisKKyAgICAgICAgbGlid2Via2l0Mmd0ayBmYWlscyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9j
bWFrZS9PcHRpb25zR1RLLmNtYWtlOiBFcnJvciBvdXQgaWYgV2ViR0wgaXMgZW5hYmxlZAorICAg
ICAgICBidXQgT3BlbkdMIGlzIG5vdCBmb3VuZDsgdXNlIHRleHR1cmUgbWFwcGVyIGluIGFsbCBj
YXNlcy4KKwogMjAxNS0wNC0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp
YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2UgYW5k
IE5FV1MgZm9yIDIuOC4xIHJlbGVhc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFr
ZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGEyODkxZWQu
LmY4Y2UwMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBi
L1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0yOTY5LDggKzI5NjksNiBAQCBpZiAo
V1RGX1VTRV8zRF9HUkFQSElDUykKICAgICBlbmRpZiAoKQogCiAgICAgbGlzdChBUFBFTkQgV2Vi
Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCi0gICAgICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdM
RS8iCi0gICAgICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlL0tIUiIKICAgICAg
ICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL2dwdSIKICAgICApCiAKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZwppbmRleCAyOTJmYWUzLi41YTdiM2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw
MTUtMDUtMDcgIFBoaWxpcCBDaGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisK
KyAgICAgICAgbGlid2Via2l0Mmd0ayBmYWlscyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMu
dHh0OiBSZW1vdmUgdGhpcmQtcGFydHkgQU5HTEUgZGlyZWN0b3JpZXMgZnJvbQorICAgICAgICBj
b25kaXRpb25hbCwgYXMgdGhleSBzaG91bGQgYmUgYWRkZWQgaW4gYWxsIGNhc2VzLgorICAgICAg
ICAqIFBsYXRmb3JtR1RLLmNtYWtlOiBJbmNsdWRlIHRoaXJkLXBhcnR5IEFOR0xFIGRpcmVjdG9y
aWVzIGFuZAorICAgICAgICB0ZXh0dXJlIG1hcHBlciBzb3VyY2UuCisKIDIwMTUtMDQtMTMgIENo
cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uOiBTY3Jv
bGxpbmcgb24gcG9wc2NpLmNvbSBzcGVuZHMgdG9vIG11Y2ggdGltZSBpbiBGcmFtZVZpZXc6OnZp
ZXdwb3J0c0NvbnRlbnRzQ2hhbmdlZCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0
Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDYw
MGRiYTYuLjY5MDEyODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt
YWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0yMiw2ICsyMiw5
IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dFQkNP
UkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRm
b3JtL3RleHQvZ3RrIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS90ZXh0L2ljdSIKKyAg
ICAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRSIKKyAgICAiJHtD
TUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0dMU0xBTkci
CisgICAgIiR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVk
ZS9LSFIiCiApCiAKIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwpAQCAtMjA5LDYgKzIxMiw4
IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVQbGF0Zm9ybUdUS19TT1VSQ0VTCiAgICAgcGxhdGZvcm0v
Z3JhcGhpY3MvZ3RrL0ltYWdlQnVmZmVyR3RrLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2d0
ay9JbWFnZUd0ay5jcHAKIAorICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xh
eWVyVGV4dHVyZU1hcHBlci5jcHAKKwogICAgIHBsYXRmb3JtL2d0ay9Db250ZXh0TWVudUd0ay5j
cHAKICAgICBwbGF0Zm9ybS9ndGsvQ29udGV4dE1lbnVJdGVtR3RrLmNwcAogICAgIHBsYXRmb3Jt
L2d0ay9DdXJzb3JHdGsuY3BwCkBAIC0zNjMsNyArMzY4LDYgQEAgaWYgKEVOQUJMRV9URVhUVVJF
X01BUFBFUikKICAgICAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h
cCIKICAgICApCiAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAgIHBsYXRm
b3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKICAgICAg
ICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKICAgICAgICAg
cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcAog
ICAgICkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNl
L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggNTk5NjY5Zi4uMTEzY2Y4ZiAxMDA2NDQKLS0t
IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlv
bnNHVEsuY21ha2UKQEAgLTExMiw2ICsxMTIsOSBAQCBpZiAoKE9QRU5HTF9GT1VORCBPUiBPUEVO
R0xFUzJfRk9VTkQpIEFORCAoR0xYX0ZPVU5EIE9SIEVHTF9GT1VORCkpCiAgICAgICAgIFdFQktJ
VF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMg
T0ZGKQogICAgIGVuZGlmICgpCiBlbHNlICgpCisgICAgaWYgKEVOQUJMRV9XRUJHTCkKKyAgICAg
ICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiT3BlbkdMIGlzIG5lZWRlZCBmb3IgV2ViR0wgc3VwcG9y
dCIpCisgICAgZW5kaWYgKCkKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF
TkFCTEVfV0VCR0wgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO
QUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGQVVM
VF9QT1JUX1ZBTFVFKFVTRV9SRURJUkVDVEVEX1hDT01QT1NJVEVfV0lORE9XIE9GRikKQEAgLTM0
OCwxMiArMzUxLDEzIEBAIGlmIChFTkFCTEVfU1BFTExDSEVDSykKICAgICBmaW5kX3BhY2thZ2Uo
RW5jaGFudCBSRVFVSVJFRCkKIGVuZGlmICgpCiAKK2FkZF9kZWZpbml0aW9ucygtRFdURl9VU0Vf
VEVYVFVSRV9NQVBQRVI9MSkKKwogaWYgKChPUEVOR0xfRk9VTkQgT1IgT1BFTkdMRVMyX0ZPVU5E
KSBBTkQgKEdMWF9GT1VORCBPUiBFR0xfRk9VTkQpKQogICAgIHNldChFTkFCTEVfVEVYVFVSRV9N
QVBQRVIgMSkKICAgICBzZXQoV1RGX1VTRV8zRF9HUkFQSElDUyAxKQogCiAgICAgYWRkX2RlZmlu
aXRpb25zKC1EV1RGX1VTRV8zRF9HUkFQSElDUz0xKQotICAgIGFkZF9kZWZpbml0aW9ucygtRFdU
Rl9VU0VfVEVYVFVSRV9NQVBQRVI9MSkKICAgICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFX1RF
WFRVUkVfTUFQUEVSX0dMPTEpCiAgICAgYWRkX2RlZmluaXRpb25zKC1ERU5BQkxFXzNEX1JFTkRF
UklORz0xKQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>252818</attachid>
            <date>2015-05-10 11:24:53 -0700</date>
            <delta_ts>2015-05-10 14:50:24 -0700</delta_ts>
            <desc>Patch for master</desc>
            <filename>138332.patch</filename>
            <type>text/plain</type>
            <size>3846</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0Njg1MGNiLi45YjAxNzI3
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTUtMDUtMTAgIFBoaWxpcCBDaGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+
CisKKyAgICAgICAgbGlid2Via2l0Mmd0ayBmYWlscyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9j
bWFrZS9PcHRpb25zR1RLLmNtYWtlOiBVU0UoVEVYVFVSRV9NQVBQRVIpIG11c3QgYmUKKyAgICAg
ICAgZW5hYmxlZCByZWdhcmRsZXNzIG9mIHdoZXRoZXIgT3BlbkdMIGlzLCBiZWNhdXNlIGNlcnRh
aW4gc3ltYm9scworICAgICAgICBzdWNoIGFzIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6OmNyZWF0
ZSgpIG5lZWQgdG8gYmUgYnVpbHQuCisKIDIwMTUtMDUtMDkgIFlvYXYgV2Vpc3MgIDx5b2F2QHlv
YXYud3M+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBQSUNUVVJFX1NJWkVTIGJ1aWxkIGZsYWcKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUv
Q01ha2VMaXN0cy50eHQKaW5kZXggNjU0NTEyZi4uNWUyMWM3YiAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50
eHQKQEAgLTMxMTQsNiArMzExNCwxMSBAQCBpZiAoRU5BQkxFX0dSQVBISUNTX0NPTlRFWFRfM0Qp
CiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAogICAgICAg
ICBwbGF0Zm9ybS9ncmFwaGljcy9Gb3JtYXRDb252ZXJ0ZXIuY3BwCiAgICAgKQorZWxzZSAoKQor
ICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUworICAgICAgICAiJHtU
SElSRFBBUlRZX0RJUn0vQU5HTEUvIgorICAgICAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUv
aW5jbHVkZS9LSFIiCisgICAgKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9XRUJfUkVQTEFZKQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh
bmdlTG9nCmluZGV4IDhiOTc0ZTEuLjBkZTE1ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBA
QAorMjAxNS0wNS0xMCAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNv
bT4KKworICAgICAgICBsaWJ3ZWJraXQyZ3RrIGZhaWxzIHRvIGxpbmsgd2l0aG91dCBvcGVuZ2wK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzMgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VM
aXN0cy50eHQ6IFRoZSB0aGlyZC1wYXJ0eSBBTkdMRSBkaXJlY3RvcmllcyBuZWVkIHRvIGJlCisg
ICAgICAgIGluY2x1ZGVkIGV2ZW4gaWYgRU5BQkxFKEdSQVBISUNTX0NPTlRFWFRfM0QpIGlzIGZh
bHNlLiBIb3dldmVyLAorICAgICAgICB3ZSBpbmNsdWRlIHRoZW0gaW4gYW4gZWxzZSBjbGF1c2Ug
YmVjYXVzZSBmb3IgdGhlCisgICAgICAgIEVOQUJMRShHUkFQSElDU19DT05URVhUXzNEKSBjYXNl
LCB0aGV5IG5lZWQgdG8gYmUgaW5jbHVkZWQgaW4gYQorICAgICAgICBjZXJ0YWluIG9yZGVyLgor
ICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOiBXZSBuZWVkIHRoZSBHTFNMQU5HIGluY2x1ZGUg
ZGlyZWN0b3J5LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0
dXJlUG9vbC5jcHA6IFJlbW92ZQorICAgICAgICByZWZlcmVuY2UgdG8gbm8gbG9uZ2VyIGV4aXN0
ZW50IGhlYWRlciBmaWxlLgorCiAyMDE1LTA1LTEwICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFj
aEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IERvbid0IGV4cG9zZSBlbGVtZW50cyBhcyBkYXRh
IHRhYmxlcyBqdXN0IGJlY2F1c2UgdGhleSB1c2UgZGlzcGxheTogdGFibGUKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZv
cm1HVEsuY21ha2UKaW5kZXggYjVkMDliNy4uYjVkMDYyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsu
Y21ha2UKQEAgLTI0LDYgKzI0LDcgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVD
VE9SSUVTCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvZ3RrIgogICAgICIk
e1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9
L3BsYXRmb3JtL3RleHQvZ3RrIgorICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRl
L0dMU0xBTkciCiApCiAKIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVQb29s
LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0
dXJlUG9vbC5jcHAKaW5kZXggZWRiNGNjZi4uNjdiOTFmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVQb29sLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBv
b2wuY3BwCkBAIC0zMCw4ICszMCw2IEBACiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQogI2lu
Y2x1ZGUgIkJpdG1hcFRleHR1cmVHTC5oIgogI2luY2x1ZGUgIkdMQ29udGV4dC5oIgotI2Vsc2UK
LSNpbmNsdWRlICJCaXRtYXBUZXh0dXJlSW1hZ2VCdWZmZXIuaCIKICNlbmRpZgogCiBuYW1lc3Bh
Y2UgV2ViQ29yZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBi
L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDRkMGU5ZDguLmMyZDk5NTkgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr
ZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yNzcsNiArMjc3LDggQEAgaWYgKEVOQUJMRV9NRURJQV9T
VFJFQU0pCiAgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX09QRU5XRUJSVEMgVFJVRSkK
IGVuZGlmICgpCiAKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9URVhUVVJFX01BUFBFUiBU
UlVFKQorCiBpZiAoRU5BQkxFX09QRU5HTCkKICAgICAjIEVOQUJMRV9PUEVOR0wgaXMgdHJ1ZSBp
ZiBlaXRoZXIgVVNFX09QRU5HTCBvciBFTkFCTEVfR0xFUzIgaXMgdHJ1ZS4KICAgICAjIEJ1dCBV
U0VfT1BFTkdMIGlzIHRoZSBvcHBvc2l0ZSBvZiBFTkFCTEVfR0xFUzIuCkBAIC0zMDAsNyArMzAy
LDYgQEAgaWYgKEVOQUJMRV9PUEVOR0wpCiAKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChF
TkFCTEVfR1JBUEhJQ1NfQ09OVEVYVF8zRCBUUlVFKQogCi0gICAgU0VUX0FORF9FWFBPU0VfVE9f
QlVJTEQoVVNFX1RFWFRVUkVfTUFQUEVSIFRSVUUpCiAgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJ
TEQoVVNFX1RFWFRVUkVfTUFQUEVSX0dMIFRSVUUpCiAKICAgICBTRVRfQU5EX0VYUE9TRV9UT19C
VUlMRChVU0VfRUdMICR7RUdMX0ZPVU5EfSkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>252826</attachid>
            <date>2015-05-10 14:50:03 -0700</date>
            <delta_ts>2015-05-14 08:56:33 -0700</delta_ts>
            <desc>Patch for master</desc>
            <filename>bug-138332-20150510144843.patch</filename>
            <type>text/plain</type>
            <size>3863</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGI5NzRlMTk3MWYyNWFi
MTI1OWYyOGFiYWE5NmQ3MjgwOTZiZmFhMS4uM2U1ZTk5Njc0MmRhZjI4ZmI3MDU0MWIzN2U4YWQz
YTA4YzY5ZTkxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTEwICBQaGls
aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIGxpYndl
YmtpdDJndGsgZmFpbHMgdG8gbGluayB3aXRob3V0IG9wZW5nbAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzMyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogVGhlIHRoaXJk
LXBhcnR5IEFOR0xFIGRpcmVjdG9yaWVzIG5lZWQgdG8gYmUKKyAgICAgICAgaW5jbHVkZWQgZXZl
biBpZiBFTkFCTEUoR1JBUEhJQ1NfQ09OVEVYVF8zRCkgaXMgZmFsc2UuIFRoZXkgbXVzdAorICAg
ICAgICBiZSBpbmNsdWRlZCBhZnRlciB0aGUgT3BlbkdMIGhlYWRlcnMgYXMgdGhlIGNvbW1lbnQg
c2F5cy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBv
b2wuY3BwOiBSZW1vdmUKKyAgICAgICAgcmVmZXJlbmNlIHRvIG5vIGxvbmdlciBleGlzdGVudCBo
ZWFkZXIgZmlsZS4KKwogMjAxNS0wNS0xMCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBw
bGUuY29tPgogCiAgICAgICAgIEFYOiBEb24ndCBleHBvc2UgZWxlbWVudHMgYXMgZGF0YSB0YWJs
ZXMganVzdCBiZWNhdXNlIHRoZXkgdXNlIGRpc3BsYXk6IHRhYmxlCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0
CmluZGV4IDY1NDUxMmYyODY4MzAwMjIwMjU5MzMzNDVhYmYzYTliNmM3YmNiYWIuLjUwODViNzA1
MjMxZjJhOGY0NTI3NzEwOWU4M2RlMDBlNzgyYjkzYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBA
IC0zMDE1LDggKzMwMTUsNiBAQCBpZiAoRU5BQkxFX0dSQVBISUNTX0NPTlRFWFRfM0QpCiAgICAg
ZW5kaWYgKCkKIAogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwot
ICAgICAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvIgotICAgICAgICAiJHtUSElSRFBBUlRZ
X0RJUn0vQU5HTEUvaW5jbHVkZS9LSFIiCiAgICAgICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9y
bS9ncmFwaGljcy9ncHUiCiAgICAgKQogCkBAIC0zMTE2LDYgKzMxMTQsMTIgQEAgaWYgKEVOQUJM
RV9HUkFQSElDU19DT05URVhUXzNEKQogICAgICkKIGVuZGlmICgpCiAKK2xpc3QoQVBQRU5EIFdl
YkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUworICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS8i
CisgICAgIiR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvS0hSIgorICAgICIke1RISVJE
UEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlL0dMU0xBTkciCispCisKIGlmIChFTkFCTEVfV0VCX1JF
UExBWSkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAg
ICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9pbnNwZWN0b3IiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBvb2wuY3BwIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVQb29s
LmNwcAppbmRleCBlZGI0Y2NmZTFmMTAzYTMyYmRhYjkzMzkwODg5OTdmODJjODk3NzQ5Li42N2I5
MWYwNjM1MGQ3NjU0MWRjMTRhMDJhNmQ1NjM2NWI2ZTM1ODdmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBvb2wuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJl
UG9vbC5jcHAKQEAgLTMwLDggKzMwLDYgQEAKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wpCiAj
aW5jbHVkZSAiQml0bWFwVGV4dHVyZUdMLmgiCiAjaW5jbHVkZSAiR0xDb250ZXh0LmgiCi0jZWxz
ZQotI2luY2x1ZGUgIkJpdG1hcFRleHR1cmVJbWFnZUJ1ZmZlci5oIgogI2VuZGlmCiAKIG5hbWVz
cGFjZSBXZWJDb3JlIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl
IGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggNGQwZTlkODMxZDdjZWE5OWNl
MTVlY2NjNmM1YTU4ZDk1NmI0MjA2My4uYzJkOTk1OTA2NjQ0Mzc5N2Y1NWJhYTRjOTQ4ZGE1Yjk4
NTg5MDg1MyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIv
U291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKQEAgLTI3Nyw2ICsyNzcsOCBAQCBpZiAoRU5B
QkxFX01FRElBX1NUUkVBTSkKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfT1BFTldF
QlJUQyBUUlVFKQogZW5kaWYgKCkKIAorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1RFWFRV
UkVfTUFQUEVSIFRSVUUpCisKIGlmIChFTkFCTEVfT1BFTkdMKQogICAgICMgRU5BQkxFX09QRU5H
TCBpcyB0cnVlIGlmIGVpdGhlciBVU0VfT1BFTkdMIG9yIEVOQUJMRV9HTEVTMiBpcyB0cnVlLgog
ICAgICMgQnV0IFVTRV9PUEVOR0wgaXMgdGhlIG9wcG9zaXRlIG9mIEVOQUJMRV9HTEVTMi4KQEAg
LTMwMCw3ICszMDIsNiBAQCBpZiAoRU5BQkxFX09QRU5HTCkKIAogICAgIFNFVF9BTkRfRVhQT1NF
X1RPX0JVSUxEKEVOQUJMRV9HUkFQSElDU19DT05URVhUXzNEIFRSVUUpCiAKLSAgICBTRVRfQU5E
X0VYUE9TRV9UT19CVUlMRChVU0VfVEVYVFVSRV9NQVBQRVIgVFJVRSkKICAgICBTRVRfQU5EX0VY
UE9TRV9UT19CVUlMRChVU0VfVEVYVFVSRV9NQVBQRVJfR0wgVFJVRSkKIAogICAgIFNFVF9BTkRf
RVhQT1NFX1RPX0JVSUxEKFVTRV9FR0wgJHtFR0xfRk9VTkR9KQpkaWZmIC0tZ2l0IGEvQ2hhbmdl
TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDQ2ODUwY2JlMzhjN2Y1NDg3ZGNlYzRlN2IyZjVmZDAxYjYy
YzM0NDYuLjliMDE3MjdmMjNlNTM5YTViYTAwNDMwNTIwMmM0M2UzMzMwMDlhNGMgMTAwNjQ0Ci0t
LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNS0wNS0x
MCAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4KKworICAgICAg
ICBsaWJ3ZWJraXQyZ3RrIGZhaWxzIHRvIGxpbmsgd2l0aG91dCBvcGVuZ2wKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzMgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv
bnNHVEsuY21ha2U6IFVTRShURVhUVVJFX01BUFBFUikgbXVzdCBiZQorICAgICAgICBlbmFibGVk
IHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciBPcGVuR0wgaXMsIGJlY2F1c2UgY2VydGFpbiBzeW1ib2xz
CisgICAgICAgIHN1Y2ggYXMgV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6Y3JlYXRlKCkgbmVlZCB0
byBiZSBidWlsdC4KKwogMjAxNS0wNS0wOSAgWW9hdiBXZWlzcyAgPHlvYXZAeW9hdi53cz4KIAog
ICAgICAgICBSZW1vdmUgdGhlIFBJQ1RVUkVfU0laRVMgYnVpbGQgZmxhZwo=
</data>
<flag name="review"
          id="277673"
          type_id="1"
          status="+"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>253122</attachid>
            <date>2015-05-14 08:56:33 -0700</date>
            <delta_ts>2015-06-20 12:04:41 -0700</delta_ts>
            <desc>Updated patch for master</desc>
            <filename>138332.patch</filename>
            <type>text/plain</type>
            <size>2933</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAKKysrIGEvU291cmNlL1dlYkNvcmUvQ2hh
bmdlTG9nICAKQEAgLTEsMyArMSwxNiBAQCAKKzIwMTUtMDUtMTAgIFBoaWxpcCBDaGltZW50byAg
PHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisKKyAgICAgICAgbGlid2Via2l0Mmd0ayBmYWls
cyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBUaGUgdGhpcmQtcGFydHkgQU5HTEUg
ZGlyZWN0b3JpZXMgbmVlZCB0byBiZQorICAgICAgICBpbmNsdWRlZCBldmVuIGlmIEVOQUJMRShH
UkFQSElDU19DT05URVhUXzNEKSBpcyBmYWxzZS4gVGhleSBtdXN0CisgICAgICAgIGJlIGluY2x1
ZGVkIGFmdGVyIHRoZSBPcGVuR0wgaGVhZGVycyBhcyB0aGUgY29tbWVudCBzYXlzLgorICAgICAg
ICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJlUG9vbC5jcHA6IFJlbW92
ZQorICAgICAgICByZWZlcmVuY2UgdG8gbm8gbG9uZ2VyIGV4aXN0ZW50IGhlYWRlciBmaWxlLgor
CiAyMDE1LTA1LTEwICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAg
ICAgICAgQVg6IERvbid0IGV4cG9zZSBlbGVtZW50cyBhcyBkYXRhIHRhYmxlcyBqdXN0IGJlY2F1
c2UgdGhleSB1c2UgZGlzcGxheTogdGFibGUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0
cy50eHQgCisrKyBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IApAQCAtMzAxNSw4ICsz
MDE1LDYgQEAgaWYgKEVOQUJMRV9HUkFQSElDU19DT05URVhUXzNEKQogICAgIGVuZGlmICgpCiAK
ICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKLSAgICAgICAgIiR7
VEhJUkRQQVJUWV9ESVJ9L0FOR0xFLyIKLSAgICAgICAgIiR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xF
L2luY2x1ZGUvS0hSIgogICAgICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3Mv
Z3B1IgogICAgICkKIApAQCAtMzExNiw2ICszMTE0LDExIEBAIGlmIChFTkFCTEVfR1JBUEhJQ1Nf
Q09OVEVYVF8zRCkKICAgICApCiBlbmRpZiAoKQogCitsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xV
REVfRElSRUNUT1JJRVMKKyAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvIgorICAgICIke1RI
SVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlL0tIUiIKKykKKwogaWYgKEVOQUJMRV9XRUJfUkVQ
TEFZKQogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICAg
ICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2luc3BlY3RvciIKLS0tIGEvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVQb29sLmNwcCAKKysrIGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVQb29sLmNw
cCAKQEAgLTMwLDggKzMwLDYgQEAgCiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQogI2luY2x1
ZGUgIkJpdG1hcFRleHR1cmVHTC5oIgogI2luY2x1ZGUgIkdMQ29udGV4dC5oIgotI2Vsc2UKLSNp
bmNsdWRlICJCaXRtYXBUZXh0dXJlSW1hZ2VCdWZmZXIuaCIKICNlbmRpZgogCiBuYW1lc3BhY2Ug
V2ViQ29yZSB7Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIAorKysgYS9Tb3Vy
Y2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSAKQEAgLTI3Nyw2ICsyNzcsOCBAQCBpZiAoRU5BQkxF
X01FRElBX1NUUkVBTSkKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfT1BFTldFQlJU
QyBUUlVFKQogZW5kaWYgKCkKIAorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1RFWFRVUkVf
TUFQUEVSIFRSVUUpCisKIGlmIChFTkFCTEVfT1BFTkdMKQogICAgICMgRU5BQkxFX09QRU5HTCBp
cyB0cnVlIGlmIGVpdGhlciBVU0VfT1BFTkdMIG9yIEVOQUJMRV9HTEVTMiBpcyB0cnVlLgogICAg
ICMgQnV0IFVTRV9PUEVOR0wgaXMgdGhlIG9wcG9zaXRlIG9mIEVOQUJMRV9HTEVTMi4KQEAgLTMw
MCw3ICszMDIsNiBAQCBpZiAoRU5BQkxFX09QRU5HTCkKIAogICAgIFNFVF9BTkRfRVhQT1NFX1RP
X0JVSUxEKEVOQUJMRV9HUkFQSElDU19DT05URVhUXzNEIFRSVUUpCiAKLSAgICBTRVRfQU5EX0VY
UE9TRV9UT19CVUlMRChVU0VfVEVYVFVSRV9NQVBQRVIgVFJVRSkKICAgICBTRVRfQU5EX0VYUE9T
RV9UT19CVUlMRChVU0VfVEVYVFVSRV9NQVBQRVJfR0wgVFJVRSkKIAogICAgIFNFVF9BTkRfRVhQ
T1NFX1RPX0JVSUxEKFVTRV9FR0wgJHtFR0xfRk9VTkR9KQotLS0gYS9DaGFuZ2VMb2cgCisrKyBh
L0NoYW5nZUxvZyAKQEAgLTEsMyArMSwxNCBAQCAKKzIwMTUtMDUtMTAgIFBoaWxpcCBDaGltZW50
byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisKKyAgICAgICAgbGlid2Via2l0Mmd0ayBm
YWlscyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBVU0Uo
VEVYVFVSRV9NQVBQRVIpIG11c3QgYmUKKyAgICAgICAgZW5hYmxlZCByZWdhcmRsZXNzIG9mIHdo
ZXRoZXIgT3BlbkdMIGlzLCBiZWNhdXNlIGNlcnRhaW4gc3ltYm9scworICAgICAgICBzdWNoIGFz
IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI6OmNyZWF0ZSgpIG5lZWQgdG8gYmUgYnVpbHQuCisKIDIw
MTUtMDUtMDkgIFlvYXYgV2Vpc3MgIDx5b2F2QHlvYXYud3M+CiAKICAgICAgICAgUmVtb3ZlIHRo
ZSBQSUNUVVJFX1NJWkVTIGJ1aWxkIGZsYWc=
</data>
<flag name="review"
          id="277980"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
    <flag name="commit-queue"
          id="277981"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>255294</attachid>
            <date>2015-06-20 12:04:14 -0700</date>
            <delta_ts>2015-06-21 03:07:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138332-20150620120334.patch</filename>
            <type>text/plain</type>
            <size>3846</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA3MDY1YzBiZGY0YTcy
MTEwMzY3MWZlZjhlNWI3OGQ1OTZkM2MyNC4uZTY2MWFhNGRiYjk2NWJkY2M1M2EwNGJlYTUxMzgy
NjE3YWJhNjQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTEwICBQaGls
aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIGxpYndl
YmtpdDJndGsgZmFpbHMgdG8gbGluayB3aXRob3V0IG9wZW5nbAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzMyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogVGhlIHRoaXJk
LXBhcnR5IEFOR0xFIGRpcmVjdG9yaWVzIG5lZWQgdG8gYmUKKyAgICAgICAgaW5jbHVkZWQgZXZl
biBpZiBFTkFCTEUoR1JBUEhJQ1NfQ09OVEVYVF8zRCkgaXMgZmFsc2UuIFRoZXkgbXVzdAorICAg
ICAgICBiZSBpbmNsdWRlZCBhZnRlciB0aGUgT3BlbkdMIGhlYWRlcnMgYXMgdGhlIGNvbW1lbnQg
c2F5cy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBv
b2wuY3BwOiBSZW1vdmUKKyAgICAgICAgcmVmZXJlbmNlIHRvIG5vIGxvbmdlciBleGlzdGVudCBo
ZWFkZXIgZmlsZS4KKwogMjAxNS0wNi0xOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJv
QGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IGFic29sdXRlIHZhbHVlIHdhcm5pbmcgaW4gTG9j
YWxpemVkU3RyaW5nc0d0ay5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlz
dHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggZDY3ZmVhZGI5MDdi
ZTc1ZDU1ZDIwMzEzYzJkMTk1ODVlY2QxYTI5ZC4uYTVjZGI2OGQyZmE2ZGMyYzA4YmRkYmVkZjFh
ODk4MWRlN2U3OTYyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQK
KysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTMwNDcsOCArMzA0Nyw2IEBA
IGlmIChFTkFCTEVfR1JBUEhJQ1NfQ09OVEVYVF8zRCkKICAgICBlbmRpZiAoKQogCiAgICAgbGlz
dChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCi0gICAgICAgICIke1RISVJEUEFS
VFlfRElSfS9BTkdMRS8iCi0gICAgICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRl
L0tIUiIKICAgICAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL2dwdSIKICAg
ICApCiAKQEAgLTMxNDgsNiArMzE0NiwxMSBAQCBpZiAoRU5BQkxFX0dSQVBISUNTX0NPTlRFWFRf
M0QpCiAgICAgKQogZW5kaWYgKCkKIAorbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVD
VE9SSUVTCisgICAgIiR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFLyIKKyAgICAiJHtUSElSRFBBUlRZ
X0RJUn0vQU5HTEUvaW5jbHVkZS9LSFIiCispCisKIGlmIChFTkFCTEVfV0VCX1JFUExBWSkKICAg
ICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAgICAgIiR7SkFW
QVNDUklQVENPUkVfRElSfS9pbnNwZWN0b3IiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBvb2wuY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRleHR1cmVQb29sLmNwcAppbmRl
eCBlZGI0Y2NmZTFmMTAzYTMyYmRhYjkzMzkwODg5OTdmODJjODk3NzQ5Li42N2I5MWYwNjM1MGQ3
NjU0MWRjMTRhMDJhNmQ1NjM2NWI2ZTM1ODdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVyZVBvb2wuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRtYXBUZXh0dXJlUG9vbC5jcHAK
QEAgLTMwLDggKzMwLDYgQEAKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wpCiAjaW5jbHVkZSAi
Qml0bWFwVGV4dHVyZUdMLmgiCiAjaW5jbHVkZSAiR0xDb250ZXh0LmgiCi0jZWxzZQotI2luY2x1
ZGUgIkJpdG1hcFRleHR1cmVJbWFnZUJ1ZmZlci5oIgogI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJD
b3JlIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNl
L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggNTVhZTI0MzdlY2NkMmFlYTcxNjlkY2ZlZjQ4
ZGRkMGJiZWJkNDg1Yi4uZjZjOGYwNjIzZTBjODQ4YWQ0NmRkMzg4NjNlNTJjM2M1ODhmN2VhMSAx
MDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2Nt
YWtlL09wdGlvbnNHVEsuY21ha2UKQEAgLTI5NSw2ICsyOTUsOCBAQCBpZiAoRU5BQkxFX01FRElB
X1NUUkVBTSkKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfT1BFTldFQlJUQyBUUlVF
KQogZW5kaWYgKCkKIAorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1RFWFRVUkVfTUFQUEVS
IFRSVUUpCisKIGlmIChFTkFCTEVfT1BFTkdMKQogICAgICMgRU5BQkxFX09QRU5HTCBpcyB0cnVl
IGlmIGVpdGhlciBVU0VfT1BFTkdMIG9yIEVOQUJMRV9HTEVTMiBpcyB0cnVlLgogICAgICMgQnV0
IFVTRV9PUEVOR0wgaXMgdGhlIG9wcG9zaXRlIG9mIEVOQUJMRV9HTEVTMi4KQEAgLTMxOCw3ICsz
MjAsNiBAQCBpZiAoRU5BQkxFX09QRU5HTCkKIAogICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxE
KEVOQUJMRV9HUkFQSElDU19DT05URVhUXzNEIFRSVUUpCiAKLSAgICBTRVRfQU5EX0VYUE9TRV9U
T19CVUlMRChVU0VfVEVYVFVSRV9NQVBQRVIgVFJVRSkKICAgICBTRVRfQU5EX0VYUE9TRV9UT19C
VUlMRChVU0VfVEVYVFVSRV9NQVBQRVJfR0wgVFJVRSkKIAogICAgIFNFVF9BTkRfRVhQT1NFX1RP
X0JVSUxEKFVTRV9FR0wgJHtFR0xfRk9VTkR9KQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh
bmdlTG9nCmluZGV4IDIxMjU0MThiZDc0ZjU0ZTdhYjFlNjA0N2NmOTY3ZDgxZjM1ODQxOTcuLjdi
MjEyYzcyZjU5ZWI5OTNlMzIxMWI0MmU3ZDlhN2NkYWYxY2Y5MTkgMTAwNjQ0Ci0tLSBhL0NoYW5n
ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNS0wNS0xMCAgUGhpbGlw
IENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4KKworICAgICAgICBsaWJ3ZWJr
aXQyZ3RrIGZhaWxzIHRvIGxpbmsgd2l0aG91dCBvcGVuZ2wKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzMgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h
a2U6IFVTRShURVhUVVJFX01BUFBFUikgbXVzdCBiZQorICAgICAgICBlbmFibGVkIHJlZ2FyZGxl
c3Mgb2Ygd2hldGhlciBPcGVuR0wgaXMsIGJlY2F1c2UgY2VydGFpbiBzeW1ib2xzCisgICAgICAg
IHN1Y2ggYXMgV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6Y3JlYXRlKCkgbmVlZCB0byBiZSBidWls
dC4KKwogMjAxNS0wNi0xOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5j
b20+CiAKICAgICAgICAgW0NNYWtlXSBGaW5kR1RLMy5jbWFrZSBzaG91bGQgbm90IG1vZGlmeSB0
aGUgdmFsdWVzIG9mIGJ1aWxkIG9wdGlvbnMK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>260116</attachid>
            <date>2015-08-27 20:59:38 -0700</date>
            <delta_ts>2015-09-04 20:36:41 -0700</delta_ts>
            <desc>Patch for 2.8.5</desc>
            <filename>bug-138332-20150827205925.patch</filename>
            <type>text/plain</type>
            <size>4387</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNmMGIyNjYzZWJlMzAx
N2RmN2FjNWQxMDJhNmYxZGY3Mzg2ZGFmZS4uOWYzMTJkZGJkMTMyMDg1NzFmOWJkMTBlODI3Nzdj
MzIxOGNhOGUwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTI3ICBQaGls
aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIGxpYndl
YmtpdDJndGsgZmFpbHMgdG8gbGluayB3aXRob3V0IG9wZW5nbAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzMyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlIHRo
aXJkLXBhcnR5IEFOR0xFIGRpcmVjdG9yaWVzIGZyb20KKyAgICAgICAgY29uZGl0aW9uYWwsIGFz
IHRoZXkgc2hvdWxkIGJlIGFkZGVkIGluIGFsbCBjYXNlcy4KKyAgICAgICAgKiBQbGF0Zm9ybUdU
Sy5jbWFrZTogSW5jbHVkZSB0aGlyZC1wYXJ0eSBBTkdMRSBkaXJlY3RvcmllcyBhbmQKKyAgICAg
ICAgdGV4dHVyZSBtYXBwZXIgc291cmNlLgorCiAyMDE1LTA4LTA2ICBDYXJsb3MgR2FyY2lhIENh
bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggdGhl
IGJ1aWxkIHdpdGggUkVTT1VSQ0VfVElNSU5HIGRpc2FibGVkLgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApp
bmRleCBmOGFiOGE0YTE1OWI0ZWE4NGQxZGViODc3Y2FmNDI3NDIzMTUxNjI3Li42MTU1MmYzMGI3
MjJkZjdjNWVkNmUyNGZmMDQ5MGViMmIyYjljYWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAt
Mjk4MSw4ICsyOTgxLDYgQEAgaWYgKFdURl9VU0VfM0RfR1JBUEhJQ1MpCiAgICAgZW5kaWYgKCkK
IAogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwotICAgICAgICAi
JHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvIgotICAgICAgICAiJHtUSElSRFBBUlRZX0RJUn0vQU5H
TEUvaW5jbHVkZS9LSFIiCiAgICAgICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9ncmFwaGlj
cy9ncHUiCiAgICAgKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5j
bWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDI1MGY2Nzc1YTY5
N2U4YmY0MDAxZGYwYmI3NTFhZTRjMjE2MzBhNTcuLjI2MDU5OThjMWI0NWU5NWQ2MTcyNWVhOGMz
OWI2NThkMDRhZWY4YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt
YWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0yMiw2ICsyMiw4
IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dFQkNP
UkVfRElSfS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRm
b3JtL3RleHQvZ3RrIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS90ZXh0L2ljdSIKKyAg
ICAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRSIKKyAgICAiJHtD
TUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0tIUiIKICkK
IAogbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCkBAIC0xMjEsNiArMTIzLDggQEAgbGlzdChB
UFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVudHlwZS9P
cGVuVHlwZVZlcnRpY2FsRGF0YS5jcHAKIAorICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9H
cmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKKwogICAgIHBsYXRmb3JtL2d0ay9FcnJvcnNH
dGsuY3BwCiAgICAgcGxhdGZvcm0vZ3RrL0V2ZW50TG9vcEd0ay5jcHAKICAgICBwbGF0Zm9ybS9n
dGsvRmlsZVN5c3RlbUd0ay5jcHAKQEAgLTM2Myw3ICszNjcsNiBAQCBpZiAoRU5BQkxFX1RFWFRV
UkVfTUFQUEVSKQogICAgICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4
bWFwIgogICAgICkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAgICAgICAgcGxh
dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAogICAg
ICAgICBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAogICAgICAg
ICBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3Bw
CiAgICAgKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3Vy
Y2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCAwNWEyMzYxMDFkNDM1ZjdkMDJkMmM2OTJm
NmVhNzc5MDkyNjU2N2I5Li5lMWFkOTc4N2IwNDIwMzhjZDhmNjQyNWI4YzI3OGQwNzNmNmEyMGZm
IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2Uv
Y21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtMTEyLDYgKzExMiw5IEBAIGlmICgoT1BFTkdMX0ZP
VU5EIE9SIE9QRU5HTEVTMl9GT1VORCkgQU5EIChHTFhfRk9VTkQgT1IgRUdMX0ZPVU5EKSkKICAg
ICAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FDQ0VMRVJBVEVE
XzJEX0NBTlZBUyBPRkYpCiAgICAgZW5kaWYgKCkKIGVsc2UgKCkKKyAgICBpZiAoRU5BQkxFX1dF
QkdMKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJPcGVuR0wgaXMgbmVlZGVkIGZvciBX
ZWJHTCBzdXBwb3J0IikKKyAgICBlbmRpZiAoKQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q
T1JUX1ZBTFVFKEVOQUJMRV9XRUJHTCBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP
UlRfVkFMVUUoRU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyBPRkYpCiAgICAgV0VCS0lUX09Q
VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoVVNFX1JFRElSRUNURURfWENPTVBPU0lURV9XSU5ET1cg
T0ZGKQpAQCAtMzQ4LDEyICszNTEsMTMgQEAgaWYgKEVOQUJMRV9TUEVMTENIRUNLKQogICAgIGZp
bmRfcGFja2FnZShFbmNoYW50IFJFUVVJUkVEKQogZW5kaWYgKCkKIAorYWRkX2RlZmluaXRpb25z
KC1EV1RGX1VTRV9URVhUVVJFX01BUFBFUj0xKQorCiBpZiAoKE9QRU5HTF9GT1VORCBPUiBPUEVO
R0xFUzJfRk9VTkQpIEFORCAoR0xYX0ZPVU5EIE9SIEVHTF9GT1VORCkpCiAgICAgc2V0KEVOQUJM
RV9URVhUVVJFX01BUFBFUiAxKQogICAgIHNldChXVEZfVVNFXzNEX0dSQVBISUNTIDEpCiAKICAg
ICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFXzNEX0dSQVBISUNTPTEpCi0gICAgYWRkX2RlZmlu
aXRpb25zKC1EV1RGX1VTRV9URVhUVVJFX01BUFBFUj0xKQogICAgIGFkZF9kZWZpbml0aW9ucygt
RFdURl9VU0VfVEVYVFVSRV9NQVBQRVJfR0w9MSkKICAgICBhZGRfZGVmaW5pdGlvbnMoLURFTkFC
TEVfM0RfUkVOREVSSU5HPTEpCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwpp
bmRleCA3NjE4MjVkYzI4NjQxODUyMGY2NWE3MTU1NTk2YmVkZjdhODE3NDI2Li4zYjhjYjllZWE5
MDc2MDdjMDU1NjMxODI5NzU0NDQ4ZWU1ZWFlMTRkIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysr
IGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDgtMjcgIFBoaWxpcCBDaGltZW50
byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisKKyAgICAgICAgbGlid2Via2l0Mmd0ayBm
YWlscyB0byBsaW5rIHdpdGhvdXQgb3BlbmdsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBFcnJv
ciBvdXQgaWYgV2ViR0wgaXMgZW5hYmxlZAorICAgICAgICBidXQgT3BlbkdMIGlzIG5vdCBmb3Vu
ZDsgdXNlIHRleHR1cmUgbWFwcGVyIGluIGFsbCBjYXNlcy4KKwogMjAxNS0wOC0wNiAgQ2FybG9z
IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl
ZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2UgYW5kIE5FV1MgZm9yIDIuOC41IHJlbGVhc2UuCg==
</data>
<flag name="review"
          id="285307"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>260670</attachid>
            <date>2015-09-04 20:36:41 -0700</date>
            <delta_ts>2015-09-14 11:02:43 -0700</delta_ts>
            <desc>Patch for 2.8 branch</desc>
            <filename>138332.patch</filename>
            <type>text/plain</type>
            <size>3783</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNmMGIyNjYzZWJlMzAx
N2RmN2FjNWQxMDJhNmYxZGY3Mzg2ZGFmZS4uOWYzMTJkZGJkMTMyMDg1NzFmOWJkMTBlODI3Nzdj
MzIxOGNhOGUwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTI3ICBQaGls
aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIGxpYndl
YmtpdDJndGsgZmFpbHMgdG8gbGluayB3aXRob3V0IG9wZW5nbAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzMyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogSW5jbHVk
ZSB0aGlyZC1wYXJ0eSBBTkdMRSBkaXJlY3RvcmllcyBhbmQKKyAgICAgICAgdGV4dHVyZSBtYXBw
ZXIgc291cmNlIHVuY29uZGl0aW9uYWxseS4KKwogMjAxNS0wOC0wNiAgQ2FybG9zIEdhcmNpYSBD
YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IHRo
ZSBidWlsZCB3aXRoIFJFU09VUkNFX1RJTUlORyBkaXNhYmxlZC4KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsu
Y21ha2UKaW5kZXggMjUwZjY3NzVhNjk3ZThiZjQwMDFkZjBiYjc1MWFlNGMyMTYzMGE1Ny4uMjYw
NTk5OGMxYjQ1ZTk1ZDYxNzI1ZWE4YzM5YjY1OGQwNGFlZjhjOSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1H
VEsuY21ha2UKQEAgLTIyLDYgKzIyLDggQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJ
UkVDVE9SSUVTCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvc291cCIKICAg
ICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vdGV4dC9ndGsiCiAgICAgIiR7V0VCQ09SRV9ESVJ9
L3BsYXRmb3JtL3RleHQvaWN1IgorICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9UaGly
ZFBhcnR5L0FOR0xFIgorICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9UaGlyZFBhcnR5
L0FOR0xFL2luY2x1ZGUvS0hSIgogKQogCiBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKQEAg
LTEyMSw2ICsxMjMsOCBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKIAogICAgIHBsYXRm
b3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlVmVydGljYWxEYXRhLmNwcAogCisgICAgcGxh
dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAorCiAg
ICAgcGxhdGZvcm0vZ3RrL0Vycm9yc0d0ay5jcHAKICAgICBwbGF0Zm9ybS9ndGsvRXZlbnRMb29w
R3RrLmNwcAogICAgIHBsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcApAQCAtMzYzLDcgKzM2
Nyw2IEBAIGlmIChFTkFCTEVfVEVYVFVSRV9NQVBQRVIpCiAgICAgICAgICIke1dFQkNPUkVfRElS
fS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAiCiAgICAgKQogICAgIGxpc3QoQVBQRU5EIFdlYkNv
cmVfU09VUkNFUwotICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXll
clRleHR1cmVNYXBwZXIuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0
dXJlTWFwcGVyR0wuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl
TWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAKICAgICApCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2Uv
T3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDA1
YTIzNjEwMWQ0MzVmN2QwMmQyYzY5MmY2ZWE3NzkwOTI2NTY3YjkuLmUxYWQ5Nzg3YjA0MjAzOGNk
OGY2NDI1YjhjMjc4ZDA3M2Y2YTIwZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25z
R1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMTIsNiAr
MTEyLDkgQEAgaWYgKChPUEVOR0xfRk9VTkQgT1IgT1BFTkdMRVMyX0ZPVU5EKSBBTkQgKEdMWF9G
T1VORCBPUiBFR0xfRk9VTkQpKQogICAgICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W
QUxVRShFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIE9GRikKICAgICBlbmRpZiAoKQogZWxz
ZSAoKQorICAgIGlmIChFTkFCTEVfV0VCR0wpCisgICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1Ig
Ik9wZW5HTCBpcyBuZWVkZWQgZm9yIFdlYkdMIHN1cHBvcnQiKQorICAgIGVuZGlmICgpCiAgICAg
V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQkdMIE9GRikKICAgICBX
RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FO
VkFTIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShVU0VfUkVESVJF
Q1RFRF9YQ09NUE9TSVRFX1dJTkRPVyBPRkYpCkBAIC0zNDgsMTIgKzM1MSwxMyBAQCBpZiAoRU5B
QkxFX1NQRUxMQ0hFQ0spCiAgICAgZmluZF9wYWNrYWdlKEVuY2hhbnQgUkVRVUlSRUQpCiBlbmRp
ZiAoKQogCithZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFX1RFWFRVUkVfTUFQUEVSPTEpCisKIGlm
ICgoT1BFTkdMX0ZPVU5EIE9SIE9QRU5HTEVTMl9GT1VORCkgQU5EIChHTFhfRk9VTkQgT1IgRUdM
X0ZPVU5EKSkKICAgICBzZXQoRU5BQkxFX1RFWFRVUkVfTUFQUEVSIDEpCiAgICAgc2V0KFdURl9V
U0VfM0RfR1JBUEhJQ1MgMSkKIAogICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfM0RfR1JB
UEhJQ1M9MSkKLSAgICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFX1RFWFRVUkVfTUFQUEVSPTEp
CiAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9URVhUVVJFX01BUFBFUl9HTD0xKQogICAg
IGFkZF9kZWZpbml0aW9ucygtREVOQUJMRV8zRF9SRU5ERVJJTkc9MSkKIApkaWZmIC0tZ2l0IGEv
Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDc2MTgyNWRjMjg2NDE4NTIwZjY1YTcxNTU1OTZi
ZWRmN2E4MTc0MjYuLjNiOGNiOWVlYTkwNzYwN2MwNTU2MzE4Mjk3NTQ0NDhlZTVlYWUxNGQgMTAw
NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx
NS0wOC0yNyAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4KKwor
ICAgICAgICBsaWJ3ZWJraXQyZ3RrIGZhaWxzIHRvIGxpbmsgd2l0aG91dCBvcGVuZ2wKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzMgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtl
L09wdGlvbnNHVEsuY21ha2U6IEVycm9yIG91dCBpZiBXZWJHTCBpcyBlbmFibGVkCisgICAgICAg
IGJ1dCBPcGVuR0wgaXMgbm90IGZvdW5kOyB1c2UgdGV4dHVyZSBtYXBwZXIgaW4gYWxsIGNhc2Vz
LgorCiAyMDE1LTA4LTA2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv
bT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc0dUSy5jbWFrZSBhbmQgTkVX
UyBmb3IgMi44LjUgcmVsZWFzZS4K
</data>

          </attachment>
      

    </bug>

</bugzilla>