138316 2014-11-03 10:37:46 -0800 RenderCounter shouldn't need a pre-destructor hook. 2014-11-03 12:17:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 1045771 0 kling 2014-11-03 10:37:46 -0800 RenderCounter has a willBeDestroyed() hook, but it doesn't actually need it. It was done that way originally because there were no guarantees about calling RenderObject::view() in a renderer destructor. These days that's not a problem. Even if you are the RenderView. For real. 1045783 1 240863 kling 2014-11-03 10:54:57 -0800 Created attachment 240863 Patch 1045818 2 240863 commit-queue 2014-11-03 12:17:39 -0800 Comment on attachment 240863 Patch Clearing flags on attachment: 240863 Committed r175485: <http://trac.webkit.org/changeset/175485> 1045819 3 commit-queue 2014-11-03 12:17:43 -0800 All reviewed patches have been landed. Closing bug. 240863 2014-11-03 10:54:57 -0800 2014-11-03 12:17:39 -0800 Patch bug-138316.diff text/plain 2273 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4Nzc2ZGY5Li43NjVkZTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTQtMTEtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbmRlckNvdW50ZXIgc2hvdWxkbid0IG5lZWQgYSBwcmUtZGVzdHJ1Y3RvciBob29rLgor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4MzE2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlckNvdW50ZXIgd2lsbCBhdXRvbWF0 aWNhbGx5IHJlZ2lzdGVyL3VucmVnaXN0ZXIgaXRzZWxmIHdpdGgKKyAgICAgICAgdGhlIFJlbmRl clZpZXcgd2hlbiBjb25zdHJ1Y3RlZC9kZXN0cm95ZWQuCisKKyAgICAgICAgSXQgd2FzIHVzaW5n IGEgd2lsbEJlRGVzdHJveWVkKCkgaG9vayBiZWNhdXNlIGl0IHVzZWQgdG8gYmUgdGhhdCB5b3UK KyAgICAgICAgY291bGRuJ3QgZ2V0IHRvIHRoZSBSZW5kZXJWaWV3IGluIHRoZSBkZXN0cnVjdG9y LiBUaGF0J3Mgbm8gbG9uZ2VyCisgICAgICAgIGFuIGlzc3VlIGFzIERvY3VtZW50IHByb21pc2Vz IHRoYXQgUmVuZGVyVmlldyBpcyB0aGUgbGFzdCByZW5kZXIgdHJlZQorICAgICAgICBub2RlIHRv IGdvIGF3YXkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJDb3VudGVyOjp+UmVuZGVyQ291bnRlcik6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJDb3VudGVyOjp3aWxsQmVEZXN0cm95ZWQpOiBEZWxldGVkLgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJDb3VudGVyLmg6CisKKzIwMTQtMTEtMDMgIEFuZHJlYXMgS2xp bmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIFJlbmRlckxheWVyTW9kZWxPYmplY3Qg c2hvdWxkbid0IG5lZWQgYSBwcmUtZGVzdHJ1Y3RvciBob29rLgogICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTM4MzE0PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQ291bnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291 bnRlci5jcHAKaW5kZXggNWQ1NzA2OS4uYjQ2Y2RhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJDb3VudGVyLmNwcApAQCAtMzUwLDE4ICszNTAsMTQgQEAgUmVuZGVyQ291bnRl cjo6UmVuZGVyQ291bnRlcihEb2N1bWVudCYgZG9jdW1lbnQsIGNvbnN0IENvdW50ZXJDb250ZW50 JiBjb3VudGVyKQogCiBSZW5kZXJDb3VudGVyOjp+UmVuZGVyQ291bnRlcigpCiB7CisgICAgdmll dygpLnJlbW92ZVJlbmRlckNvdW50ZXIoKTsKKwogICAgIGlmIChtX2NvdW50ZXJOb2RlKSB7CiAg ICAgICAgIG1fY291bnRlck5vZGUtPnJlbW92ZVJlbmRlcmVyKHRoaXMpOwogICAgICAgICBBU1NF UlQoIW1fY291bnRlck5vZGUpOwogICAgIH0KIH0KIAotdm9pZCBSZW5kZXJDb3VudGVyOjp3aWxs QmVEZXN0cm95ZWQoKQotewotICAgIHZpZXcoKS5yZW1vdmVSZW5kZXJDb3VudGVyKCk7Ci0gICAg UmVuZGVyVGV4dDo6d2lsbEJlRGVzdHJveWVkKCk7Ci19Ci0KIGNvbnN0IGNoYXIqIFJlbmRlckNv dW50ZXI6OnJlbmRlck5hbWUoKSBjb25zdAogewogICAgIHJldHVybiAiUmVuZGVyQ291bnRlciI7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvdW50ZXIuaAppbmRleCBiZjNkNDQ1Li42 MTMwMGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRl ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb3VudGVyLmgKQEAgLTQy LDkgKzQyLDYgQEAgcHVibGljOgogCiAgICAgdm9pZCB1cGRhdGVDb3VudGVyKCk7CiAKLXByb3Rl Y3RlZDoKLSAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlRGVzdHJveWVkKCkgb3ZlcnJpZGU7Ci0KIHBy aXZhdGU6CiAgICAgdmlydHVhbCBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3Qgb3ZlcnJp ZGU7CiAgICAgdmlydHVhbCBib29sIGlzQ291bnRlcigpIGNvbnN0IG92ZXJyaWRlOwo=