<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138309</bug_id>
          
          <creation_ts>2014-11-03 06:14:12 -0800</creation_ts>
          <short_desc>[EFL] Fix the build if LOG_DISABLED=0 in release mode</short_desc>
          <delta_ts>2014-11-03 10:01:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tibor Mészáros">mtiborinf</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1045721</commentid>
    <comment_count>0</comment_count>
    <who name="Tibor Mészáros">mtiborinf</who>
    <bug_when>2014-11-03 06:14:12 -0800</bug_when>
    <thetext>Enabling logging in release mode can be enough to debug an issue.
But now the build is broken with the following error:

../../Source/WebCore/platform/efl/LoggingEfl.cpp: In function &apos;WTF::String WebCore::logLevelString()&apos;:
../../Source/WebCore/platform/efl/LoggingEfl.cpp:40:141: error: &apos;EINA_LOG_WARN&apos; was not declared in this scope</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1045723</commentid>
    <comment_count>1</comment_count>
      <attachid>240846</attachid>
    <who name="Tibor Mészáros">mtiborinf</who>
    <bug_when>2014-11-03 06:19:52 -0800</bug_when>
    <thetext>Created attachment 240846
Patch

This patch will fix the build error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1045756</commentid>
    <comment_count>2</comment_count>
      <attachid>240846</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-11-03 09:24:31 -0800</bug_when>
    <thetext>Comment on attachment 240846
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1045763</commentid>
    <comment_count>3</comment_count>
      <attachid>240846</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-03 10:01:01 -0800</bug_when>
    <thetext>Comment on attachment 240846
Patch

Clearing flags on attachment: 240846

Committed r175472: &lt;http://trac.webkit.org/changeset/175472&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1045764</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-03 10:01:06 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240846</attachid>
            <date>2014-11-03 06:19:52 -0800</date>
            <delta_ts>2014-11-03 10:01:01 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>patch_v3.patch</filename>
            <type>text/plain</type>
            <size>898</size>
            <attacher name="Tibor Mészáros">mtiborinf</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA2NzAwYzY2Li5kYTRmNjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTQtMTEtMDMgIFRpYm9yIE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2VkQHBhcnRu
ZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRml4IHRoZSBidWlsZCBpZiBMT0dfRElT
QUJMRUQ9MCBpbiByZWxlYXNlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTEzODMwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0xvZ2dpbmdFZmwuY3BwOgorCiAyMDE0LTEx
LTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSAnem9v
bScgQ1NTIHByb3BlcnR5IHRvIHRoZSBuZXcgU3R5bGVCdWlsZGVyCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9lZmwvTG9nZ2luZ0VmbC5jcHAKaW5kZXggYjcwYjYzZC4uNmZkZjE4NyAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvZ2dpbmdFZmwuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2dnaW5nRWZsLmNwcApAQCAtMjYsNiArMjYsNyBA
QAogCiAjaWYgIUxPR19ESVNBQkxFRAogCisjaW5jbHVkZSA8RWluYS5oPgogI2luY2x1ZGUgPHd0
Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>