138306 2014-11-03 04:02:03 -0800 'noreturn' function does return warning in LLVMOverrides.cpp 2014-11-10 00:00:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned buildbot commit-queue fpizlo oliver rniwa oldest_to_newest 1045705 0 akiss 2014-11-03 04:02:03 -0800 When building with FTL JIT enabled (on x86_64/Linux), gcc is emitting the following warning: [71/651] Building CXX object Source/JavaScriptCore/CMakeFiles/llvmForJSC.dir/llvm/library/LLVMOverrides.cpp.o ../../Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp: In function ‘void abort()’: ../../Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp:57:1: warning: ‘noreturn’ function does return [enabled by default] } ^ No big issue, but it would be better to get rid of it. 1045706 1 240839 akiss 2014-11-03 04:04:37 -0800 Created attachment 240839 Proposed patch. No regressions on x86_64/Linux/GTK 1045710 2 240840 akiss 2014-11-03 04:44:38 -0800 Created attachment 240840 Proposed patch, v2 Mac seems to be more rigorous. Adding more NO_RETURNs. 1047490 3 240840 commit-queue 2014-11-10 00:00:40 -0800 Comment on attachment 240840 Proposed patch, v2 Clearing flags on attachment: 240840 Committed r175802: <http://trac.webkit.org/changeset/175802> 1047491 4 commit-queue 2014-11-10 00:00:44 -0800 All reviewed patches have been landed. Closing bug. 240839 2014-11-03 04:04:37 -0800 2014-11-03 04:44:38 -0800 Proposed patch. llvm-fix-abort-noreturn-warning-v1.patch text/plain 1921 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJlNjc1MzMuLjFjNTQ3NjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTAzICBBa29zIEtpc3MgIDxh a2lzc0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRml4ICdub3JldHVybicgZnVuY3Rpb24g ZG9lcyByZXR1cm4gd2FybmluZyBpbiBMTFZNT3ZlcnJpZGVzLmNwcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzA2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsbHZtL2xpYnJhcnkvTExWTU92ZXJy aWRlcy5jcHA6CisgICAgICAgIEFkZCBOT19SRVRVUk4gdG8gZ19sbHZtVHJhcENhbGxiYWNrLgor ICAgICAgICAqIGxsdm0vbGlicmFyeS9MTFZNVHJhcENhbGxiYWNrLmg6IAorICAgICAgICBMaWtl d2lzZS4gQWxzbyBpbmNsdWRlIHd0Zi9Bc3NlcnRpb25zLmggdG8gbWFrZSBOT19SRVRVUk4gdmlz aWJsZS4KKwogMjAxNC0xMS0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihDTWFrZSk6IE1ha2UgaXQgcG9zc2libGUgdG8g YnVpbGQgd2l0aG91dCBpbnRyb3NwZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvbGx2bS9saWJyYXJ5L0xMVk1PdmVycmlkZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2xsdm0vbGlicmFyeS9MTFZNT3ZlcnJpZGVzLmNwcAppbmRleCBjZWQ0MDY2Li5iYTVkZmYx IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1PdmVy cmlkZXMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbHZtL2xpYnJhcnkvTExWTU92 ZXJyaWRlcy5jcHAKQEAgLTMyLDcgKzMyLDcgQEAKIGV4dGVybiAiQyIgaW50IF9fY3hhX2F0ZXhp dCgpOwogZXh0ZXJuICJDIiBpbnQgX19jeGFfYXRleGl0KCkgeyByZXR1cm4gMDsgfQogCi12b2lk ICgqZ19sbHZtVHJhcENhbGxiYWNrKShjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pOwordm9pZCAo KmdfbGx2bVRyYXBDYWxsYmFjaykoY29uc3QgY2hhciogbWVzc2FnZSwgLi4uKSBOT19SRVRVUk47 CiAKIC8vIElmIExMVk0gdHJpZXMgdG8gcmFpc2Ugc2lnbmFscywgYWJvcnQsIG9yIGZhaWwgYW4g YXNzZXJ0aW9uLCB0aGVuIGxldAogLy8gV2ViS2l0IGhhbmRsZSBpdCBpbnN0ZWFkIG9mIHRyYXBw aW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9MTFZN VHJhcENhbGxiYWNrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1U cmFwQ2FsbGJhY2suaAppbmRleCA5MjYyMGIwLi42YmNhZjZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1UcmFwQ2FsbGJhY2suaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1UcmFwQ2FsbGJhY2suaApAQCAtMjYs NyArMjYsOSBAQAogI2lmbmRlZiBMTFZNVHJhcENhbGxiYWNrX2gKICNkZWZpbmUgTExWTVRyYXBD YWxsYmFja19oCiAKLWV4dGVybiB2b2lkICgqZ19sbHZtVHJhcENhbGxiYWNrKShjb25zdCBjaGFy KiBtZXNzYWdlLCAuLi4pOworI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisKK2V4dGVybiB2 b2lkICgqZ19sbHZtVHJhcENhbGxiYWNrKShjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pIE5PX1JF VFVSTjsKIAogI2VuZGlmIC8vIExMVk1UcmFwQ2FsbGJhY2tfaAogCg== 240840 2014-11-03 04:44:38 -0800 2014-11-10 00:00:40 -0800 Proposed patch, v2 llvm-fix-abort-noreturn-warning-v2.patch text/plain 3250 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJlNjc1MzMuLjJkNDA5MzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTExLTAzICBBa29zIEtpc3MgIDxh a2lzc0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRml4ICdub3JldHVybicgZnVuY3Rpb24g ZG9lcyByZXR1cm4gd2FybmluZyBpbiBMTFZNT3ZlcnJpZGVzLmNwcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MzA2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIE5PX1JFVFVSTiB3aGVyZSBu ZWVkZWQuCisKKyAgICAgICAgKiBsbHZtL2xpYnJhcnkvTExWTUV4cG9ydHMuY3BwOgorICAgICAg ICAoaW5pdGlhbGl6ZUFuZEdldEpTQ0xMVk1BUEkpOgorICAgICAgICAqIGxsdm0vbGlicmFyeS9M TFZNT3ZlcnJpZGVzLmNwcDoKKyAgICAgICAgKiBsbHZtL2xpYnJhcnkvTExWTVRyYXBDYWxsYmFj ay5oOgorCiAyMDE0LTExLTAxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKENNYWtlKTogTWFrZSBpdCBwb3NzaWJsZSB0byBi dWlsZCB3aXRob3V0IGludHJvc3BlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbHZtL2xpYnJhcnkvTExWTUV4cG9ydHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsdm0vbGlicmFyeS9MTFZNRXhwb3J0cy5jcHAKaW5kZXggYjE5NzlmMi4uNGRhOGI0OCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9MTFZNRXhwb3J0cy5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9MTFZNRXhwb3J0cy5j cHAKQEAgLTUzLDE0ICs1MywxNSBAQAogI3VuZGVmIF9fU1REQ19MSU1JVF9NQUNST1MKICN1bmRl ZiBfX1NURENfQ09OU1RBTlRfTUFDUk9TCiAKLWV4dGVybiAiQyIgV1RGX0VYUE9SVF9QUklWQVRF IEpTQzo6TExWTUFQSSogaW5pdGlhbGl6ZUFuZEdldEpTQ0xMVk1BUEkodm9pZCAoKikoY29uc3Qg Y2hhciosIC4uLikpOworc3RhdGljIHZvaWQgbGx2bUNyYXNoKGNvbnN0IGNoYXIqKSBOT19SRVRV Uk47CitleHRlcm4gIkMiIFdURl9FWFBPUlRfUFJJVkFURSBKU0M6OkxMVk1BUEkqIGluaXRpYWxp emVBbmRHZXRKU0NMTFZNQVBJKHZvaWQgKCopKGNvbnN0IGNoYXIqLCAuLi4pIE5PX1JFVFVSTik7 CiAKIHN0YXRpYyB2b2lkIGxsdm1DcmFzaChjb25zdCBjaGFyKiByZWFzb24pCiB7CiAgICAgZ19s bHZtVHJhcENhbGxiYWNrKCJMTFZNIGZhdGFsIGVycm9yOiAlcyIsIHJlYXNvbik7CiB9CiAKLWV4 dGVybiAiQyIgSlNDOjpMTFZNQVBJKiBpbml0aWFsaXplQW5kR2V0SlNDTExWTUFQSSh2b2lkICgq Y2FsbGJhY2spKGNvbnN0IGNoYXIqLCAuLi4pKQorZXh0ZXJuICJDIiBKU0M6OkxMVk1BUEkqIGlu aXRpYWxpemVBbmRHZXRKU0NMTFZNQVBJKHZvaWQgKCpjYWxsYmFjaykoY29uc3QgY2hhciosIC4u LikgTk9fUkVUVVJOKQogewogICAgIGdfbGx2bVRyYXBDYWxsYmFjayA9IGNhbGxiYWNrOwogICAg IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsdm0vbGlicmFyeS9MTFZNT3Zl cnJpZGVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbHZtL2xpYnJhcnkvTExWTU92ZXJy aWRlcy5jcHAKaW5kZXggY2VkNDA2Ni4uZWYyODgzNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2xsdm0vbGlicmFyeS9MTFZNT3ZlcnJpZGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1PdmVycmlkZXMuY3BwCkBAIC0zMiwxMyArMzIs MTMgQEAKIGV4dGVybiAiQyIgaW50IF9fY3hhX2F0ZXhpdCgpOwogZXh0ZXJuICJDIiBpbnQgX19j eGFfYXRleGl0KCkgeyByZXR1cm4gMDsgfQogCi12b2lkICgqZ19sbHZtVHJhcENhbGxiYWNrKShj b25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pOwordm9pZCAoKmdfbGx2bVRyYXBDYWxsYmFjaykoY29u c3QgY2hhciogbWVzc2FnZSwgLi4uKSBOT19SRVRVUk47CiAKIC8vIElmIExMVk0gdHJpZXMgdG8g cmFpc2Ugc2lnbmFscywgYWJvcnQsIG9yIGZhaWwgYW4gYXNzZXJ0aW9uLCB0aGVuIGxldAogLy8g V2ViS2l0IGhhbmRsZSBpdCBpbnN0ZWFkIG9mIHRyYXBwaW5nLgogZXh0ZXJuICJDIiBpbnQgcmFp c2UoaW50IHNpZ25hbCk7Ci1leHRlcm4gIkMiIHZvaWQgX19hc3NlcnRfcnRuKGNvbnN0IGNoYXIq IGZ1bmN0aW9uLCBjb25zdCBjaGFyKiBmaWxlbmFtZSwgaW50IGxpbmVOdW1iZXIsIGNvbnN0IGNo YXIqIGV4cHJlc3Npb24pOwotZXh0ZXJuICJDIiB2b2lkIGFib3J0KHZvaWQpOworZXh0ZXJuICJD IiB2b2lkIF9fYXNzZXJ0X3J0bihjb25zdCBjaGFyKiBmdW5jdGlvbiwgY29uc3QgY2hhciogZmls ZW5hbWUsIGludCBsaW5lTnVtYmVyLCBjb25zdCBjaGFyKiBleHByZXNzaW9uKSBOT19SRVRVUk47 CitleHRlcm4gIkMiIHZvaWQgYWJvcnQodm9pZCkgTk9fUkVUVVJOOwogCiBleHRlcm4gIkMiIGlu dCByYWlzZShpbnQgc2lnbmFsKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsdm0vbGlicmFyeS9MTFZNVHJhcENhbGxiYWNrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGx2bS9saWJyYXJ5L0xMVk1UcmFwQ2FsbGJhY2suaAppbmRleCA5MjYyMGIwLi42YmNhZjZkIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1UcmFwQ2Fs bGJhY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGx2bS9saWJyYXJ5L0xMVk1UcmFw Q2FsbGJhY2suaApAQCAtMjYsNyArMjYsOSBAQAogI2lmbmRlZiBMTFZNVHJhcENhbGxiYWNrX2gK ICNkZWZpbmUgTExWTVRyYXBDYWxsYmFja19oCiAKLWV4dGVybiB2b2lkICgqZ19sbHZtVHJhcENh bGxiYWNrKShjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pOworI2luY2x1ZGUgPHd0Zi9Bc3NlcnRp b25zLmg+CisKK2V4dGVybiB2b2lkICgqZ19sbHZtVHJhcENhbGxiYWNrKShjb25zdCBjaGFyKiBt ZXNzYWdlLCAuLi4pIE5PX1JFVFVSTjsKIAogI2VuZGlmIC8vIExMVk1UcmFwQ2FsbGJhY2tfaAog Cg==