138303 2014-11-03 02:17:04 -0800 2 date tests fail on 2014.11.01 - the last day of daylight saving 2016-11-07 03:54:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=139123 https://bugs.webkit.org/show_bug.cgi?id=142531 InRadar P1 Major --- 71371 136363 1 ossy webkit-unassigned barraclough benjamin cmarcelo fpizlo ggaren jdapena mark.lam ossy rniwa roger_fong sun.shin webkit-bug-importer xingri oldest_to_newest 1045691 0 ossy 2014-11-03 02:17:04 -0800 Maybe it is related to bug130967 somehow. - Nov 01 03:43 - r175450 - 0 failures: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/9652 - Nov 01 11:27 - r175453 - 12 failures: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/9653 ... - Nov 02 00:48 - r175460 - 12 failures: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/9661 - Nov 02 09:08 - r175462 - 0 failures: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/9662 1045692 1 ossy 2014-11-03 02:21:08 -0800 Only 2 different test ( with all configuration 2*6 ): - mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla new Date(1414918204891)).getHours() = 1 FAILED! expected: 0 - mozilla-tests.yaml/ecma/Date/15.9.5.34-1.js.mozilla TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getTime() = 1420015811536 FAILED! expected: 1420098611536 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.valueOf() = 1420015811536 FAILED! expected: 1420098611536 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getUTCFullYear() = 2014 FAILED! expected: 2015 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getUTCMonth() = 11 FAILED! expected: 0 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getUTCDate() = 31 FAILED! expected: 1 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getUTCDay() = 3 FAILED! expected: 4 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getUTCHours() = 8 FAILED! expected: 7 TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getHours() = 0 FAILED! expected: 23 1045875 2 webkit-bug-importer 2014-11-03 15:21:23 -0800 <rdar://problem/18859472> 1045879 3 sun.shin 2014-11-03 15:44:07 -0800 This year's PDT ends at Sun, Nov 2, 2:00 AM. So, the error time boundary seems a little bit mis-matched with DST. But I will double check it by reverting the changes locally. 1045995 4 sun.shin 2014-11-03 21:59:24 -0800 @Csaba, could you please specify timezone information? In PST(PDT) timezone, it works same with/without patch of bug130967. 1075583 5 ossy 2015-03-09 04:40:15 -0700 mozilla-tests.yaml/ecma/Date/15.9.5.34-1.js.mozilla failed again on all bots: Apple Mavericks bot: Mar 08 14:51 181246 success #12794 Build successful Mar 08 10:24 181245 failure #12793 Failed 6 jsc tests failed Mar 08 00:21 181222 failure #12792 Failed 6 jsc tests failed Mar 07 21:18 181220 failure #12791 Failed 6 jsc tests failed Mar 07 19:53 181219 success #12790 Build successful Apple Yosemite bot: Mar 08 14:50 181246 success #161 Build successful Mar 08 10:15 181245 failure #160 Failed 6 jsc tests failed Mar 08 00:18 181222 failure #159 Failed 6 jsc tests failed Mar 07 21:14 181220 failure #158 Failed 6 jsc tests failed Mar 07 19:50 181219 success #157 Build successful EFL bot: Mar 08 14:33 181246 failure #20280 success Mar 08 10:03 181245 failure #20279 Failed 4 jsc tests failed Mar 08 03:28 181242 failure #20278 Failed 8 jsc tests failed Mar 08 00:11 181222 failure #20277 Failed 4 jsc tests failed Mar 07 22:52 181221 failure #20276 Failed 4 jsc tests failed Mar 07 20:58 181220 failure #20275 Failed 4 jsc tests failed Mar 07 19:38 181219 failure #20274 success ... mozilla-tests.yaml/ecma/Date/15.9.5.34-1.js.mozilla-llint: TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getTime() = 1451586369509 FAILED! expected: 1451582769509 mozilla-tests.yaml/ecma/Date/15.9.5.34-1.js.mozilla-llint: TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.valueOf() = 1451586369509 FAILED! expected: 1451582769509 mozilla-tests.yaml/ecma/Date/15.9.5.34-1.js.mozilla-llint: TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getUTCHours() = 18 FAILED! expected: 17 mozilla-tests.yaml/ecma/Date/15.9.5.34-1.js.mozilla-llint: TDATE = new Date(now); (TDATE).setMonth(11,31); TDATE.getHours() = 10 FAILED! expected: 9 1075584 6 ossy 2015-03-09 04:40:47 -0700 similar bug: bug139123 1076346 7 sun.shin 2015-03-11 09:30:04 -0700 Just for sharing, I have verified that this issue does not related with bug130967 since event after I manually reverted the patch, same issue still existed. I am looking into this issue what make this error regardless of the relationship. 1079144 8 sun.shin 2015-03-22 05:33:04 -0700 This issue re-introduced from https://bugs.webkit.org/show_bug.cgi?id=136363 which was originally fixed by https://bugs.webkit.org/show_bug.cgi?id=71371. Mozilla also has same issue: <https://bugzilla.mozilla.org/show_bug.cgi?id=610185> We need to re-block those test cases to prevent another investigation in DST period. 1079147 9 249195 sun.shin 2015-03-22 07:37:04 -0700 Created attachment 249195 Patch 1079148 10 249196 sun.shin 2015-03-22 07:46:50 -0700 Created attachment 249196 Patch 1079149 11 249197 sun.shin 2015-03-22 07:54:00 -0700 Created attachment 249197 Patch 1079234 12 249197 ossy 2015-03-23 00:13:37 -0700 Comment on attachment 249197 Patch Skipping tests doesn't fix the issue. And run-javascriptcore-tests run stress tests by default, which ignores this kind of skipping. 1079239 13 sun.shin 2015-03-23 01:03:01 -0700 If so, what is your purpose to create this issue? Do we need to fix the mozilla date test cases to adapt DST changing? It fails on Mozilla also. 1079246 14 ossy 2015-03-23 02:20:01 -0700 (In reply to comment #13) > If so, what is your purpose to create this issue? Do we need to fix the > mozilla date test cases to adapt DST changing? It fails on Mozilla also. I have 2 problems with the proposed patch: - Adding a test to @testsToSkip list doesn't skip it in the real life, because run-javascriptcore-tests run stress tests by default with the run-jsc-stres-tests harness. (Can be orverriden manually with --no-jsc-stress) This list is for the old mozilla test harnes, which isn't used by default. If we really want to skip a test, it should be done in Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml too. - I don't think if we should skip a full test just because one test case in it fails on 1-2 days in a year. 15.9.5.14.js: (only the "now" case fails only when DST changes) addTestCase( now ); addTestCase( TIME_YEAR_0 ); addTestCase( TIME_1970 ); addTestCase( TIME_1900 ); addTestCase( TIME_2000 ); addTestCase( UTC_FEB_29_2000 ); addTestCase( UTC_JAN_1_2005 ); I think we should skip only the "now" case it this test after adding DST specific tests too and adding crash-only tests for the "now" case. See bug139123 too. 1079273 15 sun.shin 2015-03-23 03:58:19 -0700 Now I can understand your intention. Thanks for the explanation. 1248705 16 ossy 2016-11-07 03:54:38 -0800 Still valid bug, bots are red again due to PST->PDT change. mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: 15.9.5.14 Date.prototype.getHours() mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: (new Date(1478388956518)).getHours() = 16 FAILED! expected: 15 mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: (new Date(1478392556518)).getHours() = 17 FAILED! expected: 16 mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: (new Date(1478396156518)).getHours() = 18 FAILED! expected: 17 mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: (new Date(1478399756518)).getHours() = 19 FAILED! expected: 18 mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: (new Date(1478403356518)).getHours() = 20 FAILED! expected: 19 mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline: (new Date(1478406956518)).getHours() = 21 FAILED! expected: 20 249195 2015-03-22 07:37:04 -0700 2015-03-22 07:46:43 -0700 Patch bug-138303-20150322143628.patch text/plain 1410 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxODMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOThjYTA0NTAwYjc5N2I3MDIxMzg5N2I4NmY5NjBiZmQ3 MDJlMWMwNi4uMWQwNWEzZmQyYjIwNDNiNGFjZTk0ZjlkMTRjNzAyZWVkNzJhMzBhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTAzLTIyICBCeXVuZ3Nlb24gU2hpbiAgPHN1bi5zaGluQHdlYmtpdC5vcmc+CisK KyAgICAgICAgU2tpcCBzb21lIEVDTUFTY3JpcHQgdGVzdHMgdGhhdCBmYWlsIGF0IERTVCBjaGFu Z2luZyB0aW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKGRlZmF1bHRK c0RyaXZlckFyZ3NGb3JNb3ppbGxhVGVzdHMpOgorCiAyMDE1LTAzLTIwICBNYXJrIEhhaG5lbmJl cmcgIDxtaGFobmVuYkBnbWFpbC5jb20+CiAKICAgICAgICAgR0NUaW1lciBzaG91bGQga25vdyBr ZWVwIHRyYWNrIG9mIG5lc3RlZCBHQyBwaGFzZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNv cmUtdGVzdHMKaW5kZXggNWFmOWJlMTk0NjI1NjliY2Q2YmNmYjYyZjc1YjhkM2ZlYzM2NDVmMS4u YzAxMDVhZjQ4ZDZkYmQ2M2I2Nzc5ZGUxZDc2NjRjNDg5ZDY2MGQ2YiAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9y dW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKQEAgLTQwOCw2ICs0MDgsMTAgQEAgc3ViIGRlZmF1bHRK c0RyaXZlckFyZ3NGb3JNb3ppbGxhVGVzdHMKICAgICBteSBAdGVzdHNUb1NraXAgPSAoCiAgICAg ICAgICMgZnVuY3Rpb24uYXJndW1lbnRzIGhhdmUgYmVlbiBkaXNhYmxlZAogICAgICAgICAianMx XzQvRnVuY3Rpb25zL2Z1bmN0aW9uLTAwMS5qcyIsCisgICAgICAgICMgVGhlc2UgdGhyZWUgZmFp bCBhdCBEU1QgY2hhbmdpbmcgdGltZXMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcxMzcxCisgICAgICAgICJlY21hL0RhdGUvMTUuOS41LjE0LmpzIiwKKyAgICAgICAg ImVjbWEvRGF0ZS8xNS45LjUuMzEtMS5qcyIsCisgICAgICAgICJlY21hL0RhdGUvMTUuOS41LjM0 LTEuanMiLAogICAgICk7CiAKICAgICBAdGVzdHNUb1NraXAgPSAoQHRlc3RzVG9Ta2lwLCBAdGVz dHNUb1NraXBPbldpbmRvd3MpIGlmIGlzQXBwbGVXaW5XZWJLaXQoKTsK 249196 2015-03-22 07:46:50 -0700 2015-03-22 07:53:51 -0700 Patch bug-138303-20150322144615.patch text/plain 1411 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxODMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOThjYTA0NTAwYjc5N2I3MDIxMzg5N2I4NmY5NjBiZmQ3 MDJlMWMwNi4uMWQwNWEzZmQyYjIwNDNiNGFjZTk0ZjlkMTRjNzAyZWVkNzJhMzBhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTAzLTIyICBCeXVuZ3Nlb24gU2hpbiAgPHN1bi5zaGluQHdlYmtpdC5vcmc+CisK KyAgICAgICAgU2tpcCBzb21lIEVDTUFTY3JpcHQgdGVzdHMgdGhhdCBmYWlsIGF0IERTVCBjaGFu Z2luZyB0aW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM4MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKGRlZmF1bHRK c0RyaXZlckFyZ3NGb3JNb3ppbGxhVGVzdHMpOgorCiAyMDE1LTAzLTIwICBNYXJrIEhhaG5lbmJl cmcgIDxtaGFobmVuYkBnbWFpbC5jb20+CiAKICAgICAgICAgR0NUaW1lciBzaG91bGQga25vdyBr ZWVwIHRyYWNrIG9mIG5lc3RlZCBHQyBwaGFzZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNv cmUtdGVzdHMKaW5kZXggNWFmOWJlMTk0NjI1NjliY2Q2YmNmYjYyZjc1YjhkM2ZlYzM2NDVmMS4u ZTNlMjJkZGE2YzFmNDc5YjUwNTczMDRkMzQ3ZjZjOGJkOGRiNWM2MCAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9y dW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKQEAgLTQwOCw2ICs0MDgsMTAgQEAgc3ViIGRlZmF1bHRK c0RyaXZlckFyZ3NGb3JNb3ppbGxhVGVzdHMKICAgICBteSBAdGVzdHNUb1NraXAgPSAoCiAgICAg ICAgICMgZnVuY3Rpb24uYXJndW1lbnRzIGhhdmUgYmVlbiBkaXNhYmxlZAogICAgICAgICAianMx XzQvRnVuY3Rpb25zL2Z1bmN0aW9uLTAwMS5qcyIsCisgICAgICAgICMgVGhlc2UgdGhyZWUgZmFp bCBhdCBEU1QgY2hhbmdpbmcgdGltZXMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzODMwMworICAgICAgICAiZWNtYS9EYXRlLzE1LjkuNS4xNC5qcyIsCisgICAgICAg ICJlY21hL0RhdGUvMTUuOS41LjMxLTEuanMiLAorICAgICAgICAiZWNtYS9EYXRlLzE1LjkuNS4z NC0xLmpzIiwKICAgICApOwogCiAgICAgQHRlc3RzVG9Ta2lwID0gKEB0ZXN0c1RvU2tpcCwgQHRl c3RzVG9Ta2lwT25XaW5kb3dzKSBpZiBpc0FwcGxlV2luV2ViS2l0KCk7Cg== 249197 2015-03-22 07:54:00 -0700 2015-03-23 00:13:37 -0700 Patch bug-138303-20150322145325.patch text/plain 1481 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxODMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOThjYTA0NTAwYjc5N2I3MDIxMzg5N2I4NmY5NjBiZmQ3 MDJlMWMwNi4uMjQ5ZjdlMzUzMjViMDNjMjk0NmE3ODMzZjAwYzNmN2M5Yzc2YmNlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAzLTIyICBCeXVuZ3Nlb24gU2hpbiAgPHN1bi5zaGluQHdlYmtpdC5vcmc+CisK KyAgICAgICAgMiBkYXRlIHRlc3RzIGZhaWwgb24gMjAxNC4xMS4wMSAtIHRoZSBsYXN0IGRheSBv ZiBkYXlsaWdodCBzYXZpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzODMwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNraXAgc29tZSBFQ01BU2NyaXB0IHRlc3RzIHRoYXQgZmFpbCBhdCBEU1QgY2hh bmdpbmcgdGltZXMgb24gUFNUIFRpbWV6b25lLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2 YXNjcmlwdGNvcmUtdGVzdHM6CisgICAgICAgIChkZWZhdWx0SnNEcml2ZXJBcmdzRm9yTW96aWxs YVRlc3RzKToKKwogMjAxNS0wMy0yMCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJAZ21haWwu Y29tPgogCiAgICAgICAgIEdDVGltZXIgc2hvdWxkIGtub3cga2VlcCB0cmFjayBvZiBuZXN0ZWQg R0MgcGhhc2VzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10 ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCmluZGV4IDVhZjli ZTE5NDYyNTY5YmNkNmJjZmI2MmY3NWI4ZDNmZWMzNjQ1ZjEuLjMzZmQyZmJmNTEyNTY5NTdmNWQ0 YzVhOGRlMDA5OGQ0MmFlYTJiOTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFz Y3JpcHRjb3JlLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRl c3RzCkBAIC00MDgsNiArNDA4LDkgQEAgc3ViIGRlZmF1bHRKc0RyaXZlckFyZ3NGb3JNb3ppbGxh VGVzdHMKICAgICBteSBAdGVzdHNUb1NraXAgPSAoCiAgICAgICAgICMgZnVuY3Rpb24uYXJndW1l bnRzIGhhdmUgYmVlbiBkaXNhYmxlZAogICAgICAgICAianMxXzQvRnVuY3Rpb25zL2Z1bmN0aW9u LTAwMS5qcyIsCisgICAgICAgICMgVGhlc2UgdHdvIGZhaWwgYXQgRFNUIGNoYW5naW5nIHRpbWVz IG9uIFBTVCB0aW1lem9uZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM4MzAzCisgICAgICAgICJlY21hL0RhdGUvMTUuOS41LjE0LmpzIiwKKyAgICAgICAgImVjbWEv RGF0ZS8xNS45LjUuMzQtMS5qcyIsCiAgICAgKTsKIAogICAgIEB0ZXN0c1RvU2tpcCA9IChAdGVz dHNUb1NraXAsIEB0ZXN0c1RvU2tpcE9uV2luZG93cykgaWYgaXNBcHBsZVdpbldlYktpdCgpOwo=