138289 2014-11-01 23:27:17 -0700 Reduce the cost of argumentCount checks in the JS bindings 2014-11-02 10:19:53 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue ggaren kling rniwa simon.fraser oldest_to_newest 1045581 0 cdumez 2014-11-01 23:27:17 -0700 Reduce the cost of argumentCount checks in the JS bindings by hinting to the compiler that it is UNLIKELY that those methods are called with too few arguments. 1045582 1 240807 cdumez 2014-11-01 23:30:00 -0700 Created attachment 240807 Patch 1045601 2 240807 commit-queue 2014-11-02 08:38:00 -0800 Comment on attachment 240807 Patch Clearing flags on attachment: 240807 Committed r175462: <http://trac.webkit.org/changeset/175462> 1045602 3 commit-queue 2014-11-02 08:38:03 -0800 All reviewed patches have been landed. Closing bug. 1045613 4 simon.fraser 2014-11-02 10:15:01 -0800 This broke bindings tests: https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/7751/steps/bindings-generation-tests/logs/stdio 1045614 5 cdumez 2014-11-02 10:17:36 -0800 (In reply to comment #4) > This broke bindings tests: > https://build.webkit.org/builders/ > Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/7751/steps/bindings- > generation-tests/logs/stdio Oh, they need to be rebaselined, I'll take care of it now, thanks. 1045615 6 cdumez 2014-11-02 10:19:53 -0800 Rebaselined the bindings tests in <http://trac.webkit.org/changeset/175463>. 240807 2014-11-01 23:30:00 -0700 2014-11-02 08:38:00 -0800 Patch bug-138289-20141101233009.patch text/plain 1760 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJjODdmOTJlN2ZhNTdh MmQzOTYwYmU5N2I0ZGExMGU0NzMzZWIxYi4uYWVlMTlkZjc1ZTk4MTI3YWY5MjAxZDIyY2YzMmUy OWQwZTA3NWYwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTExLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVkdWNlIHRoZSBjb3N0IG9m IGFyZ3VtZW50Q291bnQgY2hlY2tzIGluIHRoZSBKUyBiaW5kaW5ncworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4Mjg5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2xpZ2h0bHkgcmVkdWNlIHRoZSBjb3N0 IG9mIGFyZ3VtZW50Q291bnQgY2hlY2tzIGluIHRoZSBKUyBiaW5kaW5ncyBieQorICAgICAgICBo aW50aW5nIHRvIHRoZSBjb21waWxlciB0aGF0IGl0IGlzIFVOTElLRUxZIHRoYXQgdGhvc2UgbWV0 aG9kcyBhcmUKKyAgICAgICAgY2FsbGVkIHdpdGggdG9vIGZldyBhcmd1bWVudHMuCisKKyAgICAg ICAgSSBzZWUgYSAzJSBwcm9ncmVzc2lvbiBvbiBQZXJmb3JtYW5jZVRlc3RzL0RPTS9ET01EaXZX YWxrLmh0bWwKKyAgICAgICAgcGVyZm9ybWFuY2UgdGVzdC4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVBcmd1bWVudHNDb3VudENoZWNrKToK KwogMjAxNC0xMS0wMSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1v dmUgdGhlIC13ZWJraXQtdHJhbnNmb3JtIHByb3BlcnR5IHRvIHRoZSBuZXcgU3R5bGVCdWlsZGVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtCmluZGV4IGYzMGJkZmRlZGZkZTFhYTNmNzE4OGRjMmU2ZWUyNDlkZWRhMDg1NWMuLjg1OTVk MTkwMDIwMjNkZWNjOGRmOTg0Y2E4NjZmYjRkYjU4NDgxNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0zMTY2LDcgKzMx NjYsNyBAQCBzdWIgR2VuZXJhdGVBcmd1bWVudHNDb3VudENoZWNrCiAgICAgfQogICAgIGlmICgk bnVtTWFuZGF0b3J5UGFyYW1zID49IDEpCiAgICAgewotICAgICAgICBwdXNoKEAkb3V0cHV0QXJy YXksICIgICAgaWYgKGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA8ICRudW1NYW5kYXRvcnlQYXJhbXMp XG4iKTsKKyAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgIGlmIChVTkxJS0VMWShleGVj LT5hcmd1bWVudENvdW50KCkgPCAkbnVtTWFuZGF0b3J5UGFyYW1zKSlcbiIpOwogICAgICAgICBw dXNoKEAkb3V0cHV0QXJyYXksICIgICAgICAgIHJldHVybiB0aHJvd1ZNRXJyb3IoZXhlYywgY3Jl YXRlTm90RW5vdWdoQXJndW1lbnRzRXJyb3IoZXhlYykpO1xuIik7CiAgICAgfQogfQo=