138270 2014-10-31 17:27:59 -0700 StyleBuilder: Stop using custom code for -webkit-hyphenate-limit-lines 2014-10-31 18:31:46 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137910 1 cdumez cdumez benjamin commit-queue kling oldest_to_newest 1045451 0 cdumez 2014-10-31 17:27:59 -0700 Stop using custom code for -webkit-hyphenate-limit-lines in the new StyleBuilder. We don't really need to, we can just have a Converter specific to this property. 1045452 1 240771 cdumez 2014-10-31 17:30:19 -0700 Created attachment 240771 Patch 1045463 2 240771 commit-queue 2014-10-31 18:31:42 -0700 Comment on attachment 240771 Patch Clearing flags on attachment: 240771 Committed r175445: <http://trac.webkit.org/changeset/175445> 1045464 3 commit-queue 2014-10-31 18:31:46 -0700 All reviewed patches have been landed. Closing bug. 240771 2014-10-31 17:30:19 -0700 2014-10-31 18:31:42 -0700 Patch bug-138270-20141031173028.patch text/plain 4701 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ4ZTg5OTQ0NjVjODVh MDU3NjEzYWUxMmVmYmQxYjcwMDczMGJlZC4uNTA5MmEwZGU5ZGJhODY2MjQ5YzFjOTdhMjg5ZGRm MWE5YjcwMGE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTEwLTMxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgU3R5bGVCdWlsZGVyOiBTdG9w IHVzaW5nIGN1c3RvbSBjb2RlIGZvciAtd2Via2l0LWh5cGhlbmF0ZS1saW1pdC1saW5lcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MjcwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1c2luZyBj dXN0b20gY29kZSBmb3IgLXdlYmtpdC1oeXBoZW5hdGUtbGltaXQtbGluZXMgaW4gdGhlIG5ldwor ICAgICAgICBTdHlsZUJ1aWxkZXIuIFdlIGRvbid0IHJlYWxseSBuZWVkIHRvLCB3ZSBjYW4ganVz dCBoYXZlIGEgQ29udmVydGVyCisgICAgICAgIHNwZWNpZmljIHRvIHRoaXMgcHJvcGVydHkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBj c3MvQ1NTUHJvcGVydHlOYW1lcy5pbjoKKyAgICAgICAgKiBjc3MvU3R5bGVCdWlsZGVyQ29udmVy dGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZUJ1aWxkZXJDb252ZXJ0ZXI6OmNvbnZlcnRX ZWJraXRIeXBoZW5hdGVMaW1pdExpbmVzKToKKyAgICAgICAgKiBjc3MvU3R5bGVCdWlsZGVyQ3Vz dG9tLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZUJ1aWxkZXJGdW5jdGlvbnM6OmFwcGx5VmFs dWVXZWJraXRIeXBoZW5hdGVMaW1pdExpbmVzKTogRGVsZXRlZC4KKworMjAxNC0xMC0zMSAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIFN1cHBvcnQgdGhyb3R0bGlu ZyBvZiBET01UaW1lcnMgdXNpbmcgbmVzdGVkIHNldFRpbWVvdXQoKSBjYWxscwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MjYyCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eU5hbWVzLmluIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4KaW5kZXggMThiY2I0MmQwMmJlYjgyNGVmODYwNDFh ODA4MzU0MmY4Y2RlZDRlZi4uOWE1NDNhZGNkOWMxNWE0NTY0ZGVmMzc3MzhjOWUzZDI1NGZkZTRi ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4KKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4KQEAgLTM5MCw3ICszOTAs NyBAQCBqdXN0aWZ5LWNvbnRlbnQgW05ld1N0eWxlQnVpbGRlcl0KIC13ZWJraXQtaHlwaGVuYXRl LWNoYXJhY3RlciBbSW5oZXJpdGVkXQogLXdlYmtpdC1oeXBoZW5hdGUtbGltaXQtYWZ0ZXIgW0lu aGVyaXRlZCwgTmV3U3R5bGVCdWlsZGVyLCBOYW1lRm9yTWV0aG9kcz1IeXBoZW5hdGlvbkxpbWl0 QWZ0ZXIsIENvbnZlcnRlcj1OdW1iZXI8c2hvcnQ+XQogLXdlYmtpdC1oeXBoZW5hdGUtbGltaXQt YmVmb3JlIFtJbmhlcml0ZWQsIE5ld1N0eWxlQnVpbGRlciwgTmFtZUZvck1ldGhvZHM9SHlwaGVu YXRpb25MaW1pdEJlZm9yZSwgQ29udmVydGVyPU51bWJlcjxzaG9ydD5dCi0td2Via2l0LWh5cGhl bmF0ZS1saW1pdC1saW5lcyBbSW5oZXJpdGVkLCBOZXdTdHlsZUJ1aWxkZXIsIE5hbWVGb3JNZXRo b2RzPUh5cGhlbmF0aW9uTGltaXRMaW5lcywgQ3VzdG9tPVZhbHVlXQorLXdlYmtpdC1oeXBoZW5h dGUtbGltaXQtbGluZXMgW0luaGVyaXRlZCwgTmV3U3R5bGVCdWlsZGVyLCBOYW1lRm9yTWV0aG9k cz1IeXBoZW5hdGlvbkxpbWl0TGluZXMsIENvbnZlcnRlcj1XZWJraXRIeXBoZW5hdGVMaW1pdExp bmVzXQogLXdlYmtpdC1oeXBoZW5zIFtJbmhlcml0ZWQsIE5ld1N0eWxlQnVpbGRlciwgVHlwZU5h bWU9SHlwaGVuc10KIC1lcHViLWh5cGhlbnMgPSAtd2Via2l0LWh5cGhlbnMKIC13ZWJraXQtaW5p dGlhbC1sZXR0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXJD b252ZXJ0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXJDb252ZXJ0ZXIuaApp bmRleCA5Mzg5YmJkNDUxN2ZjNzBkM2M1NjZlMjBmNmRmODIwMjc5OTMyMDkzLi43ZmJhZDMyOTEz NGM5MWExMjJmZWQyNzM3MTViOGUzOTEyYWIwM2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVCdWlsZGVyQ29udmVydGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlQnVpbGRlckNvbnZlcnRlci5oCkBAIC00Nyw2ICs0Nyw3IEBAIHB1YmxpYzoKICAgICBzdGF0 aWMgTGVuZ3RoU2l6ZSBjb252ZXJ0UmFkaXVzKFN0eWxlUmVzb2x2ZXImLCBDU1NWYWx1ZSYpOwog ICAgIHN0YXRpYyBUZXh0RGVjb3JhdGlvbiBjb252ZXJ0VGV4dERlY29yYXRpb24oU3R5bGVSZXNv bHZlciYsIENTU1ZhbHVlJik7CiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0YXRpYyBUIGNv bnZlcnROdW1iZXIoU3R5bGVSZXNvbHZlciYsIENTU1ZhbHVlJik7CisgICAgc3RhdGljIHNob3J0 IGNvbnZlcnRXZWJraXRIeXBoZW5hdGVMaW1pdExpbmVzKFN0eWxlUmVzb2x2ZXImLCBDU1NWYWx1 ZSYpOwogICAgIHRlbXBsYXRlIDxDU1NQcm9wZXJ0eUlEIHByb3BlcnR5PiBzdGF0aWMgTmluZVBp ZWNlSW1hZ2UgY29udmVydEJvcmRlckltYWdlKFN0eWxlUmVzb2x2ZXImLCBDU1NWYWx1ZSYpOwog ICAgIHRlbXBsYXRlIDxDU1NQcm9wZXJ0eUlEIHByb3BlcnR5PiBzdGF0aWMgTmluZVBpZWNlSW1h Z2UgY29udmVydEJvcmRlck1hc2soU3R5bGVSZXNvbHZlciYsIENTU1ZhbHVlJik7CiAgICAgdGVt cGxhdGUgPENTU1Byb3BlcnR5SUQgcHJvcGVydHk+IHN0YXRpYyBQYXNzUmVmUHRyPFN0eWxlSW1h Z2U+IGNvbnZlcnRCb3JkZXJJbWFnZVNvdXJjZShTdHlsZVJlc29sdmVyJiwgQ1NTVmFsdWUmKTsK QEAgLTIwOSw2ICsyMTAsMTQgQEAgaW5saW5lIFQgU3R5bGVCdWlsZGVyQ29udmVydGVyOjpjb252 ZXJ0TnVtYmVyKFN0eWxlUmVzb2x2ZXImLCBDU1NWYWx1ZSYgdmFsdWUpCiAgICAgcmV0dXJuIHBy aW1pdGl2ZVZhbHVlLmdldFZhbHVlPFQ+KENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSKTsK IH0KIAoraW5saW5lIHNob3J0IFN0eWxlQnVpbGRlckNvbnZlcnRlcjo6Y29udmVydFdlYmtpdEh5 cGhlbmF0ZUxpbWl0TGluZXMoU3R5bGVSZXNvbHZlciYsIENTU1ZhbHVlJiB2YWx1ZSkKK3sKKyAg ICBhdXRvJiBwcmltaXRpdmVWYWx1ZSA9IGRvd25jYXN0PENTU1ByaW1pdGl2ZVZhbHVlPih2YWx1 ZSk7CisgICAgaWYgKHByaW1pdGl2ZVZhbHVlLmdldFZhbHVlSUQoKSA9PSBDU1NWYWx1ZU5vTGlt aXQpCisgICAgICAgIHJldHVybiAtMTsKKyAgICByZXR1cm4gcHJpbWl0aXZlVmFsdWUuZ2V0VmFs dWU8c2hvcnQ+KENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSKTsKK30KKwogdGVtcGxhdGUg PENTU1Byb3BlcnR5SUQgcHJvcGVydHk+CiBpbmxpbmUgTmluZVBpZWNlSW1hZ2UgU3R5bGVCdWls ZGVyQ29udmVydGVyOjpjb252ZXJ0Qm9yZGVySW1hZ2UoU3R5bGVSZXNvbHZlciYgc3R5bGVSZXNv bHZlciwgQ1NTVmFsdWUmIHZhbHVlKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlQnVpbGRlckN1c3RvbS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlQnVpbGRlckN1 c3RvbS5oCmluZGV4IGNiNGNlMjg5NmM4Mjk2MDU0MWQ4ODNiZWY1NTE0YmQ4NzVmNzZjODIuLjk0 M2U4YjBiMWYwZTRlMjlmNGY0NDgxOTY1NGJlMjU4ZGJhNWY1YzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXJDdXN0b20uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvU3R5bGVCdWlsZGVyQ3VzdG9tLmgKQEAgLTMzLDE1ICszMyw2IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogbmFtZXNwYWNlIFN0eWxlQnVpbGRlckZ1bmN0aW9ucyB7CiAKLWlubGluZSB2b2lk IGFwcGx5VmFsdWVXZWJraXRIeXBoZW5hdGVMaW1pdExpbmVzKFN0eWxlUmVzb2x2ZXImIHN0eWxl UmVzb2x2ZXIsIENTU1ZhbHVlJiB2YWx1ZSkKLXsKLSAgICBhdXRvJiBwcmltaXRpdmVWYWx1ZSA9 IGRvd25jYXN0PENTU1ByaW1pdGl2ZVZhbHVlPih2YWx1ZSk7Ci0gICAgc2hvcnQgbnVtYmVyID0g LTE7Ci0gICAgaWYgKHByaW1pdGl2ZVZhbHVlLmdldFZhbHVlSUQoKSAhPSBDU1NWYWx1ZU5vTGlt aXQpCi0gICAgICAgIG51bWJlciA9IHByaW1pdGl2ZVZhbHVlLmdldFZhbHVlPHNob3J0PihDU1NQ cmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUik7Ci0gICAgc3R5bGVSZXNvbHZlci5zdHlsZSgpLT5z ZXRIeXBoZW5hdGlvbkxpbWl0TGluZXMobnVtYmVyKTsKLX0KLQogaW5saW5lIHZvaWQgYXBwbHlW YWx1ZVdlYmtpdE1hcnF1ZWVJbmNyZW1lbnQoU3R5bGVSZXNvbHZlciYgc3R5bGVSZXNvbHZlciwg Q1NTVmFsdWUmIHZhbHVlKQogewogICAgIGF1dG8mIHByaW1pdGl2ZVZhbHVlID0gZG93bmNhc3Q8 Q1NTUHJpbWl0aXZlVmFsdWU+KHZhbHVlKTsK