138263 2014-10-31 15:20:23 -0700 Change the ScrollingThread code to use RunLoop::main().dispatch() rather than callOnMainThread(), which has Obj-C overhead 2014-10-31 16:14:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca cmarcelo commit-queue jamesr luiz simon.fraser thorton tonikitoo oldest_to_newest 1045395 0 simon.fraser 2014-10-31 15:20:23 -0700 Change the ScrollingThread code to use RunLoop::main().dispatch() rather than callOnMainThread(), which has Obj-C overhead 1045396 1 240759 simon.fraser 2014-10-31 15:21:34 -0700 Created attachment 240759 Patch 1045397 2 simon.fraser 2014-10-31 15:22:09 -0700 rdar://problem/18833601 1045398 3 240759 ggaren 2014-10-31 15:23:56 -0700 Comment on attachment 240759 Patch Should we change the implementation of callOnMainThread to use RunLoop::main().dispatch? 1045401 4 simon.fraser 2014-10-31 15:30:11 -0700 (In reply to comment #3) > Comment on attachment 240759 [details] > Patch > > Should we change the implementation of callOnMainThread to use > RunLoop::main().dispatch? Probably, but the fix needs to take the iOS WebThread into account. 1045423 5 240759 commit-queue 2014-10-31 16:14:47 -0700 Comment on attachment 240759 Patch Clearing flags on attachment: 240759 Committed r175433: <http://trac.webkit.org/changeset/175433> 1045424 6 commit-queue 2014-10-31 16:14:51 -0700 All reviewed patches have been landed. Closing bug. 240759 2014-10-31 15:21:34 -0700 2014-10-31 16:14:47 -0700 Patch bug-138263-20141031152142.patch text/plain 3348 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I0NGNkZDk0ZTJjMDUy NTE4OWFjMWE5MjExZmIyNDkyZGIxYWIxYi4uZTFjMTJiOTMzYWZjMWJhN2I1OGEzZmUxMWQ4OWRh ZGYxOTM0ODcxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEwLTMxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSB0aGUg U2Nyb2xsaW5nVGhyZWFkIGNvZGUgdG8gdXNlIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaCgpIHJh dGhlciB0aGFuIGNhbGxPbk1haW5UaHJlYWQoKSwgd2hpY2ggaGFzIE9iai1DIG92ZXJoZWFkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgyNjMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjYWxsT25NYWlu VGhyZWFkKCkgdXNlcyAtcGVyZm9ybVNlbGVjdG9yOm9uTWFpblRocmVhZDp3aXRoT2JqZWN0Ondh aXRVbnRpbERvbmU6LCBzbworICAgICAgICBpdCdzIHNsaWdodGx5IG1vcmUgZWZmaWNpZW50IHRv IHVzZSBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goKS4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xs aW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaHJlYWRl ZFNjcm9sbGluZ1RyZWU6OmludmFsaWRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6VGhyZWFkZWRT Y3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdUcmVlTm9kZURpZFNjcm9sbCk6CisgICAgICAgIChXZWJD b3JlOjpUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OmhhbmRsZVdoZWVsRXZlbnRQaGFzZSk6CisKIDIw MTQtMTAtMzEgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgd2Via2l0IHByZWZpeCBmcm9tIENTUyBjb2x1bW5zLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5j cHAKaW5kZXggM2JmYjE4NmE5OTM1MmJmOTg5ZjkzZDNhZTY4Nzk0N2YxNDM5YTZjNC4uZThkOTNh ZGNjYjA0OTg4ZTFlNDQ1MWIwZTQ3MjIzYzJiNDVmYTc0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwCkBAIC0z NSw3ICszNSw3IEBACiAjaW5jbHVkZSAiU2Nyb2xsaW5nVHJlZU5vZGUuaCIKICNpbmNsdWRlICJT Y3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZS5oIgogI2luY2x1ZGUgIlNjcm9sbGluZ1RyZWVTdGlj a3lOb2RlLmgiCi0jaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KKyNpbmNsdWRlIDx3dGYvUnVu TG9vcC5oPgogI2luY2x1ZGUgPHd0Zi9UZW1wb3JhcnlDaGFuZ2UuaD4KIAogbmFtZXNwYWNlIFdl YkNvcmUgewpAQCAtODYsNyArODYsNyBAQCB2b2lkIFRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6aW52 YWxpZGF0ZSgpCiAgICAgLy8gU2luY2UgdGhpcyBjYW4gcG90ZW50aWFsbHkgYmUgdGhlIGxhc3Qg cmVmZXJlbmNlIHRvIHRoZSBzY3JvbGxpbmcgY29vcmRpbmF0b3IsCiAgICAgLy8gd2UgbmVlZCB0 byByZWxlYXNlIGl0IG9uIHRoZSBtYWluIHRocmVhZCBzaW5jZSBpdCBoYXMgbWVtYmVyIHZhcmlh YmxlcyAoc3VjaCBhcyB0aW1lcnMpCiAgICAgLy8gdGhhdCBleHBlY3QgdG8gYmUgZGVzdHJveWVk IGZyb20gdGhlIG1haW4gdGhyZWFkLgotICAgIGNhbGxPbk1haW5UaHJlYWQoYmluZChkZXJlZlNj cm9sbGluZ0Nvb3JkaW5hdG9yLCBtX3Njcm9sbGluZ0Nvb3JkaW5hdG9yLnJlbGVhc2UoKS5sZWFr UmVmKCkpKTsKKyAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goYmluZChkZXJlZlNjcm9sbGlu Z0Nvb3JkaW5hdG9yLCBtX3Njcm9sbGluZ0Nvb3JkaW5hdG9yLnJlbGVhc2UoKS5sZWFrUmVmKCkp KTsKIH0KIAogdm9pZCBUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OmNvbW1pdE5ld1RyZWVTdGF0ZShQ YXNzT3duUHRyPFNjcm9sbGluZ1N0YXRlVHJlZT4gc2Nyb2xsaW5nU3RhdGVUcmVlKQpAQCAtMTAz LDcgKzEwMyw3IEBAIHZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdUcmVlTm9k ZURpZFNjcm9sbChTY3JvbGxpbmdOb2RlSUQgbm9kZUlELCBjCiAgICAgaWYgKG5vZGVJRCA9PSBy b290Tm9kZSgpLT5zY3JvbGxpbmdOb2RlSUQoKSkKICAgICAgICAgc2V0TWFpbkZyYW1lU2Nyb2xs UG9zaXRpb24oc2Nyb2xsUG9zaXRpb24pOwogCi0gICAgY2FsbE9uTWFpblRocmVhZChiaW5kKCZB c3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY2hlZHVsZVVwZGF0ZVNjcm9sbFBvc2l0aW9uQWZ0 ZXJBc3luY1Njcm9sbCwgbV9zY3JvbGxpbmdDb29yZGluYXRvci5nZXQoKSwgbm9kZUlELCBzY3Jv bGxQb3NpdGlvbiwgaXNIYW5kbGluZ1Byb2dyYW1tYXRpY1Njcm9sbCgpLCBzY3JvbGxpbmdMYXll clBvc2l0aW9uQWN0aW9uKSk7CisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKGJpbmQoJkFz eW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNjaGVkdWxlVXBkYXRlU2Nyb2xsUG9zaXRpb25BZnRl ckFzeW5jU2Nyb2xsLCBtX3Njcm9sbGluZ0Nvb3JkaW5hdG9yLmdldCgpLCBub2RlSUQsIHNjcm9s bFBvc2l0aW9uLCBpc0hhbmRsaW5nUHJvZ3JhbW1hdGljU2Nyb2xsKCksIHNjcm9sbGluZ0xheWVy UG9zaXRpb25BY3Rpb24pKTsKIH0KIAogI2lmIFBMQVRGT1JNKE1BQykKQEAgLTExMiw3ICsxMTIs NyBAQCB2b2lkIFRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6aGFuZGxlV2hlZWxFdmVudFBoYXNlKFBs YXRmb3JtV2hlZWxFdmVudFBoYXNlIHBoYXNlKQogICAgIGlmICghbV9zY3JvbGxpbmdDb29yZGlu YXRvcikKICAgICAgICAgcmV0dXJuOwogCi0gICAgY2FsbE9uTWFpblRocmVhZChiaW5kKCZTY3Jv bGxpbmdDb29yZGluYXRvcjo6aGFuZGxlV2hlZWxFdmVudFBoYXNlLCBtX3Njcm9sbGluZ0Nvb3Jk aW5hdG9yLmdldCgpLCBwaGFzZSkpOworICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChiaW5k KCZTY3JvbGxpbmdDb29yZGluYXRvcjo6aGFuZGxlV2hlZWxFdmVudFBoYXNlLCBtX3Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmdldCgpLCBwaGFzZSkpOwogfQogI2VuZGlmCiAK