138255 2014-10-31 11:12:49 -0700 Make writes to RegExpObject.lastIndex cacheable. 2014-10-31 12:28:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling barraclough commit-queue ggaren kling oldest_to_newest 1045312 0 kling 2014-10-31 11:12:49 -0700 We're not caching writes to RegExpObject.lastIndex. Let's try doing that. 1045313 1 240745 kling 2014-10-31 11:13:39 -0700 Created attachment 240745 Patch 1045325 2 240745 ggaren 2014-10-31 11:33:47 -0700 Comment on attachment 240745 Patch IC is nice. It's probably even nicer just to make lastIndex a vanilla JS property. 1045334 3 kling 2014-10-31 11:50:01 -0700 (In reply to comment #2) > Comment on attachment 240745 [details] > Patch > > IC is nice. It's probably even nicer just to make lastIndex a vanilla JS > property. Yeah. I'll land this, but let's talk about that. 1045345 4 240745 commit-queue 2014-10-31 12:28:09 -0700 Comment on attachment 240745 Patch Clearing flags on attachment: 240745 Committed r175416: <http://trac.webkit.org/changeset/175416> 1045346 5 commit-queue 2014-10-31 12:28:12 -0700 All reviewed patches have been landed. Closing bug. 240745 2014-10-31 11:13:39 -0700 2014-10-31 12:28:09 -0700 Patch bug-138255.diff text/plain 2298 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDJmNjAwMTcuLmM3ODIyZTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTEwLTMxICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHdyaXRlcyB0byBSZWdFeHBPYmpl Y3QubGFzdEluZGV4IGNhY2hlYWJsZS4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEz ODI1NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZSB3ZXJlIG5lZ2xlY3RpbmcgdG8gSUMgdGhlIHB1dHMgdG8gUmVnRXhwT2JqZWN0Lmxhc3RJbmRl eCBvbiBPY3RhbmUvcmVnZXhwLAorICAgICAgICBhbmQgZW5kZWQgdXAgc3BlbmRpbmcgNC41JSBv ZiBhIHRpbWUgcHJvZmlsZSBpbiBvcGVyYXRpb25QdXRCeUlkTm9uU3RyaWN0LgorCisgICAgICAg IH4zJSBwcm9ncmVzc2lvbiBvbiBPY3RhbmUvcmVnZXhwLgorCisgICAgICAgICogcnVudGltZS9S ZWdFeHBPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpyZWdFeHBPYmplY3RTZXRMYXN0SW5kZXhT dHJpY3QpOgorICAgICAgICAoSlNDOjpyZWdFeHBPYmplY3RTZXRMYXN0SW5kZXhOb25TdHJpY3Qp OgorICAgICAgICAoSlNDOjpSZWdFeHBPYmplY3Q6OnB1dCk6CisKIDIwMTQtMTAtMzAgIERhbmEg QnVya2FydCAgPGRidXJrYXJ0QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTg4MjEyNjA+IFByZXBhcmUgZm9yIHRoZSBteXN0ZXJpb3VzIGZ1dHVyZQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE9iamVjdC5jcHAKaW5kZXggNWI5MWFjMi4uNWY0 ZTc2ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2Jq ZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3Qu Y3BwCkBAIC0yOTAsMTAgKzI5MCwyMyBAQCBFbmNvZGVkSlNWYWx1ZSByZWdFeHBPYmplY3RTb3Vy Y2UoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCogc2xvdEJhc2UsIEVuY29kZWRKUwogICAgIHJl dHVybiBKU1ZhbHVlOjplbmNvZGUocmVnRXhwT2JqZWN0U291cmNlSW50ZXJuYWwoZXhlYywgcGF0 dGVybiwgcGF0dGVybi5jaGFyYWN0ZXJzMTYoKSwgcGF0dGVybi5sZW5ndGgoKSkpOwogfQogCitz dGF0aWMgdm9pZCByZWdFeHBPYmplY3RTZXRMYXN0SW5kZXhTdHJpY3QoRXhlY1N0YXRlKiBleGVj LCBKU09iamVjdCogc2xvdEJhc2UsIEVuY29kZWRKU1ZhbHVlLCBFbmNvZGVkSlNWYWx1ZSB2YWx1 ZSkKK3sKKyAgICBhc1JlZ0V4cE9iamVjdChzbG90QmFzZSktPnNldExhc3RJbmRleChleGVjLCBK U1ZhbHVlOjpkZWNvZGUodmFsdWUpLCB0cnVlKTsKK30KKworc3RhdGljIHZvaWQgcmVnRXhwT2Jq ZWN0U2V0TGFzdEluZGV4Tm9uU3RyaWN0KEV4ZWNTdGF0ZSogZXhlYywgSlNPYmplY3QqIHNsb3RC YXNlLCBFbmNvZGVkSlNWYWx1ZSwgRW5jb2RlZEpTVmFsdWUgdmFsdWUpCit7CisgICAgYXNSZWdF eHBPYmplY3Qoc2xvdEJhc2UpLT5zZXRMYXN0SW5kZXgoZXhlYywgSlNWYWx1ZTo6ZGVjb2RlKHZh bHVlKSwgZmFsc2UpOworfQorCiB2b2lkIFJlZ0V4cE9iamVjdDo6cHV0KEpTQ2VsbCogY2VsbCwg RXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBKU1ZhbHVlIHZhbHVl LCBQdXRQcm9wZXJ0eVNsb3QmIHNsb3QpCiB7CiAgICAgaWYgKHByb3BlcnR5TmFtZSA9PSBleGVj LT5wcm9wZXJ0eU5hbWVzKCkubGFzdEluZGV4KSB7CiAgICAgICAgIGFzUmVnRXhwT2JqZWN0KGNl bGwpLT5zZXRMYXN0SW5kZXgoZXhlYywgdmFsdWUsIHNsb3QuaXNTdHJpY3RNb2RlKCkpOworICAg ICAgICBzbG90LnNldEN1c3RvbVByb3BlcnR5KGFzUmVnRXhwT2JqZWN0KGNlbGwpLCBzbG90Lmlz U3RyaWN0TW9kZSgpCisgICAgICAgICAgICA/IHJlZ0V4cE9iamVjdFNldExhc3RJbmRleFN0cmlj dAorICAgICAgICAgICAgOiByZWdFeHBPYmplY3RTZXRMYXN0SW5kZXhOb25TdHJpY3QpOwogICAg ICAgICByZXR1cm47CiAgICAgfQogICAgIEJhc2U6OnB1dChjZWxsLCBleGVjLCBwcm9wZXJ0eU5h bWUsIHZhbHVlLCBzbG90KTsK