138249 2014-10-31 07:54:42 -0700 Clean-up use of boolean attributes in media tests 2014-10-31 11:29:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson buildbot commit-queue glenn jer.noble philipj rniwa sergio oldest_to_newest 1045273 0 eric.carlson 2014-10-31 07:54:42 -0700 The value of a boolean attribute is not considered, so cleanup tests that include them. 1045274 1 240734 eric.carlson 2014-10-31 08:01:04 -0700 Created attachment 240734 Proposed patch 1045300 2 240734 bfulgham 2014-10-31 10:49:18 -0700 Comment on attachment 240734 Proposed patch r=me. 1045320 3 240734 commit-queue 2014-10-31 11:28:56 -0700 Comment on attachment 240734 Proposed patch Clearing flags on attachment: 240734 Committed r175412: <http://trac.webkit.org/changeset/175412> 1045321 4 commit-queue 2014-10-31 11:29:00 -0700 All reviewed patches have been landed. Closing bug. 240734 2014-10-31 08:01:04 -0700 2014-10-31 11:28:56 -0700 Proposed patch patch_1.txt text/plain 3412 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3NTQwOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEwLTMxICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENsZWFuLXVwIHVzZSBvZiBib29sZWFu IGF0dHJpYnV0ZXMgaW4gbWVkaWEgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzODI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogbWVkaWEvcmVzb3VyY2VzL2ZvcmVpZ25vYmplY3QtbWVkaWEu c3ZnOiBhdXRvcGxheT0idHJ1ZSIgPT4gYXV0b3BsYXkKKyAgICAgICAgKiBtZWRpYS9yZXNvdXJj ZXMvdmlkZW8td2l0aC1wb3N0ZXItYXMtb2JqZWN0LWZhbGxiYWNrLmh0bWw6ICBjb250cm9scz0i dHJ1ZSIgPT4gY29udHJvbHMKKyAgICAgICAgKiBtZWRpYS92aWRlby1jYW52YXMtc291cmNlLmh0 bWw6IERpdHRvLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNhbnZhcy5odG1sLWRpc2FibGVkOiBE aXR0by4KKwogMjAxNC0xMC0zMSAgQW5kcnplaiBCYWRvd3NraSAgPGEuYmFkb3dza2lAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgW0FUS10gSW1wcm92ZSBBY2Nlc3NpYmlsaXR5VGFibGVDZWxsJ3Mg ZGV0ZXJtaW5lQWNjZXNzaWJpbGl0eVJvbGUgZnVuY3Rpb24uCkluZGV4OiBMYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1jYW52YXMtc291cmNlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tY2FudmFzLXNvdXJjZS5odG1sCShyZXZpc2lvbiAxNzUyMTcpCisrKyBMYXlv dXRUZXN0cy9tZWRpYS92aWRlby1jYW52YXMtc291cmNlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTM3LDcgKzM3LDcgQEAKIAogICAgIDxib2R5IG9ubG9hZD0ic3RhcnQoKSIgPgogICAgICAgICA8 cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KLSAgICAgICAgPHZpZGVvIGNvbnRyb2xzPSJ0cnVlIj48 L3ZpZGVvPgorICAgICAgICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KICAgICAgICAgPGNhbnZh cyB3aWR0aD0iMTYwIiBoZWlnaHQ9IjEyMCIgPjwvY2FudmFzPgogICAgICAgICA8ZGl2IGlkPSJj b25zb2xlIj48L2Rpdj4KICAgICA8L2JvZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRl by1jYW52YXMuaHRtbC1kaXNhYmxlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92 aWRlby1jYW52YXMuaHRtbC1kaXNhYmxlZAkocmV2aXNpb24gMTc1MjE3KQorKysgTGF5b3V0VGVz dHMvbWVkaWEvdmlkZW8tY2FudmFzLmh0bWwtZGlzYWJsZWQJKHdvcmtpbmcgY29weSkKQEAgLTc1 LDcgKzc1LDcgQEAKICAgICA8Ym9keSBvbmxvYWQ9InN0YXJ0KCkiID4KIAogICAgIDxkaXY+Ci0g ICAgICAgIDx2aWRlbyBjb250cm9scz0idHJ1ZSI+PC92aWRlbz4KKyAgICAgICAgPHZpZGVvIGNv bnRyb2xzPjwvdmlkZW8+CiAgICAgICAgIDxjYW52YXMgd2lkdGg9IjE2MCIgaGVpZ2h0PSIxMjAi ID48L2NhbnZhcz4KICAgICA8L2Rpdj4KIApJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvcmVzb3Vy Y2VzL2ZvcmVpZ25vYmplY3QtbWVkaWEuc3ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21l ZGlhL3Jlc291cmNlcy9mb3JlaWdub2JqZWN0LW1lZGlhLnN2ZwkocmV2aXNpb24gMTc1MjE3KQor KysgTGF5b3V0VGVzdHMvbWVkaWEvcmVzb3VyY2VzL2ZvcmVpZ25vYmplY3QtbWVkaWEuc3ZnCSh3 b3JraW5nIGNvcHkpCkBAIC0yLDkgKzIsOSBAQAogICA8cmVjdCB4PSIwIiB5PSIwIiB3aWR0aD0i MzIwcHgiIGhlaWdodD0iNDgwcHgiIHN0eWxlPSJmaWxsOmdyZWVuIi8+CiAgIDxmb3JlaWduT2Jq ZWN0IHg9IjAiIHk9IjAiIHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiPgogICAgIDxib2R5IHht bG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KLQkJPHZpZGVvIHNyYz0idGVzdC5t cDQiIGF1dG9wbGF5PSJ0cnVlIiB3aWR0aD0iMzIwcHgiIGhlaWdodD0iMjQwcHgiPjwvdmlkZW8+ IAotCQk8YXVkaW8gc3JjPSJ0ZXN0Lm9nYSIgYXV0b3BsYXk9InRydWUiPjwvYXVkaW8+IAotCQk8 dmlkZW8gYXV0b3BsYXk9InRydWUiIHdpZHRoPSIzMjBweCIgaGVpZ2h0PSIyNDBweCI+CisJCTx2 aWRlbyBzcmM9InRlc3QubXA0IiBhdXRvcGxheSB3aWR0aD0iMzIwcHgiIGhlaWdodD0iMjQwcHgi PjwvdmlkZW8+IAorCQk8YXVkaW8gc3JjPSJ0ZXN0Lm9nYSIgYXV0b3BsYXk+PC9hdWRpbz4gCisJ CTx2aWRlbyBhdXRvcGxheSB3aWR0aD0iMzIwcHgiIGhlaWdodD0iMjQwcHgiPgogCQkJPHNvdXJj ZSBzcmM9J3Rlc3Qub2d2JyAvPgogCQkJPHNvdXJjZSBzcmM9J3Rlc3QubXA0JyAvPgogCQk8L3Zp ZGVvPgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvcmVzb3VyY2VzL3ZpZGVvLXdpdGgtcG9zdGVy LWFzLW9iamVjdC1mYWxsYmFjay5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlh L3Jlc291cmNlcy92aWRlby13aXRoLXBvc3Rlci1hcy1vYmplY3QtZmFsbGJhY2suaHRtbAkocmV2 aXNpb24gMTc1MjE3KQorKysgTGF5b3V0VGVzdHMvbWVkaWEvcmVzb3VyY2VzL3ZpZGVvLXdpdGgt cG9zdGVyLWFzLW9iamVjdC1mYWxsYmFjay5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEs NyBAQAogPHNjcmlwdCBzcmM9Ii4uL21lZGlhLWZpbGUuanMiPjwvc2NyaXB0PgogPGJvZHkgb25s b2FkPSJvcGVuZXIuY2hpbGRMb2FkZWQoKSI+CiA8b2JqZWN0IGhlaWdodD0iNTAwIiB3aWR0aD0i NTAwIj4KLTx2aWRlbyBpZD0idGhlVmlkZW8iIGNvbnRyb2xzPSJjb250cm9scyIgcG9zdGVyPSIu Li9jb250ZW50L2FiZS5wbmciIHByZWxvYWQ9ImF1dG8iPgorPHZpZGVvIGlkPSJ0aGVWaWRlbyIg Y29udHJvbHMgcG9zdGVyPSIuLi9jb250ZW50L2FiZS5wbmciIHByZWxvYWQ9ImF1dG8iPgogPC92 aWRlbz4KIDxzY3JpcHQ+CiBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGhlVmlkZW8iKS5zcmMg PSBmaW5kTWVkaWFGaWxlKCd2aWRlbycsICcuLi9jb250ZW50L2NvdW50aW5nJyk7Cg==