138248 2014-10-31 07:13:04 -0700 Type clash warnings in CSSGrammar.y 2014-10-31 12:11:03 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned commit-queue darin koivisto simon.fraser oldest_to_newest 1045270 0 akiss 2014-10-31 07:13:04 -0700 When building WebKit (release, for x86-64/Linux/GTK, but actually there is/should be nothing platform or port-specific in the issue), bison is emitting the following warnings: [190/4820] Generating ../../DerivedSources/WebCore/CSSGrammar.h, ../../DerivedSources/WebCore/CSSGrammar.cpp /home/akiss/devel/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:576.17-25: warning: type clash on default action: <boolean> != <> [-Wother] supports_error: error ';' | error invalid_block ; ^^^^^^^^^ /home/akiss/devel/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:576.29-47: warning: type clash on default action: <boolean> != <> [-Wother] supports_error: error ';' | error invalid_block ; ^^^^^^^^^^^^^^^^^^^ Actually, this causes no issues when running the generated code but it would be cleaner to get rid of the warnings and make bison happy, IMHO. 1045271 1 240733 akiss 2014-10-31 07:19:33 -0700 Created attachment 240733 Proposed patch. Caused no regression. 1045342 2 240733 commit-queue 2014-10-31 12:10:58 -0700 Comment on attachment 240733 Proposed patch. Clearing flags on attachment: 240733 Committed r175415: <http://trac.webkit.org/changeset/175415> 1045343 3 commit-queue 2014-10-31 12:11:03 -0700 All reviewed patches have been landed. Closing bug. 240733 2014-10-31 07:19:33 -0700 2014-10-31 12:10:58 -0700 Proposed patch. css-warning-fix-v1.patch text/plain 1223 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MGQ4NjhmLi45ZTQwNmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMTAtMzEgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KKworICAg ICAgICBGaXggdHlwZSBjbGFzaCB3YXJuaW5nIGluIHN1cHBvcnRzX2Vycm9yIHJ1bGUgb2YgQ1NT R3JhbW1hci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzODI0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGVkIGV4cGxpY2l0IGFjdGlvbnMgdG8gc3VwcG9ydHNfZXJyb3IgcnVsZSBpbiBDU1NHcmFt bWFyLnkuaW4gc2luY2UKKyAgICAgICAgdGhlIGRlZmF1bHQgYWN0aW9ucyBjYXVzZWQgYmlzb24g dG8gZW1pdCB0eXBlIGNsYXNoIHdhcm5pbmdzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNh dXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNzcy9DU1NHcmFt bWFyLnkuaW46CisKIDIwMTQtMTAtMzAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIEVsaW1pbmF0ZSBSZXNvdXJjZUJ1ZmZlciBhbmQgdXNlIFNoYXJlZEJ1ZmZlciBk aXJlY3RseSBpbnN0ZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1h ci55LmluIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgppbmRleCAzMDhhMDFh Li5jOGJkZDk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55Lmlu CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4KQEAgLTcyNSw3ICs3MjUs MTQgQEAgc3VwcG9ydHM6CiAgICAgfQogICAgIDsKIAotc3VwcG9ydHNfZXJyb3I6IGVycm9yICc7 JyB8IGVycm9yIGludmFsaWRfYmxvY2sgOworc3VwcG9ydHNfZXJyb3I6IAorICAgIGVycm9yICc7 JyB7CisgICAgICAgICQkID0gZmFsc2U7CisgICAgfQorICAgIHwgZXJyb3IgaW52YWxpZF9ibG9j ayB7CisgICAgICAgICQkID0gZmFsc2U7CisgICAgfQorICAgIDsKIAogYmVmb3JlX3N1cHBvcnRz X3J1bGU6CiAgICAgLyogZW1wdHkgKi8gewo=