138246 2014-10-31 04:09:46 -0700 REGRESSION(r163656): Remote inspector doesn't work unless preferences change after page initialization 2014-11-01 02:59:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 1 cgarcia webkit-unassigned andersca ap joepeck thorton oldest_to_newest 1045259 0 cgarcia 2014-10-31 04:09:46 -0700 The problem is that initializeWebPage() is still using pageGroup().preferences() instead of m_preferences to check if developer extras are enabled to enable remote inspection of the page. 1045260 1 240731 cgarcia 2014-10-31 04:12:20 -0700 Created attachment 240731 Patch 1045338 2 240731 joepeck 2014-10-31 12:01:33 -0700 Comment on attachment 240731 Patch r=me 1045505 3 cgarcia 2014-11-01 02:59:13 -0700 Committed r175451: <http://trac.webkit.org/changeset/175451> 240731 2014-10-31 04:12:20 -0700 2014-10-31 12:01:33 -0700 Patch wk2-remote-inspector.diff text/plain 1440 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMDc1ZDIzLi5lODI4ZjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMTAtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2MzY1Nik6IFJlbW90ZSBpbnNwZWN0b3IgZG9lc24n dCB3b3JrIHVubGVzcyBwcmVmZXJlbmNlcyBjaGFuZ2UgYWZ0ZXIgcGFnZSBpbml0aWFsaXphdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MjQ2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBy b2JsZW0gaXMgdGhhdCBpbml0aWFsaXplV2ViUGFnZSgpIGlzIHN0aWxsIHVzaW5nCisgICAgICAg IHBhZ2VHcm91cCgpLnByZWZlcmVuY2VzKCkgaW5zdGVhZCBvZiBtX3ByZWZlcmVuY2VzIHRvIGNo ZWNrIGlmCisgICAgICAgIGRldmVsb3BlciBleHRyYXMgYXJlIGVuYWJsZWQgdG8gZW5hYmxlIHJl bW90ZSBpbnNwZWN0aW9uIG9mIHRoZSBwYWdlLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZVdl YlBhZ2UpOiBVc2UgbV9wcmVmZXJlbmNlcworICAgICAgICBpbnN0ZWFkIG9mIHBhZ2VHcm91cCgp LnByZWZlcmVuY2VzKCkuCisKIDIwMTQtMTAtMjggIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxh cGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTdXBwb3J0IHNjcmlwdCBtZXNzYWdl IGhhbmRsZXJzIFdlYktpdFVzZXJDb250ZW50TWFuYWdlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA0NDgwMTczLi4wYmMyYjczIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNjM5LDcgKzYzOSw3IEBAIHZvaWQg V2ViUGFnZVByb3h5Ojppbml0aWFsaXplV2ViUGFnZSgpCiAjZW5kaWYKIAogI2lmIEVOQUJMRShJ TlNQRUNUT1JfU0VSVkVSKQotICAgIGlmIChwYWdlR3JvdXAoKS5wcmVmZXJlbmNlcygpLmRldmVs b3BlckV4dHJhc0VuYWJsZWQoKSkKKyAgICBpZiAobV9wcmVmZXJlbmNlcy0+ZGV2ZWxvcGVyRXh0 cmFzRW5hYmxlZCgpKQogICAgICAgICBpbnNwZWN0b3IoKS0+ZW5hYmxlUmVtb3RlSW5zcGVjdGlv bigpOwogI2VuZGlmCiAK