138241 2014-10-30 23:24:16 -0700 AX:setSelectedRows loop is incorrect -- ignores the count 2016-09-05 01:22:27 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All NEW InRadar P2 Normal --- 1 cfleizach mdaiter aboxhall apinheiro cdumez commit-queue dmazzoni jcraig jdiggs joepeck mario mdaiter samuel_white webkit-bug-importer oldest_to_newest 1045236 0 cfleizach 2014-10-30 23:24:16 -0700 From: https://bugs.webkit.org/show_bug.cgi?id=126915#c12 > >> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1650 > >> + for (const auto& selectedRow : selectedRows) > > > > I don't believe this change is correct. It ignores the count variable that is set above depending on isMultiSelectable() so I am assuming we can now select more than 1 row even if it is not multiSelectable. > > I think you're right too This was reported by clang static analyzer. Would you mind making the fix? I don't feel like writing the layout test for this :) 1045237 1 webkit-bug-importer 2014-10-30 23:24:24 -0700 <rdar://problem/18834530> 1045239 2 webkit-bug-importer 2014-10-30 23:25:14 -0700 <rdar://problem/18834534> 1113875 3 257963 mdaiter 2015-07-31 14:59:00 -0700 Created attachment 257963 Patch 1113893 4 mdaiter 2015-07-31 15:23:42 -0700 Is this what you were trying to do? 1121381 5 257963 cfleizach 2015-08-27 11:36:29 -0700 Comment on attachment 257963 Patch is it possible to add a layout test? thanks 1226388 6 257963 joepeck 2016-09-05 01:19:47 -0700 Comment on attachment 257963 Patch This issue still exists because this never landed. The static analyzer warning still exists. This never landed because there was no test. Any ideas on how to write one? 1226389 7 257963 cfleizach 2016-09-05 01:22:27 -0700 Comment on attachment 257963 Patch I think a layout test would try to use the accessibility setSelectedRows method with more than 1 item on a non-multi-selectable selection box, then verify that only one row is selected. 257963 2015-07-31 14:59:00 -0700 2015-08-27 11:36:29 -0700 Patch bug-138241-20150731145858.patch text/plain 1563 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM2MzZlNGFlZjRhNzJl MzFlZDMzODRiZDQyMGE1YzQ3MThhNTk5Ni4uZjA2ZGI1ZDllNjJhNGUzMzFmMzcyMTU3OTM1NDk1 ZmJiZmQ3MGM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTMxICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeGVkIHNldFNlbGVj dGVkUm93cyBmdW5jdGlvbiBmb3Igc2luZ2xlIHNlbGVjdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MjQxCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xODgzNDUzMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzZXRTZWxlY3RlZFJvd3Mp OgorCiAyMDE1LTA3LTMxICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBIYXZlIERhdGFPYmplY3RHdGs6OnVua25vd25UeXBlcygpIHJldHVybiBh IHJlZmVyZW5jZSB0byB0aGUgSGFzaE1hcCBvYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCmluZGV4 IDEzYjcyMTlmNThhZGMwOTJiNDI4YzliNzgzZWZjMmJmMTBmNmMxYTAuLmM4NTM1ZmJlNTNiODg0 Yzc4ZGNiZjIyMDFmZmY4MjdkYTU5ZmRhY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApAQCAtMTcw Niw4ICsxNzA2LDExIEBAIHZvaWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c2V0U2VsZWN0 ZWRSb3dzKEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgc2VsCiAgICAgaWYgKGNvdW50ID4g MSAmJiAhaXNNdWx0aSkKICAgICAgICAgY291bnQgPSAxOwogICAgIAotICAgIGZvciAoY29uc3Qg YXV0byYgc2VsZWN0ZWRSb3cgOiBzZWxlY3RlZFJvd3MpCisgICAgZm9yIChjb25zdCBhdXRvJiBz ZWxlY3RlZFJvdyA6IHNlbGVjdGVkUm93cykgewogICAgICAgICBzZWxlY3RlZFJvdy0+c2V0U2Vs ZWN0ZWQodHJ1ZSk7CisgICAgICAgIGlmIChjb3VudCA9PSAxKQorICAgICAgICAgICAgYnJlYWs7 CisgICAgfQogfQogICAgIAogdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzZXRWYWx1 ZShjb25zdCBTdHJpbmcmIHN0cmluZykK