138240 2014-10-30 22:50:17 -0700 Fix a couple of warnings in JSC reported by clang static analyzer 2014-10-31 10:37:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue fpizlo ggaren oliver oldest_to_newest 1045229 0 cdumez 2014-10-30 22:50:17 -0700 Fix a couple of warnings in JSC reported by clang static analyzer, about useless variable assignment / variable scope. 1045230 1 240725 cdumez 2014-10-30 22:53:33 -0700 Created attachment 240725 Patch 1045231 2 cdumez 2014-10-30 22:55:38 -0700 The static analyzer also found https://bugs.webkit.org/show_bug.cgi?id=136869#c26 but I'll let someone else fix that one as I am not sure what was Oliver's intent. 1045285 3 240725 ggaren 2014-10-31 09:59:10 -0700 Comment on attachment 240725 Patch r=me 1045297 4 240725 commit-queue 2014-10-31 10:37:21 -0700 Comment on attachment 240725 Patch Clearing flags on attachment: 240725 Committed r175411: <http://trac.webkit.org/changeset/175411> 1045298 5 commit-queue 2014-10-31 10:37:26 -0700 All reviewed patches have been landed. Closing bug. 240725 2014-10-30 22:53:33 -0700 2014-10-31 10:37:21 -0700 Patch bug-138240-20141030225342.patch text/plain 3210 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZjYwMDE3MDAwYmMyMzczOTFjMTlmOTQwODI0MWE2ZTBkOTk2ZmU0Li45NWJjMjMxN2E0OWU5NGQ4 Njc5ZjkyOGYzN2M5NzZiNDc1Y2NjZDI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0xMC0zMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBhIGNvdXBsZSBvZiB3YXJuaW5ncyBpbiBKU0MgcmVwb3J0ZWQgYnkgY2xh bmcgc3RhdGljIGFuYWx5emVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzgyNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggYSBjb3VwbGUgb2Ygd2FybmluZ3MgaW4gSlNDIHJlcG9ydGVkIGJ5IGNs YW5nIHN0YXRpYyBhbmFseXplciBhYm91dAorICAgICAgICB2YWx1ZSBzdG9yZWQgaW4gdmFyaWFi bGVzIG5ldmVyIGJlaW5nIHJlYWQuIFRoaXMgaXMgYWRkcmVzc2VkIGJ5CisgICAgICAgIHJlZHVj aW5nIHRoZSBzY29wZSBvZiB0aGUgdmFyaWFibGUgb3IgcmVtb3ZpbmcgdGhlIHZhcmlhYmxlIGVu dGlyZWx5LgorCisgICAgICAgICogZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpDb25zdGFudEZvbGRpbmdQaGFzZTo6ZW1pdEdldEJ5T2Zmc2V0KToK KyAgICAgICAgKiBydW50aW1lL1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OnRocm93RXhjZXB0 aW9uKToKKwogMjAxNC0xMC0zMCAgRGFuYSBCdXJrYXJ0ICA8ZGJ1cmthcnRAYXBwbGUuY29tPgog CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODgyMTI2MD4gUHJlcGFyZSBmb3IgdGhlIG15c3Rl cmlvdXMgZnV0dXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nv bnN0YW50Rm9sZGluZ1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29u c3RhbnRGb2xkaW5nUGhhc2UuY3BwCmluZGV4IDIwMGI2ZmI1OTcyNTg4NGQ5NzcxOTc4YWY3NjY1 OWIzMjljYTNmMDcuLjYzMGYzMGNkMjk0NzljMzc2NTc3YjEzOWQ5NzI1MzJkZjNhNjAxMzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhh c2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5n UGhhc2UuY3BwCkBAIC00OTIsNyArNDkyLDYgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgICAgIE5v ZGVPcmlnaW4gb3JpZ2luID0gbm9kZS0+b3JpZ2luOwogICAgICAgICBFZGdlIGNoaWxkRWRnZSA9 IG5vZGUtPmNoaWxkMSgpOwotICAgICAgICBOb2RlKiBjaGlsZCA9IGNoaWxkRWRnZS5ub2RlKCk7 CiAKICAgICAgICAgYWRkQmFzZUNoZWNrKGluZGV4SW5CbG9jaywgbm9kZSwgYmFzZVZhbHVlLCB2 YXJpYW50LnN0cnVjdHVyZVNldCgpKTsKICAgICAgICAgCkBAIC01MDcsNyArNTA2LDcgQEAgcHJp dmF0ZToKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgaWYgKHZhcmlhbnQuYWx0ZXJuYXRl QmFzZSgpKSB7Ci0gICAgICAgICAgICBjaGlsZCA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydENvbnN0 YW50KGluZGV4SW5CbG9jaywgb3JpZ2luLCB2YXJpYW50LmFsdGVybmF0ZUJhc2UoKSk7CisgICAg ICAgICAgICBOb2RlKiBjaGlsZCA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydENvbnN0YW50KGluZGV4 SW5CbG9jaywgb3JpZ2luLCB2YXJpYW50LmFsdGVybmF0ZUJhc2UoKSk7CiAgICAgICAgICAgICBj aGlsZEVkZ2UgPSBFZGdlKGNoaWxkLCBLbm93bkNlbGxVc2UpOwogICAgICAgICB9IGVsc2UKICAg ICAgICAgICAgIGNoaWxkRWRnZS5zZXRVc2VLaW5kKEtub3duQ2VsbFVzZSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9WTS5jcHAKaW5kZXggODY2NDVjZTczNzMyMjBmZTI0ZmVkZDZjZGI5Y2Q2 YzA0ZTM3ZWI2Yy4uMWRmMTllYTY0OTExNjgzODgwMDM5ZjJiMTUwYmJhOWY2NjgzNmFkOCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcApAQCAtNjYwLDcgKzY2MCw2IEBAIEpTVmFs dWUgVk06OnRocm93RXhjZXB0aW9uKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSBlcnJvcikKICAg ICAgICAgaWYgKHN0YWNrRnJhbWUuYnl0ZWNvZGVPZmZzZXQpCiAgICAgICAgICAgICBicmVhazsK ICAgICB9Ci0gICAgdW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQgPSBzdGFja0ZyYW1lLmJ5dGVjb2Rl T2Zmc2V0OwogICAgIGlmICghaGFzRXJyb3JJbmZvKGV4ZWMsIGV4Y2VwdGlvbikpIHsKICAgICAg ICAgLy8gRklYTUU6IFdlIHNob3VsZCBvbmx5IHJlYWxseSBiZSBhZGRpbmcgdGhlc2UgcHJvcGVy dGllcyB0byBWTSBnZW5lcmF0ZWQgZXhjZXB0aW9ucywKICAgICAgICAgLy8gYnV0IHRoZSBpbnNw ZWN0b3IgY3VycmVudGx5IHJlcXVpcmVzIHRoZXNlIGZvciBhbGwgdGhyb3duIG9iamVjdHMuCkBA IC02ODAsOCArNjc5LDcgQEAgSlNWYWx1ZSBWTTo6dGhyb3dFeGNlcHRpb24oRXhlY1N0YXRlKiBl eGVjLCBKU1ZhbHVlIGVycm9yKQogCiAgICAgICAgIGlmIChjYWxsRnJhbWUgJiYgY2FsbEZyYW1l LT5jb2RlQmxvY2soKSkgewogICAgICAgICAgICAgc3RhY2tGcmFtZSA9IHN0YWNrVHJhY2UuYXQo c3RhY2tJbmRleCk7Ci0gICAgICAgICAgICBieXRlY29kZU9mZnNldCA9IHN0YWNrRnJhbWUuYnl0 ZWNvZGVPZmZzZXQ7Ci0gICAgICAgICAgICBhcHBlbmRTb3VyY2VUb0Vycm9yKGNhbGxGcmFtZSwg c3RhdGljX2Nhc3Q8RXJyb3JJbnN0YW5jZSo+KGV4Y2VwdGlvbiksIGJ5dGVjb2RlT2Zmc2V0KTsK KyAgICAgICAgICAgIGFwcGVuZFNvdXJjZVRvRXJyb3IoY2FsbEZyYW1lLCBzdGF0aWNfY2FzdDxF cnJvckluc3RhbmNlKj4oZXhjZXB0aW9uKSwgc3RhY2tGcmFtZS5ieXRlY29kZU9mZnNldCk7CiAg ICAgICAgIH0KICAgICB9CiAK