138231 2014-10-30 14:22:45 -0700 Use references in calculateMinimumPageHeight() for non-optional arguments 2014-10-30 14:39:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino esprehn+autocc glenn hyatt jonlee kondapallykalyan simon.fraser thorton oldest_to_newest 1045118 0 mmaxfield 2014-10-30 14:22:45 -0700 Use references in calculateMinimumPageHeight() for non-optional arguments 1045121 1 240698 mmaxfield 2014-10-30 14:23:46 -0700 Created attachment 240698 Patch 1045135 2 mmaxfield 2014-10-30 14:39:51 -0700 https://trac.webkit.org/r175383 240698 2014-10-30 14:23:46 -0700 2014-10-30 14:33:44 -0700 Patch bug-138231-20141030142354.patch text/plain 3079 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Mzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE1OTAyNzkxZDM1MmYz ZThlNjZiN2E3MmY1M2FmNzRhYjM0ZWUxZC4uMWZiNTFjOTExMWQyMjE0MGVlZWJjMWYxNDU0NWRh NTk1NzYxNTNmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTEwLTMwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIHJlZmVy ZW5jZXMgaW4gY2FsY3VsYXRlTWluaW11bVBhZ2VIZWlnaHQoKSBmb3Igbm9uLW9wdGlvbmFsIGFy Z3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM4MjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpj YWxjdWxhdGVNaW5pbXVtUGFnZUhlaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9j a0Zsb3c6OmFkanVzdExpbmVQb3NpdGlvbkZvclBhZ2luYXRpb24pOgorCisyMDE0LTEwLTMwICBN eWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKICAgICAgICAgTWlncmF0 ZSBDb21wbGV4VGV4dENvbnRyb2xsZXJDb3JlVGV4dCB0byB1c2UgU1BJIGluc3RlYWQgb2YgV0tT SQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MjI4 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXgg MDQxYWNmNzA2YTRhZDlhNTY4OTY3ZmJiMzJjYjFlZGY0NzUzOTM5MC4uNmQ0OTM3MjQzYWE5OTRk YTI4MjYxZGQyNmVjOTYxMDNjMDk2MDgxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrRmxvdy5jcHAKQEAgLTE1ODgsMTMgKzE1ODgsMTMgQEAgTGF5b3V0VW5pdCBS ZW5kZXJCbG9ja0Zsb3c6OmFkanVzdEJsb2NrQ2hpbGRGb3JQYWdpbmF0aW9uKExheW91dFVuaXQg bG9naWNhbFRvcEEKICAgICByZXR1cm4gcmVzdWx0OwogfQogCi1zdGF0aWMgaW5saW5lIExheW91 dFVuaXQgY2FsY3VsYXRlTWluaW11bVBhZ2VIZWlnaHQoUmVuZGVyU3R5bGUqIHJlbmRlclN0eWxl LCBSb290SW5saW5lQm94KiBsYXN0TGluZSwgTGF5b3V0VW5pdCBsaW5lVG9wLCBMYXlvdXRVbml0 IGxpbmVCb3R0b20pCitzdGF0aWMgaW5saW5lIExheW91dFVuaXQgY2FsY3VsYXRlTWluaW11bVBh Z2VIZWlnaHQoUmVuZGVyU3R5bGUmIHJlbmRlclN0eWxlLCBSb290SW5saW5lQm94JiBsYXN0TGlu ZSwgTGF5b3V0VW5pdCBsaW5lVG9wLCBMYXlvdXRVbml0IGxpbmVCb3R0b20pCiB7CiAgICAgLy8g V2UgbWF5IHJlcXVpcmUgYSBjZXJ0YWluIG1pbmltdW0gbnVtYmVyIG9mIGxpbmVzIHBlciBwYWdl IGluIG9yZGVyIHRvIHNhdGlzZnkKICAgICAvLyBvcnBoYW5zIGFuZCB3aWRvd3MsIGFuZCB0aGF0 IG1heSBhZmZlY3QgdGhlIG1pbmltdW0gcGFnZSBoZWlnaHQuCi0gICAgdW5zaWduZWQgbGluZUNv dW50ID0gc3RkOjptYXg8dW5zaWduZWQ+KHJlbmRlclN0eWxlLT5oYXNBdXRvT3JwaGFucygpID8g MSA6IHJlbmRlclN0eWxlLT5vcnBoYW5zKCksIHJlbmRlclN0eWxlLT5oYXNBdXRvV2lkb3dzKCkg PyAxIDogcmVuZGVyU3R5bGUtPndpZG93cygpKTsKKyAgICB1bnNpZ25lZCBsaW5lQ291bnQgPSBz dGQ6Om1heDx1bnNpZ25lZD4ocmVuZGVyU3R5bGUuaGFzQXV0b09ycGhhbnMoKSA/IDEgOiByZW5k ZXJTdHlsZS5vcnBoYW5zKCksIHJlbmRlclN0eWxlLmhhc0F1dG9XaWRvd3MoKSA/IDEgOiByZW5k ZXJTdHlsZS53aWRvd3MoKSk7CiAgICAgaWYgKGxpbmVDb3VudCA+IDEpIHsKLSAgICAgICAgUm9v dElubGluZUJveCogbGluZSA9IGxhc3RMaW5lOworICAgICAgICBSb290SW5saW5lQm94KiBsaW5l ID0gJmxhc3RMaW5lOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAxOyBpIDwgbGluZUNvdW50 ICYmIGxpbmUtPnByZXZSb290Qm94KCk7IGkrKykKICAgICAgICAgICAgIGxpbmUgPSBsaW5lLT5w cmV2Um9vdEJveCgpOwogCkBAIC0xNjMyLDcgKzE2MzIsNyBAQCB2b2lkIFJlbmRlckJsb2NrRmxv dzo6YWRqdXN0TGluZVBvc2l0aW9uRm9yUGFnaW5hdGlvbihSb290SW5saW5lQm94KiBsaW5lQm94 LCBMYQogICAgIExheW91dFVuaXQgbG9naWNhbE9mZnNldCA9IHN0ZDo6bWluKGxpbmVCb3gtPmxp bmVUb3BXaXRoTGVhZGluZygpLCBsb2dpY2FsVmlzdWFsT3ZlcmZsb3cueSgpKTsKICAgICBMYXlv dXRVbml0IGxvZ2ljYWxCb3R0b20gPSBzdGQ6Om1heChsaW5lQm94LT5saW5lQm90dG9tV2l0aExl YWRpbmcoKSwgbG9naWNhbFZpc3VhbE92ZXJmbG93Lm1heFkoKSk7CiAgICAgTGF5b3V0VW5pdCBs aW5lSGVpZ2h0ID0gbG9naWNhbEJvdHRvbSAtIGxvZ2ljYWxPZmZzZXQ7Ci0gICAgdXBkYXRlTWlu aW11bVBhZ2VIZWlnaHQobG9naWNhbE9mZnNldCwgY2FsY3VsYXRlTWluaW11bVBhZ2VIZWlnaHQo JnN0eWxlKCksIGxpbmVCb3gsIGxvZ2ljYWxPZmZzZXQsIGxvZ2ljYWxCb3R0b20pKTsKKyAgICB1 cGRhdGVNaW5pbXVtUGFnZUhlaWdodChsb2dpY2FsT2Zmc2V0LCBjYWxjdWxhdGVNaW5pbXVtUGFn ZUhlaWdodChzdHlsZSgpLCAqbGluZUJveCwgbG9naWNhbE9mZnNldCwgbG9naWNhbEJvdHRvbSkp OwogICAgIGxvZ2ljYWxPZmZzZXQgKz0gZGVsdGE7CiAgICAgbGluZUJveC0+c2V0UGFnaW5hdGlv blN0cnV0KDApOwogICAgIGxpbmVCb3gtPnNldElzRmlyc3RBZnRlclBhZ2VCcmVhayhmYWxzZSk7 Cg==