138225 2014-10-30 13:12:48 -0700 bisect-builds should support WebKit clients other than Safari 2014-11-05 10:39:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 matthew_hanson webkit-unassigned bshafiei ddkilzer webkit-bug-importer oldest_to_newest 1045094 0 matthew_hanson 2014-10-30 13:12:48 -0700 Currently bisect-builds only works with Safari. I propose that we add an argument that allows users to specify which application should be run against the nightly WebKit frameworks. 1045106 1 240693 matthew_hanson 2014-10-30 14:07:22 -0700 Created attachment 240693 Patch 1045107 2 webkit-bug-importer 2014-10-30 14:08:02 -0700 <rdar://problem/18829294> 1045176 3 240693 ddkilzer 2014-10-30 16:48:21 -0700 Comment on attachment 240693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240693&action=review r=me with comments addressed. > Tools/Scripts/bisect-builds:38 > -# $safariPath = "/path/to/Safari.app"; > +# $applicationPath = "/path/to/Application.app"; This should not change unless we're going to support $Settings::applicationPath and remove $Settings::safariPath. Or keep $safariPath and add $applicationPath here. # $safariPath = "/path/to/Safari.app"; + # $applicationPath = "/path/to/Application.app"; > Tools/Scripts/bisect-builds:73 > my $safariPath = $Settings::safariPath; > +my $applicationPath; I would expect this to be change to the following if we were supported in the ~/.bisect-buildsrc file: my $applicationPath = $Settings:: applicationPath; > Tools/Scripts/bisect-builds:430 > + # Check for both appliactions and application bundles. Typo: appliactions > Tools/Scripts/bisect-builds:436 > + push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $isBundle; Very nice. Should we only do this if $safariPath is set instead of $isBundle? push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $safariPath; Or does this work for multiple apps? 1045184 4 240693 matthew_hanson 2014-10-30 17:19:18 -0700 Comment on attachment 240693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240693&action=review Thanks for the review! >> Tools/Scripts/bisect-builds:38 >> +# $applicationPath = "/path/to/Application.app"; > > This should not change unless we're going to support $Settings::applicationPath and remove $Settings::safariPath. Or keep $safariPath and add $applicationPath here. > > # $safariPath = "/path/to/Safari.app"; > + # $applicationPath = "/path/to/Application.app"; I noticed this after sending out this patch. I'll keep it set to $safariPath here. This might be a good thing to change/add in a future patch. >> Tools/Scripts/bisect-builds:73 >> +my $applicationPath; > > I would expect this to be change to the following if we were supported in the ~/.bisect-buildsrc file: > > my $applicationPath = $Settings:: applicationPath; See above. >> Tools/Scripts/bisect-builds:436 >> + push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $isBundle; > > Very nice. Should we only do this if $safariPath is set instead of $isBundle? > > push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $safariPath; > > Or does this work for multiple apps? This works with multiple apps. I have tested it with Mail and iTunes so far, but I would expect it to work with others. 1045186 5 matthew_hanson 2014-10-30 17:26:54 -0700 Committed r175401: <http://trac.webkit.org/changeset/175401> 1046529 6 matthew_hanson 2014-11-05 10:39:21 -0800 *** Bug 137577 has been marked as a duplicate of this bug. *** 240693 2014-10-30 14:07:22 -0700 2014-10-30 16:48:21 -0700 Patch bug-138225-20141030140731.patch text/plain 6130 matthew_hanson U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Mzc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjE3NmI0MWRkNDBmOWE2MTE5NTY1YTRmZTFmYjMwMjhl NzI2YjdlNi4uZjNhY2E2OTgyZGEwMTc5NWE1YzE0MWZhNDI5OGJhNTI0YTJlYzQ0MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0 IEBACiAyMDE0LTEwLTMwICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRoZXdfaGFuc29uQGFwcGxlLmNv bT4KIAorICAgICAgICBiaXNlY3QtYnVpbGRzIHNob3VsZCBzdXBwb3J0IFdlYktpdCBjbGllbnRz IG90aGVyIHRoYW4gU2FmYXJpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzgyMjUKKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgc3VwcG9ydCBmb3Ig YmlzZWN0aW5nIFdlYktpdCBuaWdodGx5IGJ1aWxkcyB3aXRoIGNsaWVudHMgb3RoZXIgdGhhbiBT YWZhcmkuCisKKyAgICAgICAgVGhlIC1hIC8gLS1hcHBsaWNhdGlvbiBvcHRpb25hbCBhcmd1bWVu dCBhbGxvd3MgdGhlIHVzZXIgdG8gc3BlY2lmeSB3aGljaCBhcHBsaWNhdGlvbiAob3IgYXBwbGlj YXRpb24gYnVuZGxlKQorICAgICAgICBzaG91bGQgYmUgcnVuIGFnYWluc3QgdGhlIFdlYktpdCBu aWdodGx5IGJ1aWxkcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvYmlzZWN0LWJ1aWxkczoKKyAgICAgICAgU3dhcCBvdXQgJHNhZmFy aVBhdGggZm9yIHRoZSBtb3JlIGdlbmVyYWwgJGFwcGxpY2F0aW9uUGF0aAorICAgICAgICBMZWF2 ZSAtLXNhZmFyaS1wYXRoIGFzIGEgY29tbWFuZGxpbmUgb3B0aW9uIGZvciBiYWNrd2FyZHMgY29t cGF0aWJpbGl0eQorICAgICAgICAobW91bnRBbmRSdW5OaWdodGx5KToKKyAgICAgICAgVXNlIEZp bGU6OlNwZWMtPmNhdCBjb3JyZWN0bHkgKG9uZSBkaXJlY3RvcnkgcGVyIGFyZ3VtZW50KQorICAg ICAgICBVc2Ugb3BlbiAtLXdhaXQtYXBwcyBpbnN0ZWFkIG9mIHJ1bm5pbmcgdGhlIHRhcmdldCBh cHBsaWNhdGlvbiBkaXJlY3RseQorCisyMDE0LTEwLTMwICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRo ZXdfaGFuc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBVcGRhdGUgc2FmYXJpVmVyc2lvbiB0byBz YWZhcmlWZXJzaW9uU3RyaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzgxOTMKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVp bGRzIGIvVG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVpbGRzCmluZGV4IGNiMGRlNzAwOTEzODE2Yzdi NTVjODg0NGMyMzdmZDYwYTkyNDk0NDkuLjkzYjA4Y2IxOTI2YjI5ZGQ5ZjA2Mjk1Njc2NTNlOWJl OGU5MWFmYjAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcworKysgYi9U b29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMKQEAgLTM1LDcgKzM1LDcgQEAKICMKICMgJGJyYW5j aCA9ICJicmFuY2gtbmFtZSI7CiAjICRuaWdodGx5RG93bmxvYWREaXJlY3RvcnkgPSAifi9wYXRo L3RvL25pZ2h0bHkvZG93bmxvYWRzIjsKLSMgJHNhZmFyaVBhdGggPSAiL3BhdGgvdG8vU2FmYXJp LmFwcCI7CisjICRhcHBsaWNhdGlvblBhdGggPSAiL3BhdGgvdG8vQXBwbGljYXRpb24uYXBwIjsK IAogdXNlIHN0cmljdDsKIApAQCAtNzAsNiArNzAsNyBAQCBteSAldmFsaWRCcmFuY2hlcyA9IG1h cCB7ICRfID0+IDEgfSBxdyhmZWF0dXJlLWJyYW5jaCB0cnVuayk7CiBteSAkYnJhbmNoID0gJFNl dHRpbmdzOjpicmFuY2g7CiBteSAkbmlnaHRseURvd25sb2FkRGlyZWN0b3J5ID0gJFNldHRpbmdz OjpuaWdodGx5RG93bmxvYWREaXJlY3Rvcnk7CiBteSAkc2FmYXJpUGF0aCA9ICRTZXR0aW5nczo6 c2FmYXJpUGF0aDsKK215ICRhcHBsaWNhdGlvblBhdGg7CiAKIG15IEBuaWdodGxpZXM7CiAKQEAg LTg2LDYgKzg3LDcgQEAgbXkgJHRlc3RVUkw7CiBteSAkcmVzdWx0ID0gR2V0T3B0aW9ucygKICAg ICBzaGFyZWRDb21tYW5kTGluZU9wdGlvbnMoKSwKICAgICAiYnxicmFuY2g9cyIgICAgICAgICAg ICAgPT4gXCRicmFuY2gsCisgICAgImF8YXBwbGljYXRpb249cyIgICAgICAgID0+IFwkYXBwbGlj YXRpb25QYXRoLAogICAgICJkfGRvd25sb2FkLWRpcmVjdG9yeT1zIiA9PiBcJG5pZ2h0bHlEb3du bG9hZERpcmVjdG9yeSwKICAgICAiaHxoZWxwIiAgICAgICAgICAgICAgICAgPT4gXCRzaG93SGVs cCwKICAgICAibHxsb2NhbCEiICAgICAgICAgICAgICAgPT4gXCRsb2NhbE9ubHksCkBAIC0xMDcs MjYgKzEwOSwzMCBAQCBpZiAoISRyZXN1bHQgfHwgJHNob3dIZWxwIHx8IHNjYWxhcihAQVJHVikg PiAwKSB7CiAgICAgcHJpbnQgU1RERVJSICJVc2FnZTogIiAuIGJhc2VuYW1lKCQwKSAuICIgW29w dGlvbnNdIFt1cmxdXG4iOwogICAgIHByaW50IFNUREVSUiA8PEVORDsKICAgWy1ifC0tYnJhbmNo IG5hbWVdICAgICAgICAgICAgIG5hbWUgb2YgdGhlIG5pZ2h0bHkgYnVpbGQgYnJhbmNoIChkZWZh dWx0OiB0cnVuaykKKyAgWy1hfC0tYXBwbGljYXRpb24gcGF0aF0gICAgICAgIHBhdGggdG8gZXhl Y3V0YWJsZSBvZiBhcHBsaWNhdGlvbiB0byB0ZXN0IChkZWZhdWx0OiAvQXBwbGljYXRpb25zL1Nh ZmFyaS5hcHApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIE5vdCBzdXBwb3J0 ZWQgb24gV2luZG93cyBvciBpT1MKICAgWy1kfC0tZG93bmxvYWQtZGlyZWN0b3J5IGRpcl0gIG5p Z2h0bHkgYnVpbGQgZG93bmxvYWQgZGlyZWN0b3J5IChkZWZhdWx0OiB+L0xpYnJhcnkvQ2FjaGVz L1dlYktpdC1OaWdodGxpZXMpCiAgIFstaHwtLWhlbHBdICAgICAgICAgICAgICAgICAgICBzaG93 IHRoaXMgaGVscCBtZXNzYWdlCiAgIFstbHwtLWxvY2FsXSAgICAgICAgICAgICAgICAgICBvbmx5 IHVzZSBsb2NhbCAoYWxyZWFkeSBkb3dubG9hZGVkKSBuaWdodGxpZXMKICAgWy1wfC0tcHJvZ3Jl c3Npb25dICAgICAgICAgICAgIHNlYXJjaGluZyBmb3IgYSBwcm9ncmVzc2lvbiwgbm90IGEgcmVn cmVzc2lvbgogICBbLXJ8LS1yZXZpc2lvbiBNWzpOXV0gICAgICAgICAgc3BlY2lmeSBzdGFydGlu ZyAoYW5kIG9wdGlvbmFsIGVuZGluZykgcmV2aXNpb25zIHRvIHNlYXJjaAogICBbLS1zYWZhcmkt cGF0aCBwYXRoXSAgICAgICAgICAgcGF0aCB0byBTYWZhcmkgYXBwbGljYXRpb24gYnVuZGxlIChk ZWZhdWx0OiAvQXBwbGljYXRpb25zL1NhZmFyaS5hcHApCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAqIFtERVBSRUNBVEVEXTogVGhlIC1hLy0tYXBwbGljYXRpb24gYXJndW1lbnQg d2lsbCBvdmVycmlkZSB0aGlzIGFyZ3VtZW50LCBpZiBib3RoIGFyZSBzZXQuCiAgIFstc3wtLXNh bml0eS1jaGVja10gICAgICAgICAgICB2ZXJpZnkgYm90aCBzdGFydGluZyBhbmQgZW5kaW5nIHJl dmlzaW9ucyBiZWZvcmUgYmlzZWN0aW5nCiBFTkQKICAgICBwcmludCBTVERFUlIgc2hhcmVkQ29t bWFuZExpbmVPcHRpb25zVXNhZ2UoYnJhY2tldHMgPT4gMSwgaW5kZW50ID0+IDIsIHN3aXRjaFdp ZHRoID0+IDMwKTsKICAgICBleGl0IDE7CiB9CiAKKyRzYWZhcmlQYXRoID0gZ2xvYigkc2FmYXJp UGF0aCkgaWYgJHNhZmFyaVBhdGggPX4gL15+LzsKKyRzYWZhcmlQYXRoID0gc2FmYXJpUGF0aEZy b21TYWZhcmlCdW5kbGUoJHNhZmFyaVBhdGgpIGlmICRzYWZhcmlQYXRoID1+IG0jXC5hcHAvKiM7 CiskYXBwbGljYXRpb25QYXRoID0gJGFwcGxpY2F0aW9uUGF0aCA/IEZpbGU6OlNwZWMtPnJlbDJh YnMoJGFwcGxpY2F0aW9uUGF0aCkgOiAkc2FmYXJpUGF0aDsKKwogbXkgJG5pZ2h0bHlXZWJTaXRl ID0gImh0dHA6Ly9uaWdodGx5LndlYmtpdC5vcmciOwogbXkgJG5pZ2h0bHlCdWlsZHNVUkxCYXNl ID0gJG5pZ2h0bHlXZWJTaXRlIC4gRmlsZTo6U3BlYy0+Y2F0ZGlyKCIvYnVpbGRzIiwgJGJyYW5j aCwgIm1hYyIpOwogbXkgJG5pZ2h0bHlGaWxlc1VSTEJhc2UgPSAkbmlnaHRseVdlYlNpdGUgLiBG aWxlOjpTcGVjLT5jYXRkaXIoIi9maWxlcyIsICRicmFuY2gsICJtYWMiKTsKIAogJG5pZ2h0bHlE b3dubG9hZERpcmVjdG9yeSA9IGdsb2IoJG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSkgaWYgJG5p Z2h0bHlEb3dubG9hZERpcmVjdG9yeSA9fiAvXn4vOwotJHNhZmFyaVBhdGggPSBnbG9iKCRzYWZh cmlQYXRoKSBpZiAkc2FmYXJpUGF0aCA9fiAvXn4vOwotJHNhZmFyaVBhdGggPSBzYWZhcmlQYXRo RnJvbVNhZmFyaUJ1bmRsZSgkc2FmYXJpUGF0aCkgaWYgJHNhZmFyaVBhdGggPX4gbSNcLmFwcC8q IzsKLQogJG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSA9IEZpbGU6OlNwZWMtPmNhdGRpcigkbmln aHRseURvd25sb2FkRGlyZWN0b3J5LCAkYnJhbmNoKTsKIGlmICghIC1kICRuaWdodGx5RG93bmxv YWREaXJlY3RvcnkpIHsKICAgICBta3BhdGgoJG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSwgMCwg MDc1NSkgfHwgZGllICJDb3VsZCBub3QgY3JlYXRlICRuaWdodGx5RG93bmxvYWREaXJlY3Rvcnk6 ICQhIjsKQEAgLTQxMSwyMSArNDE3LDMwIEBAIHN1YiBtb3VudEFuZFJ1bk5pZ2h0bHkoJCQkJCkK ICAgICAgICAgZGllICJDb3VsZCBub3QgbW91bnQgJGRpc2tJbWFnZSBhdCAkbW91bnRQYXRoIiBp ZiAkaSA+IDEwMDsKICAgICB9CiAKLSAgICBteSAkZnJhbWV3b3JrUGF0aDsKKyAgICBteSAkZnJh bWV3b3JrUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcigkbW91bnRQYXRoLCAiV2ViS2l0LmFwcCIs ICJDb250ZW50cyIpOwogICAgIGlmICgtZCAiL1ZvbHVtZXMvV2ViS2l0L1dlYktpdC5hcHAvQ29u dGVudHMvRnJhbWV3b3JrcyIpIHsKLSAgICAgICAgbXkgJG9zWFZlcnNpb24gPSBqb2luKCcuJywg KHNwbGl0KC9cLi8sIGZpbmRNYWNPU1hWZXJzaW9uKCkpKVswLi4xXSk7Ci0gICAgICAgICRmcmFt ZXdvcmtQYXRoID0gIi9Wb2x1bWVzL1dlYktpdC9XZWJLaXQuYXBwL0NvbnRlbnRzL0ZyYW1ld29y a3MvJG9zWFZlcnNpb24iOworICAgICAgICBteSAkb3N4U2hvcnRWZXJzaW9uID0gam9pbignLics IChzcGxpdCgvXC4vLCBmaW5kTWFjT1NYVmVyc2lvbigpKSlbMC4uMV0pOworICAgICAgICAkZnJh bWV3b3JrUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcigkZnJhbWV3b3JrUGF0aCwgIkZyYW1ld29y a3MiLCAkb3N4U2hvcnRWZXJzaW9uKTsKICAgICB9IGVsc2UgewotICAgICAgICAkZnJhbWV3b3Jr UGF0aCA9ICIvVm9sdW1lcy9XZWJLaXQvV2ViS2l0LmFwcC9Db250ZW50cy9SZXNvdXJjZXMiOwor ICAgICAgICAkZnJhbWV3b3JrUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcigkZnJhbWV3b3JrUGF0 aCwgIlJlc291cmNlcyIpOwogICAgIH0KIAogICAgICR0ZW1wRmlsZSB8fD0gIiI7CiAKKyAgICAj IENoZWNrIGZvciBib3RoIGFwcGxpYWN0aW9ucyBhbmQgYXBwbGljYXRpb24gYnVuZGxlcy4KKyAg ICBteSAkaXNCdW5kbGUgPSAtZCAkYXBwbGljYXRpb25QYXRoIHx8ICgtZiAkYXBwbGljYXRpb25Q YXRoICYmIC14ICRhcHBsaWNhdGlvblBhdGggJiYgJGFwcGxpY2F0aW9uUGF0aCA9fiBtIy9Db250 ZW50cy9NYWNPUy8jKTsKKworICAgIG15IEBhcmdzID0gKCRhcHBsaWNhdGlvblBhdGgpOworICAg IHVuc2hpZnQgQGFyZ3MsICJvcGVuIiwgIi0td2FpdC1hcHBzIiwgIi1hIiBpZiAkaXNCdW5kbGU7 CisgICAgcHVzaCBAYXJncywgJHRlbXBGaWxlIGlmICR0ZW1wRmlsZTsKKyAgICBwdXNoIEBhcmdz LCAiLS1hcmdzIiwgIi1BcHBsZVBlcnNpc3RlbmNlSWdub3JlU3RhdGUiLCAiWUVTIiBpZiAkaXNC dW5kbGU7CisKKyAgICAjIEZJWE1FOiBBZGQgc3VwcG9ydCBmb3IgcGFzc2luZyB0aHJvdWdoIGFk ZGl0aW9uYWwgYXJndW1lbnRzIHRvIHRoZSB0YXJnZXQgYXBwbGljYXRpb24KKwogICAgIHsKICAg ICAgICAgbG9jYWwgJUVOViA9ICVFTlY7CiAgICAgICAgIHNldHVwTWFjV2ViS2l0RW52aXJvbm1l bnQoJGZyYW1ld29ya1BhdGgpOwotCi0gICAgICAgIGAkc2FmYXJpICR0ZW1wRmlsZWA7CisgICAg ICAgIHN5c3RlbSB7ICRhcmdzWzBdIH0gQGFyZ3M7CiAgICAgfQogCiAgICAgYGhkaXV0aWwgZGV0 YWNoICckbW91bnRQYXRoJyAyPiAkZGV2TnVsbGA7Cg==