138223 2014-10-30 12:29:37 -0700 Long spins under rangeExpandedAroundPosition on Yahoo Mail 2014-10-30 15:38:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin enrica sam oldest_to_newest 1045085 0 thorton 2014-10-30 12:29:37 -0700 Long spins under rangeExpandedAroundPosition on Yahoo Mail 1045086 1 240687 thorton 2014-10-30 12:31:32 -0700 Created attachment 240687 Patch 1045089 2 240687 enrica 2014-10-30 12:40:14 -0700 Comment on attachment 240687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240687&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:517 > + end = end.previous(Character); What happens when you reach a null position before the number of characters to expand? I think you should handle that case in both directions. 1045090 3 240687 thorton 2014-10-30 12:46:46 -0700 Comment on attachment 240687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240687&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:517 >> + end = end.previous(Character); > > What happens when you reach a null position before the number of characters to expand? I think you should handle that case in both directions. Interesting! I'm surprised the telephone number code I stole this from has never been a problem. 1045153 4 thorton 2014-10-30 15:29:56 -0700 It looks like the positions never become null, they just climb the tree and then stick at one end or the other. Works exactly as you'd hope. 1045157 5 240687 enrica 2014-10-30 15:32:20 -0700 Comment on attachment 240687 Patch Thanks for looking into that!. Looks good to me. 1045158 6 thorton 2014-10-30 15:38:16 -0700 http://trac.webkit.org/changeset/175388 240687 2014-10-30 12:31:32 -0700 2014-10-30 15:32:20 -0700 Patch bug-138223-20141030123142.patch text/plain 7026 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWYwOGJmMTdkYjljYzU1 Y2Q1ZGRlNTJhOGNhMTYxNWI1YmFiNDNmYS4uMGM4YTQxMmVmYzYwMzY2YTdmYzUzYzFjMWU4YzFi NjZhNzc1ZGZiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEwLTMwICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIExvbmcgc3BpbnMg dW5kZXIgcmFuZ2VFeHBhbmRlZEFyb3VuZFBvc2l0aW9uIG9uIFlhaG9vIE1haWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODIyMworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTg4MTk1NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgRXhwb3J0IHNvbWUg dGhpbmdzLgorCiAyMDE0LTEwLTI5ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBh cHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIE5PVCBSRUFDSEVEIGJlY2F1c2UgUmVuZGVy U3R5bGU6OnNldFdvcmRTcGFjaW5nKCkgZG9lcyBub3QgaGFuZGxlIGEgTGVuZ3RoIHZhbHVlIG9m IHR5cGUgJ0NhbGN1bGF0ZWQnLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGI5MGE2NDZlMmFmOGE4ZDg4ZjQ0ODkz YjI4NzIxMjVhODcwYWQxZDcuLjU5MjRjZDJhYjYyMDgyNGFlZTI5ZjcwOWFiODJlZmE5OTExOWFh ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxNC0xMC0zMCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBMb25nIHNwaW5zIHVuZGVyIHJh bmdlRXhwYW5kZWRBcm91bmRQb3NpdGlvbiBvbiBZYWhvbyBNYWlsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgyMjMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzE4ODE5NTQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tOgorICAgICAg ICAoV2ViS2l0OjpyYW5nZUV4cGFuZGVkQXJvdW5kUG9zaXRpb25CeUNoYXJhY3RlcnMpOgorICAg ICAgICBSZWltcGxlbWVudCByYW5nZUV4cGFuZGVkQXJvdW5kUG9zaXRpb24gdG8gb3BlcmF0ZSBv biBjaGFyYWN0ZXJzIGluc3RlYWQgb2YgbGluZXMsCisgICAgICAgIGFuZCB0byB1c2UgUG9zaXRp b24uIE1vdmluZyBWaXNpYmxlUG9zaXRpb25zIGJ5IGxpbmUgY2FuIGJlIHZlcnkgZXhwZW5zaXZl IGluIHNvbWUgY2FzZXMsCisgICAgICAgIGFuZCBmb3IgZ2VuZXJhdGluZyBsb29rdXAvRGF0YSBE ZXRlY3RvcnMgY29udGV4dCwgd2UgZG9uJ3QgY2FyZSBhYm91dCB0aGF0IGtpbmQgb2YgcHJlY2lz aW9uLgorICAgICAgICBUaGlzIG1ha2VzIHRoaXMgZnVuY3Rpb24gfjEwMDB4IGZhc3RlciB3aGVu IGl0IGhpdHMgb24gYSByb3cgaW4gdGhlIFlhaG9vIE1haWwgbWVzc2FnZSBsaXN0LgorCisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2U6OnBlcmZvcm1EaWN0aW9uYXJ5TG9va3VwQXRMb2NhdGlvbik6 CisgICAgICAgIChXZWJLaXQ6OnNjYW5Gb3JEYXRhRGV0ZWN0ZWRJdGVtcyk6CisgICAgICAgIEFk b3B0IHRoZSBuZXcgcmFuZ2VFeHBhbmRlZEFyb3VuZFBvc2l0aW9uQnlDaGFyYWN0ZXJzLCBleHBh bmRpbmcgMjUwIGNoYXJhY3RlcnMKKyAgICAgICAgYmVmb3JlIGFuZCBhZnRlciwgd2hpY2ggcm91 Z2hseSBtYXRjaGVzIHdoYXQgd2Ugd2VyZSB1c3VhbGx5IGdldHRpbmcgZ29pbmcgYnkgbGluZSwK KyAgICAgICAgYW5kIGlzIGEgcmVhc29uYWJsZSBhbW91bnQgb2YgY29udGV4dCBmb3IgdGhlc2Ug b3BlcmF0aW9ucy4KKwogMjAxNC0xMC0yOSAgSHVuc2VvcCBKZW9uZyAgPGhzODUuamVvbmdAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFVzZSBtb2Rlcm4gZm9y LWxvb3BzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBiL1NvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCmluZGV4IDM3ZGJhZGFjOGFlNTUxYTlkZTAxZTdhZGQw ZDYxZmViMWJmNzMzZGMuLjU0YzQ3ZjU0MzFiOGQwMzJlMjg1ODhjNjU0MTE0NmMyZjk1YWQ2NmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1dlYkNvcmUuZXhwLmluCkBAIC0xMDQ4LDYgKzEwNDgsNyBAQCBfX1pON1dlYkNvcmUy NHJlZGlyZWN0Q2hhaW5BbGxvd3NSZXVzZUVOU18yNFJlZGlyZWN0Q2hhaW5DYWNoZVN0YXR1c0UK IF9fWk43V2ViQ29yZTI1YWRkTGFuZ3VhZ2VDaGFuZ2VPYnNlcnZlckVQdlBGdlMwX0UKIF9fWk43 V2ViQ29yZTI1Y29tcHV0ZVZpZXdwb3J0QXR0cmlidXRlc0VOU18xN1ZpZXdwb3J0QXJndW1lbnRz RWlpaWZOU183SW50U2l6ZUUKIF9fWk43V2ViQ29yZTI1Y3JlYXRlQ2Fub25pY2FsVVVJRFN0cmlu Z0V2CitfX1pON1dlYkNvcmUyNWRpcmVjdGlvbk9mRW5jbG9zaW5nQmxvY2tFUktOU184UG9zaXRp b25FCiBfX1pON1dlYkNvcmUyNWdldE91dE9mTGluZUNhY2hlZFdyYXBwZXJFUE5TXzE3SlNET01H bG9iYWxPYmplY3RFUE5TXzROb2RlRQogX19aTjdXZWJDb3JlMjV1cGRhdGVSZWRpcmVjdENoYWlu U3RhdHVzRVJOU18yNFJlZGlyZWN0Q2hhaW5DYWNoZVN0YXR1c0VSS05TXzE2UmVzb3VyY2VSZXNw b25zZUUKIF9fWk43V2ViQ29yZTI2Q29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIxNmNvbnRleHRE ZXN0cm95ZWRFdgpAQCAtMjA0Myw2ICsyMDQ0LDggQEAgX19aTks3V2ViQ29yZThQb3NpdGlvbjI0 cGFyZW50QW5jaG9yZWRFcXVpdmFsZW50RXYKIF9fWk5LN1dlYkNvcmU4UG9zaXRpb24yNWxlYWRp bmdXaGl0ZXNwYWNlUG9zaXRpb25FTlNfOUVBZmZpbml0eUViCiBfX1pOSzdXZWJDb3JlOFBvc2l0 aW9uMjZ0cmFpbGluZ1doaXRlc3BhY2VQb3NpdGlvbkVOU185RUFmZmluaXR5RWIKIF9fWk5LN1dl YkNvcmU4UG9zaXRpb24yOG9mZnNldEZvclBvc2l0aW9uQWZ0ZXJBbmNob3JFdgorX19aTks3V2Vi Q29yZThQb3NpdGlvbjRuZXh0RU5TXzE2UG9zaXRpb25Nb3ZlVHlwZUUKK19fWk5LN1dlYkNvcmU4 UG9zaXRpb244cHJldmlvdXNFTlNfMTZQb3NpdGlvbk1vdmVUeXBlRQogX19aTks3V2ViQ29yZThQ b3NpdGlvbjh1cHN0cmVhbUVOU18yN0VkaXRpbmdCb3VuZGFyeUNyb3NzaW5nUnVsZUUKIF9fWk5L N1dlYkNvcmU4U2V0dGluZ3MxNWZpeGVkRm9udEZhbWlseUUxMVVTY3JpcHRDb2RlCiBfX1pOSzdX ZWJDb3JlOFNldHRpbmdzMTVzZXJpZkZvbnRGYW1pbHlFMTFVU2NyaXB0Q29kZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCmluZGV4 IDAyYWUzNmQ3NDU5YTEyZmEzMTNhZWY1NjMyNDI1MTg1MWQ3NzhiMzkuLjhkYjgxYTAwZjMxYzM2 NzBhNzNkNTM3YjMxMTQ1YjU5MTZhOGJjM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0KQEAgLTUwMSwzMiArNTAxLDIzIEBA IHN0YXRpYyBib29sIHNob3VsZFVzZVNlbGVjdGlvbihjb25zdCBWaXNpYmxlUG9zaXRpb24mIHBv c2l0aW9uLCBjb25zdCBWaXNpYmxlU2VsCiAgICAgcmV0dXJuIGlzUG9zaXRpb25JblJhbmdlKHBv c2l0aW9uLCBzZWxlY3RlZFJhbmdlLmdldCgpKTsKIH0KIAotc3RhdGljIFBhc3NSZWZQdHI8UmFu Z2U+IHJhbmdlRXhwYW5kZWRBcm91bmRQb3NpdGlvbihjb25zdCBWaXNpYmxlUG9zaXRpb24mIHBv c2l0aW9uLCBpbnQgbnVtYmVyT2ZMaW5lc1RvRXhwYW5kKQorc3RhdGljIFBhc3NSZWZQdHI8UmFu Z2U+IHJhbmdlRXhwYW5kZWRBcm91bmRQb3NpdGlvbkJ5Q2hhcmFjdGVycyhjb25zdCBWaXNpYmxl UG9zaXRpb24mIHBvc2l0aW9uLCBpbnQgbnVtYmVyT2ZDaGFyYWN0ZXJzVG9FeHBhbmQpCiB7Ci0g ICAgVmlzaWJsZVBvc2l0aW9uIGNvbnRleHRTdGFydCA9IHBvc2l0aW9uOwotICAgIFZpc2libGVQ b3NpdGlvbiBjb250ZXh0RW5kID0gcG9zaXRpb247Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBu dW1iZXJPZkxpbmVzVG9FeHBhbmQ7IGkrKykgewotICAgICAgICBWaXNpYmxlUG9zaXRpb24gbiA9 IHByZXZpb3VzTGluZVBvc2l0aW9uKGNvbnRleHRTdGFydCwgY29udGV4dFN0YXJ0LmxpbmVEaXJl Y3Rpb25Qb2ludEZvckJsb2NrRGlyZWN0aW9uTmF2aWdhdGlvbigpKTsKLSAgICAgICAgaWYgKG4u aXNOdWxsKCkgfHwgbiA9PSBjb250ZXh0U3RhcnQpCi0gICAgICAgICAgICBicmVhazsKLSAgICAg ICAgY29udGV4dFN0YXJ0ID0gbjsKLSAgICB9Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1i ZXJPZkxpbmVzVG9FeHBhbmQ7IGkrKykgewotICAgICAgICBWaXNpYmxlUG9zaXRpb24gbiA9IG5l eHRMaW5lUG9zaXRpb24oY29udGV4dEVuZCwgY29udGV4dEVuZC5saW5lRGlyZWN0aW9uUG9pbnRG b3JCbG9ja0RpcmVjdGlvbk5hdmlnYXRpb24oKSk7Ci0gICAgICAgIGlmIChuLmlzTnVsbCgpIHx8 IG4gPT0gY29udGV4dEVuZCkKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjb250ZXh0RW5k ID0gbjsKKyAgICBQb3NpdGlvbiBzdGFydCA9IHBvc2l0aW9uLmRlZXBFcXVpdmFsZW50KCk7Cisg ICAgUG9zaXRpb24gZW5kID0gcG9zaXRpb24uZGVlcEVxdWl2YWxlbnQoKTsKKyAgICBmb3IgKGlu dCBpID0gMDsgaSA8IG51bWJlck9mQ2hhcmFjdGVyc1RvRXhwYW5kOyArK2kpIHsKKyAgICAgICAg aWYgKGRpcmVjdGlvbk9mRW5jbG9zaW5nQmxvY2soc3RhcnQpID09IExUUikKKyAgICAgICAgICAg IHN0YXJ0ID0gc3RhcnQucHJldmlvdXMoQ2hhcmFjdGVyKTsKKyAgICAgICAgZWxzZQorICAgICAg ICAgICAgc3RhcnQgPSBzdGFydC5uZXh0KENoYXJhY3Rlcik7CisKKyAgICAgICAgaWYgKGRpcmVj dGlvbk9mRW5jbG9zaW5nQmxvY2soZW5kKSA9PSBMVFIpCisgICAgICAgICAgICBlbmQgPSBlbmQu bmV4dChDaGFyYWN0ZXIpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBlbmQgPSBlbmQucHJl dmlvdXMoQ2hhcmFjdGVyKTsKICAgICB9CiAKLSAgICBWaXNpYmxlUG9zaXRpb24gbGluZVN0YXJ0 ID0gc3RhcnRPZkxpbmUoY29udGV4dFN0YXJ0KTsKLSAgICBpZiAoIWxpbmVTdGFydC5pc051bGwo KSkKLSAgICAgICAgY29udGV4dFN0YXJ0ID0gbGluZVN0YXJ0OwotCi0gICAgVmlzaWJsZVBvc2l0 aW9uIGxpbmVFbmQgPSBlbmRPZkxpbmUoY29udGV4dEVuZCk7Ci0gICAgaWYgKCFsaW5lRW5kLmlz TnVsbCgpKQotICAgICAgICBjb250ZXh0RW5kID0gbGluZUVuZDsKLSAgICAKLSAgICByZXR1cm4g bWFrZVJhbmdlKGNvbnRleHRTdGFydCwgY29udGV4dEVuZCk7CisgICAgcmV0dXJuIG1ha2VSYW5n ZShzdGFydCwgZW5kKTsKIH0KIAogdm9pZCBXZWJQYWdlOjpwZXJmb3JtRGljdGlvbmFyeUxvb2t1 cEF0TG9jYXRpb24oY29uc3QgRmxvYXRQb2ludCYgZmxvYXRQb2ludCkKQEAgLTU1Niw4ICs1NDcs OCBAQCB2b2lkIFdlYlBhZ2U6OnBlcmZvcm1EaWN0aW9uYXJ5TG9va3VwQXRMb2NhdGlvbihjb25z dCBGbG9hdFBvaW50JiBmbG9hdFBvaW50KQogCiAgICAgTlNEaWN0aW9uYXJ5ICpvcHRpb25zID0g bmlsOwogCi0gICAgLy8gQXMgY29udGV4dCwgd2UgYXJlIGdvaW5nIHRvIHVzZSBmb3VyIGxpbmVz IG9mIHRleHQgYmVmb3JlIGFuZCBhZnRlciB0aGUgcG9pbnQuIChEaWN0aW9uYXJ5IGNhbiBzb21l dGltZXMgbG9vayB1cCB0aGluZ3MgdGhhdCBhcmUgZm91ciBsaW5lcyBsb25nKQotICAgIFJlZlB0 cjxSYW5nZT4gZnVsbENoYXJhY3RlclJhbmdlID0gcmFuZ2VFeHBhbmRlZEFyb3VuZFBvc2l0aW9u KHBvc2l0aW9uLCA0KTsKKyAgICAvLyBBcyBjb250ZXh0LCB3ZSBhcmUgZ29pbmcgdG8gdXNlIDI1 MCBjaGFyYWN0ZXJzIG9mIHRleHQgYmVmb3JlIGFuZCBhZnRlciB0aGUgcG9pbnQuCisgICAgUmVm UHRyPFJhbmdlPiBmdWxsQ2hhcmFjdGVyUmFuZ2UgPSByYW5nZUV4cGFuZGVkQXJvdW5kUG9zaXRp b25CeUNoYXJhY3RlcnMocG9zaXRpb24sIDI1MCk7CiAgICAgTlNSYW5nZSByYW5nZVRvUGFzcyA9 IE5TTWFrZVJhbmdlKFRleHRJdGVyYXRvcjo6cmFuZ2VMZW5ndGgobWFrZVJhbmdlKGZ1bGxDaGFy YWN0ZXJSYW5nZS0+c3RhcnRQb3NpdGlvbigpLCBwb3NpdGlvbikuZ2V0KCkpLCAwKTsKIAogICAg IFN0cmluZyBmdWxsUGxhaW5UZXh0U3RyaW5nID0gcGxhaW5UZXh0KGZ1bGxDaGFyYWN0ZXJSYW5n ZS5nZXQoKSk7CkBAIC0xMDcxLDcgKzEwNjIsNyBAQCBzdGF0aWMgUmV0YWluUHRyPEREQWN0aW9u Q29udGV4dD4gc2NhbkZvckRhdGFEZXRlY3RlZEl0ZW1zKGNvbnN0IEhpdFRlc3RSZXN1bHQmCiAg ICAgaWYgKHBvc2l0aW9uLmlzTnVsbCgpKQogICAgICAgICBwb3NpdGlvbiA9IGZpcnN0UG9zaXRp b25Jbk9yQmVmb3JlTm9kZShub2RlKTsKIAotICAgIFJlZlB0cjxSYW5nZT4gY29udGV4dFJhbmdl ID0gcmFuZ2VFeHBhbmRlZEFyb3VuZFBvc2l0aW9uKHBvc2l0aW9uLCA0KTsKKyAgICBSZWZQdHI8 UmFuZ2U+IGNvbnRleHRSYW5nZSA9IHJhbmdlRXhwYW5kZWRBcm91bmRQb3NpdGlvbkJ5Q2hhcmFj dGVycyhwb3NpdGlvbiwgMjUwKTsKICAgICBpZiAoIWNvbnRleHRSYW5nZSkKICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAK