138216 2014-10-30 11:35:44 -0700 When a client certificate is rejected, Safari says the website didn’t accept the certificate “unknown” instead of naming the certificate 2014-10-30 11:49:01 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz ap oldest_to_newest 1045064 0 mitz 2014-10-30 11:35:44 -0700 When trying to authenticate to a website using a client certificate, if the server rejects the certificate, Safari shows an error sheet saying “The website “…” did not accept the certificate “unknown””. Instead of “unknown” it is supposed to name the certificate that was used. It’s not working because the error object is missing the NSErrorClientCertificateChainKey key in its userInfo dictionary. Patch forthcoming. 1045065 1 240684 mitz 2014-10-30 11:38:24 -0700 Created attachment 240684 Include NSErrorClientCertificateChainKey when encoding error user info 1045068 2 240684 ap 2014-10-30 11:44:17 -0700 Comment on attachment 240684 Include NSErrorClientCertificateChainKey when encoding error user info View in context: https://bugs.webkit.org/attachment.cgi?id=240684&action=review > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:203 > + ASSERT(^{ Fun times. 1045070 3 mitz 2014-10-30 11:49:01 -0700 Fixed in <http://trac.webkit.org/r175374>. 240684 2014-10-30 11:38:24 -0700 2014-10-30 11:44:17 -0700 Include NSErrorClientCertificateChainKey when encoding error user info bug-138216-20141030113832.patch text/plain 4034 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTM3MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEwLTMwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV2hlbiBhIGNsaWVudCBjZXJ0aWZp Y2F0ZSBpcyByZWplY3RlZCwgU2FmYXJpIHNheXMgdGhlIHdlYnNpdGUgZGlkbuKAmXQgYWNjZXB0 IHRoZSBjZXJ0aWZpY2F0ZSDigJx1bmtub3du4oCdIGluc3RlYWQgb2YgbmFtaW5nIHRoZSBjZXJ0 aWZpY2F0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM4MjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTaGFyZWQvY2YvQXJndW1lbnRDb2RlcnNDRi5jcHA6CisgICAgICAgIChJUEM6OnR5cGVGcm9t Q0ZUeXBlUmVmKTogUmVtb3ZlIG5vLWxvbmdlci1uZWNlc3NhcnkgcGxhdGZvcm0gZ3VhcmRzIGFy b3VuZCBTZWNJZGVudGl0eVJlZi4KKyAgICAgICAgKElQQzo6ZW5jb2RlKTogRGl0dG8uCisgICAg ICAgIChJUEM6OmRlY29kZSk6IERpdHRvLgorICAgICAgICAqIFNoYXJlZC9tYWMvV2ViQ29yZUFy Z3VtZW50Q29kZXJzTWFjLm1tOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPFJlc291cmNl RXJyb3I+OjplbmNvZGVQbGF0Zm9ybURhdGEpOiBJZiBOU0Vycm9yQ2xpZW50Q2VydGlmaWNhdGVD aGFpbktleQorICAgICAgICBpcyBwcmVzZW50IGluIHRoZSBlcnJvcuKAmXMgdXNlckluZm8gZGlj dGlvbmFyeSwgYXNzZXJ0IHRoYXQgaXTigJlzIGFuIGFycmF5IG9mIGlkZW50aXRpZXMgYW5kCisg ICAgICAgIGNlcnRpZmljYXRlcywgYW5kIGluY2x1ZGUgaXQgaW4gdGhlIGZpbHRlcmVkIGRpY3Rp b25hcnkuCisKIDIwMTQtMTAtMjkgIEh1bnNlb3AgSmVvbmcgIDxoczg1Lmplb25nQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFtDb29yZGluYXRlZEdyYXBoaWNzXSBVc2UgbW9kZXJuIGZvci1sb29w cwpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0FyZ3VtZW50Q29kZXJzQ0YuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NGLmNw cAkocmV2aXNpb24gMTc1MzcyKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0FyZ3VtZW50 Q29kZXJzQ0YuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MCw5ICs4MCw3IEBAIGVudW0gQ0ZUeXBl IHsKICAgICBDRlN0cmluZywKICAgICBDRlVSTCwKICAgICBTZWNDZXJ0aWZpY2F0ZSwKLSNpZiBQ TEFURk9STShJT1MpCiAgICAgU2VjSWRlbnRpdHksCi0jZW5kaWYKICNpZiBIQVZFKFNFQ19LRVlD SEFJTikKICAgICBTZWNLZXljaGFpbkl0ZW0sCiAjZW5kaWYKQEAgLTEyMSwxMCArMTE5LDggQEAg c3RhdGljIENGVHlwZSB0eXBlRnJvbUNGVHlwZVJlZihDRlR5cGVSZQogICAgICAgICByZXR1cm4g Q0ZVUkw7CiAgICAgaWYgKHR5cGVJRCA9PSBTZWNDZXJ0aWZpY2F0ZUdldFR5cGVJRCgpKQogICAg ICAgICByZXR1cm4gU2VjQ2VydGlmaWNhdGU7Ci0jaWYgUExBVEZPUk0oSU9TKQogICAgIGlmICh0 eXBlSUQgPT0gU2VjSWRlbnRpdHlHZXRUeXBlSUQoKSkKICAgICAgICAgcmV0dXJuIFNlY0lkZW50 aXR5OwotI2VuZGlmCiAjaWYgSEFWRShTRUNfS0VZQ0hBSU4pCiAgICAgaWYgKHR5cGVJRCA9PSBT ZWNLZXljaGFpbkl0ZW1HZXRUeXBlSUQoKSkKICAgICAgICAgcmV0dXJuIFNlY0tleWNoYWluSXRl bTsKQEAgLTE3MywxMSArMTY5LDkgQEAgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyJiBlbmNv ZGVyLCBDRgogICAgIGNhc2UgU2VjQ2VydGlmaWNhdGU6CiAgICAgICAgIGVuY29kZShlbmNvZGVy LCAoU2VjQ2VydGlmaWNhdGVSZWYpdHlwZVJlZik7CiAgICAgICAgIHJldHVybjsKLSNpZiBQTEFU Rk9STShJT1MpCiAgICAgY2FzZSBTZWNJZGVudGl0eToKICAgICAgICAgZW5jb2RlKGVuY29kZXIs IChTZWNJZGVudGl0eVJlZikodHlwZVJlZikpOwogICAgICAgICByZXR1cm47Ci0jZW5kaWYKICNp ZiBIQVZFKFNFQ19LRVlDSEFJTikKICAgICBjYXNlIFNlY0tleWNoYWluSXRlbToKICAgICAgICAg ZW5jb2RlKGVuY29kZXIsIChTZWNLZXljaGFpbkl0ZW1SZWYpdHlwZVJlZik7CkBAIC0yNzAsNyAr MjY0LDYgQEAgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiBkZWNvZGVyLCBSZQogICAgICAg ICByZXN1bHQgPSBhZG9wdENGKGNlcnRpZmljYXRlLmxlYWtSZWYoKSk7CiAgICAgICAgIHJldHVy biB0cnVlOwogICAgIH0KLSNpZiBQTEFURk9STShJT1MpCiAgICAgY2FzZSBTZWNJZGVudGl0eTog ewogICAgICAgICBSZXRhaW5QdHI8U2VjSWRlbnRpdHlSZWY+IGlkZW50aXR5OwogICAgICAgICBp ZiAoIWRlY29kZShkZWNvZGVyLCBpZGVudGl0eSkpCkBAIC0yNzgsNyArMjcxLDYgQEAgYm9vbCBk ZWNvZGUoQXJndW1lbnREZWNvZGVyJiBkZWNvZGVyLCBSZQogICAgICAgICByZXN1bHQgPSBhZG9w dENGKGlkZW50aXR5LmxlYWtSZWYoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KLSNl bmRpZgogI2lmIEhBVkUoU0VDX0tFWUNIQUlOKQogICAgIGNhc2UgU2VjS2V5Y2hhaW5JdGVtOiB7 CiAgICAgICAgIFJldGFpblB0cjxTZWNLZXljaGFpbkl0ZW1SZWY+IGtleWNoYWluSXRlbTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvV2ViQ29yZUFyZ3VtZW50Q29kZXJzTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvV2ViQ29yZUFyZ3VtZW50 Q29kZXJzTWFjLm1tCShyZXZpc2lvbiAxNzUzNzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv bWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTk4LDYg KzE5OCwxOSBAQCB2b2lkIEFyZ3VtZW50Q29kZXI8UmVzb3VyY2VFcnJvcj46OmVuY29kCiAgICAg ICAgICAgICBDRkRpY3Rpb25hcnlTZXRWYWx1ZShmaWx0ZXJlZFVzZXJJbmZvLmdldCgpLCBrZXks IHZhbHVlKTsKICAgICB9XTsKIAorICAgIGlmIChOU0FycmF5ICpjbGllbnRJZGVudGl0eUFuZENl cnRpZmljYXRlcyA9IFt1c2VySW5mbyBvYmplY3RGb3JLZXk6QCJOU0Vycm9yQ2xpZW50Q2VydGlm aWNhdGVDaGFpbktleSJdKSB7CisgICAgICAgIEFTU0VSVChbY2xpZW50SWRlbnRpdHlBbmRDZXJ0 aWZpY2F0ZXMgaXNLaW5kT2ZDbGFzczpbTlNBcnJheSBjbGFzc11dKTsKKyAgICAgICAgQVNTRVJU KF57CisgICAgICAgICAgICBmb3IgKGlkIG9iamVjdCBpbiBjbGllbnRJZGVudGl0eUFuZENlcnRp ZmljYXRlcykgeworICAgICAgICAgICAgICAgIGlmIChDRkdldFR5cGVJRChvYmplY3QpICE9IFNl Y0lkZW50aXR5R2V0VHlwZUlEKCkgJiYgQ0ZHZXRUeXBlSUQob2JqZWN0KSAhPSBTZWNDZXJ0aWZp Y2F0ZUdldFR5cGVJRCgpKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg ICAgICAgICB9CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfSgpKTsKKworICAg ICAgICBDRkRpY3Rpb25hcnlTZXRWYWx1ZShmaWx0ZXJlZFVzZXJJbmZvLmdldCgpLCBAIk5TRXJy b3JDbGllbnRDZXJ0aWZpY2F0ZUNoYWluS2V5IiwgY2xpZW50SWRlbnRpdHlBbmRDZXJ0aWZpY2F0 ZXMpOworICAgIH07CisKICAgICBJUEM6OmVuY29kZShlbmNvZGVyLCBmaWx0ZXJlZFVzZXJJbmZv LmdldCgpKTsKIAogICAgIGlkIHBlZXJDZXJ0aWZpY2F0ZUNoYWluID0gW3VzZXJJbmZvIG9iamVj dEZvcktleTpAIk5TRXJyb3JQZWVyQ2VydGlmaWNhdGVDaGFpbktleSJdOwo=