138210 2014-10-30 02:55:21 -0700 [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser 2017-03-11 10:49:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 kumar.rohit webkit-unassigned bugs-noreply buildbot cgarcia clopez mrobinson ossy pnormand rniwa svillar zan oldest_to_newest 1045003 0 kumar.rohit 2014-10-30 02:55:21 -0700 Add keyboard support for creating new window in Webkit GTK Minibrowser using 'ctrl' + 'n' keys. 1045006 1 240664 kumar.rohit 2014-10-30 03:05:23 -0700 Created attachment 240664 Patch 1095097 2 ossy 2015-05-15 04:44:55 -0700 cc-ing more GTK reviewer 1153347 3 240664 mcatanzaro 2016-01-06 20:24:49 -0800 Comment on attachment 240664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240664&action=review Thanks, sorry for the late review. > Tools/ChangeLog:3 > + [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser keyborad -> keyboard > Tools/MiniBrowser/gtk/BrowserWindow.c:566 > +static void createNewWindow(BrowserWindow *window, gpointer user_data) user_data -> userData 240664 2014-10-30 03:05:23 -0700 2016-01-06 20:24:49 -0800 Patch bug-138210-20141030153647.patch text/plain 2437 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MzY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzQyY2U2YTYyNTk2MGEyOWRhNTkwYTU5NjAyY2ZlMWJl NjhlMTllNi4uOGU2MzBhNmYwYmFmMjI4YzE3M2Y5M2JkMzY1ZmU0NTY1MTA5YjJkNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTMwICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIGtleWJvcmFkIHN1cHBvcnQgZm9yIGNy ZWF0aW5nIG5ldyB3aW5kb3cgaW4gR1RLIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgyMTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2lu ZG93LmM6CisgICAgICAgIChjcmVhdGVOZXdXaW5kb3cpOiBDYWxsYmFjayB0byBjcmVhdGUgbmV3 IHdpbmRvdyBvbiBwcmVzc2luZyAnQ3RybCcrJ24nIGtleXMuCisgICAgICAgIChicm93c2VyX3dp bmRvd19pbml0KToKKwogMjAxNC0xMC0yOSAgSmFrZSBOaWVsc2VuICA8amFjb2JfbmllbHNlbkBh cHBsZS5jb20+CiAKICAgICAgICAgQ29tbWl0UXVldWUgYW5kIEVXUyBzaG91bGQgcmVqZWN0IGFu eSBwYXRjaGVzIHRoYXQgcmVzdWx0IGluIGNvbnNpc3RlbnQgdGVzdApkaWZmIC0tZ2l0IGEvVG9v bHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMKaW5kZXggY2Q5Yjg5N2UzMjE2ZjFlYWI2NTlhNDk3ZWE4NTQ5YmQy YjM2MDRiOS4uYWE3YjUwNDQ2ZjcwMTdlMjMxMjM3YTVmYmUwM2EyMDMzOWVmYTExYSAxMDA2NDQK LS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYworKysgYi9Ub29scy9N aW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCkBAIC01NjMsNiArNTYzLDE1IEBAIHN0YXRp YyB2b2lkIGxvYWRIb21lUGFnZShCcm93c2VyV2luZG93ICp3aW5kb3csIGdwb2ludGVyIHVzZXJf ZGF0YSkKICAgICB3ZWJraXRfd2ViX3ZpZXdfbG9hZF91cmkod2luZG93LT53ZWJWaWV3LCBCUk9X U0VSX0RFRkFVTFRfVVJMKTsKIH0KIAorc3RhdGljIHZvaWQgY3JlYXRlTmV3V2luZG93KEJyb3dz ZXJXaW5kb3cgKndpbmRvdywgZ3BvaW50ZXIgdXNlcl9kYXRhKQoreworICAgIFdlYktpdFdlYlZp ZXcgKm5ld1dlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2Via2l0X3dlYl92aWV3X25ld193aXRo X2NvbnRleHQod2Via2l0X3dlYl92aWV3X2dldF9jb250ZXh0KHdpbmRvdy0+d2ViVmlldykpKTsK KyAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3NldHRpbmdzKG5ld1dlYlZpZXcsIHdlYmtpdF93ZWJf dmlld19nZXRfc2V0dGluZ3Mod2luZG93LT53ZWJWaWV3KSk7CisgICAgR3RrV2lkZ2V0ICpuZXdX aW5kb3cgPSBicm93c2VyX3dpbmRvd19uZXcobmV3V2ViVmlldywgR1RLX1dJTkRPVyh3aW5kb3cp KTsKKyAgICB3ZWJraXRfd2ViX3ZpZXdfbG9hZF91cmkobmV3V2ViVmlldywgQlJPV1NFUl9ERUZB VUxUX1VSTCk7CisgICAgZ3RrX3dpZGdldF9zaG93KG5ld1dpbmRvdyk7Cit9CisKIHN0YXRpYyB2 b2lkIGJyb3dzZXJXaW5kb3dGaW5hbGl6ZShHT2JqZWN0ICpnT2JqZWN0KQogewogICAgIEJyb3dz ZXJXaW5kb3cgKndpbmRvdyA9IEJST1dTRVJfV0lORE9XKGdPYmplY3QpOwpAQCAtNjcyLDYgKzY4 MSwxMCBAQCBzdGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dzZXJXaW5kb3cgKndp bmRvdykKICAgICBndGtfYWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdE S19LRVlfS1BfMCwgR0RLX0NPTlRST0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCiAgICAgICAg IGdfY2Nsb3N1cmVfbmV3X3N3YXAoR19DQUxMQkFDSyhkZWZhdWx0Wm9vbUNhbGxiYWNrKSwgd2lu ZG93LCBOVUxMKSk7CiAKKyAgICAvKiBDcmVhdGUgbmV3IHdpbmRvdyAqLyAKKyAgICBndGtfYWNj ZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfbiwgR0RLX0NPTlRS T0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAo R19DQUxMQkFDSyhjcmVhdGVOZXdXaW5kb3cpLCB3aW5kb3csIE5VTEwpKTsKKwogICAgIEd0a1dp ZGdldCAqdG9vbGJhciA9IGd0a190b29sYmFyX25ldygpOwogICAgIHdpbmRvdy0+dG9vbGJhciA9 IHRvb2xiYXI7CiAgICAgZ3RrX29yaWVudGFibGVfc2V0X29yaWVudGF0aW9uKEdUS19PUklFTlRB QkxFKHRvb2xiYXIpLCBHVEtfT1JJRU5UQVRJT05fSE9SSVpPTlRBTCk7Cg==