138205 2014-10-29 18:45:57 -0700 Add diagnostic logging to track page loads. 2015-02-20 15:47:59 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson cdumez commit-queue japhet webkit-bug-importer oldest_to_newest 1044946 0 eric.carlson 2014-10-29 18:45:57 -0700 Add diagnostic logging to track the number of page loads. 1044947 1 eric.carlson 2014-10-29 18:46:40 -0700 <rdar://problem/18173017> 1044948 2 webkit-bug-importer 2014-10-29 18:47:01 -0700 <rdar://problem/18820041> 1044954 3 240649 eric.carlson 2014-10-29 19:17:45 -0700 Created attachment 240649 Proposed patch. 1044955 4 commit-queue 2014-10-29 19:19:03 -0700 Attachment 240649 did not pass style-queue: ERROR: Source/WebCore/loader/FrameLoader.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1044956 5 240650 eric.carlson 2014-10-29 19:28:13 -0700 Created attachment 240650 Updated patch > ERROR: Source/WebCore/loader/FrameLoader.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Oh the horror! 1045072 6 240650 commit-queue 2014-10-30 12:04:31 -0700 Comment on attachment 240650 Updated patch Clearing flags on attachment: 240650 Committed r175375: <http://trac.webkit.org/changeset/175375> 1045073 7 commit-queue 2014-10-30 12:04:38 -0700 All reviewed patches have been landed. Closing bug. 1070852 8 240650 cdumez 2015-02-20 15:47:53 -0800 Comment on attachment 240650 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=240650&action=review > Source/WebCore/loader/FrameLoader.cpp:2270 > + page->chrome().client().logDiagnosticMessage(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingKeys::passKey() : DiagnosticLoggingKeys::failKey()); This seems to log for each frame load (included subframes). Was this the intention? 240649 2014-10-29 19:17:45 -0700 2014-10-29 19:28:13 -0700 Proposed patch. patch_2.txt text/plain 3226 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTM2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEwLTI5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBkaWFnbm9zdGlj IGxvZ2dpbmcgdG8gdHJhY2sgcGFnZSBsb2Fkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODIwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTgx NzMwMTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmNoZWNrTG9hZENvbXBsZXRlRm9yVGhpc0ZyYW1lKTogTG9nIHBhZ2UgbG9hZCBzdWNjZXNzIG9y IGZhaWx1cmUuCisKKyAgICAgICAgKiBwYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VMb2FkZWRLZXkpOiBO ZXcuCisgICAgICAgICogcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaDoKKwogMjAxNC0xMC0y OSAgSHVuc2VvcCBKZW9uZyAgPGhzODUuamVvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0Nv b3JkaW5hdGVkR3JhcGhpY3NdIFVzZSBtb2Rlcm4gZm9yLWxvb3BzCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDE3NTIyMykKKysrIFNvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDYgKzQ0LDcg QEAKICNpbmNsdWRlICJDaHJvbWUuaCIKICNpbmNsdWRlICJDaHJvbWVDbGllbnQuaCIKICNpbmNs dWRlICJDb250ZW50U2VjdXJpdHlQb2xpY3kuaCIKKyNpbmNsdWRlICJEaWFnbm9zdGljTG9nZ2lu Z0tleXMuaCIKICNpbmNsdWRlICJET01JbXBsZW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkRPTVdp bmRvdy5oIgogI2luY2x1ZGUgIkRhdGFiYXNlTWFuYWdlci5oIgpAQCAtMjI0Miw3ICsyMjQzLDgg QEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2hlY2tMb2FkQ29tcGxldGVGb3JUaAogICAgICAgICAgICAg ICAgIHJldHVybjsKIAogICAgICAgICAgICAgbV9wcm9ncmVzc1RyYWNrZXItPnByb2dyZXNzQ29t cGxldGVkKCk7Ci0gICAgICAgICAgICBpZiAoUGFnZSogcGFnZSA9IG1fZnJhbWUucGFnZSgpKSB7 CisgICAgICAgICAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS5wYWdlKCk7CisgICAgICAgICAgICBp ZiAocGFnZSkgewogICAgICAgICAgICAgICAgIGlmIChtX2ZyYW1lLmlzTWFpbkZyYW1lKCkpCiAg ICAgICAgICAgICAgICAgICAgIHBhZ2UtPnJlc2V0UmVsZXZhbnRQYWludGVkT2JqZWN0Q291bnRl cigpOwogICAgICAgICAgICAgfQpAQCAtMjI2Miw2ICsyMjY0LDExIEBAIHZvaWQgRnJhbWVMb2Fk ZXI6OmNoZWNrTG9hZENvbXBsZXRlRm9yVGgKICAgICAgICAgICAgIGlmIChBWE9iamVjdENhY2hl KiBjYWNoZSA9IG1fZnJhbWUuZG9jdW1lbnQoKS0+ZXhpc3RpbmdBWE9iamVjdENhY2hlKCkpCiAg ICAgICAgICAgICAgICAgY2FjaGUtPmZyYW1lTG9hZGluZ0V2ZW50Tm90aWZpY2F0aW9uKCZtX2Zy YW1lLCBsb2FkaW5nRXZlbnQpOwogCisgICAgICAgICAgICBpZiAoIXBhZ2UgfHwgIXBhZ2UtPnNl dHRpbmdzKCkuZGlhZ25vc3RpY0xvZ2dpbmdFbmFibGVkKCkpCisgICAgICAgICAgICAgICAgcmV0 dXJuOworCisgICAgICAgICAgICBwYWdlLT5jaHJvbWUoKS5jbGllbnQoKS5sb2dEaWFnbm9zdGlj TWVzc2FnZShEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VMb2FkZWRLZXkoKSwgZW1wdHlTdHJp bmcoKSwgZXJyb3IuaXNOdWxsKCkgPyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhc3NLZXkoKSA6 IERpYWdub3N0aWNMb2dnaW5nS2V5czo6ZmFpbEtleSgpKTsKKwogICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICB9CiAgICAgICAgIApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9z dGljTG9nZ2luZ0tleXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRGlh Z25vc3RpY0xvZ2dpbmdLZXlzLmNwcAkocmV2aXNpb24gMTc1MjIzKQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04Myw0 ICs4Myw5IEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6Om5vb3BLZXkoKQogICAgIHJl dHVybiBBU0NJSUxpdGVyYWwoIm5vb3AiKTsKIH0KIAorU3RyaW5nIERpYWdub3N0aWNMb2dnaW5n S2V5czo6cGFnZUxvYWRlZEtleSgpCit7CisgICAgcmV0dXJuIFdURjo6QVNDSUlMaXRlcmFsKCJw YWdlTG9hZGVkIik7Cit9CisKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3Rp Y0xvZ2dpbmdLZXlzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9z dGljTG9nZ2luZ0tleXMuaAkocmV2aXNpb24gMTc1MjIzKQorKysgU291cmNlL1dlYkNvcmUvcGFn ZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEsNyBA QCBwdWJsaWM6CiAgICAgc3RhdGljIFN0cmluZyBwYWdlQ29udGFpbnNBdExlYXN0T25lUGx1Z2lu S2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBwYWdlQ29udGFpbnNNZWRpYUVuZ2luZUtleSgpOwog ICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRhaW5zQXRMZWFzdE9uZU1lZGlhRW5naW5lS2V5KCk7 CisgICAgc3RhdGljIFN0cmluZyBwYWdlTG9hZGVkS2V5KCk7CiAKICAgICAvLyBTdWNjZXNzIGtl eXMuCiAgICAgc3RhdGljIFN0cmluZyBwYXNzS2V5KCk7Cg== 240650 2014-10-29 19:28:13 -0700 2014-10-30 12:04:31 -0700 Updated patch patch_3.txt text/plain 3227 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTM2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEwLTI5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBkaWFnbm9zdGlj IGxvZ2dpbmcgdG8gdHJhY2sgcGFnZSBsb2Fkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODIwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTgx NzMwMTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmNoZWNrTG9hZENvbXBsZXRlRm9yVGhpc0ZyYW1lKTogTG9nIHBhZ2UgbG9hZCBzdWNjZXNzIG9y IGZhaWx1cmUuCisKKyAgICAgICAgKiBwYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VMb2FkZWRLZXkpOiBO ZXcuCisgICAgICAgICogcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaDoKKwogMjAxNC0xMC0y OSAgSHVuc2VvcCBKZW9uZyAgPGhzODUuamVvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0Nv b3JkaW5hdGVkR3JhcGhpY3NdIFVzZSBtb2Rlcm4gZm9yLWxvb3BzCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDE3NTIyMykKKysrIFNvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYgKzQ3LDcg QEAKICNpbmNsdWRlICJET01JbXBsZW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkRPTVdpbmRvdy5o IgogI2luY2x1ZGUgIkRhdGFiYXNlTWFuYWdlci5oIgorI2luY2x1ZGUgIkRpYWdub3N0aWNMb2dn aW5nS2V5cy5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2Fk VGltaW5nLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIuaCIKQEAgLTIyNDIsNyArMjI0Myw4 IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNoZWNrTG9hZENvbXBsZXRlRm9yVGgKICAgICAgICAgICAg ICAgICByZXR1cm47CiAKICAgICAgICAgICAgIG1fcHJvZ3Jlc3NUcmFja2VyLT5wcm9ncmVzc0Nv bXBsZXRlZCgpOwotICAgICAgICAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLnBhZ2UoKSkg eworICAgICAgICAgICAgUGFnZSogcGFnZSA9IG1fZnJhbWUucGFnZSgpOworICAgICAgICAgICAg aWYgKHBhZ2UpIHsKICAgICAgICAgICAgICAgICBpZiAobV9mcmFtZS5pc01haW5GcmFtZSgpKQog ICAgICAgICAgICAgICAgICAgICBwYWdlLT5yZXNldFJlbGV2YW50UGFpbnRlZE9iamVjdENvdW50 ZXIoKTsKICAgICAgICAgICAgIH0KQEAgLTIyNjIsNiArMjI2NCwxMSBAQCB2b2lkIEZyYW1lTG9h ZGVyOjpjaGVja0xvYWRDb21wbGV0ZUZvclRoCiAgICAgICAgICAgICBpZiAoQVhPYmplY3RDYWNo ZSogY2FjaGUgPSBtX2ZyYW1lLmRvY3VtZW50KCktPmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpKQog ICAgICAgICAgICAgICAgIGNhY2hlLT5mcmFtZUxvYWRpbmdFdmVudE5vdGlmaWNhdGlvbigmbV9m cmFtZSwgbG9hZGluZ0V2ZW50KTsKIAorICAgICAgICAgICAgaWYgKCFwYWdlIHx8ICFwYWdlLT5z ZXR0aW5ncygpLmRpYWdub3N0aWNMb2dnaW5nRW5hYmxlZCgpKQorICAgICAgICAgICAgICAgIHJl dHVybjsKKworICAgICAgICAgICAgcGFnZS0+Y2hyb21lKCkuY2xpZW50KCkubG9nRGlhZ25vc3Rp Y01lc3NhZ2UoRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlTG9hZGVkS2V5KCksIGVtcHR5U3Ry aW5nKCksIGVycm9yLmlzTnVsbCgpID8gRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYXNzS2V5KCkg OiBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmZhaWxLZXkoKSk7CisKICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgfQogICAgICAgICAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0Rp YWdub3N0aWNMb2dnaW5nS2V5cy5jcHAJKHJldmlzaW9uIDE3NTIyMykKKysrIFNvdXJjZS9XZWJD b3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODMs NCArODMsOSBAQCBTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpub29wS2V5KCkKICAgICBy ZXR1cm4gQVNDSUlMaXRlcmFsKCJub29wIik7CiB9CiAKK1N0cmluZyBEaWFnbm9zdGljTG9nZ2lu Z0tleXM6OnBhZ2VMb2FkZWRLZXkoKQoreworICAgIHJldHVybiBXVEY6OkFTQ0lJTGl0ZXJhbCgi cGFnZUxvYWRlZCIpOworfQorCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0 aWNMb2dnaW5nS2V5cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmgJKHJldmlzaW9uIDE3NTIyMykKKysrIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgJKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDcg QEAgcHVibGljOgogICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRhaW5zQXRMZWFzdE9uZVBsdWdp bktleSgpOwogICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRhaW5zTWVkaWFFbmdpbmVLZXkoKTsK ICAgICBzdGF0aWMgU3RyaW5nIHBhZ2VDb250YWluc0F0TGVhc3RPbmVNZWRpYUVuZ2luZUtleSgp OworICAgIHN0YXRpYyBTdHJpbmcgcGFnZUxvYWRlZEtleSgpOwogCiAgICAgLy8gU3VjY2VzcyBr ZXlzLgogICAgIHN0YXRpYyBTdHJpbmcgcGFzc0tleSgpOwo=