13820 2007-05-22 11:39:58 -0700 Height of cursor should be same as height of text, not line-height 2023-11-15 18:08:51 -0800 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) All All RESOLVED DUPLICATE 249621 InRadar P4 Normal --- 1 just1gb webkit-unassigned ahmad.saleem792 ap bfulgham joone rniwa victor.singh1983 webkit-bug-importer webkit yurtaev.egor oldest_to_newest 9429 0 just1gb 2007-05-22 11:39:58 -0700 When CSS attribute line-height is specified for <textarea>, height of cursor shown is equal to the value of attribute specified. Spec "http://www.w3.org/TR/REC-CSS1#line-height" does not say anything about cursor size. Behaviour Safari: Shows a big cursor. IE: shows smaller cursor (equal to height of text, not line-height) Firefox: Definitely buggy.. shows big cursor for first charecter, shows smaller cursor for other charecters in a line 4897 1 15500 ap 2007-07-13 05:27:58 -0700 Created attachment 15500 test case 4899 2 ap 2007-07-13 05:32:50 -0700 Confirmed with r24182. The behavior is slightly different from what Tiger WebKit had, but this probably doesn't qualify it as a regression. 62711 3 17595 amitjoshi_79 2007-11-29 12:43:34 -0800 Created attachment 17595 patch for fixing the cursor height issue It a simple patch that should fix the cursor height issue in the caretRect method of RenderText. Also I had to override caretRect in RenderTextControlInnerBlock to take care of the initial state of the cursor (before first text char is entered). This is my first attempt to hack webkit code- so please let me know if I am not following the process correctly. 62712 4 17595 hyatt 2007-11-29 12:47:52 -0800 Comment on attachment 17595 patch for fixing the cursor height issue On Mac, the height of the caret is the full height of the line and not just the height of the text. I am not sure what platform you are writing this for, but this may be a platform behavioral difference that needs an #ifdef. 62713 5 17595 hyatt 2007-11-29 12:49:27 -0800 Comment on attachment 17595 patch for fixing the cursor height issue I would need to check to see what OS X textareas do, but generic editing (like TextEdit) uses the full height of the root line. 62714 6 hyatt 2007-11-29 12:54:56 -0800 Bring up TextEdit on the Mac and set spacing to "double." You will see that our behavior matches TextEdit. If we decide this behavior needs to be different on non-Mac platforms, there's a lot more work to do than merely patching caretRect, since selection also behaves this way. 62716 7 hyatt 2007-11-29 13:09:05 -0800 If you're going for more Windows-like behavior, I would suggest that RenderTheme have a new method like "usesRaggedSelection." Then many places will have to check that and change their behavior accordingly. You would probably want to turn off selection gap filling off as well, as it no longer makes much sense if your selection is going to be ragged and ugly (ducks). 62737 8 amitjoshi_79 2007-11-29 17:38:16 -0800 I was only testing on windows platform, but I guess I did miss the selection issue. Earlier comment on this issue suggested that the behavior on IE is better in this respect and I guess thats what I tried to achieve (except for the selection). I'll see if I can fix that as well. 534595 9 victor.singh1983 2012-01-11 23:35:52 -0800 Hi Applied this patch on Icecream sandwich webkit. But if we change the font size then cursor size does,nt change We have tried this use case on midas demo http://www-archive.mozilla.org/editor/midasdemo/ Please help this new bie Thanks and Regards Victor 534639 10 victor.singh1983 2012-01-12 01:07:27 -0800 (In reply to comment #9) > Hi > > Applied this patch on Icecream sandwich webkit. > > > But if we change the font size then cursor size does,nt change > > We have tried this use case on midas demo > > http://www-archive.mozilla.org/editor/midasdemo/ > > Please help this new bie > > > Thanks and Regards > Victor While debugging i have found that locclcaretRect() in RenderTextControlInnerBlock never gets called 534644 11 victor.singh1983 2012-01-12 01:22:01 -0800 (In reply to comment #9) > Hi > > Applied this patch on Icecream sandwich webkit. > > > But if we change the font size then cursor size does,nt change > > We have tried this use case on midas demo > > http://www-archive.mozilla.org/editor/midasdemo/ > > Please help this new bie > > > Thanks and Regards > Victor While debugging i have found that locclcaretRect() in RenderTextControlInnerBlock never gets called 535612 12 victor.singh1983 2012-01-13 05:43:15 -0800 Hi, I have made change that is make a new function to handle fontFace and fontSize and checked from editor if selected text is zero if not then insertHTML "<font size=\""+ fontSizeValue + "\" face=\"" + fontNameValue + "\">" + "&#27;</font>"; However it creates one issue that if user keeps changing the fonts at the same cursor position then we will have lot of font elements so need to remove such font element which have only escape chracter inside them Thanks Victor 1255356 13 webkit-bug-importer 2016-12-01 12:37:27 -0800 <rdar://problem/29464647> 1882389 14 ahmad.saleem792 2022-07-12 07:29:12 -0700 I am not able to reproduce this bug in Safari 15.5 on macOS 12.4 based not attached test case and I test via following: 1) Caret Indicator is of normal size and I typed multiple words and there was no changes in the caret indicator size. 2) I hovered the cursor on the <textarea> and there was no change in cursor size. (With and without text present in the <textarea>) Both of above tests were performed while loading the test case in Private Window. It matches with other browsers (Chrome Canary 105 and Firefox Nightly 104). I think it got fixed along the way (if I am testing it correctly) and can be marked as "RESOLVED CONFIGURATION CHANGED". If I am testing incorrectly, please retest accordingly or add some more instruction clarity. Thanks! 1882901 15 ap 2022-07-12 20:29:28 -0700 This is still a problem. Just hit Return in the attached test case, and the cursor height changes to line-height. Chrome works correctly. 1959725 16 ahmad.saleem792 2023-06-03 17:18:36 -0700 (In reply to Alexey Proskuryakov from comment #15) > This is still a problem. Just hit Return in the attached test case, and the > cursor height changes to line-height. Chrome works correctly. @ap - I am not able to reproduce this on 'Return' as well in Safari 16.5. 1959727 17 ap 2023-06-03 17:59:38 -0700 Still reproduces for me. The cursor becomes much bigger after pressing Return. 1992963 18 joone 2023-11-15 18:08:51 -0800 *** This bug has been marked as a duplicate of bug 249621 *** 15500 2007-07-13 05:27:58 -0700 2007-07-13 05:27:58 -0700 test case textarea.html text/html 69 ap PHRleHRhcmVhIHN0eWxlPSJsaW5lLWhlaWdodDo1OyB3aWR0aDo0MDA7IGhlaWdodDo0MDA7Ij4K PC90ZXh0YXJlYT4K 17595 2007-11-29 12:43:34 -0800 2010-06-10 15:13:58 -0700 patch for fixing the cursor height issue patch#13820 text/plain 1979 amitjoshi_79 SW5kZXg6IFJlbmRlclRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFJlbmRlclRleHQuY3BwCShyZXZp c2lvbiAyODAyNCkKKysrIFJlbmRlclRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTksOSAr MzU5LDggQEAgSW50UmVjdCBSZW5kZXJUZXh0OjpjYXJldFJlY3QoaW50IG9mZnNldAogICAgIGlm ICghYm94KQogICAgICAgICByZXR1cm4gSW50UmVjdCgpOwogCi0gICAgaW50IGhlaWdodCA9IGJv eC0+cm9vdCgpLT5ib3R0b21PdmVyZmxvdygpIC0gYm94LT5yb290KCktPnRvcE92ZXJmbG93KCk7 Ci0gICAgaW50IHRvcCA9IGJveC0+cm9vdCgpLT50b3BPdmVyZmxvdygpOwotCisgICAgaW50IGhl aWdodCA9IGJveC0+Ym90dG9tT3ZlcmZsb3coKSAtIGJveC0+dG9wT3ZlcmZsb3coKTsKKyAgICBp bnQgdG9wID0gYm94LT50b3BPdmVyZmxvdygpOwogICAgIGludCBsZWZ0ID0gYm94LT5wb3NpdGlv bkZvck9mZnNldChvZmZzZXQpOwogCiAgICAgaW50IHJvb3RMZWZ0ID0gYm94LT5yb290KCktPnhQ b3MoKTsKSW5kZXg6IFJlbmRlclRleHRDb250cm9sLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBSZW5kZXJU ZXh0Q29udHJvbC5jcHAJKHJldmlzaW9uIDI4MDI0KQorKysgUmVuZGVyVGV4dENvbnRyb2wuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02Myw2ICs2Myw3IEBAIHB1YmxpYzoKICAgICBSZW5kZXJUZXh0 Q29udHJvbElubmVyQmxvY2soTm9kZSogbm9kZSkgOiBSZW5kZXJCbG9jayhub2RlKSB7IH0KIAog ICAgIHZpcnR1YWwgYm9vbCBub2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVzdCYsIEhpdFRl c3RSZXN1bHQmLCBpbnQgeCwgaW50IHksIGludCB0eCwgaW50IHR5LCBIaXRUZXN0QWN0aW9uKTsK KyAgICB2aXJ0dWFsIEludFJlY3QgY2FyZXRSZWN0KGludCBvZmZzZXQsIEVBZmZpbml0eSA9IFVQ U1RSRUFNLCBpbnQqIGV4dHJhV2lkdGhUb0VuZE9mTGluZSA9IDApOwogfTsKIAogYm9vbCBSZW5k ZXJUZXh0Q29udHJvbElubmVyQmxvY2s6Om5vZGVBdFBvaW50KGNvbnN0IEhpdFRlc3RSZXF1ZXN0 JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGludCB4LCBpbnQgeSwgaW50IHR4LCBp bnQgdHksIEhpdFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikKQEAgLTcxLDYgKzcyLDE3IEBAIGJv b2wgUmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrOjpub2RlQXQKICAgICAKICAgICByZXR1cm4g UmVuZGVyQmxvY2s6Om5vZGVBdFBvaW50KHJlcXVlc3QsIHJlc3VsdCwgeCwgeSwgdHgsIHR5LCBy ZW5kZXJlci0+cGxhY2Vob2xkZXJJc1Zpc2libGUoKSA/IEhpdFRlc3RCbG9ja0JhY2tncm91bmQg OiBoaXRUZXN0QWN0aW9uKTsKIH0KK0ludFJlY3QgUmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2Nr OjpjYXJldFJlY3QoaW50IG9mZnNldCwgRUFmZmluaXR5IGFmZmluaXR5LCBpbnQqIGV4dHJhV2lk dGhUb0VuZE9mTGluZSkKK3sKKwlJbnRSZWN0IGNhcmV0ID0gUmVuZGVyQmxvY2s6OmNhcmV0UmVj dChvZmZzZXQsYWZmaW5pdHksZXh0cmFXaWR0aFRvRW5kT2ZMaW5lKTsKKwkvL0ZpeCB0aGUgaGVp Z2h0IGFuZCB5LXBvc2l0aW9uIG9mIHRoZSBjYXJldCB0byByZWZsZWN0IGZvbnQgaGVpZ2h0CisJ aWYgKHN0eWxlKCkpIHsKKwkJY29uc3QgRm9udCAmIGYgPSBzdHlsZSgpLT5mb250KCk7CisJCWNh cmV0LnNldEhlaWdodChmLmhlaWdodCgpKTsKKwkJY2FyZXQuc2V0WShjYXJldC55KCkrIGJhc2Vs aW5lUG9zaXRpb24odHJ1ZSxmYWxzZSkgLSBmLmFzY2VudCgpKTsKKwl9CisJcmV0dXJuIGNhcmV0 OworfQogCiBSZW5kZXJUZXh0Q29udHJvbDo6UmVuZGVyVGV4dENvbnRyb2woTm9kZSogbm9kZSwg Ym9vbCBtdWx0aUxpbmUpCiAgICAgOiBSZW5kZXJCbG9jayhub2RlKQo=