<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138194</bug_id>
          
          <creation_ts>2014-10-29 15:56:00 -0700</creation_ts>
          <short_desc>Final-ize more of TextFieldInputType&apos;s virtual functions</short_desc>
          <delta_ts>2014-10-29 17:16:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>benjamin</cc>
    
    <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>kling</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1044880</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-10-29 15:56:00 -0700</bug_when>
    <thetext>Final-ize more of TextFieldInputType&apos;s virtual functions for performance.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044883</commentid>
    <comment_count>1</comment_count>
      <attachid>240635</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-10-29 15:57:18 -0700</bug_when>
    <thetext>Created attachment 240635
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044918</commentid>
    <comment_count>2</comment_count>
      <attachid>240635</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-29 17:16:22 -0700</bug_when>
    <thetext>Comment on attachment 240635
Patch

Clearing flags on attachment: 240635

Committed r175358: &lt;http://trac.webkit.org/changeset/175358&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044919</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-29 17:16:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240635</attachid>
            <date>2014-10-29 15:57:18 -0700</date>
            <delta_ts>2014-10-29 17:16:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138194-20141029155726.patch</filename>
            <type>text/plain</type>
            <size>5396</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGEyNTJhNmZlYWU4MzBh
MGRhNTI4NmY1ZWJhNDdkNjAzNWE4ZGQ1OS4uNGU2ZWFkNDBiNWZkNTdlN2NlMDE5M2QyYmI3ZjZl
MWE1ZjdhODJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTI5ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRmluYWwtaXplIG1vcmUgb2Yg
VGV4dEZpZWxkSW5wdXRUeXBlJ3MgdmlydHVhbCBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODE5NAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpbmFsLWl6ZSBtb3JlIG9mIFRleHRGaWVs
ZElucHV0VHlwZSdzIHZpcnR1YWwgZnVuY3Rpb25zIGZvcgorICAgICAgICBwZXJmb3JtYW5jZS4K
KworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAq
IGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmg6CisKIDIwMTQtMTAtMjkgIFphbGFuIEJ1anRhcyAg
PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgaW52YWxpZCBmbG9hdCBmcm9tIFJv
b3RJbmxpbmVCb3guCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElu
cHV0VHlwZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuaAppbmRl
eCBlN2ZmNTFiODJlM2YxYmVjNWZkYWJiZWM0YTA3ODk3YzI1ZGE4ZThjLi5jMmE4MjYxMmUxYWJm
YjJmMTczODRjOGRiMTZiMzJkZmRlMjU2MzI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o
dG1sL1RleHRGaWVsZElucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZp
ZWxkSW5wdXRUeXBlLmgKQEAgLTQ4LDIzICs0OCwyMyBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVh
bCB2b2lkIGhhbmRsZUtleWRvd25FdmVudChLZXlib2FyZEV2ZW50Kikgb3ZlcnJpZGU7CiAgICAg
dm9pZCBoYW5kbGVLZXlkb3duRXZlbnRGb3JTcGluQnV0dG9uKEtleWJvYXJkRXZlbnQqKTsKIAot
ICAgIHZpcnR1YWwgSFRNTEVsZW1lbnQqIGNvbnRhaW5lckVsZW1lbnQoKSBjb25zdCBvdmVycmlk
ZTsKLSAgICB2aXJ0dWFsIEhUTUxFbGVtZW50KiBpbm5lckJsb2NrRWxlbWVudCgpIGNvbnN0IG92
ZXJyaWRlOwotICAgIHZpcnR1YWwgVGV4dENvbnRyb2xJbm5lclRleHRFbGVtZW50KiBpbm5lclRl
eHRFbGVtZW50KCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCBIVE1MRWxlbWVudCogaW5u
ZXJTcGluQnV0dG9uRWxlbWVudCgpIGNvbnN0IG92ZXJyaWRlOworICAgIHZpcnR1YWwgSFRNTEVs
ZW1lbnQqIGNvbnRhaW5lckVsZW1lbnQoKSBjb25zdCBvdmVycmlkZSBmaW5hbDsKKyAgICB2aXJ0
dWFsIEhUTUxFbGVtZW50KiBpbm5lckJsb2NrRWxlbWVudCgpIGNvbnN0IG92ZXJyaWRlIGZpbmFs
OworICAgIHZpcnR1YWwgVGV4dENvbnRyb2xJbm5lclRleHRFbGVtZW50KiBpbm5lclRleHRFbGVt
ZW50KCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVhbCBIVE1MRWxlbWVudCogaW5u
ZXJTcGluQnV0dG9uRWxlbWVudCgpIGNvbnN0IG92ZXJyaWRlIGZpbmFsOwogCiBwcm90ZWN0ZWQ6
CiAgICAgdmlydHVhbCBib29sIG5lZWRzQ29udGFpbmVyKCkgY29uc3Q7Ci0gICAgdmlydHVhbCBi
b29sIHNob3VsZEhhdmVTcGluQnV0dG9uKCkgY29uc3Q7CisgICAgdmlydHVhbCBib29sIHNob3Vs
ZEhhdmVTcGluQnV0dG9uKCkgY29uc3QgZmluYWw7CiAgICAgdmlydHVhbCB2b2lkIGNyZWF0ZVNo
YWRvd1N1YnRyZWUoKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgZGVzdHJveVNoYWRvd1N1
YnRyZWUoKSBvdmVycmlkZTsKLSAgICB2aXJ0dWFsIHZvaWQgYXR0cmlidXRlQ2hhbmdlZCgpIG92
ZXJyaWRlOwotICAgIHZpcnR1YWwgdm9pZCBkaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQoKSBvdmVy
cmlkZTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVhZG9ubHlBdHRyaWJ1dGVDaGFuZ2VkKCkgb3ZlcnJp
ZGU7Ci0gICAgdmlydHVhbCBib29sIHN1cHBvcnRzUmVhZE9ubHkoKSBjb25zdCBvdmVycmlkZTsK
LSAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlQmx1ckV2ZW50KCkgb3ZlcnJpZGU7CisgICAgdmlydHVh
bCB2b2lkIGF0dHJpYnV0ZUNoYW5nZWQoKSBvdmVycmlkZSBmaW5hbDsKKyAgICB2aXJ0dWFsIHZv
aWQgZGlzYWJsZWRBdHRyaWJ1dGVDaGFuZ2VkKCkgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVh
bCB2b2lkIHJlYWRvbmx5QXR0cmlidXRlQ2hhbmdlZCgpIG92ZXJyaWRlIGZpbmFsOworICAgIHZp
cnR1YWwgYm9vbCBzdXBwb3J0c1JlYWRPbmx5KCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CisgICAg
dmlydHVhbCB2b2lkIGhhbmRsZUJsdXJFdmVudCgpIG92ZXJyaWRlIGZpbmFsOwogICAgIHZpcnR1
YWwgdm9pZCBzZXRWYWx1ZShjb25zdCBTdHJpbmcmLCBib29sIHZhbHVlQ2hhbmdlZCwgVGV4dEZp
ZWxkRXZlbnRCZWhhdmlvcikgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCB2b2lkIHVwZGF0ZUlubmVy
VGV4dFZhbHVlKCkgb3ZlcnJpZGU7CisgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUlubmVyVGV4dFZh
bHVlKCkgb3ZlcnJpZGUgZmluYWw7CiAjaWYgUExBVEZPUk0oSU9TKQogICAgIHZpcnR1YWwgU3Ry
aW5nIHNhbml0aXplVmFsdWUoY29uc3QgU3RyaW5nJikgY29uc3Qgb3ZlcnJpZGU7CiAjZW5kaWYK
QEAgLTc3LDMwICs3NywzMCBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGRpZFNldFZh
bHVlQnlVc2VyRWRpdChWYWx1ZUNoYW5nZVN0YXRlKTsKIAogcHJpdmF0ZToKLSAgICB2aXJ0dWFs
IGJvb2wgaXNLZXlib2FyZEZvY3VzYWJsZShLZXlib2FyZEV2ZW50KikgY29uc3Qgb3ZlcnJpZGU7
Ci0gICAgdmlydHVhbCBib29sIGlzTW91c2VGb2N1c2FibGUoKSBjb25zdCBvdmVycmlkZTsKLSAg
ICB2aXJ0dWFsIGJvb2wgaXNUZXh0RmllbGQoKSBjb25zdCBvdmVycmlkZTsKLSAgICB2aXJ0dWFs
IGJvb2wgdmFsdWVNaXNzaW5nKGNvbnN0IFN0cmluZyYpIGNvbnN0IG92ZXJyaWRlOwotICAgIHZp
cnR1YWwgdm9pZCBoYW5kbGVCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudChCZWZvcmVUZXh0SW5zZXJ0
ZWRFdmVudCopIG92ZXJyaWRlOwotICAgIHZpcnR1YWwgdm9pZCBmb3J3YXJkRXZlbnQoRXZlbnQq
KSBvdmVycmlkZTsKLSAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkU3VibWl0SW1wbGljaXRseShFdmVu
dCopIG92ZXJyaWRlOworICAgIHZpcnR1YWwgYm9vbCBpc0tleWJvYXJkRm9jdXNhYmxlKEtleWJv
YXJkRXZlbnQqKSBjb25zdCBvdmVycmlkZSBmaW5hbDsKKyAgICB2aXJ0dWFsIGJvb2wgaXNNb3Vz
ZUZvY3VzYWJsZSgpIGNvbnN0IG92ZXJyaWRlIGZpbmFsOworICAgIHZpcnR1YWwgYm9vbCBpc1Rl
eHRGaWVsZCgpIGNvbnN0IG92ZXJyaWRlIGZpbmFsOworICAgIHZpcnR1YWwgYm9vbCB2YWx1ZU1p
c3NpbmcoY29uc3QgU3RyaW5nJikgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVhbCB2
b2lkIGhhbmRsZUJlZm9yZVRleHRJbnNlcnRlZEV2ZW50KEJlZm9yZVRleHRJbnNlcnRlZEV2ZW50
Kikgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVhbCB2b2lkIGZvcndhcmRFdmVudChFdmVudCop
IG92ZXJyaWRlIGZpbmFsOworICAgIHZpcnR1YWwgYm9vbCBzaG91bGRTdWJtaXRJbXBsaWNpdGx5
KEV2ZW50Kikgb3ZlcnJpZGUgZmluYWw7CiAgICAgdmlydHVhbCBSZW5kZXJQdHI8UmVuZGVyRWxl
bWVudD4gY3JlYXRlSW5wdXRSZW5kZXJlcihQYXNzUmVmPFJlbmRlclN0eWxlPikgb3ZlcnJpZGU7
CiAgICAgdmlydHVhbCBib29sIHNob3VsZFVzZUlucHV0TWV0aG9kKCkgY29uc3Qgb3ZlcnJpZGU7
CiAjaWYgIVBMQVRGT1JNKElPUykKICAgICB2aXJ0dWFsIFN0cmluZyBzYW5pdGl6ZVZhbHVlKGNv
bnN0IFN0cmluZyYpIGNvbnN0IG92ZXJyaWRlOwogI2VuZGlmCiAgICAgdmlydHVhbCBib29sIHNo
b3VsZFJlc3BlY3RMaXN0QXR0cmlidXRlKCkgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCBIVE1MRWxl
bWVudCogcGxhY2Vob2xkZXJFbGVtZW50KCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgdmlydHVhbCB2
b2lkIHVwZGF0ZVBsYWNlaG9sZGVyVGV4dCgpIG92ZXJyaWRlOwotICAgIHZpcnR1YWwgYm9vbCBh
cHBlbmRGb3JtRGF0YShGb3JtRGF0YUxpc3QmLCBib29sIG11bHRpcGFydCkgY29uc3Qgb3ZlcnJp
ZGU7Ci0gICAgdmlydHVhbCB2b2lkIHN1YnRyZWVIYXNDaGFuZ2VkKCkgb3ZlcnJpZGU7CisgICAg
dmlydHVhbCBIVE1MRWxlbWVudCogcGxhY2Vob2xkZXJFbGVtZW50KCkgY29uc3Qgb3ZlcnJpZGUg
ZmluYWw7CisgICAgdmlydHVhbCB2b2lkIHVwZGF0ZVBsYWNlaG9sZGVyVGV4dCgpIG92ZXJyaWRl
IGZpbmFsOworICAgIHZpcnR1YWwgYm9vbCBhcHBlbmRGb3JtRGF0YShGb3JtRGF0YUxpc3QmLCBi
b29sIG11bHRpcGFydCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVhbCB2b2lkIHN1
YnRyZWVIYXNDaGFuZ2VkKCkgb3ZlcnJpZGUgZmluYWw7CiAKICAgICAvLyBTcGluQnV0dG9uRWxl
bWVudDo6U3BpbkJ1dHRvbk93bmVyIGZ1bmN0aW9ucy4KLSAgICB2aXJ0dWFsIHZvaWQgZm9jdXNB
bmRTZWxlY3RTcGluQnV0dG9uT3duZXIoKSBvdmVycmlkZTsKLSAgICB2aXJ0dWFsIGJvb2wgc2hv
dWxkU3BpbkJ1dHRvblJlc3BvbmRUb01vdXNlRXZlbnRzKCkgb3ZlcnJpZGU7Ci0gICAgdmlydHVh
bCBib29sIHNob3VsZFNwaW5CdXR0b25SZXNwb25kVG9XaGVlbEV2ZW50cygpIG92ZXJyaWRlOwot
ICAgIHZpcnR1YWwgdm9pZCBzcGluQnV0dG9uU3RlcERvd24oKSBvdmVycmlkZTsKLSAgICB2aXJ0
dWFsIHZvaWQgc3BpbkJ1dHRvblN0ZXBVcCgpIG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBm
b2N1c0FuZFNlbGVjdFNwaW5CdXR0b25Pd25lcigpIG92ZXJyaWRlIGZpbmFsOworICAgIHZpcnR1
YWwgYm9vbCBzaG91bGRTcGluQnV0dG9uUmVzcG9uZFRvTW91c2VFdmVudHMoKSBvdmVycmlkZSBm
aW5hbDsKKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkU3BpbkJ1dHRvblJlc3BvbmRUb1doZWVsRXZl
bnRzKCkgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVhbCB2b2lkIHNwaW5CdXR0b25TdGVwRG93
bigpIG92ZXJyaWRlIGZpbmFsOworICAgIHZpcnR1YWwgdm9pZCBzcGluQnV0dG9uU3RlcFVwKCkg
b3ZlcnJpZGUgZmluYWw7CiAKICAgICBSZWZQdHI8SFRNTEVsZW1lbnQ+IG1fY29udGFpbmVyOwog
ICAgIFJlZlB0cjxIVE1MRWxlbWVudD4gbV9pbm5lckJsb2NrOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>