138193 2014-10-29 15:53:19 -0700 bisect-builds should filter out nightlies that predate the introduction of an OS X operating system 2014-10-30 13:57:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 matthew_hanson webkit-unassigned ddkilzer webkit-bug-importer oldest_to_newest 1044879 0 matthew_hanson 2014-10-29 15:53:19 -0700 bisect-builds should only attempt to bisect the subset of nightlies that ships a framework for the version of OS X that bisect-builds is running on. For Yosemite, this corresponds to nightlies created at or after r174650. For Mavericks, this corresponds to nightlies created at or after r157846. For Mountain Lion, this corresponds to nightlies created at or after r122421. 1044891 1 240636 matthew_hanson 2014-10-29 16:03:54 -0700 Created attachment 240636 Patch 1044894 2 webkit-bug-importer 2014-10-29 16:05:25 -0700 <rdar://problem/18818279> 1044907 3 240636 ddkilzer 2014-10-29 16:53:15 -0700 Comment on attachment 240636 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240636&action=review r=me with the comments resolved. > Tools/ChangeLog:10 > + It also does a bit of refactoring, including distinguishing between versions and version strings and > + saving versions to local variables instead of using eval in each conditional. +1 for the performance optimization. :) > Tools/ChangeLog:18 > + Restrict the set of nifhtlies to r122421 and above when running Mountain Lion. Typo: nifhtlies => nightlies > Tools/Scripts/bisect-builds:349 > + } > + > + if ($osxVersion ge v10.5) { Should this turn into an elsif? There's no need to re-run the code in this block for 10.8, 10.9 or 10.10. } elsif ($osxVersion ge v10.5) { If we wanted to be thorough, we could also add a FIXME comment for v10.6 and v10.7, but it probably doesn't matter at this point. > Tools/Scripts/bisect-builds:364 > if ($safariVersion eq "4 Public Beta") { This line needs to change to: if ($safariVersionString eq "4 Public Beta") { > Tools/Scripts/bisect-builds:375 > die "Requires Safari 2.0 or newer"; You could change the die statement below this patch context to be: die "Requires Mac OS X 10.4 (Tiger) or later"; 1044914 4 matthew_hanson 2014-10-29 17:13:11 -0700 Committed r175357: <http://trac.webkit.org/changeset/175357> 1045103 5 matthew_hanson 2014-10-30 13:57:53 -0700 Committed r175377: <http://trac.webkit.org/changeset/175377> 240636 2014-10-29 16:03:54 -0700 2014-10-29 16:53:15 -0700 Patch bug-138193-20141029160402.patch text/plain 4142 matthew_hanson U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTZlMDkxZDZhOGFhODkzMmViODNkZWM1YWZmODQ4ZjQy NDFiYWUwNC4uNWYyYzYzNjY0NGVjNTQwODBlMGIyY2FmZGQ5YWU5ZTY3MDI1MGQxYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE0LTEwLTI5ICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRoZXdfaGFuc29uQGFwcGxlLmNv bT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzIHNob3VsZCBmaWx0ZXIgb3V0IG5pZ2h0bGllcyB0 aGF0IHByZWRhdGUgdGhlIGludHJvZHVjdGlvbiBvZiBhbiBPUyBYIG9wZXJhdGluZyBzeXN0ZW0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODE5Mwor CisgICAgICAgIFRoaXMgcGF0Y2ggcmVzdHJpY3RzIHRoZSBzZXQgb2YgbmlnaHRsZXMgdG8gYmlz ZWN0IHRvIG9ubHkgdGhvc2UgbmlnaHRsaWVzIHRoYXQgc2hpcCB3aXRoIGZyYW1ld29ya3MKKyAg ICAgICAgZm9yIHRoZSB0YXJnZXQgT1MgKG9ubHkgc3VwcG9ydCBmb3IgT1MgWCBZb3NlbWl0ZSwg TWF2ZXJpY2tzIGFuZCBNb3VudGFpbiBMaW9uIHdhcyBhZGRlZC4pCisKKyAgICAgICAgSXQgYWxz byBkb2VzIGEgYml0IG9mIHJlZmFjdG9yaW5nLCBpbmNsdWRpbmcgZGlzdGluZ3Vpc2hpbmcgYmV0 d2VlbiB2ZXJzaW9ucyBhbmQgdmVyc2lvbiBzdHJpbmdzIGFuZAorICAgICAgICBzYXZpbmcgdmVy c2lvbnMgdG8gbG9jYWwgdmFyaWFibGVzIGluc3RlYWQgb2YgdXNpbmcgZXZhbCBpbiBlYWNoIGNv bmRpdGlvbmFsLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9iaXNlY3QtYnVpbGRzOgorICAgICAgICAobWFrZU5pZ2h0bHlMaXN0KToK KyAgICAgICAgUmVzdHJpY3QgdGhlIHNldCBvZiBuaWdodGxpZXMgdG8gcjE3NDY1MCBhbmQgYWJv dmUgd2hlbiBydW5uaW5nIFlvc2VtaXRlLgorICAgICAgICBSZXN0cmljdCB0aGUgc2V0IG9mIG5p Z2h0bGllcyB0byByMTU3ODQ2IGFuZCBhYm92ZSB3aGVuIHJ1bm5pbmcgTWF2ZXJpY2tzLgorICAg ICAgICBSZXN0cmljdCB0aGUgc2V0IG9mIG5pZmh0bGllcyB0byByMTIyNDIxIGFuZCBhYm92ZSB3 aGVuIHJ1bm5pbmcgTW91bnRhaW4gTGlvbi4KKwogMjAxNC0xMC0xNiAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIE9TT2JqZWN0UHRyIGlzIG1pc3NpbmcgbGVha1Jl ZigpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMgYi9Ub29scy9TY3Jp cHRzL2Jpc2VjdC1idWlsZHMKaW5kZXggMTEzMGIwMDEyMTU0YjljN2JkNGMxOTBhNmQ2ODFjMTlj ZGJiNjIzZC4uZDgwNzlkNTFmODNkMWViOGY5ZTUyNjRkMjQ4Y2ZhZGExZmM1ODUzNSAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVpbGRzCisrKyBiL1Rvb2xzL1NjcmlwdHMvYmlz ZWN0LWJ1aWxkcwpAQCAtMzEyLDcgKzMxMiw3IEBAIHN1YiBsb2FkU2V0dGluZ3MoKQogCiBzdWIg bWFrZU5pZ2h0bHlMaXN0KCQkJCQpCiB7Ci0gICAgbXkgKCR1c2VMb2NhbEZpbGVzLCAkbG9jYWxE aXJlY3RvcnksICRtYWNPU1hWZXJzaW9uLCAkc2FmYXJpVmVyc2lvbikgPSBAXzsKKyAgICBteSAo JHVzZUxvY2FsRmlsZXMsICRsb2NhbERpcmVjdG9yeSwgJG9zeFZlcnNpb25TdHJpbmcsICRzYWZh cmlWZXJzaW9uU3RyaW5nKSA9IEBfOwogICAgIG15IEBmaWxlczsKIAogICAgIGlmICgkdXNlTG9j YWxGaWxlcykgewpAQCAtMzM1LDMwICszMzUsNDEgQEAgc3ViIG1ha2VOaWdodGx5TGlzdCgkJCQk KQogICAgICAgICBjbG9zZShOSUdIVExJRVMpOwogICAgIH0KIAotICAgIGlmIChldmFsICJ2JG1h Y09TWFZlcnNpb24iIGdlIHYxMC41KSB7CisgICAgbXkgJG9zeFZlcnNpb24gPSBldmFsKCJ2JG9z eFZlcnNpb25TdHJpbmciKTsKKyAgICBteSAkc2FmYXJpVmVyc2lvbiA9IGV2YWwoInYkc2FmYXJp VmVyc2lvblN0cmluZyIpOworCisgICAgaWYgKCRvc3hWZXJzaW9uIGdlIHYxMC4xMCAmJiAkb3N4 VmVyc2lvbiBsdCB2MTAuMTEpIHsKKyAgICAgICAgQGZpbGVzID0gZ3JlcCB7ICRfLT57cmV2fSA+ PSAxNzQ2NTAgfSBAZmlsZXM7CisgICAgfSBlbHNpZiAoJG9zeFZlcnNpb24gZ2UgdjEwLjkgJiYg JG9zeFZlcnNpb24gbHQgdjEwLjEwKSB7CisgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAkXy0+e3Jl dn0gPj0gMTU3ODQ2IH0gQGZpbGVzOworICAgIH0gZWxzaWYgKCRvc3hWZXJzaW9uIGdlIHYxMC44 ICYmICRvc3hWZXJzaW9uIGx0IHYxMC45KSB7CisgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAkXy0+ e3Jldn0gPj0gMTIyNDIxIH0gQGZpbGVzOworICAgIH0KKworICAgIGlmICgkb3N4VmVyc2lvbiBn ZSB2MTAuNSkgewogICAgICAgICBpZiAoJHNhZmFyaVZlcnNpb24gZXEgIjQgUHVibGljIEJldGEi KSB7CiAgICAgICAgICAgICBAZmlsZXMgPSBncmVwIHsgJF8tPntyZXZ9ID49IDM5NjgyIH0gQGZp bGVzOwotICAgICAgICB9IGVsc2lmIChldmFsICJ2JHNhZmFyaVZlcnNpb24iIGdlIHYzLjIpIHsK KyAgICAgICAgfSBlbHNpZiAoJHNhZmFyaVZlcnNpb24gZ2UgdjMuMikgewogICAgICAgICAgICAg QGZpbGVzID0gZ3JlcCB7ICRfLT57cmV2fSA+PSAzNzM0OCB9IEBmaWxlczsKLSAgICAgICAgfSBl bHNpZiAoZXZhbCAidiRzYWZhcmlWZXJzaW9uIiBnZSB2My4xKSB7CisgICAgICAgIH0gZWxzaWYg KCRzYWZhcmlWZXJzaW9uIGdlIHYzLjEpIHsKICAgICAgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAk Xy0+e3Jldn0gPj0gMjk3MTEgfSBAZmlsZXM7Ci0gICAgICAgIH0gZWxzaWYgKGV2YWwgInYkc2Fm YXJpVmVyc2lvbiIgZ2UgdjMuMCkgeworICAgICAgICB9IGVsc2lmICgkc2FmYXJpVmVyc2lvbiBn ZSB2My4wKSB7CiAgICAgICAgICAgICBAZmlsZXMgPSBncmVwIHsgJF8tPntyZXZ9ID49IDI1MTI0 IH0gQGZpbGVzOwotICAgICAgICB9IGVsc2lmIChldmFsICJ2JHNhZmFyaVZlcnNpb24iIGdlIHYy LjApIHsKKyAgICAgICAgfSBlbHNpZiAoJHNhZmFyaVZlcnNpb24gZ2UgdjIuMCkgewogICAgICAg ICAgICAgQGZpbGVzID0gZ3JlcCB7ICRfLT57cmV2fSA+PSAxOTU5NCB9IEBmaWxlczsKICAgICAg ICAgfSBlbHNlIHsKICAgICAgICAgICAgIGRpZSAiUmVxdWlyZXMgU2FmYXJpIDIuMCBvciBuZXdl ciI7CiAgICAgICAgIH0KLSAgICB9IGVsc2lmIChldmFsICJ2JG1hY09TWFZlcnNpb24iIGdlIHYx MC40KSB7CisgICAgfSBlbHNpZiAoJG9zeFZlcnNpb24gZ2UgdjEwLjQpIHsKICAgICAgICAgaWYg KCRzYWZhcmlWZXJzaW9uIGVxICI0IFB1YmxpYyBCZXRhIikgewogICAgICAgICAgICAgQGZpbGVz ID0gZ3JlcCB7ICRfLT57cmV2fSA+PSAzOTY4MiB9IEBmaWxlczsKLSAgICAgICAgfSBlbHNpZiAo ZXZhbCAidiRzYWZhcmlWZXJzaW9uIiBnZSB2My4yKSB7CisgICAgICAgIH0gZWxzaWYgKCRzYWZh cmlWZXJzaW9uIGdlIHYzLjIpIHsKICAgICAgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAkXy0+e3Jl dn0gPj0gMzczNDggfSBAZmlsZXM7Ci0gICAgICAgIH0gZWxzaWYgKGV2YWwgInYkc2FmYXJpVmVy c2lvbiIgZ2UgdjMuMSkgeworICAgICAgICB9IGVsc2lmICgkc2FmYXJpVmVyc2lvbiBnZSB2My4x KSB7CiAgICAgICAgICAgICBAZmlsZXMgPSBncmVwIHsgJF8tPntyZXZ9ID49IDI5NzExIH0gQGZp bGVzOwotICAgICAgICB9IGVsc2lmIChldmFsICJ2JHNhZmFyaVZlcnNpb24iIGdlIHYzLjApIHsK KyAgICAgICAgfSBlbHNpZiAoJHNhZmFyaVZlcnNpb24gZ2UgdjMuMCkgewogICAgICAgICAgICAg QGZpbGVzID0gZ3JlcCB7ICRfLT57cmV2fSA+PSAxOTk5MiB9IEBmaWxlczsKLSAgICAgICAgfSBl bHNpZiAoZXZhbCAidiRzYWZhcmlWZXJzaW9uIiBnZSB2Mi4wKSB7CisgICAgICAgIH0gZWxzaWYg KCRzYWZhcmlWZXJzaW9uIGdlIHYyLjApIHsKICAgICAgICAgICAgIEBmaWxlcyA9IGdyZXAgeyAk Xy0+e3Jldn0gPj0gMTE5NzYgfSBAZmlsZXM7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAg ICBkaWUgIlJlcXVpcmVzIFNhZmFyaSAyLjAgb3IgbmV3ZXIiOwo=