138175 2014-10-29 08:47:48 -0700 [EME][Mac] MediaKeySession type "keyrelease" is ignored. 2014-12-16 13:28:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson glenn philipj sergio oldest_to_newest 1044758 0 jer.noble 2014-10-29 08:47:48 -0700 [EME][Mac] MediaKeySession type "keyrelease" is ignored. 1044760 1 240604 jer.noble 2014-10-29 09:16:22 -0700 Created attachment 240604 Patch 1044765 2 240604 eric.carlson 2014-10-29 09:38:46 -0700 Comment on attachment 240604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review acknowledged > Source/WebCore/ChangeLog:12 > + Also, the code which validates update() requests needs to allow updates of containing the string Nit: "... allow updates OF containing ..." => "... allow updates containing ..." > Source/WebCore/ChangeLog:13 > + "acknowledeged", so that clients can request the confirmation messages be discarded. Nit: "acknowledeged" => "acknowledged" > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202 > + if (m_mode == KeyRelease) > + return false; > + Does this add support for "acknowledged"? 1044777 3 240604 jer.noble 2014-10-29 10:47:38 -0700 Comment on attachment 240604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review >> Source/WebCore/ChangeLog:12 >> + Also, the code which validates update() requests needs to allow updates of containing the string > > Nit: "... allow updates OF containing ..." => "... allow updates containing ..." Changed. >> Source/WebCore/ChangeLog:13 >> + "acknowledeged", so that clients can request the confirmation messages be discarded. > > Nit: "acknowledeged" => "acknowledged" Changed. >> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202 >> + > > Does this add support for "acknowledged"? Only for "keyrelease" sessions. "acknowledged" was already working for the normal flow, i.e., when calling mediaKeySession.stop(). 1044783 4 jer.noble 2014-10-29 10:54:08 -0700 Committed r175331: <http://trac.webkit.org/changeset/175331> 1056107 5 jer.noble 2014-12-16 13:28:33 -0800 <rdar://problem/19269059> 240604 2014-10-29 09:16:22 -0700 2014-10-29 09:38:46 -0700 Patch bug-138175-20141029091629.patch text/plain 3479 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Mjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQ3Njk1ZmZhNDM4NjI0 OGU3ZGUyNzQwODM5Mzg2OTVmNmU5NzAyOC4uZTNjNzJjNjcxNzZhYzFjNDY1OWRjMGEzZGU1YmQz ZTZiYzQxODI4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEwLTI5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtFTUVdW01hY10gTWVkaWFL ZXlTZXNzaW9uIHR5cGUgImtleXJlbGVhc2UiIGlzIGlnbm9yZWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgxNzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBpbmRpY2F0ZSB0aGF0IHRoZXkgd291 bGQgbGlrZSB0byByZWNldmllIGV4cGlyZWQgc2Vzc2lvbiBjb25maXJtYXRpb24gbWVzc2FnZXMs IGNsaWVudHMKKyAgICAgICAgd2lsbCBjcmVhdGUgYSBNZWRpYUtleVNlc3Npb24gd2l0aCBhIHR5 cGUgcGFyYW1ldGVyIG9mICJrZXlyZWxlYXNlIi4gVGhlIGNvZGUgd2hpY2ggdmFsaWRhdGVzCisg ICAgICAgIHRoaXMgdHlwZSBuZWVkcyB0byBiZSB1cGRhdGVkIHRvIHJlY29nbml6ZSAia2V5cmVs ZWFzZSIgYXMgYSB2YWxpZCB0eXBlLgorCisgICAgICAgIEFsc28sIHRoZSBjb2RlIHdoaWNoIHZh bGlkYXRlcyB1cGRhdGUoKSByZXF1ZXN0cyBuZWVkcyB0byBhbGxvdyB1cGRhdGVzIG9mIGNvbnRh aW5pbmcgdGhlIHN0cmluZworICAgICAgICAiYWNrbm93bGVkZWdlZCIsIHNvIHRoYXQgY2xpZW50 cyBjYW4gcmVxdWVzdCB0aGUgY29uZmlybWF0aW9uIG1lc3NhZ2VzIGJlIGRpc2NhcmRlZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9DRE1Qcml2YXRlTWVkaWFT b3VyY2VBVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6Q0RNUHJpdmF0ZU1lZGlhU291cmNl QVZGT2JqQzo6c3VwcG9ydHNNSU1FVHlwZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvQ0RNU2Vzc2lvbk1lZGlhU291cmNlQVZGT2JqQy5tbToKKyAgICAg ICAgKFdlYkNvcmU6OkNETVNlc3Npb25NZWRpYVNvdXJjZUFWRk9iakM6OnVwZGF0ZSk6CisKIDIw MTQtMTAtMjggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW0VN RV1bTWFjXSBBZG9wdCBuZXcgQVZTdHJlYW1TZXNzaW9uIEFQSTogcGFzcyBzdG9yYWdlRGlyZWN0 b3J5QXRVUkwgYXQgY3JlYXRpb24tdGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0NETVByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vQ0RNUHJp dmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQppbmRleCBkMWVkNWEwZThhNzZlNzEzN2MzODM3OTQw ZjNjY2FiM2Y2YjI5MjA4Li41YTliMTczNWFmY2ExNWY5OWVjMjhjMmY3Y2VhNWY4MTQ0ODNlMzhi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vQ0RNUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vQ0RNUHJpdmF0ZU1lZGlhU291cmNlQVZGT2Jq Qy5tbQpAQCAtNjksNiArNjksOSBAQCBib29sIENETVByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6 OnN1cHBvcnRzS2V5U3lzdGVtQW5kTWltZVR5cGUoY29uc3QgU3RyaW5nJiBrZQogCiBib29sIENE TVByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6OnN1cHBvcnRzTUlNRVR5cGUoY29uc3QgU3RyaW5n JiBtaW1lVHlwZSkKIHsKKyAgICBpZiAobWltZVR5cGUgPT0gImtleXJlbGVhc2UiKQorICAgICAg ICByZXR1cm4gdHJ1ZTsKKwogICAgIE1lZGlhRW5naW5lU3VwcG9ydFBhcmFtZXRlcnMgcGFyYW1l dGVyczsKICAgICBwYXJhbWV0ZXJzLmlzTWVkaWFTb3VyY2UgPSB0cnVlOwogICAgIHBhcmFtZXRl cnMudHlwZSA9IG1pbWVUeXBlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQ0RNU2Vzc2lvbk1lZGlhU291cmNlQVZGT2JqQy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0NE TVNlc3Npb25NZWRpYVNvdXJjZUFWRk9iakMubW0KaW5kZXggMTdlYWJmYjQxZDgzMzZlYjBjZTVj NmNkNjE5OTRhY2U4NTkwZTcwZi4uMjhlZjQwNGY3NmZkOTIwMmVjZmQ2ZDZjZGE2Yjg2YjRkMGNm MjU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvQ0RNU2Vzc2lvbk1lZGlhU291cmNlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9DRE1TZXNzaW9uTWVk aWFTb3VyY2VBVkZPYmpDLm1tCkBAIC0xNzYsOSArMTc2LDYgQEAgc3RhdGljIGJvb2wgaXNFcXVh bChVaW50OEFycmF5KiBkYXRhLCBjb25zdCBjaGFyKiBsaXRlcmFsKQogCiBib29sIENETVNlc3Np b25NZWRpYVNvdXJjZUFWRk9iakM6OnVwZGF0ZShVaW50OEFycmF5KiBrZXksIFJlZlB0cjxVaW50 OEFycmF5PiYgbmV4dE1lc3NhZ2UsIHVuc2lnbmVkIHNob3J0JiBlcnJvckNvZGUsIHVuc2lnbmVk IGxvbmcmIHN5c3RlbUNvZGUpCiB7Ci0gICAgaWYgKG1fbW9kZSA9PSBLZXlSZWxlYXNlKQotICAg ICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICBib29sIHNob3VsZEdlbmVyYXRlS2V5UmVxdWVzdCA9 ICFtX2NlcnRpZmljYXRlIHx8IGlzRXF1YWwoa2V5LCAicmVuZXciKTsKICAgICBpZiAoIW1fY2Vy dGlmaWNhdGUpIHsKICAgICAgICAgTE9HKE1lZGlhLCAiQ0RNU2Vzc2lvbk1lZGlhU291cmNlQVZG T2JqQzo6dXBkYXRlKCVwKSAtIGNlcnRpZmljYXRlIGRhdGEiLCB0aGlzKTsKQEAgLTIwMCw2ICsx OTcsOSBAQCBib29sIENETVNlc3Npb25NZWRpYVNvdXJjZUFWRk9iakM6OnVwZGF0ZShVaW50OEFy cmF5KiBrZXksIFJlZlB0cjxVaW50OEFycmF5PiYgbgogICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICB9CiAKKyAgICBpZiAobV9tb2RlID09IEtleVJlbGVhc2UpCisgICAgICAgIHJldHVybiBmYWxz ZTsKKwogICAgIFJlZlB0cjxTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQz4gcHJvdGVjdGVkU291 cmNlQnVmZmVyOwogICAgIGZvciAoYXV0byYgc291cmNlQnVmZmVyIDogbV9zb3VyY2VCdWZmZXJz KSB7CiAgICAgICAgIGlmIChzb3VyY2VCdWZmZXItPnByb3RlY3RlZFRyYWNrSUQoKSAhPSAtMSkg ewo=