138172 2014-10-29 07:35:43 -0700 FormDataBuilder should not use Document 2014-10-30 01:02:25 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 21354 1 cgarcia webkit-unassigned commit-queue darin japhet oldest_to_newest 1044748 0 cgarcia 2014-10-29 07:35:43 -0700 It's a layering violation. 1044749 1 240600 cgarcia 2014-10-29 07:38:11 -0700 Created attachment 240600 Patch 1044989 2 240600 ap 2014-10-30 00:08:14 -0700 Comment on attachment 240600 Patch Nice! 1044998 3 cgarcia 2014-10-30 01:02:25 -0700 Committed r175369: <http://trac.webkit.org/changeset/175369> 240600 2014-10-29 07:38:11 -0700 2014-10-30 00:08:14 -0700 Patch wcore-form-data-builder-violations.diff text/plain 4558 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MWZkOTQ5Li42OTEzNzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTQtMTAtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIEZvcm1EYXRhQnVpbGRlciBzaG91bGQgbm90IHVzZSBEb2N1bWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MTcyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyBvbmx5IHVz ZWQgYnkgZW5jb2RpbmdGcm9tQWNjZXB0Q2hhcnNldCgpIHRvIGZhbGxiYWNrIHRvCisgICAgICAg IGRvY3VtZW50IGlucHV0IGVuY29kaW5nLiBUaGF0IG1ldGhvZCBpcyBvbmx5IHVzZWQgYnkKKyAg ICAgICAgRm9ybVN1Ym1pc3Npb246OmNyZWF0ZSgpLCBzbyBpdCBjb3VsZCBiZSBtb3ZlZCBhcyBh IHN0YXRpYworICAgICAgICBmdW5jdGlvbiB0byBGb3JtU3VibWlzc2lvbi5jcHAuCisKKyAgICAg ICAgKiBsb2FkZXIvRm9ybVN1Ym1pc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZW5jb2Rp bmdGcm9tQWNjZXB0Q2hhcnNldCk6CisgICAgICAgIChXZWJDb3JlOjpGb3JtU3VibWlzc2lvbjo6 Y3JlYXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhQnVpbGRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGb3JtRGF0YUJ1aWxkZXI6OmVuY29kaW5nRnJvbUFjY2VwdENo YXJzZXQpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRm9ybURhdGFCdWls ZGVyLmg6CisKKzIwMTQtMTAtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCiAgICAgICAgIEZvcm1EYXRhIHNob3VsZCBub3QgdXNlIERvY3VtZW50LCBQYWdl LCBDaHJvbWUgYW5kIENocm9tZUNsaWVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MTcxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9Gb3JtU3VibWlzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRm9ybVN1Ym1p c3Npb24uY3BwCmluZGV4IGRhM2Y0YWMuLmUzMjAyYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9Gb3JtU3VibWlzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L0Zvcm1TdWJtaXNzaW9uLmNwcApAQCAtMTQwLDYgKzE0MCwyMyBAQCBpbmxpbmUgRm9ybVN1Ym1p c3Npb246OkZvcm1TdWJtaXNzaW9uKE1ldGhvZCBtZXRob2QsIGNvbnN0IFVSTCYgYWN0aW9uLCBj b25zdCBTdAogewogfQogCitzdGF0aWMgVGV4dEVuY29kaW5nIGVuY29kaW5nRnJvbUFjY2VwdENo YXJzZXQoY29uc3QgU3RyaW5nJiBhY2NlcHRDaGFyc2V0LCBEb2N1bWVudCYgZG9jdW1lbnQpCit7 CisgICAgU3RyaW5nIG5vcm1hbGl6ZWRBY2NlcHRDaGFyc2V0ID0gYWNjZXB0Q2hhcnNldDsKKyAg ICBub3JtYWxpemVkQWNjZXB0Q2hhcnNldC5yZXBsYWNlKCcsJywgJyAnKTsKKworICAgIFZlY3Rv cjxTdHJpbmc+IGNoYXJzZXRzOworICAgIG5vcm1hbGl6ZWRBY2NlcHRDaGFyc2V0LnNwbGl0KCcg JywgY2hhcnNldHMpOworCisgICAgZm9yIChhdXRvJiBjaGFyc2V0IDogY2hhcnNldHMpIHsKKyAg ICAgICAgVGV4dEVuY29kaW5nIGVuY29kaW5nKGNoYXJzZXQpOworICAgICAgICBpZiAoZW5jb2Rp bmcuaXNWYWxpZCgpKQorICAgICAgICAgICAgcmV0dXJuIGVuY29kaW5nOworICAgIH0KKworICAg IHJldHVybiBkb2N1bWVudC5pbnB1dEVuY29kaW5nKCk7Cit9CisKIFBhc3NSZWZQdHI8Rm9ybVN1 Ym1pc3Npb24+IEZvcm1TdWJtaXNzaW9uOjpjcmVhdGUoSFRNTEZvcm1FbGVtZW50KiBmb3JtLCBj b25zdCBBdHRyaWJ1dGVzJiBhdHRyaWJ1dGVzLCBQYXNzUmVmUHRyPEV2ZW50PiBldmVudCwgTG9j a0hpc3RvcnkgbG9ja0hpc3RvcnksIEZvcm1TdWJtaXNzaW9uVHJpZ2dlciB0cmlnZ2VyKQogewog ICAgIEFTU0VSVChmb3JtKTsKQEAgLTE4Miw3ICsxOTksNyBAQCBQYXNzUmVmUHRyPEZvcm1TdWJt aXNzaW9uPiBGb3JtU3VibWlzc2lvbjo6Y3JlYXRlKEhUTUxGb3JtRWxlbWVudCogZm9ybSwgY29u c3QgQQogICAgICAgICB9CiAgICAgfQogCi0gICAgVGV4dEVuY29kaW5nIGRhdGFFbmNvZGluZyA9 IGlzTWFpbHRvRm9ybSA/IFVURjhFbmNvZGluZygpIDogRm9ybURhdGFCdWlsZGVyOjplbmNvZGlu Z0Zyb21BY2NlcHRDaGFyc2V0KGNvcGllZEF0dHJpYnV0ZXMuYWNjZXB0Q2hhcnNldCgpLCBkb2N1 bWVudCk7CisgICAgVGV4dEVuY29kaW5nIGRhdGFFbmNvZGluZyA9IGlzTWFpbHRvRm9ybSA/IFVU RjhFbmNvZGluZygpIDogZW5jb2RpbmdGcm9tQWNjZXB0Q2hhcnNldChjb3BpZWRBdHRyaWJ1dGVz LmFjY2VwdENoYXJzZXQoKSwgZG9jdW1lbnQpOwogICAgIFJlZlB0cjxET01Gb3JtRGF0YT4gZG9t Rm9ybURhdGEgPSBET01Gb3JtRGF0YTo6Y3JlYXRlKGRhdGFFbmNvZGluZy5lbmNvZGluZ0ZvckZv cm1TdWJtaXNzaW9uKCkpOwogICAgIFZlY3RvcjxzdGQ6OnBhaXI8U3RyaW5nLCBTdHJpbmc+PiBm b3JtVmFsdWVzOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L0Zvcm1EYXRhQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zv cm1EYXRhQnVpbGRlci5jcHAKaW5kZXggYWNhZDhlMC4uMjFmZjU4YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YUJ1aWxkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURhdGFCdWlsZGVyLmNwcApAQCAtMjYs NyArMjYsNiBAQAogI2luY2x1ZGUgIkZvcm1EYXRhQnVpbGRlci5oIgogCiAjaW5jbHVkZSAiQmxv Yi5oIgotI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiVGV4dEVuY29kaW5nLmgiCiAj aW5jbHVkZSA8bGltaXRzPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CkBAIC03NywyMyAr NzYsNiBAQCBzdGF0aWMgdm9pZCBhcHBlbmRRdW90ZWRTdHJpbmcoVmVjdG9yPGNoYXI+JiBidWZm ZXIsIGNvbnN0IENTdHJpbmcmIHN0cmluZykKICAgICB9CiB9CiAKLVRleHRFbmNvZGluZyBGb3Jt RGF0YUJ1aWxkZXI6OmVuY29kaW5nRnJvbUFjY2VwdENoYXJzZXQoY29uc3QgU3RyaW5nJiBhY2Nl cHRDaGFyc2V0LCBEb2N1bWVudCYgZG9jdW1lbnQpCi17Ci0gICAgU3RyaW5nIG5vcm1hbGl6ZWRB Y2NlcHRDaGFyc2V0ID0gYWNjZXB0Q2hhcnNldDsKLSAgICBub3JtYWxpemVkQWNjZXB0Q2hhcnNl dC5yZXBsYWNlKCcsJywgJyAnKTsKLQotICAgIFZlY3RvcjxTdHJpbmc+IGNoYXJzZXRzOwotICAg IG5vcm1hbGl6ZWRBY2NlcHRDaGFyc2V0LnNwbGl0KCcgJywgY2hhcnNldHMpOwotCi0gICAgZm9y IChhdXRvJiBjaGFyc2V0IDogY2hhcnNldHMpIHsKLSAgICAgICAgVGV4dEVuY29kaW5nIGVuY29k aW5nKGNoYXJzZXQpOwotICAgICAgICBpZiAoZW5jb2RpbmcuaXNWYWxpZCgpKQotICAgICAgICAg ICAgcmV0dXJuIGVuY29kaW5nOwotICAgIH0KLQotICAgIHJldHVybiBkb2N1bWVudC5pbnB1dEVu Y29kaW5nKCk7Ci19Ci0KIFZlY3RvcjxjaGFyPiBGb3JtRGF0YUJ1aWxkZXI6OmdlbmVyYXRlVW5p cXVlQm91bmRhcnlTdHJpbmcoKQogewogICAgIFZlY3RvcjxjaGFyPiBib3VuZGFyeTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURhdGFCdWlsZGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhQnVpbGRlci5oCmluZGV4 IDc3YjU5ZDEuLjdhZGVjYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvRm9ybURhdGFCdWlsZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9Gb3JtRGF0YUJ1aWxkZXIuaApAQCAtMjYsMTQgKzI2LDExIEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotY2xhc3MgRG9jdW1lbnQ7CiBjbGFzcyBUZXh0RW5jb2Rpbmc7CiAKIGNsYXNz IEZvcm1EYXRhQnVpbGRlciB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRm9ybURhdGFCdWls ZGVyKTsKIHB1YmxpYzoKLSAgICBzdGF0aWMgVGV4dEVuY29kaW5nIGVuY29kaW5nRnJvbUFjY2Vw dENoYXJzZXQoY29uc3QgU3RyaW5nJiBhY2NlcHRDaGFyc2V0LCBEb2N1bWVudCYpOwotCiAgICAg Ly8gSGVscGVyIGZ1bmN0aW9ucyB1c2VkIGJ5IEhUTUxGb3JtRWxlbWVudCBmb3IgbXVsdGktcGFy dCBmb3JtIGRhdGEKICAgICBzdGF0aWMgVmVjdG9yPGNoYXI+IGdlbmVyYXRlVW5pcXVlQm91bmRh cnlTdHJpbmcoKTsKICAgICBzdGF0aWMgdm9pZCBiZWdpbk11bHRpUGFydEhlYWRlcihWZWN0b3I8 Y2hhcj4mLCBjb25zdCBDU3RyaW5nJiBib3VuZGFyeSwgY29uc3QgQ1N0cmluZyYgbmFtZSk7Cg==