138164 2014-10-28 18:13:36 -0700 Crash in CachedRawResource::canReuse() when reloading http://dnd.wizards.com/dungeons-and-dragons/story 2014-10-29 00:59:01 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Critical --- 138079 1 cdumez cdumez andersca ap barraclough commit-queue darin kling rniwa sam oldest_to_newest 1044672 0 cdumez 2014-10-28 18:13:36 -0700 Crash in CachedRawResource::canReuse() when reloading http://dnd.wizards.com/dungeons-and-dragons/story This is due to the HTTPHeaderMap iterator not initializing the KeyValue correctly when there are only uncommon headers. BackTrace: 0 com.apple.JavaScriptCore 0x000000010d48488a WTFCrash + 42 1 com.apple.WebCore 0x000000010ea7283e WTF::CaseFoldingHash::hash(WTF::StringImpl*) + 62 (StringHash.h:97) 2 com.apple.WebCore 0x000000010ea727ed WTF::CaseFoldingHash::hash(WTF::String const&) + 29 (StringHash.h:128) 3 com.apple.WebCore 0x000000010ea725c5 unsigned int WTF::IdentityHashTranslator<WTF::CaseFoldingHash>::hash<WTF::String>(WTF::String const&) + 21 (HashTable.h:281) 4 com.apple.WebCore 0x000000010ec0e7c0 WTF::KeyValuePair<WTF::String, WTF::String>* WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, WTF::String> >, WTF::CaseFoldingHash, WTF::HashMap<WTF::String, WTF::String, WTF::CaseFoldingHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >::lookup<WTF::IdentityHashTranslator<WTF::CaseFoldingHash>, WTF::String>(WTF::String const&) + 80 (HashTable.h:595) 5 com.apple.WebCore 0x000000010ec0ea6d WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, WTF::String> >, WTF::CaseFoldingHash, WTF::HashMap<WTF::String, WTF::String, WTF::CaseFoldingHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >::lookup(WTF::String const&) + 29 (HashTable.h:407) 6 com.apple.WebCore 0x000000010ec0e54b WTF::HashMap<WTF::String, WTF::String, WTF::CaseFoldingHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::get(WTF::String const&) const + 43 (HashMap.h:351) 7 com.apple.WebCore 0x000000010ec0dbe6 WebCore::CachedRawResource::canReuse(WebCore::ResourceRequest const&) const + 742 (CachedRawResource.cpp:249) 8 com.apple.WebCore 0x000000010ec222ea WebCore::CachedResourceLoader::determineRevalidationPolicy(WebCore::CachedResource::Type, WebCore::ResourceRequest&, bool, WebCore::CachedResource*, WebCore::CachedResourceRequest::DeferOption) const + 186 (CachedResourceLoader.cpp:576) 9 com.apple.WebCore 0x000000010ec211bc WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&) + 1228 (CachedResourceLoader.cpp:455) 10 com.apple.WebCore 0x000000010ec21c80 WebCore::CachedResourceLoader::requestRawResource(WebCore::CachedResourceRequest&) + 64 (CachedResourceLoader.cpp:249) 11 com.apple.WebCore 0x000000010f038145 WebCore::DocumentThreadableLoader::loadRequest(WebCore::ResourceRequest const&, WebCore::SecurityCheckPolicy) + 709 (DocumentThreadableLoader.cpp:386) 12 com.apple.WebCore 0x000000010f037cf1 WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::DocumentThreadableLoader::BlockingBehavior, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderOptions const&) + 481 (DocumentThreadableLoader.cpp:86) 13 com.apple.WebCore 0x000000010f037a1b WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::DocumentThreadableLoader::BlockingBehavior, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderOptions const&) + 59 (DocumentThreadableLoader.cpp:95) 14 com.apple.WebCore 0x000000010f037a86 WebCore::DocumentThreadableLoader::create(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderOptions const&) + 86 (DocumentThreadableLoader.cpp:67) 15 com.apple.WebCore 0x00000001108d0227 WebCore::ThreadableLoader::create(WebCore::ScriptExecutionContext*, WebCore::ThreadableLoaderClient*, WebCore::ResourceRequest const&, WebCore::ThreadableLoaderOptions const&) + 295 (ThreadableLoader.cpp:62) 16 com.apple.WebCore 0x0000000110ab1461 WebCore::XMLHttpRequest::createRequest(int&) + 1825 (XMLHttpRequest.cpp:793) 17 com.apple.WebCore 0x0000000110ab096f WebCore::XMLHttpRequest::send(WTF::String const&, int&) + 751 (XMLHttpRequest.cpp:646) 18 com.apple.WebCore 0x0000000110ab0665 WebCore::XMLHttpRequest::send(int&) + 53 (XMLHttpRequest.cpp:587) 19 com.apple.WebCore 0x000000010fde9f8c WebCore::JSXMLHttpRequest::send(JSC::ExecState*) + 172 (JSXMLHttpRequestCustom.cpp:149) 20 com.apple.WebCore 0x000000010fde685f WebCore::jsXMLHttpRequestPrototypeFunctionSend(JSC::ExecState*) + 383 (JSXMLHttpRequest.cpp:934) Radar: <rdar://problem/18801997> 1044678 1 cdumez 2014-10-28 18:41:45 -0700 The fix is trivial but I am trying to write a layout test for it. 1044685 2 240589 cdumez 2014-10-28 20:26:53 -0700 Created attachment 240589 Patch 1044727 3 240589 kling 2014-10-29 00:19:25 -0700 Comment on attachment 240589 Patch r=me, thanks for the quick fix! 1044730 4 240589 commit-queue 2014-10-29 00:58:56 -0700 Comment on attachment 240589 Patch Clearing flags on attachment: 240589 Committed r175312: <http://trac.webkit.org/changeset/175312> 1044731 5 commit-queue 2014-10-29 00:59:01 -0700 All reviewed patches have been landed. Closing bug. 240589 2014-10-28 20:26:53 -0700 2014-10-29 00:58:56 -0700 Patch 138164_HTTPHeaderMap_crash.patch text/plain 5209 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhODkxYTk3Li5hYWE4ZDJiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMTAt MjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBD YWNoZWRSYXdSZXNvdXJjZTo6Y2FuUmV1c2UoKSB3aGVuIHJlbG9hZGluZyBodHRwOi8vZG5kLndp emFyZHMuY29tL2R1bmdlb25zLWFuZC1kcmFnb25zL3N0b3J5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgxNjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCB0aGF0IGRvZXMg WEhSIGxvYWRzIGZyb20gY2FjaGUgd2l0aCBvbmx5IHVuY29tbW9uCisgICAgICAgIEhUVFAgaGVh ZGVycyB0byByZXByb2R1Y2UgYSBjcmFzaCBpbiBDYWNoZWRSYXdSZXNvdXJjZTo6Y2FuUmV1c2Uo KQorICAgICAgICB3aGVuIGl0ZXJhdGluZyBvdmVyIGEgSFRUUEhlYWRlck1hcCB0aGF0IGhhZCB1 bmNvbW1vbiBIVFRQIGhlYWRlcnMKKyAgICAgICAgYnV0IG5vIGNvbW1vbiBvbmVzLgorCisgICAg ICAgICogaHR0cC90ZXN0cy9jYWNoZS94aHItdW5jb21tb24taGVhZGVyLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9jYWNoZS94aHItdW5jb21tb24taGVhZGVyLmh0 bWw6IEFkZGVkLgorCiAyMDE0LTEwLTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIGZhc3QvbXVsdGljb2wvbXVsdGljb2wtY3JhenktbmVzdGluZy5odG1s IHNvbWV0aW1lcyBjcmFzaGVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Nh Y2hlL3hoci11bmNvbW1vbi1oZWFkZXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9jYWNoZS94aHItdW5jb21tb24taGVhZGVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi5iYTA5MDdjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS94aHItdW5jb21tb24taGVhZGVyLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDExIEBACitUZXN0IHRoYXQgd2UgZG9uJ3QgY3Jhc2ggb24geGhyIGxvYWRzIGZy b20gY2FjaGUgd2l0aCBvbmx5IHVuY29tbW9uIEhUVFAgaGVhZGVycworCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKKworbG9hZAorbG9hZAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvY2FjaGUveGhyLXVuY29tbW9uLWhlYWRlci5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9jYWNoZS94aHItdW5jb21tb24taGVhZGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uZTcwNTUyNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvY2FjaGUveGhyLXVuY29tbW9uLWhlYWRlci5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzxz Y3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PGJvZHk+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CitkZXNjcmlwdGlvbigiVGVz dCB0aGF0IHdlIGRvbid0IGNyYXNoIG9uIHhociBsb2FkcyBmcm9tIGNhY2hlIHdpdGggb25seSB1 bmNvbW1vbiBIVFRQIGhlYWRlcnMiKTsKK2pzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5jdGlv biByZXBlYXQoKSB7CisgICAgdmFyIHJlcXVlc3QyID0gbmV3IFhNTEh0dHBSZXF1ZXN0KCk7Cisg ICAgcmVxdWVzdDIuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIGZ1bmN0aW9uKCkgeyBkZWJ1Zygi bG9hZCIpOyBmaW5pc2hKU1Rlc3QoKTsgfSwgZmFsc2UpOworICAgIHJlcXVlc3QyLmFkZEV2ZW50 TGlzdGVuZXIoImVycm9yIiwgZnVuY3Rpb24oKSB7IGRlYnVnKCJlcnJvciIpOyBmaW5pc2hKU1Rl c3QoKTsgfSwgZmFsc2UpOworICAgIHJlcXVlc3QyLmFkZEV2ZW50TGlzdGVuZXIoImFib3J0Iiwg ZnVuY3Rpb24oKSB7IGRlYnVnKCJhYm9ydCIpOyBmaW5pc2hKU1Rlc3QoKTsgfSwgZmFsc2UpOwor ICAgIHJlcXVlc3QyLm9wZW4oIkdFVCIsICJyZXNvdXJjZXMvZW1wdHkudHh0IiwgdHJ1ZSk7Cisg ICAgcmVxdWVzdDIuc2V0UmVxdWVzdEhlYWRlcigiWC1DdXN0b20xIiwgInRlc3QxIik7CisgICAg cmVxdWVzdDIuc2VuZCgpOworfQorCit2YXIgcmVxdWVzdCA9IG5ldyBYTUxIdHRwUmVxdWVzdCgp OworcmVxdWVzdC5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7IGRlYnVnKCJs b2FkIik7IHJlcGVhdCgpOyB9LCBmYWxzZSk7CityZXF1ZXN0LmFkZEV2ZW50TGlzdGVuZXIoImVy cm9yIiwgZnVuY3Rpb24oKSB7IGRlYnVnKCJlcnJvciIpOyByZXBlYXQoKTsgfSwgZmFsc2UpOwor cmVxdWVzdC5hZGRFdmVudExpc3RlbmVyKCJhYm9ydCIsIGZ1bmN0aW9uKCkgeyBkZWJ1ZygiYWJv cnQiKTsgcmVwZWF0KCk7IH0sIGZhbHNlKTsKK3JlcXVlc3Qub3BlbigiR0VUIiwgInJlc291cmNl cy9lbXB0eS50eHQiLCB0cnVlKTsKK3JlcXVlc3Quc2V0UmVxdWVzdEhlYWRlcigiWC1DdXN0b20x IiwgInRlc3QxIik7CityZXF1ZXN0LnNlbmQoKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii9q cy10ZXN0LXJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGJkMjA1MDcuLjhjMWI2MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAor MjAxNC0xMC0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIENy YXNoIGluIENhY2hlZFJhd1Jlc291cmNlOjpjYW5SZXVzZSgpIHdoZW4gcmVsb2FkaW5nIGh0dHA6 Ly9kbmQud2l6YXJkcy5jb20vZHVuZ2VvbnMtYW5kLWRyYWdvbnMvc3RvcnkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODE2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgYSBj cmFzaCB3aGVuIHJlbG9hZGluZyB0aGUgZm9sbG93aW5nIFVSTDoKKyAgICAgICAgaHR0cDovL2Ru ZC53aXphcmRzLmNvbS9kdW5nZW9ucy1hbmQtZHJhZ29ucy9zdG9yeQorCisgICAgICAgIFdlIHdl cmUgY3Jhc2hpbmcgaW4gQ2FjaGVkUmF3UmVzb3VyY2U6OmNhblJldXNlKCkgYmVjYXVzZSBoZWFk ZXIua2V5CisgICAgICAgIHdvdWxkIHNvbWV0aW1lcyBiZSBhIG51bGwgU3RyaW5nIGFuZCB3ZSB3 b3VsZCBjYWxsCisgICAgICAgIEhhc2hNYXA6OmdldChudWxsU3RyaW5nKS4KKworICAgICAgICBU aGUgcmVhbCBpc3N1ZSB3YXMgdGhhdCBoZWFkZXIua2V5IHdhcyBudWxsIGluIHRoZSBmaXJzdCBw bGFjZSwgd2hpY2gKKyAgICAgICAgbWVhbnMgdGhhdCBldmVuIHRob3VnaCB0aGUgSFRUUEhlYWRl ck1hcCBpdGVyYXRvciBpcyB2YWxpZCwgaXQtPmtleQorICAgICAgICBpcyBhIG51bGwgU3RyaW5n LCB3aGljaCBzaG91bGQgbmV2ZXIgaGFwcGVuLiBUaGVyZSB3YXMgYSBidWcgaW4gdGhlCisgICAg ICAgIEhUVFBIZWFkZXJNYXBDb25zdEl0ZXJhdG9yKCkgY29uc3RydWN0b3IgdGhhdCB3b3VsZCBj YXVzZSB0aGUKKyAgICAgICAgaXRlcmF0b3Iga2V5L3ZhbHVlIHBhaXIgdG8gbm90IGdldCBpbml0 aWFsaXplZCBpZiB0aGUgSFRUUEhlYWRlck1hcAorICAgICAgICBjb250YWluZWQgKm9ubHkqIHVu Y29tbW9uIEhUVFAgaGVhZGVycy4gVGhpcyBwYXRjaCB1cGRhdGVzIHRoZQorICAgICAgICBjb25z dHJ1Y3RvciBzbyB0aGF0IHdlIGZhbGwgYmFjayB0byB1cGRhdGluZyB0aGUga2V5L3ZhbHVlIGZy b20gdGhlCisgICAgICAgIHVuY29tbW9uIGhlYWRlciBtYXAsIGlmIHdlIGZhaWxlZCB0byBpbml0 aWFsaXplZCBmcm9tIHRoZSBjb21tb24KKyAgICAgICAgaGVhZGVyIG1hcCAoYmVjYXVzZSBpdCB3 YXMgZW1wdHkpLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvY2FjaGUveGhyLXVuY29tbW9u LWhlYWRlci5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAu aDoKKyAgICAgICAgKFdlYkNvcmU6OkhUVFBIZWFkZXJNYXA6OkhUVFBIZWFkZXJNYXBDb25zdEl0 ZXJhdG9yOjpIVFRQSGVhZGVyTWFwQ29uc3RJdGVyYXRvcik6CisKIDIwMTQtMTAtMjcgIEFkYSBD aGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIGEgbmV3IGFic3Ry YWN0IGNsYXNzIGNhbGxlZCBBdWRpb1Byb2R1Y2VyIGFuZCBrZWVwIGEgc2V0IG9mIEF1ZGlvUHJv ZHVjZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBI ZWFkZXJNYXAuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1h cC5oCmluZGV4IGNjMTEyYzQuLjZiMzU4ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5oCkBAIC01Nyw3ICs1Nyw4IEBAIHB1YmxpYzoKICAg ICAgICAgICAgICwgbV9jb21tb25IZWFkZXJzSXQoY29tbW9uSGVhZGVyc0l0KQogICAgICAgICAg ICAgLCBtX3VuY29tbW9uSGVhZGVyc0l0KHVuY29tbW9uSGVhZGVyc0l0KQogICAgICAgICB7Ci0g ICAgICAgICAgICB1cGRhdGVLZXlWYWx1ZShtX2NvbW1vbkhlYWRlcnNJdCk7CisgICAgICAgICAg ICBpZiAoIXVwZGF0ZUtleVZhbHVlKG1fY29tbW9uSGVhZGVyc0l0KSkKKyAgICAgICAgICAgICAg ICB1cGRhdGVLZXlWYWx1ZShtX3VuY29tbW9uSGVhZGVyc0l0KTsKICAgICAgICAgfQogCiAgICAg ICAgIHN0cnVjdCBLZXlWYWx1ZSB7Cg==