138152 2014-10-28 15:08:34 -0700 Generalize dirtying of parent's line boxes when taking a renderer out of tree. 2014-10-29 16:02:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn koivisto kondapallykalyan oldest_to_newest 1044619 0 kling 2014-10-28 15:08:34 -0700 We currently have calls to dirtyLinesFromChangedChild() scattered in various subclass implementations of RenderObject::willBeDestroyed(). I think we can do this in RenderElement::willBeRemovedFromTree() instead. It makes more sense to me that the act of removing the renderer from the tree is what dirties other things on the same line, not its actual destruction. 1044620 1 240573 kling 2014-10-28 15:09:06 -0700 Created attachment 240573 Patch 1044888 2 240573 commit-queue 2014-10-29 16:02:07 -0700 Comment on attachment 240573 Patch Clearing flags on attachment: 240573 Committed r175352: <http://trac.webkit.org/changeset/175352> 1044889 3 commit-queue 2014-10-29 16:02:10 -0700 All reviewed patches have been landed. Closing bug. 240573 2014-10-28 15:09:06 -0700 2014-10-29 16:02:07 -0700 Patch bug-138152.diff text/plain 5110 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZDdjOWZmLi4xNTJkNDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTQtMTAtMjggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEdlbmVyYWxpemUgZGlydHlpbmcgb2YgcGFyZW50J3MgbGluZSBib3hlcyB3aGVuIHRha2lu ZyBhIHJlbmRlcmVyIG91dCBvZiB0cmVlLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2Iv MTM4MTUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluc3RlYWQgb2YgY2FsbGluZyBkaXJ0eUxpbmVzRnJvbUNoYW5nZWRDaGlsZCgpIHdoZW4gY2Vy dGFpbiB0eXBlcyBvZiByZW5kZXJlcnMKKyAgICAgICAgYXJlIGFib3V0IHRvIGJlIGRlc3Ryb3ll ZCwgYWx3YXlzIGRvIHRoaXMgaW4gUmVuZGVyRWxlbWVudDo6d2lsbEJlUmVtb3ZlZEZyb21UcmVl KCkuCisKKyAgICAgICAgVGhpcyBpcyBwYXJ0IG9mIGFuIGVmZm9ydCB0byBtYWtlIHJlbmRlciB0 cmVlIHRlYXJkb3duIGxlc3MgaW5jb21wcmVoZW5zaWJsZS4KKworICAgICAgICBXZSBzdGlsbCBk b24ndCBib3RoZXIgYXQgYWxsIGlmIHdlJ3JlIGluIHRoZSBwcm9jZXNzIG9mIHRlYXJpbmcgZG93 biB0aGUgZW50aXJlCisgICAgICAgIHJlbmRlciB0cmVlLCBzaW5jZSB0aGF0IHdvdWxkIGJlIGEg d2FzdGUgb2YgdGltZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6d2lsbEJlRGVzdHJveWVkKToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJsb2NrRmxvdzo6d2lsbEJlRGVzdHJveWVkKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50Ojp3aWxsQmVSZW1v dmVkRnJvbVRyZWUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVySW5saW5lOjp3aWxsQmVEZXN0cm95ZWQpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJSZXBsYWNlZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJS ZXBsYWNlZDo6d2lsbEJlRGVzdHJveWVkKTogRGVsZXRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyUmVwbGFjZWQuaDoKKwogMjAxNC0xMC0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY29tbWVudCBmaXggZnJvbSByMTc1MjY3Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggMGRiMzBlZC4uOWE4 MWZiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC0yNDIs MTEgKzI0Miw2IEBAIHZvaWQgUmVuZGVyQmxvY2s6OndpbGxCZURlc3Ryb3llZCgpCiAgICAgLy8g cHJvcGVybHkgZGlydHkgbGluZSBib3hlcyB0aGF0IHRoZXkgYXJlIHJlbW92ZWQgZnJvbS4gRWZm ZWN0cyB0aGF0IGRvIDpiZWZvcmUvOmFmdGVyIG9ubHkgb24gaG92ZXIgY291bGQgY3Jhc2ggb3Ro ZXJ3aXNlLgogICAgIGRlc3Ryb3lMZWZ0b3ZlckNoaWxkcmVuKCk7CiAKLSAgICBpZiAoIWRvY3Vt ZW50QmVpbmdEZXN0cm95ZWQoKSkgewotICAgICAgICBpZiAocGFyZW50KCkpCi0gICAgICAgICAg ICBwYXJlbnQoKS0+ZGlydHlMaW5lc0Zyb21DaGFuZ2VkQ2hpbGQoKnRoaXMpOwotICAgIH0KLQog ICAgIHJlbW92ZUZyb21VcGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXRUcmFuc2FjdGlvbigpOwog CiAgICAgUmVuZGVyQm94Ojp3aWxsQmVEZXN0cm95ZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggMGIyMzcyMC4uYWU2NWU1ZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKQEAgLTE2Niw4ICsx NjYsNyBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6d2lsbEJlRGVzdHJveWVkKCkKICAgICAgICAg ICAgICAgICAgICAgICAgIGNoaWxkQm94LT5yZW1vdmVGcm9tUGFyZW50KCk7CiAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgfQotICAgICAgICB9IGVsc2UgaWYgKHBhcmVudCgpKQotICAg ICAgICAgICAgcGFyZW50KCktPmRpcnR5TGluZXNGcm9tQ2hhbmdlZENoaWxkKCp0aGlzKTsKKyAg ICAgICAgfQogICAgIH0KIAogICAgIG1fbGluZUJveGVzLmRlbGV0ZUxpbmVCb3hlcygpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCmluZGV4IDQ4NWE0NzAuLmYx YTI4NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKQEAg LTEwNDEsNyArMTA0MSw3IEBAIHZvaWQgUmVuZGVyRWxlbWVudDo6d2lsbEJlUmVtb3ZlZEZyb21U cmVlKCkKICAgICBpZiAobV9zdHlsZS0+aGFzRml4ZWRCYWNrZ3JvdW5kSW1hZ2UoKSAmJiAhZnJh bWUoKS5zZXR0aW5ncygpLmZpeGVkQmFja2dyb3VuZHNQYWludFJlbGF0aXZlVG9Eb2N1bWVudCgp KQogICAgICAgICB2aWV3KCkuZnJhbWVWaWV3KCkucmVtb3ZlU2xvd1JlcGFpbnRPYmplY3QodGhp cyk7CiAKLSAgICBpZiAoaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkgJiYgcGFyZW50KCktPmNoaWxk cmVuSW5saW5lKCkpCisgICAgaWYgKCFkb2N1bWVudEJlaW5nRGVzdHJveWVkKCkpCiAgICAgICAg IHBhcmVudCgpLT5kaXJ0eUxpbmVzRnJvbUNoYW5nZWRDaGlsZCgqdGhpcyk7CiAKICAgICBpZiAo YXV0byogY29udGFpbmVyRmxvd1RocmVhZCA9IHBhcmVudCgpLT5yZW5kZXJOYW1lZEZsb3dUaHJl YWRXcmFwcGVyKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy SW5saW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwCmlu ZGV4IGY4MDY0NzIuLjUyYzkwOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJJbmxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJ bmxpbmUuY3BwCkBAIC05OCw4ICs5OCw3IEBAIHZvaWQgUmVuZGVySW5saW5lOjp3aWxsQmVEZXN0 cm95ZWQoKQogICAgICAgICAgICAgICAgIGZvciAoYXV0byBib3ggPSBmaXJzdExpbmVCb3goKTsg Ym94OyBib3ggPSBib3gtPm5leHRMaW5lQm94KCkpCiAgICAgICAgICAgICAgICAgICAgIGJveC0+ cmVtb3ZlRnJvbVBhcmVudCgpOwogICAgICAgICAgICAgfQotICAgICAgICB9IGVsc2UgaWYgKHBh cmVudCgpKSAKLSAgICAgICAgICAgIHBhcmVudCgpLT5kaXJ0eUxpbmVzRnJvbUNoYW5nZWRDaGls ZCgqdGhpcyk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBtX2xpbmVCb3hlcy5kZWxldGVMaW5l Qm94ZXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBs YWNlZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwCmlu ZGV4IGIyN2RmMmMuLmYyN2Y3OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJSZXBsYWNlZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clJlcGxhY2VkLmNwcApAQCAtNzEsMTQgKzcxLDYgQEAgUmVuZGVyUmVwbGFjZWQ6On5SZW5kZXJS ZXBsYWNlZCgpCiB7CiB9CiAKLXZvaWQgUmVuZGVyUmVwbGFjZWQ6OndpbGxCZURlc3Ryb3llZCgp Ci17Ci0gICAgaWYgKCFkb2N1bWVudEJlaW5nRGVzdHJveWVkKCkgJiYgcGFyZW50KCkpCi0gICAg ICAgIHBhcmVudCgpLT5kaXJ0eUxpbmVzRnJvbUNoYW5nZWRDaGlsZCgqdGhpcyk7Ci0KLSAgICBS ZW5kZXJCb3g6OndpbGxCZURlc3Ryb3llZCgpOwotfQotCiB2b2lkIFJlbmRlclJlcGxhY2VkOjpz dHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUqIG9s ZFN0eWxlKQogewogICAgIFJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UoZGlmZiwgb2xkU3R5bGUp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuaAppbmRleCAyZTc4MjZj Li4zZmFhODg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVw bGFjZWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuaApA QCAtNDMsOCArNDMsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgUmVuZGVyUmVwbGFjZWQoRWxlbWVudCYs IFBhc3NSZWY8UmVuZGVyU3R5bGU+LCBjb25zdCBMYXlvdXRTaXplJiBpbnRyaW5zaWNTaXplKTsK ICAgICBSZW5kZXJSZXBsYWNlZChEb2N1bWVudCYsIFBhc3NSZWY8UmVuZGVyU3R5bGU+LCBjb25z dCBMYXlvdXRTaXplJiBpbnRyaW5zaWNTaXplKTsKIAotICAgIHZpcnR1YWwgdm9pZCB3aWxsQmVE ZXN0cm95ZWQoKSBvdmVycmlkZTsKLQogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKSBvdmVycmlk ZTsKIAogICAgIHZpcnR1YWwgTGF5b3V0U2l6ZSBpbnRyaW5zaWNTaXplKCkgY29uc3Qgb3ZlcnJp ZGUgZmluYWwgeyByZXR1cm4gbV9pbnRyaW5zaWNTaXplOyB9Cg==