138120 2014-10-27 19:47:36 -0700 REGRESSION(r175233): Broke many accessibility tests (Requested by ap on #webkit). 2014-10-27 20:00:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 commit-queue commit-queue benjamin oldest_to_newest 1044388 0 commit-queue 2014-10-27 19:47:36 -0700 http://trac.webkit.org/changeset/175233 broke the build: Broke many accessibility tests (Requested by ap on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1044389 1 240521 commit-queue 2014-10-27 19:47:57 -0700 Created attachment 240521 ROLLOUT of r175233 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1044390 2 ap 2014-10-27 19:48:21 -0700 Actually, it's easier to fix. 1044393 3 240521 cdumez 2014-10-27 19:59:11 -0700 Comment on attachment 240521 ROLLOUT of r175233 Hmm, interesting. The only difference seems to be if the Element actually has the use map attribute but that attribute is null. AFAIK, this is not supposed to happen. So if this change really caused the test regressions, we should probably try to understand how this happened. 1044394 4 240521 cdumez 2014-10-27 20:00:34 -0700 Comment on attachment 240521 ROLLOUT of r175233 View in context: https://bugs.webkit.org/attachment.cgi?id=240521&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2457 > + if (node && is<HTMLImageElement>(*node) && !downcast<HTMLImageElement>(*node).fastGetAttribute(usemapAttr).isNull()) Ah ah, never mind, I missed the extra "!" :) 240521 2014-10-27 19:47:57 -0700 2014-10-27 19:48:30 -0700 ROLLOUT of r175233 bug-138120-20141027194805.patch text/plain 1709 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY5Mzc0NWQ5MWVlZDA1 MmExY2ZhYzRlMjA0M2E2OGU5OGY1YjE0My4uZmM4NTcxZDE4OWY2MzlkN2Q3ODI1OWIzNDI5YzQz NmZlYzJiZmZhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEwLTI3ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTc1MjMzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM4MTIwCisKKyAgICAgICAgQnJva2UgbWFueSBhY2Nlc3NpYmlsaXR5 IHRlc3RzIChSZXF1ZXN0ZWQgYnkgYXAgb24gI3dlYmtpdCkuCisKKyAgICAgICAgUmV2ZXJ0ZWQg Y2hhbmdlc2V0OgorCisgICAgICAgICJDbGVhbnVwIGFmdGVyIHIxNzUyMTM6IGZhc3RHZXRBdHRy aWJ1dGUoKS5pc051bGwoKSBzaG91bGQgYmUKKyAgICAgICAgZmFzdEhhc0F0dHJpYnV0ZSgpIgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNzUyMzMKKwogMjAxNC0x MC0yNCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgdGV4dC1jb21i aW5lIG5lZWRzIHRvIGNlbnRlciB0ZXh0IHdpdGhpbiB0aGUgdmVydGljYWwgc3BhY2UgdXNpbmcg Z2x5cGggYm91bmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCA4ZDNlMGRkZTdkNmFhZmIzZTEw OGZmMzQ0MWQwYWUwYTYxYTM5MTQ3Li43YjUzMzZjZTQyMDBlZDZkOGY2NDMxZGMxNjdhMzY3OTBk YjVmMDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTI0NTQsNyArMjQ1NCw3IEBAIEFjY2Vz c2liaWxpdHlSb2xlIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmRldGVybWluZUFjY2Vzc2li aWxpdHlSb2xlKCkKIAogICAgIGlmIChub2RlICYmIG5vZGUtPmlzTGluaygpKQogICAgICAgICBy ZXR1cm4gV2ViQ29yZUxpbmtSb2xlOwotICAgIGlmIChub2RlICYmIGlzPEhUTUxJbWFnZUVsZW1l bnQ+KCpub2RlKSAmJiAhZG93bmNhc3Q8SFRNTEltYWdlRWxlbWVudD4oKm5vZGUpLmZhc3RIYXNB dHRyaWJ1dGUodXNlbWFwQXR0cikpCisgICAgaWYgKG5vZGUgJiYgaXM8SFRNTEltYWdlRWxlbWVu dD4oKm5vZGUpICYmICFkb3duY2FzdDxIVE1MSW1hZ2VFbGVtZW50Pigqbm9kZSkuZmFzdEdldEF0 dHJpYnV0ZSh1c2VtYXBBdHRyKS5pc051bGwoKSkKICAgICAgICAgcmV0dXJuIEltYWdlTWFwUm9s ZTsKICAgICBpZiAoKGNzc0JveCAmJiBjc3NCb3gtPmlzTGlzdEl0ZW0oKSkgfHwgKG5vZGUgJiYg bm9kZS0+aGFzVGFnTmFtZShsaVRhZykpKQogICAgICAgICByZXR1cm4gTGlzdEl0ZW1Sb2xlOwo=