138116 2014-10-27 18:02:11 -0700 Move RenderBlock::beingDestroyed() to RenderObject. 2014-10-27 22:39:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling buildbot commit-queue esprehn+autocc glenn koivisto kondapallykalyan rniwa oldest_to_newest 1044378 0 kling 2014-10-27 18:02:11 -0700 Make "is being destroyed" a RenderObject concept instead of restricting it to RenderBlocks. I'm guessing that this was specific to blocks due to lack of bitfield space in RenderObject, and that's no longer an issue. 1044379 1 240518 kling 2014-10-27 18:02:50 -0700 Created attachment 240518 Patch 1044423 2 240518 commit-queue 2014-10-27 22:39:37 -0700 Comment on attachment 240518 Patch Clearing flags on attachment: 240518 Committed r175242: <http://trac.webkit.org/changeset/175242> 1044424 3 commit-queue 2014-10-27 22:39:41 -0700 All reviewed patches have been landed. Closing bug. 240518 2014-10-27 18:02:50 -0700 2014-10-27 22:39:37 -0700 Patch bug-138116.diff text/plain 6423 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZDVmNjg3Li5mNTViNGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTQtMTAtMjcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIE1vdmUgUmVuZGVyQmxvY2s6OmJlaW5nRGVzdHJveWVkKCkgdG8gUmVuZGVyT2JqZWN0Lgor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4MTE2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgImlzIGJlaW5nIGRlc3Ryb3llZCIg YSBSZW5kZXJPYmplY3QgY29uY2VwdCBpbnN0ZWFkIG9mIHJlc3RyaWN0aW5nCisgICAgICAgIGl0 IHRvIFJlbmRlckJsb2Nrcy4gSSdtIGd1ZXNzaW5nIHRoYXQgdGhpcyB3YXMgc3BlY2lmaWMgdG8g YmxvY2tzIGR1ZSB0bworICAgICAgICBsYWNrIG9mIGJpdGZpZWxkIHNwYWNlIGluIFJlbmRlck9i amVjdCwgYW5kIHRoYXQncyBubyBsb25nZXIgYW4gaXNzdWUuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OlJlbmRl ckJsb2NrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjp3aWxsQmVEZXN0cm95ZWQp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyQmxvY2s6OmJlaW5nRGVzdHJveWVkKTogRGVsZXRlZC4KKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxv dzo6d2lsbEJlRGVzdHJveWVkKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6ZGVzdHJveSk6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0 OjpiZWluZ0Rlc3Ryb3llZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OlJlbmRl ck9iamVjdEJpdGZpZWxkczo6UmVuZGVyT2JqZWN0Qml0ZmllbGRzKToKKwogMjAxNC0xMC0yNyAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBzZXBhcmF0ZSBI YXNoTWFwcyBmb3IgY29tbW9uIGFuZCB1bmNvbW1vbiBoZWFkZXJzIGluIEhUVFBIZWFkZXJNYXAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDU0NzZkYWIuLjAy YzBjNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtMTg2 LDcgKzE4Niw2IEBAIFJlbmRlckJsb2NrOjpSZW5kZXJCbG9jayhFbGVtZW50JiBlbGVtZW50LCBQ YXNzUmVmPFJlbmRlclN0eWxlPiBzdHlsZSwgdW5zaWduZWQKICAgICAsIG1fbGluZUhlaWdodCgt MSkKICAgICAsIG1faGFzTWFyZ2luQmVmb3JlUXVpcmsoZmFsc2UpCiAgICAgLCBtX2hhc01hcmdp bkFmdGVyUXVpcmsoZmFsc2UpCi0gICAgLCBtX2JlaW5nRGVzdHJveWVkKGZhbHNlKQogICAgICwg bV9oYXNNYXJrdXBUcnVuY2F0aW9uKGZhbHNlKQogICAgICwgbV9oYXNCb3JkZXJPclBhZGRpbmdM b2dpY2FsV2lkdGhDaGFuZ2VkKGZhbHNlKQogICAgICwgbV9saW5lTGF5b3V0UGF0aChVbmRldGVy bWluZWRQYXRoKQpAQCAtMTk4LDcgKzE5Nyw2IEBAIFJlbmRlckJsb2NrOjpSZW5kZXJCbG9jayhE b2N1bWVudCYgZG9jdW1lbnQsIFBhc3NSZWY8UmVuZGVyU3R5bGU+IHN0eWxlLCB1bnNpZ25lCiAg ICAgLCBtX2xpbmVIZWlnaHQoLTEpCiAgICAgLCBtX2hhc01hcmdpbkJlZm9yZVF1aXJrKGZhbHNl KQogICAgICwgbV9oYXNNYXJnaW5BZnRlclF1aXJrKGZhbHNlKQotICAgICwgbV9iZWluZ0Rlc3Ry b3llZChmYWxzZSkKICAgICAsIG1faGFzTWFya3VwVHJ1bmNhdGlvbihmYWxzZSkKICAgICAsIG1f aGFzQm9yZGVyT3JQYWRkaW5nTG9naWNhbFdpZHRoQ2hhbmdlZChmYWxzZSkKICAgICAsIG1fbGlu ZUxheW91dFBhdGgoVW5kZXRlcm1pbmVkUGF0aCkKQEAgLTI0MCw5ICsyMzgsNiBAQCBib29sIFJl bmRlckJsb2NrOjpoYXNSYXJlRGF0YSgpIGNvbnN0CiAKIHZvaWQgUmVuZGVyQmxvY2s6OndpbGxC ZURlc3Ryb3llZCgpCiB7Ci0gICAgLy8gTWFyayBhcyBiZWluZyBkZXN0cm95ZWQgdG8gYXZvaWQg dHJvdWJsZSB3aXRoIG1lcmdlcyBpbiByZW1vdmVDaGlsZCgpLgotICAgIG1fYmVpbmdEZXN0cm95 ZWQgPSB0cnVlOwotCiAgICAgLy8gTWFrZSBzdXJlIHRvIGRlc3Ryb3kgYW5vbnltb3VzIGNoaWxk cmVuIGZpcnN0IHdoaWxlIHRoZXkgYXJlIHN0aWxsIGNvbm5lY3RlZCB0byB0aGUgcmVzdCBvZiB0 aGUgdHJlZSwgc28gdGhhdCB0aGV5IHdpbGwKICAgICAvLyBwcm9wZXJseSBkaXJ0eSBsaW5lIGJv eGVzIHRoYXQgdGhleSBhcmUgcmVtb3ZlZCBmcm9tLiBFZmZlY3RzIHRoYXQgZG8gOmJlZm9yZS86 YWZ0ZXIgb25seSBvbiBob3ZlciBjb3VsZCBjcmFzaCBvdGhlcndpc2UuCiAgICAgZGVzdHJveUxl ZnRvdmVyQ2hpbGRyZW4oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKaW5k ZXggNDkzMjQ4MC4uNTE5MjI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmgKQEAgLTY1LDggKzY1LDYgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgflJlbmRlckJsb2Nr KCk7CiAKIHB1YmxpYzoKLSAgICBib29sIGJlaW5nRGVzdHJveWVkKCkgY29uc3QgeyByZXR1cm4g bV9iZWluZ0Rlc3Ryb3llZDsgfQotCiAgICAgLy8gVGhlc2UgdHdvIGZ1bmN0aW9ucyBhcmUgb3Zl cnJpZGRlbiBmb3IgaW5saW5lLWJsb2NrLgogICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBsaW5lSGVp Z2h0KGJvb2wgZmlyc3RMaW5lLCBMaW5lRGlyZWN0aW9uTW9kZSwgTGluZVBvc2l0aW9uTW9kZSA9 IFBvc2l0aW9uT25Db250YWluaW5nTGluZSkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CiAgICAgdmly dHVhbCBpbnQgYmFzZWxpbmVQb3NpdGlvbihGb250QmFzZWxpbmUsIGJvb2wgZmlyc3RMaW5lLCBM aW5lRGlyZWN0aW9uTW9kZSwgTGluZVBvc2l0aW9uTW9kZSA9IFBvc2l0aW9uT25Db250YWluaW5n TGluZSkgY29uc3Qgb3ZlcnJpZGU7CkBAIC01MTgsNyArNTE2LDYgQEAgcHVibGljOgogICAgIG11 dGFibGUgc2lnbmVkIG1fbGluZUhlaWdodCA6IDI1OwogICAgIHVuc2lnbmVkIG1faGFzTWFyZ2lu QmVmb3JlUXVpcmsgOiAxOyAvLyBOb3RlIHRoZXNlIHF1aXJrIHZhbHVlcyBjYW4ndCBiZSBwdXQg aW4gUmVuZGVyQmxvY2tSYXJlRGF0YSBzaW5jZSB0aGV5IGFyZSBzZXQgdG9vIGZyZXF1ZW50bHku CiAgICAgdW5zaWduZWQgbV9oYXNNYXJnaW5BZnRlclF1aXJrIDogMTsKLSAgICB1bnNpZ25lZCBt X2JlaW5nRGVzdHJveWVkIDogMTsKICAgICB1bnNpZ25lZCBtX2hhc01hcmt1cFRydW5jYXRpb24g OiAxOwogICAgIHVuc2lnbmVkIG1faGFzQm9yZGVyT3JQYWRkaW5nTG9naWNhbFdpZHRoQ2hhbmdl ZCA6IDE7CiAgICAgZW51bSBMaW5lTGF5b3V0UGF0aCB7IFVuZGV0ZXJtaW5lZFBhdGgsIFNpbXBs ZUxpbmVzUGF0aCwgTGluZUJveGVzUGF0aCwgRm9yY2VMaW5lQm94ZXNQYXRoIH07CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IDVlM2M3MWMuLjBi MjM3MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zs b3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw CkBAIC0xNDMsOSArMTQzLDYgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6Omluc2VydGVkSW50b1Ry ZWUoKQogCiB2b2lkIFJlbmRlckJsb2NrRmxvdzo6d2lsbEJlRGVzdHJveWVkKCkKIHsKLSAgICAv LyBNYXJrIGFzIGJlaW5nIGRlc3Ryb3llZCB0byBhdm9pZCB0cm91YmxlIHdpdGggbWVyZ2VzIGlu IHJlbW92ZUNoaWxkKCkuCi0gICAgbV9iZWluZ0Rlc3Ryb3llZCA9IHRydWU7Ci0KICAgICBpZiAo cmVuZGVyTmFtZWRGbG93RnJhZ21lbnQoKSkKICAgICAgICAgc2V0UmVuZGVyTmFtZWRGbG93RnJh Z21lbnQoMCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJP YmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5k ZXggNjNkZWM4Zi4uYzI5NTUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9i amVjdC5jcHAKQEAgLTIwNjEsNiArMjA2MSw4IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpkZXN0cm95 QW5kQ2xlYW51cEFub255bW91c1dyYXBwZXJzKCkKIAogdm9pZCBSZW5kZXJPYmplY3Q6OmRlc3Ry b3koKQogeworICAgIG1fYml0ZmllbGRzLnNldEJlaW5nRGVzdHJveWVkKHRydWUpOworCiAjaWYg UExBVEZPUk0oSU9TKQogICAgIGlmIChoYXNMYXllcigpKQogICAgICAgICBkb3duY2FzdDxSZW5k ZXJCb3hNb2RlbE9iamVjdD4oKnRoaXMpLmxheWVyKCktPndpbGxCZURlc3Ryb3llZCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4IDUwMGI3MWYuLmM3Zjg0ODYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKQEAgLTM3OCw2ICszNzgs OCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGlubGluZSBib29sIGlzQWZ0ZXJDb250ZW50KGNvbnN0 IFJlbmRlck9iamVjdCogb2JqKSB7IHJldHVybiBvYmogJiYgb2JqLT5pc0FmdGVyQ29udGVudCgp OyB9CiAgICAgc3RhdGljIGlubGluZSBib29sIGlzQmVmb3JlT3JBZnRlckNvbnRlbnQoY29uc3Qg UmVuZGVyT2JqZWN0KiBvYmopIHsgcmV0dXJuIG9iaiAmJiBvYmotPmlzQmVmb3JlT3JBZnRlckNv bnRlbnQoKTsgfQogCisgICAgYm9vbCBiZWluZ0Rlc3Ryb3llZCgpIGNvbnN0IHsgcmV0dXJuIG1f Yml0ZmllbGRzLmJlaW5nRGVzdHJveWVkKCk7IH0KKwogICAgIGJvb2wgZXZlckhhZExheW91dCgp IGNvbnN0IHsgcmV0dXJuIG1fYml0ZmllbGRzLmV2ZXJIYWRMYXlvdXQoKTsgfQogCiAgICAgYm9v bCBjaGlsZHJlbklubGluZSgpIGNvbnN0IHsgcmV0dXJuIG1fYml0ZmllbGRzLmNoaWxkcmVuSW5s aW5lKCk7IH0KQEAgLTkyMCw3ICs5MjIsOCBAQCBwcml2YXRlOgogCiAgICAgcHVibGljOgogICAg ICAgICBSZW5kZXJPYmplY3RCaXRmaWVsZHMoY29uc3QgTm9kZSYgbm9kZSkKLSAgICAgICAgICAg IDogbV9uZWVkc0xheW91dChmYWxzZSkKKyAgICAgICAgICAgIDogbV9iZWluZ0Rlc3Ryb3llZChm YWxzZSkKKyAgICAgICAgICAgICwgbV9uZWVkc0xheW91dChmYWxzZSkKICAgICAgICAgICAgICwg bV9uZWVkc1Bvc2l0aW9uZWRNb3ZlbWVudExheW91dChmYWxzZSkKICAgICAgICAgICAgICwgbV9u b3JtYWxDaGlsZE5lZWRzTGF5b3V0KGZhbHNlKQogICAgICAgICAgICAgLCBtX3Bvc0NoaWxkTmVl ZHNMYXlvdXQoZmFsc2UpCkBAIC05NDgsNyArOTUxLDcgQEAgcHJpdmF0ZToKICAgICAgICAgewog ICAgICAgICB9CiAgICAgICAgIAotICAgICAgICAvLyAzMSBiaXRzIGhhdmUgYmVlbiB1c2VkIGhl cmUuIFRoZXJlIGlzIG9uZSBiaXQgYXZhaWxhYmxlLgorICAgICAgICBBRERfQk9PTEVBTl9CSVRG SUVMRChiZWluZ0Rlc3Ryb3llZCwgQmVpbmdEZXN0cm95ZWQpOwogICAgICAgICBBRERfQk9PTEVB Tl9CSVRGSUVMRChuZWVkc0xheW91dCwgTmVlZHNMYXlvdXQpOwogICAgICAgICBBRERfQk9PTEVB Tl9CSVRGSUVMRChuZWVkc1Bvc2l0aW9uZWRNb3ZlbWVudExheW91dCwgTmVlZHNQb3NpdGlvbmVk TW92ZW1lbnRMYXlvdXQpOwogICAgICAgICBBRERfQk9PTEVBTl9CSVRGSUVMRChub3JtYWxDaGls ZE5lZWRzTGF5b3V0LCBOb3JtYWxDaGlsZE5lZWRzTGF5b3V0KTsK