138111 2014-10-27 16:41:26 -0700 Remove App.PaneController.bugsChangeCount in the new perf dashboard 2016-02-16 13:52:45 -0800 1 1 1 Unclassified WebKit Perf Dashboard 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa benjamin cdumez commit-queue kling rniwa oldest_to_newest 1044358 0 rniwa 2014-10-27 16:41:26 -0700 Remove a dummy variable, bugsChangeCount, in App.PaneController added in r175006. 1044492 1 240546 rniwa 2014-10-28 09:14:01 -0700 Created attachment 240546 Patch 1044500 2 240546 rniwa 2014-10-28 09:25:12 -0700 Comment on attachment 240546 Patch Thanks for the review! 1044551 3 rniwa 2014-10-28 11:01:26 -0700 Committed r175262: <http://trac.webkit.org/changeset/175262> 240546 2014-10-28 09:14:01 -0700 2014-10-28 09:25:12 -0700 Patch bug-138111-20141028091409.patch text/plain 6909 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MjIzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBiOTBlNzg3OTRiMjUzMGU3YzMyOTM4N2RjMzViM2Q0NzM5NTFhZmUwLi5mMWJlMzY2OTBi OWJlZTJmNDhiNmU1ZjVjNGYyNjRjNGNmMmI3MmEyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNC0xMC0yNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgQXBwLlBhbmVDb250cm9sbGVyLmJ1Z3NDaGFu Z2VDb3VudCBpbiB0aGUgbmV3IHBlcmYgZGFzaGJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgxMTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy92Mi9hcHAuanM6CisgICAgICAgIChB cHAuUGFuZUNvbnRyb2xsZXIuYnVnc0NoYW5nZUNvdW50KTogUmVtb3ZlZC4KKyAgICAgICAgKEFw cC5QYW5lQ29udHJvbGxlci5hY3Rpb25zLmFzc29jaWF0ZUJ1Zyk6IENhbGwgX3VwZGF0ZU1hcmtl ZFBvaW50cyBpbnN0ZWFkIG9mIGluY3JlbWVudGluZyBidWdzQ2hhbmdlQ291bnQuCisgICAgICAg IChBcHAuUGFuZUNvbnRyb2xsZXIuX3VwZGF0ZU1hcmtlZFBvaW50cyk6IEV4dHJhY3RlZCBmcm9t IEFwcC5JbnRlcmFjdGl2ZUNoYXJ0Q29tcG9uZW50Ll91cGRhdGVEb3RzV2l0aEJ1Z3MuCisgICAg ICAgIEZpbmRzIHRoZSBsaXN0IG9mIGN1cnJlbnQgcnVuJ3MgcG9pbnRzIHRoYXQgYXJlIGFzc29j aWF0ZWQgd2l0aCBidWdzLgorICAgICAgICAoQXBwLkludGVyYWN0aXZlQ2hhcnRDb21wb25lbnQu X3VwZGF0ZU1hcmtlZERvdHMpOiBSZW5hbWVkIGZyb20gX3VwZGF0ZURvdHNXaXRoQnVncy4KKyAg ICAgICAgKiBwdWJsaWMvdjIvY2hhcnQtcGFuZS5jc3M6CisgICAgICAgICguY2hhcnQgLm1hcmtl ZCk6IFJlbmFtZWQgZnJvbSAuaGFzQnVncy4KKyAgICAgICAgKiBwdWJsaWMvdjIvaW5kZXguaHRt bDogU3BlY2lmeSBjaGFydFBvaW50UmFkaXVzIGFuZCBtYXJrZWRQb2ludHMuCisKIDIwMTQtMTAt MTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGVyZiBkYXNo Ym9hcmQgc2hvdWxkIHByb3ZpZGUgYSB3YXkgdG8gYXNzb2NpYXRlIGJ1Z3Mgd2l0aCBhIHRlc3Qg cnVuCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5q cyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvYXBwLmpzCmluZGV4IGVlN2Rk M2ViZDQwOGFiZDk4Yzk5ODg2MDQxYjkyMmI1YmFiNGM0ZTcuLmRiZmFlZmEzOGM1YWMyOTkxMjhj YmUxZmYzMDA0YWVhMjdmMDRlYTggMTAwNzU1Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9wdWJsaWMvdjIvYXBwLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMv djIvYXBwLmpzCkBAIC02NjQsNyArNjY0LDYgQEAgQXBwLlBhbmVDb250cm9sbGVyID0gRW1iZXIu T2JqZWN0Q29udHJvbGxlci5leHRlbmQoewogICAgIHNoYXJlZFRpbWU6IEVtYmVyLmNvbXB1dGVk LmFsaWFzKCdwYXJlbnRDb250cm9sbGVyLnNoYXJlZFRpbWUnKSwKICAgICBzaGFyZWRTZWxlY3Rp b246IEVtYmVyLmNvbXB1dGVkLmFsaWFzKCdwYXJlbnRDb250cm9sbGVyLnNoYXJlZFNlbGVjdGlv bicpLAogICAgIHNlbGVjdGlvbjogbnVsbCwKLSAgICBidWdzQ2hhbmdlQ291bnQ6IDAsIC8vIERp cnR5IGhhY2suIFVzZWQgdG8gY2FsbCBJbnRlcmFjdGl2ZUNoYXJ0Q29tcG9uZW50J3MgX3VwZGF0 ZURvdHNXaXRoQnVncy4KICAgICBhY3Rpb25zOiB7CiAgICAgICAgIHRvZ2dsZURldGFpbHM6IGZ1 bmN0aW9uKCkKICAgICAgICAgewpAQCAtNjg5LDcgKzY4OCw3IEBAIEFwcC5QYW5lQ29udHJvbGxl ciA9IEVtYmVyLk9iamVjdENvbnRyb2xsZXIuZXh0ZW5kKHsKICAgICAgICAgICAgIHZhciBzZWxm ID0gdGhpczsKICAgICAgICAgICAgIHBvaW50Lm1lYXN1cmVtZW50LmFzc29jaWF0ZUJ1ZyhidWdU cmFja2VyLmdldCgnaWQnKSwgYnVnTnVtYmVyKS50aGVuKGZ1bmN0aW9uICgpIHsKICAgICAgICAg ICAgICAgICBzZWxmLl91cGRhdGVCdWdzKCk7Ci0gICAgICAgICAgICAgICAgc2VsZi5zZXQoJ2J1 Z3NDaGFuZ2VDb3VudCcsIHNlbGYuZ2V0KCdidWdzQ2hhbmdlQ291bnQnKSArIDEpOworICAgICAg ICAgICAgICAgIHNlbGYuX3VwZGF0ZU1hcmtlZFBvaW50cygpOwogICAgICAgICAgICAgfSk7CiAg ICAgICAgIH0sCiAgICAgICAgIHRvZ2dsZVNlYXJjaFBhbmU6IGZ1bmN0aW9uICgpCkBAIC04NDEs NyArODQwLDI0IEBAIEFwcC5QYW5lQ29udHJvbGxlciA9IEVtYmVyLk9iamVjdENvbnRyb2xsZXIu ZXh0ZW5kKHsKICAgICAgICAgICAgICAgICBlZGl0ZWRCdWdOdW1iZXI6IHRoaXMuX2hhc1Jhbmdl ID8gbnVsbCA6IGJ1Z051bWJlcnNbMF0sCiAgICAgICAgICAgICB9KTsgLy8gRklYTUU6IENyZWF0 ZSB1cmxzIGZvciBuZXcgYnVncy4KICAgICAgICAgfSkpOwotICAgIH0KKyAgICB9LAorICAgIF91 cGRhdGVNYXJrZWRQb2ludHM6IGZ1bmN0aW9uICgpCisgICAgeworICAgICAgICB2YXIgY2hhcnRE YXRhID0gdGhpcy5nZXQoJ2NoYXJ0RGF0YScpOworICAgICAgICBpZiAoIWNoYXJ0RGF0YSB8fCAh Y2hhcnREYXRhLmN1cnJlbnQpIHsKKyAgICAgICAgICAgIHRoaXMuc2V0KCdtYXJrZWRQb2ludHMn LCB7fSk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICB2YXIgc2Vy aWVzID0gY2hhcnREYXRhLmN1cnJlbnQudGltZVNlcmllc0J5Q29tbWl0VGltZSgpLnNlcmllcygp OworICAgICAgICB2YXIgbWFya2VkUG9pbnRzID0ge307CisgICAgICAgIGZvciAodmFyIGkgPSAw OyBpIDwgc2VyaWVzLmxlbmd0aDsgaSsrKSB7CisgICAgICAgICAgICB2YXIgbWVhc3VyZW1lbnQg PSBzZXJpZXNbaV0ubWVhc3VyZW1lbnQ7CisgICAgICAgICAgICBpZiAobWVhc3VyZW1lbnQuaGFz QnVncygpKQorICAgICAgICAgICAgICAgIG1hcmtlZFBvaW50c1ttZWFzdXJlbWVudC5pZCgpXSA9 IHRydWU7CisgICAgICAgIH0KKyAgICAgICAgdGhpcy5zZXQoJ21hcmtlZFBvaW50cycsIG1hcmtl ZFBvaW50cyk7CisgICAgfS5vYnNlcnZlcygnY2hhcnREYXRhJyksCiB9KTsKIAogQXBwLkludGVy YWN0aXZlQ2hhcnRDb21wb25lbnQgPSBFbWJlci5Db21wb25lbnQuZXh0ZW5kKHsKQEAgLTk4Nyw3 ICsxMDAzLDcgQEAgQXBwLkludGVyYWN0aXZlQ2hhcnRDb21wb25lbnQgPSBFbWJlci5Db21wb25l bnQuZXh0ZW5kKHsKICAgICAgICAgICAgICAgICAuZGF0YSh0aGlzLl9jdXJyZW50VGltZVNlcmll c0RhdGEpCiAgICAgICAgICAgICAuZW50ZXIoKS5hcHBlbmQoImNpcmNsZSIpCiAgICAgICAgICAg ICAgICAgLmF0dHIoImNsYXNzIiwgImRvdCIpCi0gICAgICAgICAgICAgICAgLmF0dHIoInIiLCB0 aGlzLmdldCgnaW50ZXJhY3RpdmUnKSA/IDIgOiAxKSk7CisgICAgICAgICAgICAgICAgLmF0dHIo InIiLCB0aGlzLmdldCgnY2hhcnRQb2ludFJhZGl1cycpIHx8IDEpKTsKIAogICAgICAgICBpZiAo dGhpcy5nZXQoJ2ludGVyYWN0aXZlJykpIHsKICAgICAgICAgICAgIHRoaXMuX2F0dGFjaEV2ZW50 TGlzdGVuZXIoZWxlbWVudCwgIm1vdXNlbW92ZSIsIHRoaXMuX21vdXNlTW92ZWQuYmluZCh0aGlz KSk7CkBAIC0xMTE4LDcgKzExMzQsNyBAQCBBcHAuSW50ZXJhY3RpdmVDaGFydENvbXBvbmVudCA9 IEVtYmVyLkNvbXBvbmVudC5leHRlbmQoewogICAgICAgICAgICAgICAgIC5hdHRyKCJjeCIsIGZ1 bmN0aW9uKG1lYXN1cmVtZW50KSB7IHJldHVybiB4U2NhbGUobWVhc3VyZW1lbnQudGltZSk7IH0p CiAgICAgICAgICAgICAgICAgLmF0dHIoImN5IiwgZnVuY3Rpb24obWVhc3VyZW1lbnQpIHsgcmV0 dXJuIHlTY2FsZShtZWFzdXJlbWVudC52YWx1ZSk7IH0pOwogICAgICAgICB9KTsKLSAgICAgICAg dGhpcy5fdXBkYXRlRG90c1dpdGhCdWdzKCk7CisgICAgICAgIHRoaXMuX3VwZGF0ZU1hcmtlZERv dHMoKTsKICAgICAgICAgdGhpcy5fdXBkYXRlSGlnaGxpZ2h0UG9zaXRpb25zKCk7CiAKICAgICAg ICAgaWYgKHRoaXMuX2JydXNoKSB7CkBAIC0xMTQ3LDEzICsxMTYzLDE1IEBAIEFwcC5JbnRlcmFj dGl2ZUNoYXJ0Q29tcG9uZW50ID0gRW1iZXIuQ29tcG9uZW50LmV4dGVuZCh7CiAgICAgICAgICAg ICAuc3R5bGUoInotaW5kZXgiLCAiMTAwIikKICAgICAgICAgICAgIC50ZXh0KHRoaXMuX3lBeGlz VW5pdCk7CiAgICAgfSwKLSAgICBfdXBkYXRlRG90c1dpdGhCdWdzOiBmdW5jdGlvbiAoKSB7Ci0g ICAgICAgIGlmICghdGhpcy5nZXQoJ2ludGVyYWN0aXZlJykpCi0gICAgICAgICAgICByZXR1cm47 CisgICAgX3VwZGF0ZU1hcmtlZERvdHM6IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgdmFyIG1hcmtl ZFBvaW50cyA9IHRoaXMuZ2V0KCdtYXJrZWRQb2ludHMnKSB8fCB7fTsKKyAgICAgICAgdmFyIGRl ZmF1bHREb3RSYWRpdXMgPSB0aGlzLmdldCgnY2hhcnRQb2ludFJhZGl1cycpIHx8IDE7CiAgICAg ICAgIHRoaXMuX2RvdHMuZm9yRWFjaChmdW5jdGlvbiAoZG90KSB7Ci0gICAgICAgICAgICBkb3Qu Y2xhc3NlZCgnaGFzQnVncycsIGZ1bmN0aW9uIChwb2ludCkgeyByZXR1cm4gISFwb2ludC5tZWFz dXJlbWVudC5oYXNCdWdzKCk7IH0pOwotICAgICAgICB9KQotICAgIH0ub2JzZXJ2ZXMoJ2J1Z3ND aGFuZ2VDb3VudCcpLCAvLyBOZXZlciB1c2VkIGZvciBhbnl0aGluZyBidXQgdG8gY2FsbCB0aGlz IG1ldGhvZCA6KAorICAgICAgICAgICAgZG90LmNsYXNzZWQoJ21hcmtlZCcsIGZ1bmN0aW9uIChw b2ludCkgeyByZXR1cm4gbWFya2VkUG9pbnRzW3BvaW50Lm1lYXN1cmVtZW50LmlkKCldOyB9KTsK KyAgICAgICAgICAgIGRvdC5hdHRyKCdyJywgZnVuY3Rpb24gKHBvaW50KSB7CisgICAgICAgICAg ICAgICAgcmV0dXJuIG1hcmtlZFBvaW50c1twb2ludC5tZWFzdXJlbWVudC5pZCgpXSA/IGRlZmF1 bHREb3RSYWRpdXMgKiAxLjUgOiBkZWZhdWx0RG90UmFkaXVzOyB9KTsKKyAgICAgICAgfSk7Cisg ICAgfS5vYnNlcnZlcygnbWFya2VkUG9pbnRzJyksCiAgICAgX3VwZGF0ZUhpZ2hsaWdodFBvc2l0 aW9uczogZnVuY3Rpb24gKCkgewogICAgICAgICB2YXIgeFNjYWxlID0gdGhpcy5feDsKICAgICAg ICAgdmFyIHlTY2FsZSA9IHRoaXMuX3k7CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL3YyL2NoYXJ0LXBhbmUuY3NzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy92Mi9jaGFydC1wYW5lLmNzcwppbmRleCA2Mzg0Mzg5ZWVkZTQzZjBlYmU1MDA5Y2Vk ZWU1NTBhMmE0NzQ0YjcyLi4zYjBiN2YyZWE5MDg1NWVjOGIyZjY5YmE0NGZiNjdmYjM5MWIzYjY1 IDEwMDc1NQotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2NoYXJ0LXBh bmUuY3NzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvY2hhcnQtcGFu ZS5jc3MKQEAgLTI1OCw4ICsyNTgsOCBAQAogICAgIHN0cm9rZTogbm9uZTsKIH0KIAotLmNoYXJ0 IC5oYXNCdWdzIHsKLSAgICBmaWxsOiAjMzNmOworLmNoYXJ0IC5tYXJrZWQgeworICAgIGZpbGw6 ICNjMzM7CiB9CiAKIC5jaGFydCBwYXRoLmFyZWEgewpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVy Zi53ZWJraXQub3JnL3B1YmxpYy92Mi9pbmRleC5odG1sIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy92Mi9pbmRleC5odG1sCmluZGV4IDkzNGJhOGQ2MmU2MTNiNDViNzExODlmYTg4 ODZjNDg4NTI1NjllYjMuLjg5MmQ5NTZhMWY2MmU4N2Y1OWUxMDg2N2RlOGFkNWIyZDFkMWZlNjgg MTAwNzU1Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvaW5kZXguaHRt bAorKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2luZGV4Lmh0bWwKQEAg LTE1NCw2ICsxNTQsNyBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoYXJ0RGF0YT1j aGFydERhdGEKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21haW49bWFpblBsb3REb21h aW4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRlcmFjdGl2ZT10cnVlCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY2hhcnRQb2ludFJhZGl1cz0yCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY3VycmVudEl0ZW09Y3VycmVudEl0ZW0KICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjdXJyZW50VGltZT1zaGFyZWRUaW1lCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc2VsZWN0ZWRJdGVtPXNlbGVjdGVkSXRlbQpAQCAtMTYyLDcgKzE2Myw3IEBACiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2hhcmVkU2VsZWN0aW9uPXNoYXJlZFNlbGVjdGlvbgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGVjdGlvbkNoYW5nZWQ9InJhbmdlQ2hhbmdlZCIK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxlY3Rpb25Jc0xvY2tlZD10aW1lUmFuZ2VJ c0xvY2tlZAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1Z3NDaGFuZ2VDb3VudD1idWdz Q2hhbmdlQ291bnQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYXJrZWRQb2ludHM9bWFy a2VkUG9pbnRzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgem9vbT0iem9vbWVkIn19CiAg ICAgICAgICAgICAgICAgICAgIHt7ZWxzZX19CiAgICAgICAgICAgICAgICAgICAgICAgICB7eyNp ZiBmYWlsdXJlfX0K