138099 2014-10-27 11:44:00 -0700 REGRESSION: commit logs are not shown sometimes on the new dashboard UI 2014-10-27 16:13:34 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa benjamin buildbot commit-queue kling rniwa sam oldest_to_newest 1044283 0 rniwa 2014-10-27 11:44:00 -0700 Apparently, I regressed this when I added the ability to search commit logs. 1044312 1 240498 rniwa 2014-10-27 13:26:15 -0700 Created attachment 240498 Fixes the bug 1044341 2 240498 benjamin 2014-10-27 14:53:27 -0700 Comment on attachment 240498 Fixes the bug rs=me 1044356 3 240498 commit-queue 2014-10-27 16:13:27 -0700 Comment on attachment 240498 Fixes the bug Clearing flags on attachment: 240498 Committed r175234: <http://trac.webkit.org/changeset/175234> 1044357 4 commit-queue 2014-10-27 16:13:34 -0700 All reviewed patches have been landed. Closing bug. 240498 2014-10-27 13:26:15 -0700 2014-10-27 16:13:27 -0700 Fixes the bug bug-138099-20141027132623.patch text/plain 3107 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MjIzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBiOTBlNzg3OTRiMjUzMGU3YzMyOTM4N2RjMzViM2Q0NzM5NTFhZmUwLi44ZjhhYWZjMTNm OTkwNDhhMjMxMjU4N2YyMjQ4ZGNiNDg5YzZmOTAyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OOiBjb21taXQgbG9ncyBhcmUgbm90IHNo b3duIHNvbWV0aW1lcyBvbiB0aGUgbmV3IGRhc2hib2FyZCBVSQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MDk5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IF9jdXJy ZW50SXRlbUNoYW5nZWQgbm90IHBhc3NpbmcgdGhlIHByZXZpb3VzIHBvaW50IGluIHRoZSBsaXN0 IG9mIHBvaW50cyBhbmQgYWxzbworICAgICAgICBfc2hvd0RldGFpbHMgaW52ZXJ0aW5nIHRoZSBv cmRlciBvZiB0aGUgY3VycmVudCBhbmQgb2xkIG1lYXN1cmVtZW50cy4KKworICAgICAgICAqIHB1 YmxpYy92Mi9hcHAuanM6CisgICAgICAgIChBcHAuUGFuZUNvbnRyb2xsZXIuX2N1cnJlbnRJdGVt Q2hhbmdlZCk6IFBhc3MgaW4gdGhlIHByZXZpb3VzIHBvaW50IHRvIF9zaG93RGV0YWlscyB3aGVu IHRoZXJlIGlzIG9uZS4KKyAgICAgICAgKEFwcC5QYW5lQ29udHJvbGxlci5fc2hvd0RldGFpbHMp OiBTaW5jZSBwb2ludHMgYXJlIG9yZGVyZWQgY2hyb25vbG9naWNhbGx5LCB0aGUgbGFzdCBwb2lu dCBpcyB0aGUKKyAgICAgICAgY3VycmVudCAobGF0ZXN0KSBtZWFzdXJlbWVudCBhbmQgdGhlIGZp cnN0IHBvaW50IGlzIHRoZSBvbGRlc3QgbWVhc3VyZW1lbnQuCisgICAgICAgIChBcHAuQ29tbWl0 c1ZpZXdlckNvbXBvbmVudC5jb21taXRzQ2hhbmdlZCk6IERvbid0IHNob3cgYSBzaW5nbGUgbWVh c3VyZW1lbnQgYXMgYSByYW5nZSBmb3IgY2xhcml0eS4KKwogMjAxNC0xMC0xOCAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBQZXJmIGRhc2hib2FyZCBzaG91bGQg cHJvdmlkZSBhIHdheSB0byBhc3NvY2lhdGUgYnVncyB3aXRoIGEgdGVzdCBydW4KZGlmZiAtLWdp dCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvYXBwLmpzIGIvV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9hcHAuanMKaW5kZXggZWU3ZGQzZWJkNDA4YWJkOThj OTk4ODYwNDFiOTIyYjViYWI0YzRlNy4uMzA5ZGQwZjQ1ZDRiZjEzYjc0N2E1MjEzZDhmZWVhOTBm OTQ3Yzc0MyAxMDA3NTUKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9h cHAuanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9hcHAuanMKQEAg LTc2OSwxNCArNzY5LDE2IEBAIEFwcC5QYW5lQ29udHJvbGxlciA9IEVtYmVyLk9iamVjdENvbnRy b2xsZXIuZXh0ZW5kKHsKICAgICAgICAgdmFyIHBvaW50ID0gdGhpcy5nZXQoJ2N1cnJlbnRJdGVt Jyk7CiAgICAgICAgIGlmICghcG9pbnQgfHwgIXBvaW50Lm1lYXN1cmVtZW50KQogICAgICAgICAg ICAgdGhpcy5zZXQoJ2RldGFpbHMnLCBudWxsKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAg dGhpcy5fc2hvd0RldGFpbHMoW3BvaW50XSk7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAg dmFyIHByZXZpb3VzUG9pbnQgPSBwb2ludC5zZXJpZXMucHJldmlvdXNQb2ludChwb2ludCk7Cisg ICAgICAgICAgICB0aGlzLl9zaG93RGV0YWlscyhwcmV2aW91c1BvaW50ID8gW3ByZXZpb3VzUG9p bnQsIHBvaW50XSA6IFtwb2ludF0pOworICAgICAgICB9CiAgICAgfS5vYnNlcnZlcygnY3VycmVu dEl0ZW0nKSwKICAgICBfc2hvd0RldGFpbHM6IGZ1bmN0aW9uIChwb2ludHMpCiAgICAgewogICAg ICAgICB2YXIgaXNTaG93aW5nRW5kUG9pbnQgPSAhdGhpcy5faGFzUmFuZ2U7Ci0gICAgICAgIHZh ciBjdXJyZW50TWVhc3VyZW1lbnQgPSBwb2ludHNbMF0ubWVhc3VyZW1lbnQ7Ci0gICAgICAgIHZh ciBvbGRNZWFzdXJlbWVudCA9IHBvaW50c1twb2ludHMubGVuZ3RoIC0gMV0ubWVhc3VyZW1lbnQ7 CisgICAgICAgIHZhciBjdXJyZW50TWVhc3VyZW1lbnQgPSBwb2ludHNbcG9pbnRzLmxlbmd0aCAt IDFdLm1lYXN1cmVtZW50OworICAgICAgICB2YXIgb2xkTWVhc3VyZW1lbnQgPSBwb2ludHNbMF0u bWVhc3VyZW1lbnQ7CiAgICAgICAgIHZhciBmb3JtYXR0ZWRSZXZpc2lvbnMgPSBjdXJyZW50TWVh c3VyZW1lbnQuZm9ybWF0dGVkUmV2aXNpb25zKG9sZE1lYXN1cmVtZW50KTsKICAgICAgICAgdmFy IHJldmlzaW9ucyA9IEFwcC5NYW5pZmVzdC5nZXQoJ3JlcG9zaXRvcmllcycpCiAgICAgICAgICAg ICAuZmlsdGVyKGZ1bmN0aW9uIChyZXBvc2l0b3J5KSB7IHJldHVybiBmb3JtYXR0ZWRSZXZpc2lv bnNbcmVwb3NpdG9yeS5nZXQoJ2lkJyldOyB9KQpAQCAtMTUzOCw3ICsxNTQwLDcgQEAgQXBwLkNv bW1pdHNWaWV3ZXJDb21wb25lbnQgPSBFbWJlci5Db21wb25lbnQuZXh0ZW5kKHsKICAgICAgICAg dmFyIHJldmlzaW9uSW5mbyA9IHRoaXMuZ2V0KCdyZXZpc2lvbkluZm8nKTsKIAogICAgICAgICB2 YXIgdG8gPSByZXZpc2lvbkluZm8uZ2V0KCdjdXJyZW50UmV2aXNpb24nKTsKLSAgICAgICAgdmFy IGZyb20gPSByZXZpc2lvbkluZm8uZ2V0KCdwcmV2aW91c1JldmlzaW9uJykgfHwgdG87CisgICAg ICAgIHZhciBmcm9tID0gcmV2aXNpb25JbmZvLmdldCgncHJldmlvdXNSZXZpc2lvbicpOwogICAg ICAgICB2YXIgcmVwb3NpdG9yeSA9IHRoaXMuZ2V0KCdyZXBvc2l0b3J5Jyk7CiAgICAgICAgIGlm ICghZnJvbSB8fCAhcmVwb3NpdG9yeSB8fCAhcmVwb3NpdG9yeS5nZXQoJ2hhc1JlcG9ydGVkQ29t bWl0cycpKQogICAgICAgICAgICAgcmV0dXJuOwo=