138098 2014-10-27 11:27:39 -0700 http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots 2014-10-28 09:44:32 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified OS X 10.9 RESOLVED FIXED P2 Normal --- 1 slewis ap ap commit-queue ossy slewis oldest_to_newest 1044280 0 slewis 2014-10-27 11:27:39 -0700 Failing intermittently on Yosemite WK1 Release bots. https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r175220%20(186)/results.html https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r175220%20(186)/http/tests/cookies/third-party-cookie-relaxing-pretty-diff.html Updating expectations 1044287 1 ap 2014-10-27 12:16:00 -0700 As far as I can tell, updated expectations have not been landed yet. This is kind of a bad test to skip, as we don't have much coverage. Looking into what's going on now. I can reliably reproduce by running an arbitrary test repeatedly in one terminal window, and this test in another window: run-webkit-tests -f --child-processes=7 --repeat=10000 css3/selectors3/html/css3-modsel-68.html run-webkit-tests http/tests/cookies/third-party-cookie-relaxing.html --no-retry --no-show 1044289 2 slewis 2014-10-27 12:17:45 -0700 Updated Expectations in http://trac.webkit.org/projects/webkit/changeset/175223 1044293 3 ap 2014-10-27 12:22:54 -0700 This is caused by this line in resetWebPreferencesToConsistentValues(): [WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain]; This test temporarily sets a different cookie accept policy, which gets overridden when another DRT process executes this line, so we have a race. Separate instances of DumpRenderTree are supposed to use separate cookie stores, so they should not be able to affect one another. The question is what changed in Yosemite that this is no longer true. 1044328 4 ap 2014-10-27 14:07:33 -0700 Looks like our parallel test processes used to always share cookie storages, but cookie accept policy wasn't read from the storage before Yosemite. 1044334 5 240506 ap 2014-10-27 14:13:58 -0700 Created attachment 240506 proposed fix 1044342 6 240506 commit-queue 2014-10-27 14:59:50 -0700 Comment on attachment 240506 proposed fix Clearing flags on attachment: 240506 Committed r175232: <http://trac.webkit.org/changeset/175232> 1044343 7 commit-queue 2014-10-27 14:59:52 -0700 All reviewed patches have been landed. Closing bug. 1044441 8 ossy 2014-10-28 01:21:06 -0700 (In reply to comment #6) > Comment on attachment 240506 [details] > proposed fix > > Clearing flags on attachment: 240506 > > Committed r175232: <http://trac.webkit.org/changeset/175232> It broke the build on Apple Windows bots: 1>..\platform\network\cf\NetworkStorageSessionCFNet.cpp(57): error C3861: 'getpid': identifier not found 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED. Build FAILED. 1044509 9 ap 2014-10-28 09:44:32 -0700 Should be fixed in <http://trac.webkit.org/r175254>. 240506 2014-10-27 14:13:58 -0700 2014-10-27 14:59:50 -0700 proposed fix TestingSession.txt text/plain 6118 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTIzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEwLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHAvdGVzdHMvY29va2ll cy90aGlyZC1wYXJ0eS1jb29raWUtcmVsYXhpbmcuaHRtbCBpcyBmbGFreSBvbiBib3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgwOTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzd2l0Y2hUb05ld1Rlc3RpbmdTZXNzaW9uKToKKyAg ICAgICAgQ3JlYXRlIGEgc2VwYXJhdGUgc2Vzc2lvbiBmb3IgZWFjaCBXS1RSL0RSVCBwcm9jZXNz IHdoZW4gdGVzdGluZy4KKwogMjAxNC0xMC0yNyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgRGV2aXJ0dWFsaXplIFJlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJv eDo6aXNTdHJldGNoaW5nQ2hpbGRyZW4oKS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ0ZOZXQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9u Q0ZOZXQuY3BwCShyZXZpc2lvbiAxNzUyMTYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkNGTmV0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTMsMTIgKzUzLDEyIEBAIHN0YXRpYyBPd25QdHI8TmV0d29ya1N0b3JhZ2VTZXNzaW9uPiYg ZGUKIAogdm9pZCBOZXR3b3JrU3RvcmFnZVNlc3Npb246OnN3aXRjaFRvTmV3VGVzdGluZ1Nlc3Np b24oKQogewotICAgIC8vIFNldCBhIHByaXZhdGUgc2Vzc2lvbiBmb3IgdGVzdGluZyB0byBhdm9p ZCBpbnRlcmZlcmluZyB3aXRoIGdsb2JhbCBjb29raWVzLiBUaGlzIHNob3VsZCBiZSBkaWZmZXJl bnQgZnJvbSBwcml2YXRlIGJyb3dzaW5nIHNlc3Npb24uCi0gICAgLy8gRklYTUU6IEl0IGxvb2tz IGxpa2UgY3JlYXRpbmcgYSBuZXcgc2Vzc2lvbiB3aXRoIHRoZSBzYW1lIGlkZW50aWZpZXIgbWF5 IGJlIGp1c3QgY3JlYXRpbmcgYSByZWZlcmVuY2UgdG8gdGhlIHNhbWUgc3RvcmFnZS4gU2VlIDxy ZGFyOi8vcHJvYmxlbS8xMTU3MTQ1MD4gYW5kIDxyZGFyOi8vcHJvYmxlbS8xMjM4NDM4MD4uCisg ICAgLy8gU2Vzc2lvbiBuYW1lIHNob3VsZCBiZSBzaG9ydCBlbm91Z2ggZm9yIHNoYXJlZCBtZW1v cnkgcmVnaW9uIG5hbWUgdG8gYmUgdW5kZXIgdGhlIGxpbWl0LCBvdGVocndpc2Ugc2FuZGJveCBy dWxlcyB3b24ndCB3b3JrIChzZWUgPHJkYXI6Ly9wcm9ibGVtLzEzNjQyODUyPikuCisgICAgU3Ry aW5nIHNlc3Npb25OYW1lID0gU3RyaW5nOjpmb3JtYXQoIldlYktpdCBUZXN0LSV1Iiwgc3RhdGlj X2Nhc3Q8dWludDMyX3Q+KGdldHBpZCgpKSk7CiAjaWYgUExBVEZPUk0oQ09DT0EpCi0gICAgZGVm YXVsdE5ldHdvcmtTdG9yYWdlU2Vzc2lvbigpID0gYWRvcHRQdHIobmV3IE5ldHdvcmtTdG9yYWdl U2Vzc2lvbihhZG9wdENGKHdrQ3JlYXRlUHJpdmF0ZVN0b3JhZ2VTZXNzaW9uKENGU1RSKCJQcml2 YXRlIFdlYktpdCBTZXNzaW9uIikpKSkpOworICAgIGRlZmF1bHROZXR3b3JrU3RvcmFnZVNlc3Np b24oKSA9IGFkb3B0UHRyKG5ldyBOZXR3b3JrU3RvcmFnZVNlc3Npb24oYWRvcHRDRih3a0NyZWF0 ZVByaXZhdGVTdG9yYWdlU2Vzc2lvbihzZXNzaW9uTmFtZS5jcmVhdGVDRlN0cmluZygpLmdldCgp KSkpKTsKICNlbHNlCi0gICAgZGVmYXVsdE5ldHdvcmtTdG9yYWdlU2Vzc2lvbigpID0gYWRvcHRQ dHIobmV3IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbihhZG9wdENGKHdrQ3JlYXRlUHJpdmF0ZVN0b3Jh Z2VTZXNzaW9uKENGU1RSKCJQcml2YXRlIFdlYktpdCBTZXNzaW9uIiksIGRlZmF1bHROZXR3b3Jr U3RvcmFnZVNlc3Npb24oKS0+cGxhdGZvcm1TZXNzaW9uKCkpKSkpOworICAgIGRlZmF1bHROZXR3 b3JrU3RvcmFnZVNlc3Npb24oKSA9IGFkb3B0UHRyKG5ldyBOZXR3b3JrU3RvcmFnZVNlc3Npb24o YWRvcHRDRih3a0NyZWF0ZVByaXZhdGVTdG9yYWdlU2Vzc2lvbihzZXNzaW9uTmFtZS5jcmVhdGVD RlN0cmluZygpLmdldCgpLCBkZWZhdWx0TmV0d29ya1N0b3JhZ2VTZXNzaW9uKCktPnBsYXRmb3Jt U2Vzc2lvbigpKSkpKTsKICNlbmRpZgogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzUy MzApCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAxNC0xMC0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4K KworICAgICAgICBodHRwL3Rlc3RzL2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLXJlbGF4aW5n Lmh0bWwgaXMgZmxha3kgb24gYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM4MDk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3 b3JrUHJvY2Vzcy5zYi5pbjoKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9j ZXNzLnNiLmluOgorICAgICAgICBVcGRhdGUgZm9yIHRoZSBuZXcgbmFtZSBvZiB0ZXN0aW5nIHNl c3Npb24uIE1lbW9yeSByZWdpb25zIGFyZSBub3cgb2YgdGhlIGZvcm0KKyAgICAgICAgIldlYktp dCBUZXN0LTxwaWQ+LTAiLgorCiAyMDE0LTEwLTI0ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxh aW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgaU9TIGJ1aWxkCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vz cy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMv Y29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24gMTc1MjE2KQor KysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0 d29ya1Byb2Nlc3Muc2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTg4LDcgKzg4LDcgQEAKIChhbGxv dyBpcGMtcG9zaXgtc2htLXJlYWQtZGF0YQogICAgIChpcGMtcG9zaXgtbmFtZSAiRk5ldHdvcmsu ZGVmYXVsdFN0b3JhZ2VTZXNzaW9uIikKICAgICAoaXBjLXBvc2l4LW5hbWUtcmVnZXggIyJcLlBy aXZhdGVCcm93c2luZy0iKQotICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl5Qcml2YXRlIFdl YktpdCBTZXNzaW9uLSIpKQorICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl5XZWJLaXQgVGVz dC0iKSkKIAogOzsgVmFyaW91cyBzZXJ2aWNlcyByZXF1aXJlZCBieSBDRk5ldHdvcmsgYW5kIG90 aGVyIGZyYW1ld29ya3MKIChhbGxvdyBtYWNoLWxvb2t1cApJbmRleDogU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCShyZXZpc2lv biAxNzUyMTYpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9j ZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsNyArMTQ4LDcgQEAKIChhbGxvdyBpcGMt cG9zaXgtc2htLXJlYWQtZGF0YQogICAgIChpcGMtcG9zaXgtbmFtZSAiRk5ldHdvcmsuZGVmYXVs dFN0b3JhZ2VTZXNzaW9uIikKICAgICAoaXBjLXBvc2l4LW5hbWUtcmVnZXggIyJcLlByaXZhdGVC cm93c2luZy0iKQotICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl5Qcml2YXRlIFdlYktpdCBT ZXNzaW9uLSIpKQorICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl5XZWJLaXQgVGVzdC0iKSkK IAogOzsgQ29sb3JTeW5jCiA7OyBGSVhNRTogUmVtb3ZlIG5hbWVzIHdpdGggdW5kZXJzY29yZXMg d2hlbiBwb3NzaWJsZSAoc2VlIDxyZGFyOi8vcHJvYmxlbS8xMzA3MjcyMT4pLgpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMTc1MjMwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTAtMjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CisKKyAgICAgICAgaHR0cC90ZXN0cy9jb29raWVzL3RoaXJkLXBhcnR5LWNvb2tp ZS1yZWxheGluZy5odG1sIGlzIGZsYWt5IG9uIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRp b25zOiBSZW1vdmVkIHRoZSB0ZXN0IGZyb20gZXhwZWN0YXRpb25zLiBJdCdzIHN0aWxsCisgICAg ICAgIHNraXBwZWQgb24gV0syLCBiZWNhdXNlIHdlIGRvbid0IHlldCBpbXBsZW1lbnQgdGhlIG5l Y2Vzc2FyeSBXS1RSIGZ1bmN0aW9uYWxpdHkuCisKIDIwMTQtMTAtMjcgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFsgWW9zZW1pdGUgXSBtb2RpZmll ciB0byBhIGNvdXBsZSBvZiB0ZXN0cyBpbiBzZWN0aW9uIDcuCkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNzUyMzApCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcg Y29weSkKQEAgLTE5LDEwICsxOSw2IEBAIHdlYmtpdC5vcmcvYi8xMjQzMTggZnVsbHNjcmVlbi9h bm9ueW1vdXMKIHdlYmtpdC5vcmcvYi8xMzI0MjEgZmFzdC9tdWx0aWNvbC9maXhlZC1zdGFjay5o dG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiBbIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBmYXN0 L211bHRpY29sL2ZpeGVkLXN0YWNrLmh0bWwgWyBQYXNzIF0KIAotIyBGYWlsaW5nIGl0ZXJtaXR0 ZW50bHkgb24gWW9zZW1pdGUgUmVsZWFzZSBXSzEgYm90cy4gCi13ZWJraXQub3JnL2IvMTM4MDk4 IGh0dHAvdGVzdHMvY29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtcmVsYXhpbmcuaHRtbCBbIFBh c3MgRmFpbHVyZSBdCi1bIE1vdW50YWluTGlvbiBNYXZlcmlja3MgXSBodHRwL3Rlc3RzL2Nvb2tp ZXMvdGhpcmQtcGFydHktY29va2llLXJlbGF4aW5nLmh0bWwgWyBQYXNzIF0KLQogIyMjIEVORCBP RiAoMSkgRmFpbHVyZXMgd2l0aCBidWcgcmVwb3J0cwogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIwogCg==