138096 2014-10-27 10:46:22 -0700 Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren(). 2014-10-27 13:42:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 1044265 0 kling 2014-10-27 10:46:22 -0700 Small patch inc. 1044266 1 240487 kling 2014-10-27 10:47:34 -0700 Created attachment 240487 Patch 1044267 2 240487 cdumez 2014-10-27 10:48:48 -0700 Comment on attachment 240487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240487&action=review r=me with nit. > Source/WebCore/rendering/RenderBox.cpp:2702 > if (h.isAuto() && parent()->isDeprecatedFlexibleBox() && parent()->style().boxOrient() == HORIZONTAL nit: is<RenderDeprecatedFlexibleBox>(*parent()) 1044268 3 commit-queue 2014-10-27 10:50:22 -0700 Attachment 240487 did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBox.cpp:2703: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1044324 4 kling 2014-10-27 13:42:43 -0700 Committed r175230: <http://trac.webkit.org/changeset/175230> 240487 2014-10-27 10:47:34 -0700 2014-10-27 10:48:48 -0700 Patch bug-138096.diff text/plain 3621 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZmNkMjFhLi4xZWNmODkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTQtMTAtMjcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIERldmlydHVhbGl6ZSBSZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3g6OmlzU3RyZXRjaGlu Z0NoaWxkcmVuKCkuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzgwOTY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmdW5jdGlv biBpcyBvbmx5IGV2ZXIgY2FsbGVkIG9uIGEgcmVuZGVyZXIgYWZ0ZXIgd2UndmUgY2hlY2tlZAor ICAgICAgICB0aGF0IGl0J3MgYSBSZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3gsIHNvIG1ha2Ug aXQgbm9uLXZpcnR1YWwuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZUxvZ2ljYWxIZWlnaHQpOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guaDoKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CisKKzIwMTQtMTAtMjcgIEFuZHJlYXMgS2xpbmcgIDxh a2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIE1vdmUgY2FuQ29udGFpbkZpeGVkUG9zaXRpb25P YmplY3RzKCkgdG8gUmVuZGVyRWxlbWVudC4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9i LzEzODA4OD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCBlOWI3 MWMyLi44N2Y0MGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAt NDUsNiArNDUsNyBAQAogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJQYWludEluZm8uaCIK ICNpbmNsdWRlICJSZW5kZXJCb3hSZWdpb25JbmZvLmgiCisjaW5jbHVkZSAiUmVuZGVyRGVwcmVj YXRlZEZsZXhpYmxlQm94LmgiCiAjaW5jbHVkZSAiUmVuZGVyRmxleGlibGVCb3guaCIKICNpbmNs dWRlICJSZW5kZXJHZW9tZXRyeU1hcC5oIgogI2luY2x1ZGUgIlJlbmRlcklubGluZS5oIgpAQCAt MjY5OSw3ICsyNzAwLDcgQEAgdm9pZCBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2FsSGVpZ2h0KExh eW91dFVuaXQgbG9naWNhbEhlaWdodCwgTGF5b3V0VW5pdCBsb2dpY2EKICAgICAgICAgLy8gRklY TUU6IEFjY291bnQgZm9yIGJsb2NrLWZsb3cgaW4gZmxleGlibGUgYm94ZXMuCiAgICAgICAgIC8v IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjQxOAogICAgICAgICBp ZiAoaC5pc0F1dG8oKSAmJiBwYXJlbnQoKS0+aXNEZXByZWNhdGVkRmxleGlibGVCb3goKSAmJiBw YXJlbnQoKS0+c3R5bGUoKS5ib3hPcmllbnQoKSA9PSBIT1JJWk9OVEFMCi0gICAgICAgICAgICAg ICAgJiYgcGFyZW50KCktPmlzU3RyZXRjaGluZ0NoaWxkcmVuKCkpIHsKKyAgICAgICAgICAgICAg ICAmJiBkb3duY2FzdDxSZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3g+KCpwYXJlbnQoKSkuaXNT dHJldGNoaW5nQ2hpbGRyZW4oKSkgewogICAgICAgICAgICAgaCA9IExlbmd0aChwYXJlbnRCb3go KS0+Y29udGVudExvZ2ljYWxIZWlnaHQoKSAtIG1hcmdpbkJlZm9yZSgpIC0gbWFyZ2luQWZ0ZXIo KSAtIGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCksIEZpeGVkKTsKICAgICAgICAgICAg IGNoZWNrTWluTWF4SGVpZ2h0ID0gZmFsc2U7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guaAppbmRleCBj NjFjNTg2Li4wNWE5YjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveC5oCkBAIC00NCw4ICs0NCw5IEBAIHB1YmxpYzoK ICAgICB2b2lkIGxheW91dEhvcml6b250YWxCb3goYm9vbCByZWxheW91dENoaWxkcmVuKTsKICAg ICB2b2lkIGxheW91dFZlcnRpY2FsQm94KGJvb2wgcmVsYXlvdXRDaGlsZHJlbik7CiAKKyAgICBi b29sIGlzU3RyZXRjaGluZ0NoaWxkcmVuKCkgY29uc3QgeyByZXR1cm4gbV9zdHJldGNoaW5nQ2hp bGRyZW47IH0KKwogICAgIHZpcnR1YWwgYm9vbCBhdm9pZHNGbG9hdHMoKSBjb25zdCBvdmVycmlk ZSB7IHJldHVybiB0cnVlOyB9Ci0gICAgdmlydHVhbCBib29sIGlzU3RyZXRjaGluZ0NoaWxkcmVu KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gbV9zdHJldGNoaW5nQ2hpbGRyZW47IH0KICAgICB2 aXJ0dWFsIGJvb2wgY2FuQ29sbGFwc2VBbm9ueW1vdXNCbG9ja0NoaWxkKCkgY29uc3Qgb3ZlcnJp ZGUgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIHZvaWQgcGxhY2VDaGlsZChSZW5kZXJCb3gqIGNo aWxkLCBjb25zdCBMYXlvdXRQb2ludCYgbG9jYXRpb24sIExheW91dFNpemUqIGNoaWxkTGF5b3V0 RGVsdGEgPSAwKTsKQEAgLTY5LDQgKzcwLDYgQEAgcHJpdmF0ZToKIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQogCitTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX1JFTkRFUl9PQkpFQ1QoUmVuZGVyRGVw cmVjYXRlZEZsZXhpYmxlQm94LCBpc0RlcHJlY2F0ZWRGbGV4aWJsZUJveCgpKQorCiAjZW5kaWYg Ly8gUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94X2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuaAppbmRleCAzZGEwZmM4Li41MDBiNzFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5oCkBAIC04MDUsNyArODA1LDYgQEAgcHVibGljOgogCiAgICAg Ly8gVmlydHVhbCBmdW5jdGlvbiBoZWxwZXJzIGZvciB0aGUgZGVwcmVjYXRlZCBGbGV4aWJsZSBC b3ggTGF5b3V0IChkaXNwbGF5OiAtd2Via2l0LWJveCkuCiAgICAgdmlydHVhbCBib29sIGlzRGVw cmVjYXRlZEZsZXhpYmxlQm94KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KLSAgICB2aXJ0dWFs IGJvb2wgaXNTdHJldGNoaW5nQ2hpbGRyZW4oKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogCiAg ICAgLy8gVmlydHVhbCBmdW5jdGlvbiBoZWxwZXIgZm9yIHRoZSBuZXcgRmxleGlibGVCb3ggTGF5 b3V0IChkaXNwbGF5OiAtd2Via2l0LWZsZXgpLgogICAgIHZpcnR1YWwgYm9vbCBpc0ZsZXhpYmxl Qm94KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0K