<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138086</bug_id>
          
          <creation_ts>2014-10-26 14:03:59 -0700</creation_ts>
          <short_desc>[GTK] Bump libsoup&apos;s minimum version to 2.42.0.</short_desc>
          <delta_ts>2014-12-08 09:00:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Raphael Kubo da Costa (:rakuco)">rakuco</assigned_to>
          <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>danw</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1044196</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-26 14:03:59 -0700</bug_when>
    <thetext>[GTK] Bump libsoup&apos;s minimum version.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044197</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-10-26 14:05:58 -0700</bug_when>
    <thetext>For GTK+, we shouldn&apos;t do this until the next major release. If you need to access a feature that&apos;s only accessible in a newer version of libsoup, I recommend simply using compile-time checks (https://developer.gnome.org/libsoup/stable/libsoup-2.4-Version-Information.html).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044198</commentid>
    <comment_count>2</comment_count>
      <attachid>240469</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-26 14:10:11 -0700</bug_when>
    <thetext>Created attachment 240469
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044199</commentid>
    <comment_count>3</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-26 14:12:15 -0700</bug_when>
    <thetext>Well it turns out both the 2.4 and 2.6 release series have used SOUP_CHECK_VERSION while stating in OptionsGTK.cmake that libsoup 2.40.3 was OK even though WebCore simply wouldn&apos;t build with that version.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044200</commentid>
    <comment_count>4</comment_count>
      <attachid>240469</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-10-26 14:22:58 -0700</bug_when>
    <thetext>Comment on attachment 240469
Patch

Judging by old mailing list threads it seems that WebKit2 has always depended upon 2.42, so I think the configuration file is simply incorrect here. We should probably just specify 2.42 here though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044201</commentid>
    <comment_count>5</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-26 14:25:18 -0700</bug_when>
    <thetext>Do you remember when those threads took place? Otherwise I&apos;ll try to look for those this week to add a proper explanation to the ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044203</commentid>
    <comment_count>6</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-10-26 15:17:12 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Comment on attachment 240469 [details]
&gt; Patch
&gt; 
&gt; Judging by old mailing list threads it seems that WebKit2 has always
&gt; depended upon 2.42, so I think the configuration file is simply incorrect
&gt; here. We should probably just specify 2.42 here though.

Sure. Here is the relevant thread: https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001387.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044216</commentid>
    <comment_count>7</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-26 23:45:39 -0700</bug_when>
    <thetext>I think this is simply yet another regression of the CMake switch, see:

http://trac.webkit.org/browser/releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4#L33</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044818</commentid>
    <comment_count>8</comment_count>
      <attachid>240619</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-29 13:45:50 -0700</bug_when>
    <thetext>Created attachment 240619
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044822</commentid>
    <comment_count>9</comment_count>
      <attachid>240619</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-29 14:04:24 -0700</bug_when>
    <thetext>Comment on attachment 240619
Patch

Clearing flags on attachment: 240619

Committed r175344: &lt;http://trac.webkit.org/changeset/175344&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044823</commentid>
    <comment_count>10</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-29 14:04:34 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1044824</commentid>
    <comment_count>11</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2014-10-29 14:05:08 -0700</bug_when>
    <thetext>This might be useful in the 2.4 and 2.6 branches as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053395</commentid>
    <comment_count>12</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-12-08 09:00:59 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; This might be useful in the 2.4 and 2.6 branches as well.

Both of them already depend on 2.42.0</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240469</attachid>
            <date>2014-10-26 14:10:11 -0700</date>
            <delta_ts>2014-10-29 13:45:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138086-20141026231017.patch</filename>
            <type>text/plain</type>
            <size>1314</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTIx
MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEw
LTI2ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5vcmc+CisKKyAgICAg
ICAgW0dUS10gQnVtcCBsaWJzb3VwJ3MgbWluaW11bSB2ZXJzaW9uLgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MDg2CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFNPVVBfQ0hFQ0tfVkVSU0lPTiBt
YWNybyB3YXMgYWRkZWQgaW4gbGlic291cCAyLjQxLjEsIGFuZCB0aGUKKyAgICAgICAgc291cC12
ZXJzaW9uLmggaGVhZGVyIHdhcyBhZGRlZCB0byBzb3VwLmggaW4gMi40MS40LCB3aGljaCB0aGVu
CisgICAgICAgIGJlY29tZXMgdGhlIG1pbmltdW0gdmVyc2lvbiByZXF1aXJlZCB0byBidWlsZCB0
aGUgcG9ydCB0aGVzZSBkYXlzLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsu
Y21ha2U6CisKIDIwMTQtMTAtMjEgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQGdtYWlsLmNvbT4K
IAogICAgICAgICBbRUZMXSBSZW1vdmUgdW5uZWNlc3NhcnkgRU5BQkxFXzNEX1JFTkRFUklORyBk
ZWZpbml0aW9uIGZyb20gT3B0aW9uc0VmbC5jbWFrZQpJbmRleDogU291cmNlL2NtYWtlL09wdGlv
bnNHVEsuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UJ
KHJldmlzaW9uIDE3NTE5OCkKKysrIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCSh3b3Jr
aW5nIGNvcHkpCkBAIC0zNCw3ICszNCw3IEBAIGZpbmRfcGFja2FnZShGcmVldHlwZTIgMi40LjIg
UkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoSGFyZkJ1enogMC45LjIgUkVRVUlSRUQpCiBmaW5kX3Bh
Y2thZ2UoSUNVIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKEpQRUcgUkVRVUlSRUQpCi1maW5kX3Bh
Y2thZ2UoTGliU291cCAyLjQwLjMgUkVRVUlSRUQpCitmaW5kX3BhY2thZ2UoTGliU291cCAyLjQx
LjQgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoTGliWG1sMiAyLjguMCBSRVFVSVJFRCkKIGZpbmRf
cGFja2FnZShMaWJYc2x0IDEuMS43IFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKFBORyBSRVFVSVJF
RCkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240619</attachid>
            <date>2014-10-29 13:45:50 -0700</date>
            <delta_ts>2014-10-29 14:04:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138086-20141029224557.patch</filename>
            <type>text/plain</type>
            <size>1586</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTIx
MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEw
LTI2ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5vcmc+CisKKyAgICAg
ICAgW0dUS10gQnVtcCBsaWJzb3VwJ3MgbWluaW11bSB2ZXJzaW9uIHRvIDIuNDIuMC4KKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODA4NgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBTT1VQX0NIRUNL
X1ZFUlNJT04gbWFjcm8gd2FzIGFkZGVkIGluIGxpYnNvdXAgMi40MS4xLCBhbmQgdGhlCisgICAg
ICAgIHNvdXAtdmVyc2lvbi5oIGhlYWRlciB3YXMgYWRkZWQgdG8gc291cC5oIGluIDIuNDEuNCwg
d2hpY2ggdGhlbiBiZWNvbWVzCisgICAgICAgIHRoZSBtaW5pbXVtIHZlcnNpb24gcmVxdWlyZWQg
dG8gYnVpbGQgdGhlIHBvcnQgdGhlc2UgZGF5cy4KKworICAgICAgICBJbiBhZGRpdGlvbiwgc2lu
Y2UgdGhlIGF1dG90b29scyBidWlsZCBzeXN0ZW0gcmVxdWlyZWQgMi40Mi4wIGJlZm9yZQorICAg
ICAgICBiZWluZyByZXRpcmVkLCByZXF1aXJlIHRoZSBzYW1lIHZlcnNpb24gaGVyZS4gVmVyc2lv
biAyLjQyLjAgd2FzIGFsc28KKyAgICAgICAgcmVjb21tZW5kZWQgaW4KKyAgICAgICAgaHR0cHM6
Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJraXQtZ3RrLzIwMTMtTWFyY2gvMDAxMzg3
Lmh0bWwuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAx
NC0xMC0yMSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAZ21haWwuY29tPgogCiAgICAgICAgIFtF
RkxdIFJlbW92ZSB1bm5lY2Vzc2FyeSBFTkFCTEVfM0RfUkVOREVSSU5HIGRlZmluaXRpb24gZnJv
bSBPcHRpb25zRWZsLmNtYWtlCkluZGV4OiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQkocmV2aXNpb24gMTc1
MTk4KQorKysgU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UJKHdvcmtpbmcgY29weSkKQEAg
LTM0LDcgKzM0LDcgQEAgZmluZF9wYWNrYWdlKEZyZWV0eXBlMiAyLjQuMiBSRVFVSVJFRCkKIGZp
bmRfcGFja2FnZShIYXJmQnV6eiAwLjkuMiBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShJQ1UgUkVR
VUlSRUQpCiBmaW5kX3BhY2thZ2UoSlBFRyBSRVFVSVJFRCkKLWZpbmRfcGFja2FnZShMaWJTb3Vw
IDIuNDAuMyBSRVFVSVJFRCkKK2ZpbmRfcGFja2FnZShMaWJTb3VwIDIuNDIuMCBSRVFVSVJFRCkK
IGZpbmRfcGFja2FnZShMaWJYbWwyIDIuOC4wIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKExpYlhz
bHQgMS4xLjcgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoUE5HIFJFUVVJUkVEKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>