138062 2014-10-24 15:58:11 -0700 Share sheet doesn't attach to the window 2014-10-24 16:15:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin conrad_shultz mitz simon.fraser oldest_to_newest 1044095 0 thorton 2014-10-24 15:58:11 -0700 Share sheet doesn't attach to the window 1044096 1 240444 thorton 2014-10-24 15:58:35 -0700 Created attachment 240444 Patch 1044097 2 thorton 2014-10-24 16:00:36 -0700 <rdar://problem/18767397> 1044099 3 240444 conrad_shultz 2014-10-24 16:07:24 -0700 Comment on attachment 240444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240444&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46 > +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> { Can this be done in a class extension instead? 1044102 4 thorton 2014-10-24 16:15:26 -0700 (In reply to comment #3) > Comment on attachment 240444 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240444&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46 > > +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> { > > Can this be done in a class extension instead? Oops, I missed this before landing. Maybe I can! I'll have to see. http://trac.webkit.org/changeset/175190 240444 2014-10-24 15:58:35 -0700 2014-10-24 16:04:39 -0700 Patch bug-138062-20141024155842.patch text/plain 3537 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODhhY2FkNzE4Y2JiYzhk NzAzOWJmNzU3ZDMzNGI3MDk3MWIwYTMwYi4uMGRlNzg1MTY3OGUxNjc0ZmNiZjI2NTRlN2ViODVm ZDJjNTU1OGExYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTEwLTI0ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFNoYXJlIHNoZWV0 IGRvZXNuJ3QgYXR0YWNoIHRvIHRoZSB3aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODA2MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTg3 NjczOTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIuaDoKKyAgICAgICAgV0tBY3Rp b25NZW51Q29udHJvbGxlciBpcyBub3cgYSBOU1NoYXJpbmdTZXJ2aWNle1BpY2tlcn1EZWxlZ2F0 ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbToK KyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciBfZGVmYXVsdE1lbnVJdGVtc0Zvcklt YWdlXSk6CisgICAgICAgIFNldCB1cyB1cCBhcyB0aGUgTlNTaGFyaW5nU2VydmljZVBpY2tlciBk ZWxlZ2F0ZS4KKworICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIHNoYXJpbmdTZXJ2 aWNlUGlja2VyOmRlbGVnYXRlRm9yU2hhcmluZ1NlcnZpY2U6XSk6CisgICAgICAgIFNldCB1cyB1 cCBhcyB0aGUgTlNTaGFyaW5nU2VydmljZSBkZWxlZ2F0ZS4KKworICAgICAgICAoLVtXS0FjdGlv bk1lbnVDb250cm9sbGVyIHNoYXJpbmdTZXJ2aWNlOnNvdXJjZVdpbmRvd0ZvclNoYXJlSXRlbXM6 c2hhcmluZ0NvbnRlbnRTY29wZTpdKToKKyAgICAgICAgUmV0dXJuIHRoZSBhcHByb3ByaWF0ZSB3 aW5kb3cgdG8gYXR0YWNoIHRvLgorCiAyMDE0LTEwLTI0ICBCZXRoIERha2luICA8YmRha2luQGFw cGxlLmNvbT4KIAogICAgICAgICBWZXJ5IGxhcmdlIGltYWdlcyBjcmFzaCBpbiBhY3Rpb24gbWVu dSBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9u TWVudUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25N ZW51Q29udHJvbGxlci5oCmluZGV4IDQ3YjJlNDFmNjU5ZGNmODEwZTlmODRkOTg3ZjA0MzBmYWVk OWMxZmEuLmFjNWE2YmQ1MzhmZmU4MWM1YWYzY2RiNDEwMWU5OGFiZTViN2RiNGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxl ci5oCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpbXBvcnQgIkFjdGlvbk1lbnVIaXRUZXN0UmVzdWx0 LmgiCiAjaW1wb3J0ICJXS0FjdGlvbk1lbnVJdGVtVHlwZXMuaCIKKyNpbXBvcnQgPEFwcEtpdC9O U1NoYXJpbmdTZXJ2aWNlLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAKIG5hbWVzcGFj ZSBXZWJLaXQgewpAQCAtNDAsMTAgKzQxLDkgQEAgZW51bSBjbGFzcyBBY3Rpb25NZW51U3RhdGUg ewogfTsKIH0KIAotQGNsYXNzIE5TU2hhcmluZ1NlcnZpY2VQaWNrZXI7CiBAY2xhc3MgV0tWaWV3 OwogCi1AaW50ZXJmYWNlIFdLQWN0aW9uTWVudUNvbnRyb2xsZXIgOiBOU09iamVjdCB7CitAaW50 ZXJmYWNlIFdLQWN0aW9uTWVudUNvbnRyb2xsZXIgOiBOU09iamVjdCA8TlNTaGFyaW5nU2Vydmlj ZURlbGVnYXRlLCBOU1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGU+IHsKIEBwcml2YXRlCiAg ICAgV2ViS2l0OjpXZWJQYWdlUHJveHkgKl9wYWdlOwogICAgIFdLVmlldyAqX3drVmlldzsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJv bGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJv bGxlci5tbQppbmRleCAwN2EwN2VjMjIzYjQ2NTUxMzhkZmIyYTE1NzA5YTMyY2MwZmE5ZTMyLi5l OTYyYWFlYzFiOGI3ZWEyZDM4MTA0MzJmNzY2NjdmMTc0MDkyMDZjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCkBA IC0xOTIsNiArMTkyLDcgQEAgLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0ZW1zRm9ySW1hZ2UK ICAgICAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGltYWdlID0gYml0bWFwLT5tYWtlQ0dJbWFn ZSgpOwogICAgICAgICBSZXRhaW5QdHI8TlNJbWFnZT4gbnNJbWFnZSA9IGFkb3B0TlMoW1tOU0lt YWdlIGFsbG9jXSBpbml0V2l0aENHSW1hZ2U6aW1hZ2UuZ2V0KCkgc2l6ZTpOU1plcm9TaXplXSk7 CiAgICAgICAgIF9zaGFyaW5nU2VydmljZVBpY2tlciA9IGFkb3B0TlMoW1tOU1NoYXJpbmdTZXJ2 aWNlUGlja2VyIGFsbG9jXSBpbml0V2l0aEl0ZW1zOkBbIG5zSW1hZ2UuZ2V0KCkgXV0pOworICAg ICAgICBbX3NoYXJpbmdTZXJ2aWNlUGlja2VyIHNldERlbGVnYXRlOnNlbGZdOwogICAgICAgICBb c2hhcmVJdGVtIHNldFN1Ym1lbnU6W19zaGFyaW5nU2VydmljZVBpY2tlciBtZW51XV07CiAgICAg fQogCkBAIC0yOTEsNiArMjkyLDIwIEBAIC0gKHZvaWQpX2FkZEltYWdlVG9QaG90b3M6KGlkKXNl bmRlcgogICAgIH0pOwogfQogCisjcHJhZ21hIG1hcmsgTlNTaGFyaW5nU2VydmljZVBpY2tlckRl bGVnYXRlIGltcGxlbWVudGF0aW9uCisKKy0gKGlkIDxOU1NoYXJpbmdTZXJ2aWNlRGVsZWdhdGU+ KXNoYXJpbmdTZXJ2aWNlUGlja2VyOihOU1NoYXJpbmdTZXJ2aWNlUGlja2VyICopc2hhcmluZ1Nl cnZpY2VQaWNrZXIgZGVsZWdhdGVGb3JTaGFyaW5nU2VydmljZTooTlNTaGFyaW5nU2VydmljZSAq KXNoYXJpbmdTZXJ2aWNlCit7CisgICAgcmV0dXJuIHNlbGY7Cit9CisKKyNwcmFnbWEgbWFyayBO U1NoYXJpbmdTZXJ2aWNlRGVsZWdhdGUgaW1wbGVtZW50YXRpb24KKworLSAoTlNXaW5kb3cgKilz aGFyaW5nU2VydmljZTooTlNTaGFyaW5nU2VydmljZSAqKXNoYXJpbmdTZXJ2aWNlIHNvdXJjZVdp bmRvd0ZvclNoYXJlSXRlbXM6KE5TQXJyYXkgKilpdGVtcyBzaGFyaW5nQ29udGVudFNjb3BlOihO U1NoYXJpbmdDb250ZW50U2NvcGUgKilzaGFyaW5nQ29udGVudFNjb3BlCit7CisgICAgcmV0dXJu IF93a1ZpZXcud2luZG93OworfQorCiAjcHJhZ21hIG1hcmsgTWVudSBJdGVtcwogCiAtIChSZXRh aW5QdHI8TlNNZW51SXRlbT4pX2NyZWF0ZUFjdGlvbk1lbnVJdGVtRm9yVGFnOih1aW50MzJfdCl0 YWcK