138059 2014-10-24 15:18:20 -0700 Very large images crash in action menu code 2014-10-24 16:05:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin conrad_shultz thorton oldest_to_newest 1044082 0 bdakin 2014-10-24 15:18:20 -0700 Very large images crash in action menu code. rdar://problem/18767859 1044083 1 240440 bdakin 2014-10-24 15:21:26 -0700 Created attachment 240440 Patch 1044084 2 240440 thorton 2014-10-24 15:24:26 -0700 Comment on attachment 240440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240440&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:186 > + RefPtr<ShareableBitmap> bitmap = _hitTestResult.image; could do this check in _defaultMenuItems instead so we can do smart fallback there and not worry about these things here. 1044088 3 bdakin 2014-10-24 15:28:17 -0700 http://trac.webkit.org/changeset/175187 240440 2014-10-24 15:21:26 -0700 2014-10-24 15:24:26 -0700 Patch for-review.txt text/plain 3626 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTE4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEwLTI0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBWZXJ5IGxhcmdlIGltYWdlcyBjcmFz aCBpbiBhY3Rpb24gbWVudSBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzgwNTkKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAg ICByZGFyOi8vcHJvYmxlbS8xODc2Nzg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIElmIHRoZSBIaXRUZXN0UmVzdWx0IGZhaWxlZCB0byBjcmVhdGUg YW5kIGltYWdlLCB0aGVuIGRvbuKAmXQgcHV0IHRvZ2V0aGVyIHRoZSBpbWFnZSAKKyAgICAgICAg YWN0aW9uIG1lbnUuCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9s bGVyLm1tOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9kZWZhdWx0TWVudUl0 ZW1zRm9ySW1hZ2VdKToKKworICAgICAgICBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZVNoYXJlYWJs ZSgpIGNhbiBmYWlsLiBUaGUgcmVzdWx0IG5lZWRzIHRvIGJlIG51bGwtY2hlY2tlZC4KKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2U6OnBlcmZvcm1BY3Rpb25NZW51SGl0VGVzdEF0TG9jYXRpb24pOgorCiAyMDE0LTEwLTI0 ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1l bnVDb250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzUxODUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4 MywxNyArMTgzLDE5IEBAIC0gKHZvaWQpX3F1aWNrTG9va1VSTEZyb21BY3Rpb25NZW51OihpZCkK IAogLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0ZW1zRm9ySW1hZ2UKIHsKKyAgICBSZWZQdHI8 U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBfaGl0VGVzdFJlc3VsdC5pbWFnZTsKKyAgICBpZiAo IWJpdG1hcCkKKyAgICAgICAgcmV0dXJuIEBbIF07CisKICAgICBSZXRhaW5QdHI8TlNNZW51SXRl bT4gY29weUltYWdlSXRlbSA9IFtzZWxmIF9jcmVhdGVBY3Rpb25NZW51SXRlbUZvclRhZzprV0tD b250ZXh0QWN0aW9uSXRlbVRhZ0NvcHlJbWFnZV07CiAgICAgUmV0YWluUHRyPE5TTWVudUl0ZW0+ IGFkZFRvUGhvdG9zSXRlbSA9IFtzZWxmIF9jcmVhdGVBY3Rpb25NZW51SXRlbUZvclRhZzprV0tD b250ZXh0QWN0aW9uSXRlbVRhZ0FkZEltYWdlVG9QaG90b3NdOwogICAgIFJldGFpblB0cjxOU01l bnVJdGVtPiBzYXZlVG9Eb3dubG9hZHNJdGVtID0gW3NlbGYgX2NyZWF0ZUFjdGlvbk1lbnVJdGVt Rm9yVGFnOmtXS0NvbnRleHRBY3Rpb25JdGVtVGFnU2F2ZUltYWdlVG9Eb3dubG9hZHNdOwogICAg IFJldGFpblB0cjxOU01lbnVJdGVtPiBzaGFyZUl0ZW0gPSBbc2VsZiBfY3JlYXRlQWN0aW9uTWVu dUl0ZW1Gb3JUYWc6a1dLQ29udGV4dEFjdGlvbkl0ZW1UYWdTaGFyZUltYWdlXTsKIAotICAgIGlm IChSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBfaGl0VGVzdFJlc3VsdC5pbWFnZSkg ewotICAgICAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gaW1hZ2UgPSBiaXRtYXAtPm1ha2VDR0lt YWdlKCk7Ci0gICAgICAgIFJldGFpblB0cjxOU0ltYWdlPiBuc0ltYWdlID0gYWRvcHROUyhbW05T SW1hZ2UgYWxsb2NdIGluaXRXaXRoQ0dJbWFnZTppbWFnZS5nZXQoKSBzaXplOk5TWmVyb1NpemVd KTsKLSAgICAgICAgX3NoYXJpbmdTZXJ2aWNlUGlja2VyID0gYWRvcHROUyhbW05TU2hhcmluZ1Nl cnZpY2VQaWNrZXIgYWxsb2NdIGluaXRXaXRoSXRlbXM6QFsgbnNJbWFnZS5nZXQoKSBdXSk7Ci0g ICAgICAgIFtzaGFyZUl0ZW0gc2V0U3VibWVudTpbX3NoYXJpbmdTZXJ2aWNlUGlja2VyIG1lbnVd XTsKLSAgICB9CisgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGltYWdlID0gYml0bWFwLT5tYWtl Q0dJbWFnZSgpOworICAgIFJldGFpblB0cjxOU0ltYWdlPiBuc0ltYWdlID0gYWRvcHROUyhbW05T SW1hZ2UgYWxsb2NdIGluaXRXaXRoQ0dJbWFnZTppbWFnZS5nZXQoKSBzaXplOk5TWmVyb1NpemVd KTsKKyAgICBfc2hhcmluZ1NlcnZpY2VQaWNrZXIgPSBhZG9wdE5TKFtbTlNTaGFyaW5nU2Vydmlj ZVBpY2tlciBhbGxvY10gaW5pdFdpdGhJdGVtczpAWyBuc0ltYWdlLmdldCgpIF1dKTsKKyAgICBb c2hhcmVJdGVtIHNldFN1Ym1lbnU6W19zaGFyaW5nU2VydmljZVBpY2tlciBtZW51XV07CiAKICAg ICByZXR1cm4gQFsgY29weUltYWdlSXRlbS5nZXQoKSwgYWRkVG9QaG90b3NJdGVtLmdldCgpLCBz YXZlVG9Eb3dubG9hZHNJdGVtLmdldCgpLCBzaGFyZUl0ZW0uZ2V0KCkgXTsKIH0KSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9u IDE3NTE4NCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDgyMSw3ICs0ODIxLDggQEAgdm9pZCBXZWJQYWdlOjpwZXJm b3JtQWN0aW9uTWVudUhpdFRlc3RBdAogCiAgICAgaWYgKEltYWdlKiBpbWFnZSA9IGhpdFRlc3RS ZXN1bHQuaW1hZ2UoKSkgewogICAgICAgICBhY3Rpb25NZW51UmVzdWx0LmltYWdlID0gU2hhcmVh YmxlQml0bWFwOjpjcmVhdGVTaGFyZWFibGUoSW50U2l6ZShpbWFnZS0+c2l6ZSgpKSwgU2hhcmVh YmxlQml0bWFwOjpTdXBwb3J0c0FscGhhKTsKLSAgICAgICAgYWN0aW9uTWVudVJlc3VsdC5pbWFn ZS0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0KCktPmRyYXdJbWFnZShpbWFnZSwgQ29sb3JTcGFjZURl dmljZVJHQiwgSW50UG9pbnQoKSk7CisgICAgICAgIGlmIChhY3Rpb25NZW51UmVzdWx0LmltYWdl KQorICAgICAgICAgICAgYWN0aW9uTWVudVJlc3VsdC5pbWFnZS0+Y3JlYXRlR3JhcGhpY3NDb250 ZXh0KCktPmRyYXdJbWFnZShpbWFnZSwgQ29sb3JTcGFjZURldmljZVJHQiwgSW50UG9pbnQoKSk7 CiAgICAgfQogCiAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWRQZXJmb3JtQWN0 aW9uTWVudUhpdFRlc3QoYWN0aW9uTWVudVJlc3VsdCkpOwo=